RE: [PATCH 1/4] drm/amd/powerplay: add SMU mode1 reset

2020-07-09 Thread Sheng, Wenhui
[AMD Public Use] Ok I will refine it. Brs Wenhui -Original Message- From: Zhang, Hawking Sent: Friday, July 10, 2020 2:51 PM To: Zhang, Hawking ; Sheng, Wenhui ; amd-gfx@lists.freedesktop.org Cc: Gao, Likun Subject: RE: [PATCH 1/4] drm/amd/powerplay: add SMU mode1 reset [AMD Public

RE: [PATCH 2/4] drm/amdgpu: add psp mode1 reset mode

2020-07-09 Thread Sheng, Wenhui
[AMD Public Use] Hi @Zhang, Hawking I tried to hide mp0/mp1 mode1 reset under AMD_RESET_METHOD_MODE1, while it seems that we need to tackle the difference in function amdgpu_device_gpu_recover, like following change in 3rd patch: @@ -4275,16 +4277,18 @@ int amdgpu_device_gpu_recover(struct am

RE: [PATCH 1/4] drm/amd/powerplay: add SMU mode1 reset

2020-07-09 Thread Zhang, Hawking
[AMD Public Use] BTW, we'd better make the 500ms setting to be a MACRO. We haven't passed the stress test so might need to extend the waiting in near future. + ret = smu_send_smc_msg(smu, SMU_MSG_Mode1Reset, NULL); + if (!ret) + msleep(500); Regards, Hawking -Orig

RE: [PATCH 2/2] drm/amdgpu: fix preemption unit test

2020-07-09 Thread Zhang, Hawking
[AMD Public Use] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Xiao, Jack Sent: Friday, July 10, 2020 13:45 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking Cc: Xiao, Jack Subject: [PATCH 2/2] drm/amdgpu: fix preemption unit te

RE: [PATCH 1/4] drm/amd/powerplay: add SMU mode1 reset

2020-07-09 Thread Zhang, Hawking
[AMD Public Use] We shall consider add smu mode 1 reset interface in amdgpu_dpm.c, where we have amdgpu_dpm_mode2_reset and amdgpu_dpm_baco_reset already. So totally three interfaces there amdgpu_dpm_baco_reset amdgpu_dpm_mode2_reset amdgpu_dpm_mode1_reset Does it make sense to you? Thoughts?

RE: [PATCH 4/4] drm/amdgpu: add mode1 reset module parameter

2020-07-09 Thread Zhang, Hawking
[AMD Public Use] How about we expose the reset_method as a new amdgpu module parameter? Regards, Hawking -Original Message- From: Sheng, Wenhui Sent: Friday, July 10, 2020 13:46 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Sheng, Wenhui ; Gao, Likun Subject: [PATCH 4/4] drm/

RE: [PATCH 2/4] drm/amdgpu: add psp mode1 reset mode

2020-07-09 Thread Zhang, Hawking
[AMD Public Use] Hi @Sheng, Wenhui, I'm thinking of hiding the MP0/MP1 mode 1 reset under AMD_RESET_METHOD_MODE1. the callback function reset is per ASIC function, where nv_asic_reset and soc15_aisc_reset serve for NV series and pre-NV series respectively. The new mode 1 reset will be used sta

[PATCH 4/4] drm/amdgpu: add mode1 reset module parameter

2020-07-09 Thread Wenhui Sheng
For sienna cichlid, defaut path is baco reset, only when parameter mode1_reset is set, mode1 reset will be chosen. Signed-off-by: Likun Gao Signed-off-by: Wenhui Sheng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 drivers/gpu/drm/

[PATCH 1/4] drm/amd/powerplay: add SMU mode1 reset

2020-07-09 Thread Wenhui Sheng
>From PM FW 58.26.0 for sienna cichlid, SMU mode1 reset is support, driver sends PPSMC_MSG_Mode1Reset message to PM FW could trigger this reset. Signed-off-by: Likun Gao Signed-off-by: Wenhui Sheng --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 37 +++ .../gpu/drm/amd/power

[PATCH 3/4] drm/amdgpu: enable mode1 reset

2020-07-09 Thread Wenhui Sheng
For sienna cichlid, add mode1 reset path for sGPU. Signed-off-by: Likun Gao Signed-off-by: Wenhui Sheng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 24 -- drivers/gpu/drm/amd/amdgpu/nv.c | 32 +-- drivers/gpu/drm/amd/powerplay/navi10_ppt.c|

[PATCH 2/4] drm/amdgpu: add psp mode1 reset mode

2020-07-09 Thread Wenhui Sheng
AMD_RESET_METHOD_MODE1 will be used by SMU mode1 reset for sienna cichlid, so add AMD_RESET_METHOD_PSP_MODE1 for psp mode1 reset. Signed-off-by: Likun Gao Signed-off-by: Wenhui Sheng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- d

[PATCH 1/2] drm/amdgpu/gfx10: fix race condition for kiq

2020-07-09 Thread Jack Xiao
During preemption test for gfx10, it uses kiq to trigger gfx preemption, which would result in race condition with flushing TLB for kiq. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 2/2] drm/amdgpu: fix preemption unit test

2020-07-09 Thread Jack Xiao
Remove signaled jobs from job list and ensure the job was indeed preempted. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gp

RE: [PATCH 11/14] drm/amd/powerplay: drop Sienna Cichlid specific set_soft_freq_limited_range

2020-07-09 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks. Other ASICs from SMU V11 should need this also. A new patch was created to apply this for all SMU V11 ASICs. Please see the updated patch series. BR, Evan -Original Message- From: Alex Deucher Sent: Friday, July 10, 2020 4:45 A

RE: [PATCH 02/14] drm/amd/powerplay: update Arcturus default dpm table setting

2020-07-09 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Just sent out the updated patch series with this one splitted into two as commented. BR, Evan -Original Message- From: Alex Deucher Sent: Friday, July 10, 2020 4:39 AM To: Quan, Evan Cc: amd-gfx list ; Deucher, Alexander Subject: R

[PATCH 16/16] drm/amd/powerplay: drop unused APIs and parameters

2020-07-09 Thread Evan Quan
Leftover of previous performance level setting cleanups. Change-Id: Idddc4adce365b34eacbc13f75cc0629859c6d412 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 ++-- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 9 +++-- d

[PATCH 11/16] drm/amd/powerplay: drop unnecessary Sienna Cichlid specific APIs

2020-07-09 Thread Evan Quan
As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: I04c810859794b07ce8905a8df797ed6b5ae116a8 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 178 +- 1 file ch

[PATCH 10/16] drm/amd/powerplay: drop unnecessary Navi1x specific APIs

2020-07-09 Thread Evan Quan
As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: I2c8831b9d00618c6578ee42b34e26892c5dba515 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 248 + 1 file ch

[PATCH 01/16] drm/amd/powerplay: add more members for dpm table

2020-07-09 Thread Evan Quan
These members can help to cache the clock frequencies for all dpm levels. Then simplifying the code for dpm level switching is possible. Change-Id: Ic80359adb8c0e018f306782f24e3f8906436f5e2 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 15

[PATCH 05/16] drm/amd/powerplay: update Sienna Cichlid default dpm table setup

2020-07-09 Thread Evan Quan
Cache all clocks levels for every dpm table. They are needed by other APIs. Change-Id: Idaa853356720e48ab3279f420ba1ae18bb7de4fd Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 234 -- 1 file changed, 211 insertions(+), 23 d

[PATCH 12/16] drm/amd/powerplay: drop Sienna Cichlid specific set_soft_freq_limited_range

2020-07-09 Thread Evan Quan
Use the common smu_v11_0_set_soft_freq_limited_range. Change-Id: I9f8772880b324ce9e741291751bb1b8ff4c36ea3 Signed-off-by: Evan Quan --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 20 ++- drivers/gpu/drm/amd/powerplay/smu_internal.h | 1 - drivers/gpu/drm/amd/powerplay/smu_

[PATCH 13/16] drm/amd/powerplay: apply gfxoff disablement/enablement for all SMU11 ASICs

2020-07-09 Thread Evan Quan
Before and after setting gfx clock soft max/min frequency. Change-Id: I6f828da8de096ebc0ae27eaa89f988def2d547ec Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0

[PATCH 14/16] drm/amd/powerplay: drop unnecessary wrappers

2020-07-09 Thread Evan Quan
By calling the target APIs directly. Change-Id: I0f24f603d2fcb94d2078a35c405a1406093ba5e3 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 15/16] drm/amd/powerplay: drop smu_v12_0.c unnecessary wrapper

2020-07-09 Thread Evan Quan
By moving the implemention to renoir_ppt.c considering it's really ASIC specific. Change-Id: I6f7a594235dffdf75b56d1de5b9dc6d49833d7e8 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 3 - drivers/gpu/drm/amd/powerplay/renoir_ppt.c| 17

[PATCH 06/16] drm/amd/powerplay: add new UMD pstate data structure

2020-07-09 Thread Evan Quan
This is used to cache the clock frequencies for all UMD pstates. So that we do not need to calculate from scratch on every UMD pstate switch. Change-Id: I3f2ef5ee2e6e433518f726988bbe5970848b99c8 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.

[PATCH 09/16] drm/amd/powerplay: drop unnecessary Arcturus specific APIs

2020-07-09 Thread Evan Quan
As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: Icd96ce42218d78d670dd0c1f88663fd42108b311 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 170 --- 1 file ch

[PATCH 07/16] drm/amd/powerplay: update UMD pstate clock settings

2020-07-09 Thread Evan Quan
Preparing for coming code sharing around performance level setting. Change-Id: I51b1536b62995f0fecd51b91f238793f57485aa9 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 6 +- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 47 ++--- dr

[PATCH 02/16] drm/amd/powerplay: implement a common set dpm table API for smu V11

2020-07-09 Thread Evan Quan
Maximum the code sharing around smu V11. Change-Id: Ice0a874f3f70457f1012ca566f9f784ff3e9cd94 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 4 ++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 38 +++ 2 files changed, 42 insertions(+) diff --git

[PATCH 08/16] drm/amd/powerplay: update the common API for performance level setting

2020-07-09 Thread Evan Quan
So that it can be more widely shared around SMU v11 ASICs. Change-Id: Ie110edf2ec519699448d3ff3215188ba243d2415 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 91 +++ 1 file changed, 77 insertions(+), 14 deletions(-) diff

[PATCH 03/16] drm/amd/powerplay: update Arcturus default dpm table setting

2020-07-09 Thread Evan Quan
Preparing for coming code sharing around performance level setting. Change-Id: Iaa77af7a272121503f09ad5fbfbe9dff2d2597b1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 297 --- 1 file changed, 119 insertions(+), 178 deletions(-) diff --git a/drivers/

[PATCH 04/16] drm/amd/powerplay: update Navi10 default dpm table setup

2020-07-09 Thread Evan Quan
Cache all clocks levels for every dpm table. They are needed by other APIs. Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 182 ++--- 1 file changed, 158 insertions(+), 24 d

RE: [PATCH] drm/amd/powerplay: update driver if file for sienna_cichlid

2020-07-09 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng Best Regards Kenneth -Original Message- From: Gao, Likun Sent: Friday, July 10, 2020 11:10 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Gao, Likun Subject: [PATCH] drm/amd/po

[PATCH] drm/amd/powerplay: update driver if file for sienna_cichlid

2020-07-09 Thread Likun Gao
From: Likun Gao Update sienna_cichlid driver if header and related files. Signed-off-by: Likun Gao Change-Id: If303e7fca32ebf922ee5d918855bbaca8dc61d38 --- .../inc/smu11_driver_if_sienna_cichlid.h| 17 + drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 2 +- .../gpu/d

RE: [PATCH] drm/amd/smu: correct a mistake

2020-07-09 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] There is already a patch for this. https://lists.freedesktop.org/archives/amd-gfx/2020-July/051134.html -Original Message- From: chen gong Sent: Thursday, July 9, 2020 6:41 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Gong, Cu

Re: [PATCH] drm/amdgpu: minor cleanup of phase1 suspend code

2020-07-09 Thread Alex Deucher
On Thu, Jul 9, 2020 at 3:15 PM Nirmoy Das wrote: > > Cleanup of phase1 suspend code to reduce unnecessary indentation. > > Signed-off-by: Nirmoy Das Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 -- > 1 file changed, 13 insertions(+), 10 de

Re: [PATCH 6/6] drm/amd/powerplay: drop unused code around thermal range setting

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:59 AM Evan Quan wrote: > > Leftover of previous cleanups. > > Change-Id: I36a018349647125513e47edda66db2005bd8b0c5 > Signed-off-by: Evan Quan Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 32 --- > .../gpu

Re: [PATCH 2/2] drm/amd/powerplay: correct the supported pcie GenSpeed and LaneCount

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:55 AM Evan Quan wrote: > > The LCLK dpm table setup should be performed in .update_pcie_parameters(). > Otherwise, the updated GenSpeed and LaneCount information will be lost. > > Change-Id: I028c26ca0e54098cb93d9e9266719f1762ba2d7e > Signed-off-by: Evan Quan Series is:

Re: [PATCH 14/14] drm/amd/powerplay: drop unused APIs and parameters

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:34 AM Evan Quan wrote: > > Leftover of previous performance level setting cleanups. > > Change-Id: Idddc4adce365b34eacbc13f75cc0629859c6d412 > Signed-off-by: Evan Quan patches 5-10, 12-14: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

Re: [PATCH 11/14] drm/amd/powerplay: drop Sienna Cichlid specific set_soft_freq_limited_range

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:34 AM Evan Quan wrote: > > Use the common smu_v11_0_set_soft_freq_limited_range. > > Change-Id: I9f8772880b324ce9e741291751bb1b8ff4c36ea3 > Signed-off-by: Evan Quan > --- > .../drm/amd/powerplay/sienna_cichlid_ppt.c| 20 ++- > drivers/gpu/drm/amd/powe

Re: [PATCH 04/14] drm/amd/powerplay: update Sienna Cichlid default dpm table setup

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:33 AM Evan Quan wrote: > > Cache all clocks levels for every dpm table. They are needed > by other APIs. > > Change-Id: Idaa853356720e48ab3279f420ba1ae18bb7de4fd > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- > .../drm/amd/powerplay/sienna_cichlid_ppt.c

Re: [PATCH 03/14] drm/amd/powerplay: update Navi10 default dpm table setup

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:33 AM Evan Quan wrote: > > Cache all clocks levels for every dpm table. They are needed > by other APIs. > > Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71 > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c |

Re: [PATCH 01/14] drm/amd/powerplay: add more members for dpm table

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:33 AM Evan Quan wrote: > > These members can help to cache the clock frequencies for all > dpm levels. Then simplifying the code for dpm level switching > is possible. > > Change-Id: Ic80359adb8c0e018f306782f24e3f8906436f5e2 > Signed-off-by: Evan Quan Reviewed-by: Alex D

Re: [PATCH 02/14] drm/amd/powerplay: update Arcturus default dpm table setting

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:33 AM Evan Quan wrote: > > Preparing for coming code sharing around performance level > setting. > > Change-Id: Ie32b6af39f22d05c08096959bab0e02e53856170 > Signed-off-by: Evan Quan You might want to split this into two patches, one to split out the smu_v11_0_set_single_d

Re: [PATCH] drm/amd/powerplay: correct the .get_workload_type() pointer

2020-07-09 Thread Alex Deucher
On Fri, Jul 3, 2020 at 4:54 AM Evan Quan wrote: > > This seemed a typo. > > Change-Id: I1e4da590829395617e90d0d43562f934a1ae0234 > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/smu_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 4/4] drm/amd/powerplay: put dpm frequency setting common code in smu_v11_0.c

2020-07-09 Thread Alex Deucher
On Thu, Jul 2, 2020 at 5:47 AM Evan Quan wrote: > > As designed the common code shared among all smu v11 ASCIs go to > smu_v11_0.c. This helps to maintain clear code layers. > > Change-Id: I1f848eba0b6b56f8b5ef6f0888ee6955ba1d2070 > Signed-off-by: Evan Quan Series is: Reviewed-by: Alex Deucher

Re: [PATCH 4/4] drm/amd/powerplay: drop unused code and wrapper around clock retrieving

2020-07-09 Thread Alex Deucher
On Thu, Jul 2, 2020 at 5:45 AM Evan Quan wrote: > > Clean code by dropping unnecessary ones. > > Change-Id: Idf89ef6fa787b61cd8baf8ded7e3f323bdcef189 > Signed-off-by: Evan Quan Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8 +++- > .../gpu/drm/

[PATCH] drm/amdgpu: minor cleanup of phase1 suspend code

2020-07-09 Thread Nirmoy Das
Cleanup of phase1 suspend code to reduce unnecessary indentation. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 -- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/am

[pull] amdgpu and radeon drm-fixes-5.8

2020-07-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.8. The following changes since commit dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258: Linux 5.8-rc4 (2020-07-05 16:20:22 -0700) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.8-2020-07-09 for you to fetch chang

RE: [PATCH 2/2] drm/amdgpu: stop allocating dummy GTT nodes v2

2020-07-09 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: Christian König Sent: Thursday, July 9, 2020 8:40 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Chauhan, Madhav Subject: [PATCH 2/2] drm/amdgpu: stop allocating dummy GTT nodes v2 Now that TTM is fixed up we can fina

RE: [PATCH 1/2] drm/ttm: further cleanup ttm_mem_reg handling

2020-07-09 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: Christian König Sent: Thursday, July 9, 2020 8:40 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Chauhan, Madhav Subject: [PATCH 1/2] drm/ttm: further cleanup ttm_mem_reg handling Stop touching the backend private poi

[PATCH 2/2] drm/amdgpu: stop allocating dummy GTT nodes v2

2020-07-09 Thread Christian König
Now that TTM is fixed up we can finally stop that nonsense. v2: Update the documentation as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 106 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 18 +++- 2 files changed, 43 insertions(+),

[PATCH 1/2] drm/ttm: further cleanup ttm_mem_reg handling

2020-07-09 Thread Christian König
Stop touching the backend private pointer alltogether and make sure we never put the same mem twice by. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 46 +++-- include/drm/ttm/ttm_bo_driver.h | 2 -- 2 files changed, 26 insertions(+), 22 deleti

Re: [Intel-gfx] [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Christian König
Am 09.07.20 um 14:31 schrieb Daniel Vetter: On Thu, Jul 9, 2020 at 2:11 PM Daniel Stone wrote: On Thu, 9 Jul 2020 at 09:05, Daniel Vetter wrote: On Thu, Jul 09, 2020 at 08:36:43AM +0100, Daniel Stone wrote: On Tue, 7 Jul 2020 at 21:13, Daniel Vetter wrote: Comes up every few years, gets so

[PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-09 Thread Daniel Vetter
Comes up every few years, gets somewhat tedious to discuss, let's write this down once and for all. What I'm not sure about is whether the text should be more explicit in flat out mandating the amdkfd eviction fences for long running compute workloads or workloads where userspace fencing is allowe

Re: [Intel-gfx] [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Daniel Vetter
On Thu, Jul 9, 2020 at 2:11 PM Daniel Stone wrote: > > On Thu, 9 Jul 2020 at 09:05, Daniel Vetter wrote: > > On Thu, Jul 09, 2020 at 08:36:43AM +0100, Daniel Stone wrote: > > > On Tue, 7 Jul 2020 at 21:13, Daniel Vetter wrote: > > > > Comes up every few years, gets somewhat tedious to discuss, l

Re: [Intel-gfx] [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Daniel Stone
On Thu, 9 Jul 2020 at 09:05, Daniel Vetter wrote: > On Thu, Jul 09, 2020 at 08:36:43AM +0100, Daniel Stone wrote: > > On Tue, 7 Jul 2020 at 21:13, Daniel Vetter wrote: > > > Comes up every few years, gets somewhat tedious to discuss, let's > > > write this down once and for all. > > > > Thanks fo

Re: [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Christian König
Am 07.07.20 um 22:12 schrieb Daniel Vetter: Comes up every few years, gets somewhat tedious to discuss, let's write this down once and for all. What I'm not sure about is whether the text should be more explicit in flat out mandating the amdkfd eviction fences for long running compute workloads

[PATCH] drm/amd/smu: correct a mistake

2020-07-09 Thread chen gong
Corresponding to smu_workload_get_type(smu, type) is "get_workload_type" Signed-off-by: chen gong --- drivers/gpu/drm/amd/powerplay/smu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_internal.h b/drivers/gpu/drm/amd/powerplay/smu

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

2020-07-09 Thread Daniel Vetter
Hi Jason, Below the paragraph I've added after our discussions around dma-fences outside of drivers/gpu. Good enough for an ack on this, or want something changed? Thanks, Daniel > + * Note that only GPU drivers have a reasonable excuse for both requiring > + * &mmu_interval_notifier and &shrink

Re: [Intel-gfx] [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Daniel Vetter
On Thu, Jul 09, 2020 at 08:36:43AM +0100, Daniel Stone wrote: > Hi, > > On Tue, 7 Jul 2020 at 21:13, Daniel Vetter wrote: > > Comes up every few years, gets somewhat tedious to discuss, let's > > write this down once and for all. > > Thanks for writing this up! I wonder if any of the notes from

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-07-09 Thread Daniel Vetter
On Thu, Jul 09, 2020 at 08:29:21AM +0100, Daniel Stone wrote: > Hi, > Jumping in after a couple of weeks where I've paged most everything > out of my brain ... > > On Fri, 19 Jun 2020 at 10:43, Daniel Vetter wrote: > > On Fri, Jun 19, 2020 at 10:13:35AM +0100, Chris Wilson wrote: > > > > The prop

Re: [Intel-gfx] [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-09 Thread Daniel Vetter
On Thu, Jul 09, 2020 at 08:32:41AM +0100, Daniel Stone wrote: > Hi, > > On Wed, 8 Jul 2020 at 16:13, Daniel Vetter wrote: > > On Wed, Jul 8, 2020 at 4:57 PM Christian König > > wrote: > > > Could we merge this controlled by a separate config option? > > > > > > This way we could have the checks

Re: [Intel-gfx] [PATCH 03/25] dma-buf.rst: Document why idenfinite fences are a bad idea

2020-07-09 Thread Daniel Stone
Hi, On Tue, 7 Jul 2020 at 21:13, Daniel Vetter wrote: > Comes up every few years, gets somewhat tedious to discuss, let's > write this down once and for all. Thanks for writing this up! I wonder if any of the notes from my reply to the previous-version thread would be helpful to more explicitly

Re: [Intel-gfx] [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-09 Thread Daniel Stone
Hi, On Wed, 8 Jul 2020 at 16:13, Daniel Vetter wrote: > On Wed, Jul 8, 2020 at 4:57 PM Christian König > wrote: > > Could we merge this controlled by a separate config option? > > > > This way we could have the checks upstream without having to fix all the > > stuff before we do this? > > Since

drm: BUG: unable to handle page fault for address: 17ec6000

2020-07-09 Thread Paul Menzel
Dear Linux folks, Building Linux v5.8-rc4-25-gbfe91da29bfad with Clang/LLD 1:11~++20200701093119+ffee8040534-1~exp1 from Debian experimental for 32-bit (`ARCH=i386`), starting Weston (Wayland) or X.Org Server results in non-working screen, and Linux shows the trace below [1]. [ 502.044997

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-07-09 Thread Daniel Stone
Hi, Jumping in after a couple of weeks where I've paged most everything out of my brain ... On Fri, 19 Jun 2020 at 10:43, Daniel Vetter wrote: > On Fri, Jun 19, 2020 at 10:13:35AM +0100, Chris Wilson wrote: > > > The proposed patches might very well encode the wrong contract, that's > > > all up

Re: [Proposal] DRM: AMD: Convert logging to drm_* functions.

2020-07-09 Thread Christian König
Am 08.07.20 um 18:11 schrieb Suraj Upadhyay: Hii AMD Maintainers, I plan to convert logging of information, error and warnings inside the AMD driver(s) to drm_* functions and macros for loggin, as described by the TODO list in the DRM documentation[1]. I need your approval for the change