[PATCH 4/4] drm/amdgpu: added a sysfs interface for thermal throttling related V3

2020-05-27 Thread Evan Quan
User can check and set the enablement of throttling logging and the interval between each logging. V2: simplify the sysfs interface(no string parsing) V3: add proper lock protection on updating throttling_logging_rs.interval Change-Id: Id37710e1e7fe0aaf7cc858a554db60e583be611d Signed-off-by: Evan

[PATCH 3/4] drm/amd/powerplay: enable thermal throttling logging support V2

2020-05-27 Thread Evan Quan
Currently this feature is supported on Arcturus only. PMFW will interrupt driver the first time when thermal throttling happened and every one second afterwards if the throttling continuing. On receiving the 1st interrupt, driver logs it the first time. However, if the throttling continues, the log

[PATCH 2/4] drm/amd/powerplay: implement ASIC specific thermal throttling logging

2020-05-27 Thread Evan Quan
Enable this for Arcturus only for now. Change-Id: I4ad4fbb4f932d748849574e0f4dde01bb7db487a Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 44 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/po

[PATCH 1/4] drm/amd/powerplay: update Arcturus smu-driver headers

2020-05-27 Thread Evan Quan
To fit the latest 54.24.0 PMFW. Change-Id: I38d08da6bf5120a7902b7366e09ca3fbc2c25f54 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Reviewed-by: Kenneth Feng --- .../drm/amd/powerplay/inc/smu11_driver_if_arcturus.h | 12 ++-- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h|

RE: [PATCH] drm/amdgpu/gmc10: program the smallK fragment size

2020-05-27 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, May 28, 2020 04:29 To: amd-gfx list Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu/gmc10: program the sma

RE: [PATCH 1/1] drm/amdkfd: Fix GCC 10 compiler warning

2020-05-27 Thread Lin, Amber
[AMD Public Use] Reviewed-by: Amber Lin -Original Message- From: Kuehling, Felix Sent: Monday, May 25, 2020 10:47 PM To: amd-gfx@lists.freedesktop.org Cc: Lin, Amber Subject: [PATCH 1/1] drm/amdkfd: Fix GCC 10 compiler warning GCC 10 was complaining about how we append data to a bu

[pull] amdgpu, amdkfd drm-next-5.8

2020-05-27 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.8. The following changes since commit c41219fda6e04255c44d37fd2c0d898c1c46abf1: Merge tag 'drm-intel-next-fixes-2020-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2020-05-21 10:44:33 +1000) are available in the Git repository at: git://

Re: Flaky brightness on Renoir

2020-05-27 Thread Alexander Monakov
Hi, it looks like part of the problem is that dmcu_load_iram is never called on Renoir, and yet is_dmcu_initialized returns true. Would you agree? Is something necessary to address that TODO still missing? It's from February of last year. Alexander On Wed, 27 May 2020, Alex Deucher wrote: > On

[PATCH] drm/amdgpu/pm: don't bail for in_suspend

2020-05-27 Thread Alex Deucher
Otherwise we disable sysfs/debugfs access with runtime pm. Fixes: f7c8d853b029df ("drm/amdgpu/pm: return an error during GPU reset or suspend") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 114 - 1 file changed, 57 insertions(+), 57 deletions(

Re: Flaky brightness on Renoir

2020-05-27 Thread Alex Deucher
On Wed, May 27, 2020 at 6:30 PM Alexander Monakov wrote: > > Hey, > > note that the driver does not call dmcu_load_iram on Renoir, as dm_late_init > has > > /* todo will enable for navi10 */ > if (adev->asic_type <= CHIP_RAVEN) { > ret = dmcu_load_iram(dmcu, params); > > and there

RE: Flaky brightness on Renoir

2020-05-27 Thread Alexander Monakov
Hey, note that the driver does not call dmcu_load_iram on Renoir, as dm_late_init has /* todo will enable for navi10 */ if (adev->asic_type <= CHIP_RAVEN) { ret = dmcu_load_iram(dmcu, params); and there's no other callsite for dmcu_load_iram. Why is it necessary anyway? The driv

[pull] amdgpu drm-fixes-5.7

2020-05-27 Thread Alex Deucher
Hi Dave, Daniel, A couple of small fixes for 5.7 The following changes since commit 7d9ff5eed4146bf026c69e766ff630bc0bd555bb: Merge tag 'amd-drm-fixes-5.7-2020-05-21' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2020-05-22 10:30:51 +1000) are available in the Git repository

Re: [PATCH] drm/amd/display: drop cursor position check in atomic test

2020-05-27 Thread Alex Deucher
Applied. Thanks! Alex On Sat, May 23, 2020 at 7:53 AM Simon Ser wrote: > > get_cursor_position already handles the case where the cursor has > negative off-screen coordinates by not setting > dc_cursor_position.enabled. > > Signed-off-by: Simon Ser > Fixes: 626bf90fe03f ("drm/amd/display: add

Re: [PATCH] drm/amdgpu/display: fix logic inversion in program_timing_sync()

2020-05-27 Thread Alex Deucher
Can we apply this for now until we can get further analysis on the actual root cause? Alex On Mon, Apr 6, 2020 at 10:44 AM Alex Deucher wrote: > > Ping again? > > Alex > > On Thu, Feb 20, 2020 at 8:27 AM Alex Deucher wrote: > > > > On Tue, Feb 4, 2020 at 9:06 AM Kazlauskas, Nicholas > > wrote:

Re: [PATCH] drm/amdgpu/gmc10: program the smallK fragment size

2020-05-27 Thread Alex Deucher
Ping? On Fri, May 22, 2020 at 6:17 PM Alex Deucher wrote: > > Explicitly set the smallk size to 0 (4k). This is the hw > default, but set it anyway just in case something else > changed it. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 4 > drivers/gpu

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread John Hubbard
On 2020-05-27 01:51, Daniel Vetter wrote: On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: On 2020-05-26 14:00, Souptick Joarder wrote: This code was using get_user_pages(), in a "Case 2" scenario (DMA/RDMA), using the

Re: [PATCH] drm/amdgpu: Improve the MTYPE comments

2020-05-27 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Tuesday, May 26, 2020 8:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdgpu: Improve the MTYPE comments Use words insteads of acronym for bet

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > > On 2020-05-26 14:00, Souptick Joarder wrote: > > > This code was using get_user_pages(), in a "Case 2" scenario > > > (DMA/RDMA), using the categorization from [1]. Tha

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Daniel Vetter
On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > On 2020-05-26 14:00, Souptick Joarder wrote: > > This code was using get_user_pages(), in a "Case 2" scenario > > (DMA/RDMA), using the categorization from [1]. That means that it's > > time to convert the get_user_pages() + release_pa

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread John Hubbard
On 2020-05-26 14:00, Souptick Joarder wrote: This code was using get_user_pages(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages() + release_pages() calls to pin_user_pages() + unpin_user_pages() calls. There is some