Fix a kernel-doc warning of missing struct field desription:
../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:331: warning: Function
parameter or member 'hdcp_workqueue' not described in 'amdgpu_display_manager'
Fixes: 52704fcaf74b ("drm/amd/display: Initialize HDCP work queue")
Signed-off-b
Fix a kernel-doc warning of missing struct field desription:
../drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:92: warning: Function parameter or
member 'vm' not described in 'amdgpu_vm_eviction_lock'
Fixes: a269e44989f3 ("drm/amdgpu: Avoid reclaim fs while eviction lock")
Signed-off-by: Randy Dunlap
C
The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c:485:66-71:
WARNING: conversion to bool not needed here
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c:896:68-73:
WARNING: c
发件人：Markus Elfring
发送日期：2020-04-19 17:34:47
收件人：Bernard Zhao
,amd-gfx@lists.freedesktop.org,dri-de...@lists.freedesktop.org,Alex
Deucher ,"Christian König"
,Chunming Zhou
抄送人：Andrzej Pietrasiewicz ,Daniel Vetter
,David Airlie ,Dhinakaran Pandiyan
,"José Roberto de Souza"
,Lyude Paul ,Neil
Hello Team,
I'm working on adding Adaptive Sync feature in Xserver/modesetting. When
understanding the existing AMD's implementation, I've few doubts regarding
the vrr property being set on the Window from MESA.
I have made the modifications in xserver/modesetting but when i launch the
applicatio
From: Markus Elfring
Date: 2020-04-19 17:05:07
To: Bernard Zhao
,amd-gfx@lists.freedesktop.org,dri-de...@lists.freedesktop.org,Alex
Deucher ,"Christian König"
,Chunming Zhou ,"Felix Kühling"
Cc: ker...@vivo.com,linux-ker...@vger.kernel.org,Daniel Vetter
,David Airlie
Subject: Re: [PATCH
Christian
>>> Well I was under the assumption that this is actually what is done here.
If that is not the case the patch is a rather clear NAK.
<<<
There are two kinds of problems in the current KIQ reading reg, Yintian tend to
fix one of them but not all ...
The first problem is :
During the
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Huang Rui
-Original Message-
From: Liang, Prike
Sent: Monday, April 20, 2020 10:11 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Huang, Ray
; Liang, Prike
Subject: [PATCH] drm/amd/powerplay: update smu12_d
Ras error occurs while gpu recovery. We can not add its list head
to two lists at same time.
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/dr
Hi Felix
Many thanks for your review. I have modified it according to your comments and
suggestion.
Best Regards
Yintian Tao
-Original Message-
From: Kuehling, Felix
Sent: 2020年4月17日 23:39
To: Tao, Yintian ; Liu, Monk
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu:
Update the smu12_driver_if.h header to follow the pmfw release.
Signed-off-by: Prike Liang
Reviewed-by: Alex Deucher
---
.../gpu/drm/amd/powerplay/inc/smu12_driver_if.h| 40 ++
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/
Track GPU memory usage on a per process basis and report it through
sysfs.
Signed-off-by: Mukul Joshi
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 12 ++
drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 7
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 51 ++--
3 files chan
发件人：Markus Elfring
发送日期：2020-04-19 02:18:06
收件人：Bernard Zhao ,Alex Deucher
,"Christian König"
,amd-gfx@lists.freedesktop.org,dri-de...@lists.freedesktop.org
抄送人："Felix Kühling"
,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com,Chunming
Zhou ,Daniel Vetter ,David Airlie
主题：Re: [PAT
> Maybe we could reduce the mutex_lock(&mem->lock)`s protected code area,
> and noneed to protect pr_debug.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Do you imagine that data synchronisation should evolve in other ways?
Regards,
Markus
_
kvfree ensure that the null pointer will do nothing.
If addr is NULL, first is_vmalloc_addr will not enter,
and kfree function just return when addr is NULL. There
will be no risk here.
Signed-off-by: Bernard Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +--
1 file changed, 1 insertion(+)
> kvfree ensure that the null pointer will do nothing.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Are you looking for further questionable condition checks?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_han
The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.
Signed-off-by: Bernard Zhao
w
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/am
> There is no need to if check again,
Thanks for this information.
* Should the function name be mentioned in this change description?
* Would you like to adjust the patch subject?
> maybe we could merge into the above else branch.
I suggest to reconsider this wording.
…
> +++ b/drivers/gpu
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Would you like to adjust the patch subject?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception hand
Am 17.04.20 um 17:39 schrieb Felix Kuehling:
Am 2020-04-17 um 2:53 a.m. schrieb Yintian Tao:
According to the current kiq read register method,
there will be race condition when using KIQ to read
register if multiple clients want to read at same time
just like the expample below:
1. client-A sta
Am 17.04.20 um 23:43 schrieb Rodrigo Siqueira:
Hi,
Wyatt made the below patch for fixing this issue. I can apply it on top
of this patchset if you all agree.
[Why]
Current code does not guarantee the correct endianness of memory being
copied to fw, specifically in the case where cpu isn't littl
Am 17.04.20 um 17:40 schrieb Harry Wentland:
On 2020-04-17 8:09 a.m., Christian König wrote:
Am 17.04.20 um 12:43 schrieb Michel Dänzer:
On 2020-04-17 11:22 a.m., Christian König wrote:
Agreed, just wanted to reply as well since I think something is not
correctly understood here.
The cpu_to_b
[AMD Public Use]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Dennis Li
Sent: Saturday, April 18, 2020 12:11 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
; Zhou1, Tao ; Zhang, Hawking
; Chen, Guchun
Cc: Li, Dennis
Subject: [PATCH] drm/amdgpu: repla
23 matches
Mail list logo
