Re: [PATCH] drm/amd/powerplay: implement the is_dpm_running()

2020-04-02 Thread Huang Rui
On Fri, Apr 03, 2020 at 02:03:32PM +0800, Liang, Prike wrote: > As the pmfw hasn't exported the interface of SMU feature > mask to APU SKU so just force on all the features to driver > inquired interface at early initial stage. > > Signed-off-by: Prike Liang Reviewed-by: Huang Rui > --- > dri

Re: [PATCH] drm/amdgpu: fix gfx hang during suspend with video playback

2020-04-02 Thread Huang Rui
(+ Felix) On Fri, Apr 03, 2020 at 12:07:53PM +0800, Liang, Prike wrote: > The system will be hang up during S3 as SMU is pending at GC not > respose the register CP_HQD_ACTIVE access request and this issue > can be fixed by adding RLC safe mode guard before each HQD > map/unmap retrive opt. We ne

[PATCH] drm/amd/powerplay: implement the is_dpm_running()

2020-04-02 Thread Prike Liang
As the pmfw hasn't exported the interface of SMU feature mask to APU SKU so just force on all the features to driver inquired interface at early initial stage. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 12 1 file changed, 12 insertions(+) diff --gi

[PATCH] drm/amdgpu: add SPM golden settings for Navi10

2020-04-02 Thread Tianci Yin
From: "Tianci.Yin" Add RLC_SPM golden settings Change-Id: I616e127171293d915cb3a05dee02f51cec8d8f6f Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c|9 + .../gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h | 1058 + 2 files changed, 1067 insertions(+)

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Masami Hiramatsu
On Thu, 2 Apr 2020 16:13:08 +0200 Peter Zijlstra wrote: > On Thu, Apr 02, 2020 at 09:33:54AM +0200, Christian König wrote: > > Hi Jann, > > > > Am 02.04.20 um 04:34 schrieb Jann Horn: > > > [x86 folks in CC so that they can chime in on the precise rules for this > > > stuff] > > > > > > Hi! >

RE: [PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Zhang, Jack (Jian)
Thanks Monk, I just updated the patch and it could passed 1000 rounds TDR test. Sent out an review email. Regards, Jack -Original Message- From: Liu, Monk Sent: Friday, April 3, 2020 11:38 AM To: Kuehling, Felix ; Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH]

[PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Jack Zhang
kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate Without this change, sriov tdr code path will never free those allocated memories and get memory leak. v2:add a bugfix for kiq ring test fail Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 3 +

RE: [PATCH] drm/amd/powerplay: avoid using pm_en before it is initialized

2020-04-02 Thread Zhou, Tiecheng
[AMD Official Use Only - Internal Distribution Only] Ping... -Original Message- From: Tiecheng Zhou Sent: Thursday, April 2, 2020 5:29 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou, Tiecheng ; Tao, Yintian Subject: [PATCH] drm/amd/powerplay: avoid using pm_en before it is initialized

[PATCH] drm/amdgpu: fix gfx hang during suspend with video playback

2020-04-02 Thread Prike Liang
The system will be hang up during S3 as SMU is pending at GC not respose the register CP_HQD_ACTIVE access request and this issue can be fixed by adding RLC safe mode guard before each HQD map/unmap retrive opt. Signed-off-by: Prike Liang Tested-by: Mengbing Wang --- drivers/gpu/drm/amd/amdgpu/

RE: [PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Liu, Monk
Thanks Felix Hi Jack I think below changes can resolve your problem , we had this on our customer branch already, it fix the memory leak, and also fix my previous bug . Can you make this change applied to gfx_v10/v9 ? thanks ! diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c b/d

RE: [PATCH] drm/amd/powerplay: determine pm_en at amd_powerplay_create

2020-04-02 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Tiecheng Zhou Sent: Thursday, April 2, 2020 1:40 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou, Tiecheng Subject: [PATCH] drm/amd/powerplay: determine pm_en at amd_powerplay_create Need to determine pm_en at amd_power

Re: [PATCH v2] drm/amdkfd: Provide SMI events watch

2020-04-02 Thread Felix Kuehling
On 2020-04-02 4:46 p.m., Amber Lin wrote: When the compute is malfunctioning or performance drops, the system admin will use SMI (System Management Interface) tool to monitor/diagnostic what went wrong. This patch provides an event watch interface for the user space to register events they are in

[PATCH v2] drm/amdkfd: Provide SMI events watch

2020-04-02 Thread Amber Lin
When the compute is malfunctioning or performance drops, the system admin will use SMI (System Management Interface) tool to monitor/diagnostic what went wrong. This patch provides an event watch interface for the user space to register events they are interested. After the event is registered, the

Re: [PATCH] drm/amd/display: re-order asic declarations

2020-04-02 Thread Liu, Zhan
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Shirish S Sent: Thursday, April 2, 2020 5:15 AM To: Deucher, Alexander ; Wentland, Harry ; Li, Sun peng (Leo) Cc: amd-gfx@lists.freedesktop.org ; S, Shirish Subject: [PATCH] drm/amd/display: re-order asic de

Re: [PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Felix Kuehling
[+Monk] This looks reasonable to me. However, you're effectively reverting this commit by Monk: a03eb637d2a5 drm/amdgpu: fix KIQ ring test fail in TDR of SRIOV In hind-sight, Monk's commit was broken. Removing the call to pre_reset has other consequences, such as breaking notifications about res

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Jann Horn
On Thu, Apr 2, 2020 at 11:36 AM Thomas Gleixner wrote: > Jann Horn writes: > > On Thu, Apr 2, 2020 at 9:34 AM Christian König > > wrote: > >> Am 02.04.20 um 04:34 schrieb Jann Horn: > >> > [x86 folks in CC so that they can chime in on the precise rules for > >> > this stuff] > > They are pretty

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Peter Zijlstra
On Thu, Apr 02, 2020 at 09:33:54AM +0200, Christian König wrote: > Hi Jann, > > Am 02.04.20 um 04:34 schrieb Jann Horn: > > [x86 folks in CC so that they can chime in on the precise rules for this > > stuff] > > > > Hi! > > > > I noticed that several makefiles under drivers/gpu/drm/amd/display/

Re: Possibility of RX570 responsible for spontaneous reboots (MCE) with Ryzen 3700x?

2020-04-02 Thread Clemens Eisserer
Hi Someguy, Your findings sound very familiar, my machine is also rock-solid running Windows-10 - most of the MCEs happened for me with low-load situations but firefox playing youtube in background. First I didn't care that much - but now having experienced corrupted firefox profiles and lost spre

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Jann Horn
On Thu, Apr 2, 2020 at 9:34 AM Christian König wrote: > Am 02.04.20 um 04:34 schrieb Jann Horn: > > [x86 folks in CC so that they can chime in on the precise rules for this > > stuff] > > I noticed that several makefiles under drivers/gpu/drm/amd/display/dc/ > > turn on floating-point instruction

Re: Possibility of RX570 responsible for spontaneous reboots (MCE) with Ryzen 3700x?

2020-04-02 Thread someguy108
Hello! I saw Clemens Eisserer email regarding MCE errors with his RX 570 and 3700x, and I like to add to that list of MCE spontaneous reboots as well. This is my configuration: -Ryzen 3900x + Noctua D15 -MSI X570 Unify (latest agesa as of writing) -DDR4 3200mhz 32GB kit -Sapphire Pulse 5700 XT -Cor

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Thomas Gleixner
Jann Horn writes: > On Thu, Apr 2, 2020 at 9:34 AM Christian König > wrote: >> Am 02.04.20 um 04:34 schrieb Jann Horn: >> > [x86 folks in CC so that they can chime in on the precise rules for >> > this stuff] They are pretty simple. Any code using FPU needs to be completely isolated from regul

[PATCH] drm/amd/powerplay: avoid using pm_en before it is initialized

2020-04-02 Thread Tiecheng Zhou
hwmgr->pm_en is initialized at hwmgr_hw_init. during amdgpu_device_init, there is amdgpu_asic_reset that calls to pp_get_asic_baco_capability, while hwmgr->pm_en has not yet been initialized. so avoid using pm_en in pp_get_asic_baco_capability. Signed-off-by: Tiecheng Zhou Signed-off-by: Yintian

[PATCH] drm/amd/display: re-order asic declarations

2020-04-02 Thread Shirish S
"1382d6409891 drm/amd/display: Fix RV2 Variant Detection" introduces build error of: "use of undeclared identifier 'RENOIR_A0'" To fix the same, this patch re-orders the ASIC declarations accordingly. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/display/include/dal_asic_id.h | 6 -- 1 f

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-02 Thread Christian König
Hi Jann, Am 02.04.20 um 04:34 schrieb Jann Horn: [x86 folks in CC so that they can chime in on the precise rules for this stuff] Hi! I noticed that several makefiles under drivers/gpu/drm/amd/display/dc/ turn on floating-point instructions in the compiler flags (-mhard-float, -msse and -msse2)

RE: [PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Zhang, Jack (Jian)
-Original Message- From: Jack Zhang Sent: Thursday, April 2, 2020 3:20 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate Without this

[PATCH] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-02 Thread Jack Zhang
kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate Without this change, sriov tdr code path will never free those allocated memories and get memory leak. Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a