[AMD Official Use Only - Internal Distribution Only]
Resolved issue with inputting an incorrect UMC channel index into the UMC error
address record.
Defined macros for repetitive for loops
Thank you,
John Clements
0001-drm-amdgpu-updated-UMC-error-address-record-with-cor.patch
Description: 00
[AMD Public Use]
Reviewed-and-tested-by: Guchun Chen
From: Clements, John
Sent: Tuesday, January 7, 2020 11:54 AM
To: amd-gfx@lists.freedesktop.org; dl.srdc_lnx_ras
Subject: [PATCH] drm/amdgpu: resolved bug in UMC RAS CE query
[AMD Official Use Only - Internal Distribution Only]
Submitting
[AMD Official Use Only - Internal Distribution Only]
Not necessary, but I wanted to make the register all access’ consistent.
In a future patch I shall replace the MMIO register offsets with the SMN
offsets directly instead of having *4 all over the place.
Thank you,
John Clements
From: Zhou1,
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Tao Zhou mailto:tao.zh...@amd.com>>
BTW, are you sure replacing RREG32/WREG32 with RREG32/WREG32_PCIE is also
necessary to fix the bug?
Regards,
Tao
From: Clements, John
Sent: 2020年1月7日 11:54
To: amd-gfx@lists.freedesktop.org;
On Mon, Jan 6, 2020 at 11:59 PM Arvid Brodin wrote:
>
> Hi,
>
> So I tried to use my RX 5500 XT for the first time today. Kernel updated to
> 5.4.8, fresh navi14 firmware files fetched from the linux-firmware repo, and
> of course power cable connected to the card.
>
> Booting the kernel hangs w
Hi,
So I tried to use my RX 5500 XT for the first time today. Kernel updated to
5.4.8, fresh navi14 firmware files fetched from the linux-firmware repo, and of
course power cable connected to the card.
Booting the kernel hangs when the graphics are initialized (on two different
OS:es: Ubuntu
[AMD Official Use Only - Internal Distribution Only]
Submitting patch to access CE registers via SMN and disable UMC indexing mode.
Thank you,
John Clements
0001-drm-amdgpu-resolved-bug-in-UMC-RAS-CE-query.patch
Description: 0001-drm-amdgpu-resolved-bug-in-UMC-RAS-CE-query.patch
___
Hi there,
Thank you for raising this question. Here are my two cents that came from my
own experience:
>From what you mentioned in the community thread, you tried multiple kernel
>versions on vanilla Manjaro. However, it seems like you didn't upgrade any
>user-mode driver, and I suspect that's
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Koenig, Christian
Sent: Monday, January 6, 2020 10:23 AM
To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org;
Sierra Guiza, Alejandro (Alex)
Subject: Re: [PATCH 2/5] drm/amdgpu: export function to flush TLB
On Thu, Jan 2, 2020 at 10:14 AM Harry Wentland wrote:
>
> On 2019-12-02 4:47 p.m., Thomas Anderson wrote:
> > For high-res (8K) or HFR (4K120) displays, using uncompressed pixel
> > formats like YCbCr444 would exceed the bandwidth of HDMI 2.0, so the
> > "interesting" modes would be disabled, leav
On Mon, Jan 6, 2020 at 1:34 AM Quan, Evan wrote:
>
> Ping..
>
Reviewed-by: Alex Deucher
> > -Original Message-
> > From: Quan, Evan
> > Sent: Friday, January 3, 2020 5:47 PM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Quan, Evan
> > Subject: [PATCH] drm/amd/powerplay: issue proper h
On Fri, Jan 3, 2020 at 4:47 AM Evan Quan wrote:
>
> Provided an unified entry point. And fixed the confusing that the API
> usage is conflict with what the naming implies.
At some point it would be nice to unify the interfaces between
powerplay and swSMU so we don't seem all the is_sw_smu checks,
On Fri, Jan 3, 2020 at 2:34 PM Wambui Karuga wrote:
>
> list_for_each() can be replaced by the more concise
> list_for_each_entry() here for iteration over the lists.
> This change was reported by coccinelle.
>
> Signed-off-by: Wambui Karuga
Applied. Thanks!
Alex
> ---
> .../drm/amd/display/
On Fri, Jan 3, 2020 at 2:34 PM Wambui Karuga wrote:
>
> As single statement conditionals do not need to be wrapped around
> braces, the unnecessary braces can be removed.
>
> Signed-off-by: Wambui Karuga
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/atombios_crtc.c | 3 +--
> driv
On Fri, Jan 3, 2020 at 2:34 PM Wambui Karuga wrote:
>
> Remove unnecessary variable comparisions to true/false in if statements
> and check the value of the variable directly.
>
> Signed-off-by: Wambui Karuga
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/radeon/cik_sdma.c | 2
On 2020-01-06 3:45 p.m., Alex Deucher wrote:
This reverts commit 51bfac71cade386966791a8db87a5912781d249f.
This causes stability issues on some raven boards. Revert
for now until a proper fix is completed.
Bug: https://gitlab.freedesktop.org/drm/amd/issues/934
Bug: https://bugzilla.kernel.org/
On 2020-01-06 10:03 a.m., Christian König wrote:
If provided we only sync to the BOs reservation
object and no longer to the root PD.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c| 7 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 --
On 2020-01-06 10:03 a.m., Christian König wrote:
When a BO is evicted immedially invalidate the mapped PTEs.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amd
This reverts commit 51bfac71cade386966791a8db87a5912781d249f.
This causes stability issues on some raven boards. Revert
for now until a proper fix is completed.
Bug: https://gitlab.freedesktop.org/drm/amd/issues/934
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206017
Signed-off-by: Alex Deuc
Am 06.01.20 um 20:58 schrieb Alex Deucher:
Put it on one line to avoid whitespace issues when
printing in the log.
Signed-off-by: Alex Deucher
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +--
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 +--
2 files change
Am 06.01.20 um 20:16 schrieb Felix Kuehling:
On 2020-01-06 1:35 p.m., Alex Deucher wrote:
So it can be shared with newer GMC versions.
Signed-off-by: Alex Deucher
Reviewed-by: Felix Kuehling
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 40
No idea either why that was done.
Anyway patch is Acked-by: Christian König .
Regards,
Christian.
Am 06.01.20 um 20:16 schrieb Felix Kuehling:
This patch is
Acked-by: Felix Kuehling
I don't really know why the mask was different on GFXv10. I suspect it
was laziness/simplicity of not having
Hi AMD graphic driver developer for Linux!
I have problems with playing games using Linux opensource driver
I have xfx radeon rx 590 fatboy and tested with proprietary driver games
run fine but too slow for playing
here is bit more info about my experience
ask me anything
https://community
Put it on one line to avoid whitespace issues when
printing in the log.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +--
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v1
On 2020-01-06 1:35 p.m., Alex Deucher wrote:
So it can be shared with newer GMC versions.
Signed-off-by: Alex Deucher
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 40 +
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 +
drivers/gpu/drm
This patch is
Acked-by: Felix Kuehling
I don't really know why the mask was different on GFXv10. I suspect it
was laziness/simplicity of not having the gap at engines 2,3. If we
don't have as many rings on GFXv10 ASICs we probably don't need engines 0,1.
Regards,
Felix
On 2020-01-06 1:35
Rather than open coding it. This also changes the free masks
to better reflect the usage by other components.
Signed-off-by: Alex Deucher
---
We always started at invalidation engine 4 on gmc10. Was there a
reason for that? I would have figured it would follow the same
model as older asics.
So it can be shared with newer GMC versions.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 40 +
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 +
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 32 +---
drivers/gpu/drm/amd/amdgpu/gmc_v
Am 06.01.20 um 17:04 schrieb Felix Kuehling:
On 2020-01-05 10:41 a.m., Christian König wrote:
Am 20.12.19 um 07:24 schrieb Alex Sierra:
This can be used directly from amdgpu and amdkfd to invalidate
TLB through pasid.
It supports gmc v7, v8, v9 and v10.
Change-Id: I6563a8eba2e42d1a67fa2547156c
On 2020-01-05 10:41 a.m., Christian König wrote:
Am 20.12.19 um 07:24 schrieb Alex Sierra:
This can be used directly from amdgpu and amdkfd to invalidate
TLB through pasid.
It supports gmc v7, v8, v9 and v10.
Change-Id: I6563a8eba2e42d1a67fa2547156c20da41d1e490
Signed-off-by: Alex Sierra
---
This allows to invalidate VM entries without taking the reservation lock.
v3: use -EBUSY
Signed-off-by: Christian König
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 39 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +++
2 files changed, 36 i
Make sure that we never allocate a page table for an invalidation operation.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu
When a BO is evicted immedially invalidate the mapped PTEs.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_
Allows us to reduce the overhead while syncing to fences a bit.
v2: also drop adev parameter from the functions
Signed-off-by: Christian König
Reviewed-by: Felix Kuehling
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 19 +++---
We need to update page tables without any lock held.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
i
Hi guys,
I'm still narrowing down one problem with the glob lru lock, but that only
happens in a constructed test case so far.
Please take a look and comment,
Christian.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop
Don't add the VM update fences to the resv object and remove
the handling to stop implicitely syncing to them.
Ongoing updates prevent page tables from being evicted and we manually
block for all updates to complete before releasing PDs and PTS.
This way we can do updates even without the resv ob
If provided we only sync to the BOs reservation
object and no longer to the root PD.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c| 7 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4
For HMM we need to rework how VM synchronization works, so instead of the filp
use VM as job owner.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/driver
For unlocked page table updates we need to be able
to sync to fences of a specific VM.
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 8 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 3 +-
drivers
Explicitly sync VM updates to the moving fence in PDs and PTs.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 7 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 5 +
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_c
The root PD can also contain huge PDEs.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 25 +
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index
Entirely unused.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm
Am 06.01.20 um 12:29 schrieb Michel Dänzer:
On 2019-12-26 5:53 p.m., Alex Deucher wrote:
On Thu, Dec 26, 2019 at 5:11 AM Paul Menzel
[ 13.446975] [drm] Warning: check cp_fw_version and update it to realize
GRBM requires 1-cycle delay in cp firmware
Chang, it looks l
On 2019-12-26 5:53 p.m., Alex Deucher wrote:
> On Thu, Dec 26, 2019 at 5:11 AM Paul Menzel
>>
>>> [ 13.446975] [drm] Warning: check cp_fw_version and update it to realize
>>> GRBM requires 1-cycle delay in cp firmware
>>
>> Chang, it looks like you added that warning in
[Why]
When change the connection status in a MST topology, mst device
which detect the event will send out CONNECTION_STATUS_NOTIFY messgae.
e.g. src-mst-mst-sst => src-mst (unplug) mst-sst
Currently, under the above case of unplugging device, ports which have
been allocated payloads and are no l
[AMD Public Use]
> -Original Message-
> From: Lyude Paul
> Sent: Saturday, January 4, 2020 6:02 AM
> To: Lin, Wayne ; dri-de...@lists.freedesktop.org;
> amd-gfx@lists.freedesktop.org
> Cc: Kazlauskas, Nicholas ; Wentland, Harry
> ; Zuo, Jerry ;
> sta...@vger.kernel.org
> Subject: Re: [P
[AMD Public Use]
> -原始郵件-
> 寄件者: Lyude Paul
> 寄件日期: Saturday, January 4, 2020 7:34 AM
> 收件者: Lin, Wayne ; dri-
> de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
> 副本: Kazlauskas, Nicholas ; Wentland,
> Harry ; Zuo, Jerry ;
> sta...@vger.kernel.org
> 主旨: Re: [PATCH] drm/dp_mst
48 matches
Mail list logo
