RE: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP

Hi Jiange You need to send the patch to amd-gfx for review if it intend to go drm-next branch For gibraltar branch your patch is -1 by CI _ Monk Liu|GPU Virtualization Team |AMD [sig-cloud-gpu] From: Zhao, Jiange Sent: Wednesday, October 30, 2019 10:26 AM T

Re: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP

Ping. @Deng, Emily @Liu, Monk, can you help review this patch? Thanks! Jiange From: Zhao, Jiange Sent: Tuesday, October 29, 2019 3:43 PM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Liu, Monk ; Chang,

Re: [PATCH v2 13/15] drm/amdgpu: Use mmu_range_insert instead of hmm_mirror

On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Remove the interval tree in the driver and rely on the tree maintained by > the mmu_notifier for delivering mmu_notifier invalidation callbacks. > > For some reason amdgpu has a very complicated arrangement where it tries

Re: [PATCH v2 02/15] mm/mmu_notifier: add an interval tree notifier

I haven't had enough time to fully understand the deferred logic in this change. I spotted one problem, see comments inline. On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Of the 13 users of mmu_notifiers, 8 of them use only > invalidate_range_start/end() and immedia

21:9 monitor resolution incorrect since 4.14 kernel

I have a 21:9 ultrawide monitor connected to an RX 570 with the amdgpu driver. I'm still using the 4.14 kernel since with later kernels I can't get the driver to allow use of the full resolution of 2560x1080 and I'm limited to regular HD, ie 1920x1080. The latest kernel I've tried is 5.4-rc2. My di

[PATCH] drm/amdgpu/gmc10: properly set BANK_SELECT and FRAGMENT_SIZE

These were not aligned for optimal performance for GPUVM. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 9 + drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 9 + 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c b/dr

[PATCH] drm/amdgpu/renoir: move gfxoff handling into gfx9 module

To properly handle the option parsing ordering. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 ++ drivers/gpu/drm/amd/amdgpu/soc15.c| 5 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/d

[PATCH] drm/amdgpu: remove PT BOs when unmapping

The issue is PT BOs are not freed when unmapping VA, which causes vram usage accumulated is huge in some memory stress test, such as kfd big buffer stress test. Function amdgpu_vm_bo_update_mapping() is called by both amdgpu_vm_bo_update() and amdgpu_vm_clear_freed(). The solution is replacing amdg

Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror

On Tue, Oct 29, 2019 at 07:22:37PM +, Yang, Philip wrote: > Hi Jason, > > I did quick test after merging amd-staging-drm-next with the > mmu_notifier branch, which includes this set changes. The test result > has different failures, app stuck intermittently, GUI no display etc. I > am under

Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror

Hi Jason, I did quick test after merging amd-staging-drm-next with the mmu_notifier branch, which includes this set changes. The test result has different failures, app stuck intermittently, GUI no display etc. I am understanding the changes and will try to figure out the cause. Regards, Phili

[bug report] drm/amd/display: move wm ranges reporting to end of init hw

Hello Eric Yang, This is a semi-automatic email about new static checker warnings. The patch 622a88c8259e: "drm/amd/display: move wm ranges reporting to end of init hw" from Sep 24, 2019, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_seque

Re: [PATCH] drm/sched: Fix passing zero to 'PTR_ERR' warning

On 10/29/19 2:03 PM, Dan Carpenter wrote: > On Tue, Oct 29, 2019 at 11:04:44AM -0400, Andrey Grodzovsky wrote: >> Fix a static code checker warning. >> >> Signed-off-by: Andrey Grodzovsky >> --- >> drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions

[PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning

Fix a static code checker warning. v2: Drop PTR_ERR_OR_ZERO. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/sched_main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c in

Re: [PATCH] drm/sched: Fix passing zero to 'PTR_ERR' warning

On Tue, Oct 29, 2019 at 11:04:44AM -0400, Andrey Grodzovsky wrote: > Fix a static code checker warning. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/scheduler/sche

Re: [PATCH] drm/sched: Fix passing zero to 'PTR_ERR' warning

On Tue, Oct 29, 2019 at 11:04:44AM -0400, Andrey Grodzovsky wrote: > Fix a static code checker warning. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/scheduler/sche

Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem

On Tue, Oct 29, 2019 at 04:28:43PM +, Kuehling, Felix wrote: > On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > find_vma() must be called under the mmap_sem, reorganize this code to > > do the vma check after entering the lock. > > > > Further, fix the unlocked

Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem

Am 29.10.19 um 17:28 schrieb Kuehling, Felix: On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: From: Jason Gunthorpe find_vma() must be called under the mmap_sem, reorganize this code to do the vma check after entering the lock. Further, fix the unlocked use of struct task_struct's mm, instead

Re: [PATCH] drm/sched: Fix passing zero to 'PTR_ERR' warning

Am 29.10.19 um 16:04 schrieb Andrey Grodzovsky: Fix a static code checker warning. Signed-off-by: Andrey Grodzovsky Well that one was even new to me. Patch is Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem

On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: > From: Jason Gunthorpe > > find_vma() must be called under the mmap_sem, reorganize this code to > do the vma check after entering the lock. > > Further, fix the unlocked use of struct task_struct's mm, instead use > the mm from hmm_mirror which has

[PATCH] drm/sched: Fix passing zero to 'PTR_ERR' warning

Fix a static code checker warning. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index f39b97e..898b0c9 100644 --

Re: [PATCH v2 13/15] drm/amdgpu: Use mmu_range_insert instead of hmm_mirror

On Tue, Oct 29, 2019 at 07:51:30AM +, Koenig, Christian wrote: > > +static bool amdgpu_mn_invalidate_gfx(struct mmu_range_notifier *mrn, > > +const struct mmu_notifier_range *range) > > { > > - struct amdgpu_bo *bo; > > + struct amdgpu_bo *bo = container_of

[PATCH 09/13] drm/amd/display: Validate DSC caps on MST endpoints

From: David Francis During MST mode enumeration, if a new dc_sink is created, populate it with dsc caps as appropriate. Use drm_dp_mst_dsc_aux_for_port to get the raw caps, then parse them onto dc_sink with dc_dsc_parse_dsc_dpcd. Reviewed-by: Wenjing Liu Signed-off-by: David Francis --- .../

[PATCH 05/13] drm/dp_mst: Fill branch->num_ports

From: David Francis This field on drm_dp_mst_branch was never filled It is initialized to zero when the port is kzallocced. When a port is added to the list, increment num_ports, and when a port is removed from the list, decrement num_ports. v2: remember to decrement on port removal v3: don't e

[PATCH 02/13] drm/dp_mst: Add PBN calculation for DSC modes

From: David Francis With DSC, bpp can be fractional in multiples of 1/16. Change drm_dp_calc_pbn_mode to reflect this, adding a new parameter bool dsc. When this parameter is true, treat the bpp parameter as having units not of bits per pixel, but 1/16 of a bit per pixel v2: Don't add separate

[PATCH 10/13] drm/amd/display: Write DSC enable to MST DPCD

From: David Francis Rework the dm_helpers_write_dsc_enable callback to handle the MST case. Use the cached dsc_aux field. Reviewed-by: Wenjing Liu Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 19 ++- 1 file changed, 18 insertions(+), 1 dele

[PATCH 13/13] drm/amd/display: Recalculate VCPI slots for new DSC connectors

From: Mikita Lipski Since for DSC MST connector's PBN is claculated differently due to compression, we have to recalculate both PBN and VCPI slots for that connector. The function iterates through all the active streams to find, which have DSC enabled, then recalculates PBN for it and calls drm_

[PATCH 01/13] drm/amd/display: Add MST atomic routines

From: Mikita Lipski - Adding encoder atomic check to find vcpi slots for a connector - Using DRM helper functions to calculate PBN - Adding connector atomic check to release vcpi slots if connector loses CRTC - Calculate PBN and VCPI slots only once during atomic check and store them on crtc_sta

[PATCH 06/13] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

From: David Francis Add drm_dp_mst_dsc_aux_for_port. To enable DSC, the DSC_ENABLED register might have to be written on the leaf port's DPCD, its parent's DPCD, or the MST manager's DPCD. This function finds the correct aux for the job. As part of this, add drm_dp_mst_is_virtual_dpcd. Virtual D

[PATCH 11/13] drm/amd/display: MST DSC compute fair share

From: David Francis If there is limited link bandwidth on a MST network, it must be divided fairly between the streams on that network Implement an algorithm to determine the correct DSC config for each stream The algorithm: This [ ] ( ) represents the range of b

[PATCH 08/13] drm/amd/display: Initialize DSC PPS variables to 0

From: David Francis For DSC MST, sometimes monitors would break out in full-screen static. The issue traced back to the PPS generation code, where these variables were being used uninitialized and were picking up garbage. memset to 0 to avoid this Reviewed-by: Nicholas Kazlauskas Signed-off-by

[PATCH 07/13] drm/dp_mst: Add new quirk for Synaptics MST hubs

From: Mikita Lipski Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not support virtual DPCD registers, but do support DSC. The DSC caps can be read from the physical aux, like in SST DSC. These hubs have many different DEVICE_IDs. Add a new quirk to detect this case. Reviewed-by: Wenjing Liu Rev

[PATCH 12/13] drm/dp_mst: Add DSC enablement helpers to DRM

From: Mikita Lipski Adding the following elements to add MST DSC support to DRM: - dsc_enable boolean flag to drm_dp_vcpi_allocation structure to signal, which port got DSC enabled - function drm_dp_helper_update_vcpi_slots_for_dsc allows reallocation of newly recalculated VCPI slots and raises

[PATCH 04/13] drm/dp_mst: Add MST support to DP DPCD R/W functions

From: David Francis Instead of having drm_dp_dpcd_read/write and drm_dp_mst_dpcd_read/write as entry points into the aux code, have drm_dp_dpcd_read/write handle both. This means that DRM drivers can make MST DPCD read/writes. v2: Fix spacing v3: Dump dpcd access on MST read/writes v4: Fix call

[PATCH 03/13] drm/dp_mst: Parse FEC capability on MST ports

From: David Francis As of DP1.4, ENUM_PATH_RESOURCES returns a bit indicating if FEC can be supported up to that point in the MST network. The bit is the first byte of the ENUM_PATH_RESOURCES ack reply, bottom-most bit (refer to section 2.11.9.4 of DP standard, v1.4) That value is needed for FE

[PATCH v3 00/13] DSC MST support for AMDGPU

From: Mikita Lipski This set of patches is a continuation of DSC enablement patches for AMDGPU. This set enables DSC on MST. It also contains implementation of both encoder and connector atomic check routines. First 10 patches have been introduced in multiple iterations to the mailing list befo

Re: Spontaneous reboots when using RX 560

Hi Alex, > Can you send me a copy of the vbios from that board? Did you get a chance to look at the bios see if you can find anything interesting in it ? (I guess you need some special tools for that, I'm not sure how I'd find anything in there myself). After a couple of back and forth with AsRo

Re: [PATCH] drm/amdgpu: fix gfx VF FLR test fail on navi

Acked-by: Alex Deucher From: amd-gfx on behalf of HaiJun Chang Sent: Tuesday, October 29, 2019 5:18 AM To: amd-gfx@lists.freedesktop.org Cc: Chang, HaiJun Subject: [PATCH] drm/amdgpu: fix gfx VF FLR test fail on navi Cp wptr in wb buffer is outdated after VF

RE: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: 2019年10月29日 20:43 To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom ; Ma, Le Subject: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include Fix compilation error. Change-Id

Re: [PATCH v2 06/15] RDMA/hfi1: Use mmu_range_notifier_inset for user_exp_rcv

On Tue, Oct 29, 2019 at 08:19:20AM -0400, Dennis Dalessandro wrote: > On 10/28/2019 4:10 PM, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > This converts one of the two users of mmu_notifiers to use the new API. > > The conversion is fairly straightforward, however the existing use of >

Re: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

Am 29.10.19 um 13:42 schrieb Le Ma: Fix compilation error. Change-Id: I461c558778f9a52378269324dc41b8d639f3ccbe Signed-off-by: Le Ma Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

Compiles fine. Tested-by: Tom St Denis On 2019-10-29 8:43 a.m., Deucher, Alexander wrote: > Acked-by: Alex Deucher > > *From:* amd-gfx on behalf of > Le Ma > *Sent:* Tuesday, October 29, 2019 8:42 AM > *To:* amd-gfx@l

Re: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

Acked-by: Alex Deucher From: amd-gfx on behalf of Le Ma Sent: Tuesday, October 29, 2019 8:42 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom ; Ma, Le Subject: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include Fix compilation error. Change

[PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

Fix compilation error. Change-Id: I461c558778f9a52378269324dc41b8d639f3ccbe Signed-off-by: Le Ma --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index fce206f..bbe

Re: [PATCH v2 06/15] RDMA/hfi1: Use mmu_range_notifier_inset for user_exp_rcv

On 10/28/2019 4:10 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe This converts one of the two users of mmu_notifiers to use the new API. The conversion is fairly straightforward, however the existing use of notifiers here seems to be racey. Cc: Mike Marciniszyn Cc: Dennis Dalessandro Sign

[PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions

Remove unneeded NULL check before freeing functions kfree and debugfs_remove. Signed-off-by: Saurav Girepunje --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/a

Re: [PATCH hmm 06/15] RDMA/hfi1: Use mmu_range_notifier_inset for user_exp_rcv

On 10/15/2019 2:12 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe This converts one of the two users of mmu_notifiers to use the new API. The conversion is fairly straightforward, however the existing use of notifiers here seems to be racey. Cc: Mike Marciniszyn Cc: Dennis Dalessandro Sign

[PATCH] drm/amdgpu/gfx10: fix mqd backup/restore for gfx rings

1. no need to allocate an extra member for 'mqd_backup' array 2. backup/restore mqd to/from the correct 'mqd_backup' array slot Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 9 + 2 files changed, 6 insertions(+),

Re: [PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions

Hi Saurav, the driver already has the same fix patch, you can pull the latest driver tree and check it again, thanks. >From 2032324682c1ca563e33c56e51d9ae17a2b38105 Mon Sep 17 00:00:00 2001 From: zhong jiang Date: Tue, 3 Sep 2019 14:15:05 +0800 Subject: [PATCH] drm/amdgpu: remove the redundant n

[PATCH] drm/amdgpu: fix gfx VF FLR test fail on navi

Cp wptr in wb buffer is outdated after VF FLR. The outdated wptr may cause cp to execute unexpected packets. Reset cp wptr in wb buffer. Signed-off-by: HaiJun Chang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0

Re: [PATCH v2 13/15] drm/amdgpu: Use mmu_range_insert instead of hmm_mirror

Am 28.10.19 um 21:10 schrieb Jason Gunthorpe: > From: Jason Gunthorpe > > Remove the interval tree in the driver and rely on the tree maintained by > the mmu_notifier for delivering mmu_notifier invalidation callbacks. > > For some reason amdgpu has a very complicated arrangement where it tries >

Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem

Am 28.10.19 um 21:10 schrieb Jason Gunthorpe: > From: Jason Gunthorpe > > find_vma() must be called under the mmap_sem, reorganize this code to > do the vma check after entering the lock. > > Further, fix the unlocked use of struct task_struct's mm, instead use > the mm from hmm_mirror which has a

Re: [PATCH v2 07/15] drm/radeon: use mmu_range_notifier_insert

Am 28.10.19 um 21:10 schrieb Jason Gunthorpe: > From: Jason Gunthorpe > > The new API is an exact match for the needs of radeon. > > For some reason radeon tries to remove overlapping ranges from the > interval tree, but interval trees (and mmu_range_notifier_insert) > support overlapping ranges d

[PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP

From: Jiange Zhao In the old way, when doing IH hw_init, PSP, nv_common and GMC hw.status would be reset to false, even though their hw_init have been done. In the next step, fw_loading, PSP would do hw_init again. In the new way, only reset hw.status to false for the target IP in the list. In t

RE: [PATCH 4/4] drm/amdgpu: remove ras global recovery handling from ras_controller_int handler

-Original Message- From: Chen, Guchun Sent: Tuesday, October 29, 2019 9:37 AM To: Ma, Le ; amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: RE: [PATCH 4/4] drm/amdgpu: remove ras global recovery handling from ras_controller_int handler Regards, Guchun -Original Mess

RE: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu recovery succeeded

> -Original Message- > From: Chen, Guchun > Sent: Tuesday, October 29, 2019 9:28 AM > To: Ma, Le ; amd-gfx@lists.freedesktop.org > Cc: Ma, Le > Subject: RE: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu > recovery succeeded > > > > Regards, > Guchun > > -O