[PATCH] drm/amdgpu: avoid ras error injection for retired page

2019-09-29 Thread Zhou1, Tao
check whether a page is bad page before error injection Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index fe3a

RE: [PATCH] drm/amd/amdgpu/sriov ip block setting of Arcturus

2019-09-29 Thread Zhang, Jack (Jian)
Hi, folks, Would you please help to review the patch? Thanks, Jack -Original Message- From: amd-gfx On Behalf Of Jack Zhang Sent: Monday, September 30, 2019 1:00 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH] drm/amd/amdgpu/sriov ip block setting of Arctur

[PATCH] drm/amd/amdgpu/sriov ip block setting of Arcturus

2019-09-29 Thread Jack Zhang
Add ip block setting for Arcturus SRIOV 1.PSP need to be initialized before IH. 2.SMU doesn't need to be initialized at kmd driver. 3.Arcturus doesn't support DCE hardware,it needs to skip register access to DCE. Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 ++-

RE: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo create

2019-09-29 Thread Chen, Guchun
Series is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Zhou1, Tao Sent: Monday, September 30, 2019 11:43 AM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Zhang, Hawking Subject: RE: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's b

RE: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo create

2019-09-29 Thread Zhou1, Tao
> -Original Message- > From: Chen, Guchun > Sent: 2019年9月30日 11:26 > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; > Grodzovsky, Andrey ; Zhang, Hawking > > Subject: RE: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo > create > > > Regards, > Guchun > > -Original Messa

RE: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo create

2019-09-29 Thread Chen, Guchun
Regards, Guchun -Original Message- From: Zhou1, Tao Sent: Monday, September 30, 2019 11:20 AM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Chen, Guchun ; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo create implement ras_c

[PATCH 3/3] drm/amdgpu: reuse code of ras bad page's bo create

2019-09-29 Thread Zhou1, Tao
implement ras_create_bad_pages_bo to simplify ras code Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 72 +++-- 1 file changed, 31 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 1/3] drm/amdgpu: recreate retired page's bo if vram get lost in gpu reset

2019-09-29 Thread Zhou1, Tao
the info of retired page's bo may be lost if vram lost is encountered in gpu reset (gpu page table in vram may be lost), force to recreate all bos v2: simplify NULL pointer check add more comments Signed-off-by: Tao Zhou Suggested-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 2/3] drm/amdgpu: initialize ras bad page bo array to NULL

2019-09-29 Thread Zhou1, Tao
guarantee bo pointers in bad page bo array are NULL after allocation Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 3f

[PATCH V2] drm/amdgpu: remove set but not used variable 'pipe'

2019-09-29 Thread yu kuai
Fixes gcc '-Wunused-but-set-variable' warning: rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_graphics_queue_acquire’: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning: variable ‘pipe’ set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Repor

[PATCH] drm/amdgpu: remove set but not used variable 'pipe'

2019-09-29 Thread yu kuai
Fixes gcc '-Wunused-but-set-variable' warning: rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ???amdgpu_gfx_graphics_queue_acquire???: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning: variable ???pipe??? set but not used [-Wunused-but-set-variable] It is never used, so can be removed

[PATCH] drm/amd/powerplay: Protect backend resource when unload driver

2019-09-29 Thread Jesse Zhang
From: Jesse Zhang Guest driver can be unloaded while engines still using some backend resources. That would lead to use after free and then cause guest driver failed. Need to add mutex lock before backend resources free to make sure nobody is using it. Need to check backend data availablility b

RE: [PATCH] drm/amdgpu: recreate retired page's bo if vram get lost in gpu reset

2019-09-29 Thread Zhou1, Tao
> -Original Message- > From: Chen, Guchun > Sent: 2019年9月29日 15:06 > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; > Grodzovsky, Andrey ; Zhang, Hawking > > Subject: RE: [PATCH] drm/amdgpu: recreate retired page's bo if vram get lost > in gpu reset > > > -Original Message- >

[PATCH v4 10/11] drm/amdgpu: job is secure iff CS is secure (v5)

2019-09-29 Thread Huang, Ray
Mark a job as secure, if and only if the command submission flag has the secure flag set. v2: fix the null job pointer while in vmid 0 submission. v3: Context --> Command submission. v4: filling cs parser with cs->in.flags v5: move the job secure flag setting out of amdgpu_cs_submit() Signed-off-

RE: [PATCH] drm/amdgpu: recreate retired page's bo if vram get lost in gpu reset

2019-09-29 Thread Chen, Guchun
-Original Message- From: Zhou1, Tao Sent: Sunday, September 29, 2019 2:35 PM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Chen, Guchun ; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: recreate retired page's bo if vram get lost in gpu reset the info of retire