Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-13 Thread Gerd Hoffmann
> Hi Gerd, > > I've been seeing a regression on Nouveau with recent linux-next releases > and git bisect points at this commit as the first bad one. If I revert > it (there's a tiny conflict with a patch that was merged subsequently), > things are back to normal. > > I think the reason for this i

RE: [PATCH 1/2] drm/amdgpu: Fix null ptr when calling query_ras_error_count

2019-08-13 Thread Zhou1, Tao
Referring to the series, patch #1 and #2. Regards, Tao > -Original Message- > From: Grodzovsky, Andrey > Sent: 2019年8月14日 10:42 > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Pan, Xinhui > ; Zhang, Hawking > Subject: Re: [PATCH 1/2] drm/amdgpu: Fix null ptr

Re: [PATCH 1/2] drm/amdgpu: Fix null ptr when calling query_ras_error_count

2019-08-13 Thread Grodzovsky, Andrey
Are you referring to this patch which fixes a crash or to the second patch in the serries ? Andrey From: Zhou1, Tao Sent: 13 August 2019 22:24:00 To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Grodzovsky, Andrey; Pan, Xinhu

RE: [PATCH 1/2] drm/amdgpu: Fix null ptr when calling query_ras_error_count

2019-08-13 Thread Zhou1, Tao
Hi Andrey: I'm also working on ras error address saving based on your eeprom patches, and the implementation is different from you. I'll send out my patches this week and we can discuss it. Regards, Tao > -Original Message- > From: amd-gfx On Behalf Of > Andrey Grodzovsky > Sent: 2019年

[PATCH AUTOSEL 5.2 105/123] drm/amdgpu: pin the csb buffer on hw init for gfx v8

2019-08-13 Thread Sasha Levin
From: Likun Gao [ Upstream commit 72cda9bb5e219aea0f2f62f56ae05198c59022a7 ] Without this pin, the csb buffer will be filled with inconsistent data after S3 resume. And that will causes gfx hang on gfxoff exit since this csb will be executed then. Signed-off-by: Likun Gao Tested-by: Paul Gover

Re: [PATCH] nouveau/hmm: map pages after migration

2019-08-13 Thread Jerome Glisse
On Wed, Aug 07, 2019 at 08:02:14AM -0700, Ralph Campbell wrote: > When memory is migrated to the GPU it is likely to be accessed by GPU > code soon afterwards. Instead of waiting for a GPU fault, map the > migrated memory into the GPU page tables with the same access permissions > as the source CPU

[PATCH] drm/amdkfd: Fill the name field in node topology with asic name v2

2019-08-13 Thread Zhao, Yong
The name field in node topology has not been used. We re-purpose it to hold the asic name, which can be queried by user space applications through sysfs. Change-Id: I74f4f5487db169004a9d27ea15abe99261c86220 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 18 +

[PATCH] drm/amdkfd: Fill amdgpu_task_info for KFD VMs

2019-08-13 Thread Zhao, Yong
The amdgpu_task_info will be used when printing VM page fault for KFD processes. Change-Id: Ifd983db5dceb1d477e7287e4893f80565a7a6b06 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process

RE: [PATCH 1/2] drm/amdgpu: Export function to flush TLB of specific vm hub

2019-08-13 Thread Zeng, Oak
Ping this series. @Koenig, Christian do you have more comments on this? Regards, Oak -Original Message- From: Zeng, Oak Sent: Friday, August 9, 2019 12:22 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Koenig, Christian ; Zhou1, Tao ; Zeng, Oak Subject: [PATCH 1/2] drm/am

[PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 for GFX10

2019-08-13 Thread Zhao, Yong
We have done this for pre-GFX10 asics, but GFX10 did not pick up the new change. The below is the commit message for that change. This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMISSION_OR_INVALID_PAGE_FAULT rather than usu

[PATCH 2/2] drm/amdgpu: Add more page fault info printing for GFX10

2019-08-13 Thread Zhao, Yong
The printing we did for GFX9 was not propogated to GFX10 somehow, so fix it now. Change-Id: Ic0b8381134340b83cd69c3fe186ac7a8a97b1bca Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 33 ++ 1 file changed, 28 insertions(+), 5 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: Add printing for RW extracted from VM_L2_PROTECTION_FAULT_STATUS

2019-08-13 Thread Zhao, Yong
RW is also useful in most cases. Change-Id: Icf4bd65ea168e5965a6a8ebe32ce9327a2de2851 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 296

[PATCH v2] drm/amdgpu: Start using amdgpu_ras_add_bad_pages

2019-08-13 Thread Andrey Grodzovsky
v2: Trigger GPU reset in case of new bad address errors. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 2/2] drm/amdgpu: Start using amdgpu_ras_add_bad_pages.

2019-08-13 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 296e2d9..46517c4 100644 --- a/drivers/gpu/drm

[PATCH 1/2] drm/amdgpu: Fix null ptr when calling query_ras_error_count

2019-08-13 Thread Andrey Grodzovsky
ras_err_data.err_addr was never allocated Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 50c13b0..d9fb860

Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-13 Thread Thierry Reding
On Mon, Aug 05, 2019 at 04:01:10PM +0200, Gerd Hoffmann wrote: > Drop vma_node from ttm_buffer_object, use the gem struct > (base.vma_node) instead. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- > drivers/gpu/drm/qxl/q

Re: [PATCH] drm/amdgpu/powerplay: fix spelling mistake "unsuported" -> "unsupported"

2019-08-13 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Aug 13, 2019 at 6:33 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a pr_err error message. Fix it. Also > add a space after a comma to clean up a checkpatch warning. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd

Re: [PATCH v2 15/34] staging/vc04_services: convert put_page() to put_user_page*()

2019-08-13 Thread Stefan Wahren
On 05.08.19 00:48, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit

Re: [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-08-13 Thread Geert Uytterhoeven
Hi Günter, On Thu, Aug 8, 2019 at 5:42 AM Guenter Roeck wrote: > On Fri, Jul 26, 2019 at 07:23:13PM +0200, Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > > > Signed-off-by: Andrzej Pietrasiewicz > > Reviewed-by: Neil Armstrong > > This patch results

Re: [PATCH] drm/amdgpu/powerplay: fix spelling mistake "unsuported" -> "unsupported"

2019-08-13 Thread Colin Ian King
[drm-next] On 13/08/2019 11:33, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_err error message. Fix it. Also > add a space after a comma to clean up a checkpatch warning. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c |

[PATCH] drm/amdgpu/powerplay: fix spelling mistake "unsuported" -> "unsupported"

2019-08-13 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err error message. Fix it. Also add a space after a comma to clean up a checkpatch warning. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH 2/2] drm/amdgpu: use exiting amdgput_ctx_total_num_entities function

2019-08-13 Thread Christian König
Am 13.08.19 um 11:08 schrieb Wang, Kevin(Yang): simplify driver code. Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/dri

Re: [PATCH 1/2] drm/amdgpu: fix typo error amdgput -> amdgpu

2019-08-13 Thread Christian König
Am 13.08.19 um 11:08 schrieb Wang, Kevin(Yang): fix typo error: change function name from "amdgput_ctx_total_num_entities" to "amdgpu_ctx_total_num_entities". Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 12 ++-- 1 file cha

[PATCH 2/2] drm/amdgpu: use exiting amdgput_ctx_total_num_entities function

2019-08-13 Thread Wang, Kevin(Yang)
simplify driver code. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index 95d8201a738e..89c26bb0f05c 100644 --- a/dri

[PATCH 1/2] drm/amdgpu: fix typo error amdgput -> amdgpu

2019-08-13 Thread Wang, Kevin(Yang)
fix typo error: change function name from "amdgput_ctx_total_num_entities" to "amdgpu_ctx_total_num_entities". Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

RE: [PATCH] drm/amdgpu: implement querying ras error count for mmhub

2019-08-13 Thread Chen, Guchun
Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Tuesday, August 13, 2019 4:30 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Chen, Guchun Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: implement querying ras error count for mmhub get mmh

[PATCH] drm/amdgpu: implement querying ras error count for mmhub

2019-08-13 Thread Tao Zhou
get mmhub ea ras error count by accessing EDC_CNT register Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 56 + .../asic_reg/mmhub/mmhub_9_4_0_offset.h | 21 ++ .../asic_reg/mmhub/mmhub_9_4_0_sh_mask.h | 222 ++ 3 files changed, 299 i