RE: [PATCH 9/9] drm/amdgpu/powerplay/vega120: only use PrepareMp1ForUnload for mode1 reset

Patch1 - 6: Reviewed-by: Evan Quan Patch7 - 9: I think suspend needs also be taken into consideration as vega20_power_off_asic() is also on the suspend path. That means even if the default asic method is baco, you may still need using PrepareMp1ForUnload() for suspend case.

Re: [PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

the previous patch already submitted, so need this patch to fix. thanks. Best Regards, Kevin On 7/24/19 10:34 AM, Quan, Evan wrote: > Better to combine this with previous ptach(drm/amd/powerplay: add callback > function of get_thermal_temperature_range) as one. > Since this issue to fix was actu

Re: [PATCH 6/9] drm/amdgpu: add reset_method asic callback for navi

Reviewed-by: Kevin Wang On 7/24/19 1:00 PM, Alex Deucher wrote: > Navi uses either mode1 or baco depending on various > conditions. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/

[PATCH 5/9] drm/amdgpu: add reset_method asic callback for soc15

APUs only support mode2 reset. dGPUs use either mode1 or baco depending on various conditions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/

[PATCH 4/9] drm/amdgpu: add reset_method asic callback for vi

VI always uses the legacy pci based reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index fffae4c2973b..56c882b3ea3c 100644 --- a/drivers/gpu/drm/am

[PATCH 6/9] drm/amdgpu: add reset_method asic callback for navi

Navi uses either mode1 or baco depending on various conditions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 6c59b64b9bb1

[PATCH 8/9] drm/amdgpu/powerplay/vega12: only use PrepareMp1ForUnload for mode1 reset

It's not needed for BACO. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c i

[PATCH 9/9] drm/amdgpu/powerplay/vega120: only use PrepareMp1ForUnload for mode1 reset

Use PrepareMp1ForUnload for mode1 reset and PrepareMp1ForShutdown for baco reset. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmg

[PATCH 7/9] drm/amdgpu/powerplay/vega10: only use PrepareMp1ForUnload for mode1 reset

It's not needed for BACO. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c i

[PATCH 2/9] drm/amdgpu: add reset_method asic callback for si

SI always uses the legacy pci based reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index 4b1e0c16ac41..904361451650 100644 --- a/drivers/gpu/drm/am

[PATCH 3/9] drm/amdgpu: add reset_method asic callback for cik

CIK always uses the legacy pci based reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/cik.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c index 3a4f20766a39..7b63d7a8298a 100644 --- a/drivers/gpu/dr

[PATCH 1/9] drm/amdgpu: add an asic callback to determine the reset method

Sometimes the driver may have to behave differently depending on the method we are using to reset the GPU. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/am

RE: [PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

Reviewed-by: Kenneth Feng -Original Message- From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 8:08 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Huang, Ray ; Quan, Evan ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/powerplay: fix temperature granularity error in smu11 i

RE: [PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

Better to combine this with previous ptach(drm/amd/powerplay: add callback function of get_thermal_temperature_range) as one. Since this issue to fix was actually introduced by that patch. But if the original patch was already submitted, it's OK to commit this separately. Either way, this way

Re: kernel panic: stack is corrupted in pointer

Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+79f5f028005a77ecb...@syzkaller.appspotmail.com Tested on: commit: decb705e libbpf: fix using uninitialized ioctl results git tree: bpf kernel config: https:

RE: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic

No. Hold on. Let me discuss this internally. Regards, Evan > -Original Message- > From: amd-gfx On Behalf Of > Grodzovsky, Andrey > Sent: Wednesday, July 24, 2019 4:01 AM > To: Alex Deucher ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 3/3] drm/amdgpu

[PATCH 9/9] drm/amd/display: Implement MST Aux device registration

From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Jerry Zuo Cc: Nicholas Kazlauskas Cc: Harry Wentland Signed-off-by: Leo Li --- .../display/amdgpu_dm/amdgpu_dm_mst_types.

[PATCH 8/9] drm/radeon: Implement MST Aux device registration

From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Alex Deucher Cc: Harry Wentland Signed-off-by: Leo Li --- drivers/gpu/drm/radeon/radeon_dp_mst.c | 22

[PATCH 0/9] MST AUX Devices (v3)

From: Leo Li Here's what changed in v3: * Dropped patch to expose the mst-path device attribute, in lieu of ongoing discussion for defining a better connector path property * Change WARN_ON_ONCE -> DRM_ERROR on MST dpcd read errors to avoid tainting the kernel * Unwind intel_connector_regist

[PATCH 4/9] drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent

From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. To do so, the connector needs to be registered beforehand. Therefore, shift aux registration to be after connector

[PATCH 6/9 v2] drm/i915: Implement MST Aux device registration

From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Signed-off-by: Leo Li v2 changes: Unwind intel_connector_register on mst late register failure. --- drivers/gpu/drm/i915/displa

[PATCH 7/9] drm/nouveau/kms/nv50: Implement MST Aux device registration

From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Ben Skeggs Signed-off-by: Leo Li --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 20 1 file changed, 20

[PATCH 5/9] drm/amd/display: Use connector kdev as aux device parent

From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. For example, the following udev rule: SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{edid}=="*", SY

[PATCH 2/9 v3] drm/dp_mst: Enable registration of AUX devices for MST ports

From: Ville Syrjälä All available downstream ports - physical and logical - are exposed for each MST device. They are listed in /dev/, following the same naming scheme as SST devices by appending an incremental ID. Although all downstream ports are exposed, only some will work as expected. Consi

[PATCH 3/9] drm/nouveau: Use connector kdev as aux device parent

From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. Cc: Ben Skeggs Signed-off-by: Leo Li Reviewed-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_connector.c |

[PATCH 1/9] drm/dp: Use non-cyclic idr

From: Leo Li In preparation for adding aux devices for DP MST, make the IDR non-cyclic. That way, hotplug cycling MST devices won't needlessly increment the minor version index. Signed-off-by: Leo Li Reviewed-by: Lyude Paul Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_dp_aux_dev.c | 3

Re: [PATCH v2 0/2] This series enables S/G for Picasso.

Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Tuesday, July 23, 2019 2:25 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Grodzovsky, Andrey ; Wu, Hersen ; Koenig, Christian ; S, Shirish Subject: [PATCH

Re: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic

Series is Acked-by: Andrey Grodzovsky Andrey On 7/23/19 1:00 PM, Alex Deucher wrote: > Needed to make sure the smu is idle when resetting. This may fix > sporatic failures with GPU reset. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 + >

[PATCH 1/2] drm/amdkfd: Use SQC when TCP would fail in gfx9 context save.

When a wavefront raises TRAPSTS.XNACK_ERROR with STATUS.ALLOW_REPLAY=0 subsequent memory instructions have undefined behavior. In practice SQC stores continue to work but TCP stores do not. Context save is permitted to fail after XNACK error because the wavefront will be halted and subsequently te

[PATCH 2/2] drm/amdkfd: Fix lost single step exceptions in gfx9 trap handler

If the trap is entered due to MODE.DEBUG_EN=1 and SAVECTX is raised concurrently the handler cannot identify the source of the exception. This causes the debugger to lose single step exception notification when a context save request arrives at the same time. When MODE.DEBUG_EN=1 and STATUS.HALT=0

RE: [PATCH] drm/amdkfd: Fix byte align on VegaM

That was my thought too. I'll do that as a future patch. Kent From: Kuehling, Felix Sent: Tuesday, July 23, 2019 2:51 PM To: Russell, Kent ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdkfd: Fix byte align on VegaM This was needed for VI chips before Fiji. I t

Re: [PATCH][next] drm/amd/display: fix a missing null check on a failed kzalloc

On Tue, Jul 23, 2019 at 10:23 AM Colin King wrote: > > From: Colin Ian King > > Currently the allocation of config may fail and a null pointer > dereference on config can occur. Fix this by added a null > check on a failed allocation of config. > > Addresses-Coverity: ("Dereference null return")

Re: [PATCH] drm/amdkfd: Fix byte align on VegaM

This was needed for VI chips before Fiji. I think that means Tonga, Topaz and Carrizo. As the list of supported ASICs keeps growing, we should change the condition to list only the chips that need the workaround, instead of adding every future chip to the list that don't. Regards, Felix -- F

Re: [PATCH] drm/radeon: Use dev_get_drvdata where possible

On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_drv.c | 15 +-- > 1 file changed, 5 inser

Re: [PATCH] drm/amd/display: Use dev_get_drvdata

On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- > 1 file changed, 1 inse

Re: [PATCH] drm/amdgpu: Use dev_get_drvdata where possible

On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 27 + > 1 file ch

Re: [PATCH][next] drm/amdgpu: remove redundant assignment to pointer 'ring'

On Tue, Jul 23, 2019 at 9:41 AM Colin King wrote: > > From: Colin Ian King > > The pointer 'ring' is being assigned a value that is never > read, hence the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/gpu/dr

Re: [PATCH] drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

On Tue, Jul 23, 2019 at 3:16 AM Nick Desaulniers wrote: > > arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The > AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn > on SSE2 to support emitting double precision floating point instructions > rather than calls to

[PATCH v2 2/2] drm/amd: enable S/G for RAVEN chip

From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT as supported domain v2: Move BO placement logic into amdgpu_display_supported_domains Change-Id: If34300beaa60be2d36170b7b5b096ec644502b20 Signed-off-by: Shirish S Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm

[PATCH v2 1/2] drm/amdgpu: Fix hard hang for S/G display BOs.

HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. v2: Move all BO placemnt logic to amdgpu_display_supported_domains Suggested-by: Alex Deucher Signed-off-by: An

[PATCH v2 0/2] This series enables S/G for Picasso.

First patch fix a hard hang introduced by placing the display BO in GTT memory because of HW issues with cached mappings and the second patch enables S/G. Andrey Grodzovsky (1): drm/amdgpu: Fix hard hang for S/G display BOs. Shirish S (1): drm/amd: enable S/G for RAVEN chip drivers/gpu/drm/

Re: kernel panic: stack is corrupted in pointer

Dmitry Vyukov wrote: > On Wed, Jul 17, 2019 at 10:58 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov wrote: > > === Overview > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > tags into the top byte of each pointer. Userspace programs (such as > HWASan, a memory debugging tool [1]) might use this feature and pass > tagg

[PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

From: Catalin Marinas It is not desirable to relax the ABI to allow tagged user addresses into the kernel indiscriminately. This patch introduces a prctl() interface for enabling or disabling the tagged ABI with a global sysctl control for preventing applications from enabling the relaxed ABI (me

[PATCH v19 05/15] mm: untag user pointers in mm/gup.c

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example get_user_

[PATCH v19 06/15] mm: untag user pointers in get_vaddr_frames

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. get_vaddr_frames uses provided user pointers for vma lookups, which can only by done with untagged pointers. Instead of loc

[PATCH v19 14/15] vfio/type1: untag user pointers in vaddr_get_pfn

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. vaddr_get_pfn() uses provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user poi

[PATCH v19 13/15] tee/shm: untag user pointers in tee_shm_register

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. tee_shm_register()->optee_shm_unregister()->check_mem_type() uses provided user pointers for vma lookups (via __check_mem_t

[PATCH v19 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. mlx4_get_umem_mr() uses provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user

[PATCH v19 04/15] mm: untag user pointers passed to memory syscalls

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. This patch allows tagged pointers to be passed to the following memory syscalls: get_mempolicy, madvise, mbind, mincore, ml

[PATCH v19 08/15] userfaultfd: untag user pointers

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. userfaultfd code use provided user pointers for vma lookups, which can only by done with untagged pointers. Untag user poi

[PATCH v19 10/15] drm/radeon: untag user pointers in radeon_gem_userptr_ioctl

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In radeon_gem_userptr_ioctl() an MMU notifier is set up with a (tagged) userspace pointer. The untagged address should be u

[PATCH v19 03/15] lib: untag user pointers in strn*_user

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. strncpy_from_user and strnlen_user accept user addresses as arguments, and do not go through the same path as copy_from_use

[PATCH v19 07/15] fs/namespace: untag user pointers in copy_mount_options

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In copy_mount_options a user address is being subtracted from TASK_SIZE. If the address is lower than TASK_SIZE, the size i

[PATCH v19 12/15] media/v4l2-core: untag user pointers in videobuf_dma_contig_user_get

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. videobuf_dma_contig_user_get() uses provided user pointers for vma lookups, which can only by done with untagged pointers.

[PATCH v19 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. This patch adds a simple test, that calls the uname syscall with a tagged user pointer as an argument. Without the kernel a

[PATCH v19 09/15] drm/amdgpu: untag user pointers

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In amdgpu_gem_userptr_ioctl() and amdgpu_amdkfd_gpuvm.c/init_user_pages() an MMU notifier is set up with a (tagged) userspa

[PATCH v19 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. copy_from_user (and a few other similar functions) are used to copy data from user memory into the kernel memory or vice ve

[PATCH v19 00/15] arm64: untag user pointers passed to the kernel

=== Overview arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces.

Re: Re: kernel panic: stack is corrupted in pointer

syzbot wrote: > > Dmitry Vyukov wrote: > >> On Wed, Jul 17, 2019 at 10:58 AM syzbot > >> wrote: > >> > > >> > Hello, > >> > > >> > syzbot found the following crash on: > >> > > >> > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > >> > git tree: linux-next > >> > console

Re: [PATCH 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

On 7/23/19 12:18 PM, Michel Dänzer wrote: > On 2019-07-23 6:04 p.m., Andrey Grodzovsky wrote: >> HW requires for caching to be unset for scanout BO >> mappings when the BO placement is in GTT memory. >> Usually the flag to unset is passed from user mode >> but for FB mode this was missing. >> >> S

Re: Re: kernel panic: stack is corrupted in pointer

Dmitry Vyukov wrote: On Wed, Jul 17, 2019 at 10:58 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=139880586

[PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic

Needed to make sure the smu is idle when resetting. This may fix sporatic failures with GPU reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/dri

[PATCH 2/3] drm/amdgpu/powerplay/vega10: call PrepareMp1ForUnload in power_off_asic

Needed to make sure the smu is idle when resetting. This may fix sporatic failures with GPU reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/dri

[PATCH 1/3] drm/amdgpu/powerplay/vega20: call PrepareMp1ForUnload in power_off_asic

Needed to make sure the smu is idle when resetting. This fixes sporatic failures with GPU reset. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drive

Re: [PATCH 2/3] drm/amd/display: Only allow s/g when USWC flag is set.

On 2019-07-23 6:04 p.m., Andrey Grodzovsky wrote: > This verifies we don't casue HW hang in case this flag is missing. > > Signed-off-by: Andrey Grodzovsky > Reviewed-by: Alex Deucher > Tested-by: Shirish S > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 i

RE: [PATCH 3/3] drm/amdgpu: adding xgmi error monitoring

Reviewed-By: Kent Russell Kent -Original Message- From: amd-gfx On Behalf Of Kim, Jonathan Sent: Tuesday, July 16, 2019 1:12 PM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/3] drm/amdgpu: adding xgmi error monitoring Note patch 1 sent to internal amd mailing list for review

Re: [PATCH 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

On 2019-07-23 6:04 p.m., Andrey Grodzovsky wrote: > HW requires for caching to be unset for scanout BO > mappings when the BO placement is in GTT memory. > Usually the flag to unset is passed from user mode > but for FB mode this was missing. > > Suggested-by: Alex Deucher > Signed-off-by: Andrey

RE: [PATCH 2/3] drm/amdgpu: add perfmon and fica atomics for df

Reviewed-By: Kent Russell Kent -Original Message- From: amd-gfx On Behalf Of Kim, Jonathan Sent: Tuesday, July 16, 2019 1:12 PM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/3] drm/amdgpu: add perfmon and fica atomics for df Note patch 1 sent to internal amd mailing list for

Re: [PATCH 0/3] Enable Scatter Gather for Picasso.

Series is Reviewed-by: Christian König Am 23.07.19 um 18:04 schrieb Andrey Grodzovsky: > This series enables S/G for Picasso. > First 2 patches fix a hard hang introduced by placing the display > BO in GTT memory because of HW issues with cached mappings > and the third patch enables S/G. > > And

[PATCH 3/3] drm/amd: enable S/G for RAVEN chip

From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT as supported domain Change-Id: If34300beaa60be2d36170b7b5b096ec644502b20 Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-

[PATCH 1/3] drm/amdgpu: Fix hard hang for S/G display BOs.

HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. Suggested-by: Alex Deucher Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher Tested-by: Shirish S --

[PATCH 2/3] drm/amd/display: Only allow s/g when USWC flag is set.

This verifies we don't casue HW hang in case this flag is missing. Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher Tested-by: Shirish S --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displ

[PATCH 0/3] Enable Scatter Gather for Picasso.

This series enables S/G for Picasso. First 2 patches fix a hard hang introduced by placing the display BO in GTT memory because of HW issues with cached mappings and the third patch enables S/G. Andrey Grodzovsky (2): drm/amdgpu: Fix hard hang for S/G display BOs. drm/amd/display: Only allow s

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

Hi Andrej. On Tue, Jul 23, 2019 at 02:44:50PM +0200, Andrzej Pietrasiewicz wrote: > Hi Sam, > > W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: > > Hi Andrzej > > > > On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: > > > Use the ddc pointer provided by the generic connector

RE: [PATCH] drm/amdkfd: Fix byte align on VegaM

I'll push this, I was just wondering if Felix could confirm if the TLB workaround was only for Tonga/Topaz, in which case we could check for that instead of having to expand the list in situations like this, to say "if FAMILY_VI && (TOPAZ || TONGA) then". That way it's explicitly applying the w

Re: [PATCH] drm/amdkfd: Fix byte align on VegaM

Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Tuesday, July 23, 2019 10:22 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdkfd: Fix byte align on VegaM This was missed during the addition of VegaM supp

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

Looks good to me. Acked-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:43 AM To: Feng, Kenneth ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu it look

Re: [PATCH 2/2] drm/amd/powerplay: some cosmetic fixes

Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Tuesday, July 23, 2019 4:41 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: some cosmetic fixes Drop redundant check, duplicate check,

[PATCH -next] drm/amd/display: Make pow_buffer_ptr static

Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:62:5: warning: symbol 'pow_buffer_ptr' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file chan

[PATCH][next] drm/amd/display: fix a missing null check on a failed kzalloc

From: Colin Ian King Currently the allocation of config may fail and a null pointer dereference on config can occur. Fix this by added a null check on a failed allocation of config. Addresses-Coverity: ("Dereference null return") Fixes: c2cd9d04ecf0 ("drm/amd/display: Hook up calls to do stereo

[PATCH] drm/amdkfd: Fix byte align on VegaM

This was missed during the addition of VegaM support Change-Id: I61c8fbbea77338126e3ebdfa74c286b665bdd670 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkf

Re: [PATCH 07/10] drm/i915: Implement MST Aux device registration

On 2019-07-12 4:15 p.m., Ville Syrjälä wrote: > On Fri, Jul 12, 2019 at 11:05:59PM +0300, Ville Syrjälä wrote: >> On Fri, Jul 12, 2019 at 03:48:53PM -0400, Lyude Paul wrote: >>> BTW, I just tried these patches on my T450s (using i915) and I'm seeing some >>> kernel warnings with them when adding

[PATCH][next] drm/amdgpu: remove redundant assignment to pointer 'ring'

From: Colin Ian King The pointer 'ring' is being assigned a value that is never read, hence the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH][next] drm/amd/display: remove duplicated comparison

From: Colin Ian King The comparison of surface_pitch is duplicated and hence one of these comparisons is redundant and can be removed. Remove it. Addresses-Coverity: ("Same on both sides") Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane") Signed-off-by: Colin Ian King

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

Hi Sam, W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: Hi Andrzej On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + 1 file cha

[PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

in this patch, drm/amd/powerplay: add callback function of get_thermal_temperature_range the driver missed temperature granularity change on other temperature. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 18 +- 1 file changed, 9 insertions(+), 9 dele

Re: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

sure, i know it, this patch is from navi10 topic branch. the final result don't change the temperature granularity. please see below code. but it seems miss other temperature type in this patch, i will submit a new patch to fix it. #define SMU_TEMPERATURE_UNITS_PER_CENTIGRADES (1000) > +

RE: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

Please do not change the output temperature granularity. Although it seems a little weird. It's required by hwmon interfaces design and has to be in millidegrees Celsius (@Deucher, Alexander, right?). * hwmon interfaces for GPU temperature: * * - temp[1-3]_input: the on die GPU temperature in

[PATCH] drm/radeon: Use dev_get_drvdata where possible

Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/radeon/radeon_drv.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm

RE: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

Reviewed-by: Kenneth Feng -Original Message- From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:32 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Huang, Ray ; Wang, Kevin(Yang) ; Feng, Kenneth Subject: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temp

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

it looks fine for me, please @Deucher, Alexander double check confirm. Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, July 23, 2019 5:39 PM To: amd-gfx@lists.freedesktop.o

RE: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

Reviewed-by: Kenneth Feng mailto:kenneth.f...@amd.com>> From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:36 PM To: amd-gfx@lists.freedesktop.org; Feng, Kenneth Cc: Huang, Ray Subject: Re: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range @Feng, Kenneth

[PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

change the smu_read_sensor sequence to: asic specific sensor read -> smu v11 specific sensor read -> smu v11 common sensor read Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 +++ drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 4 ++-- drivers/gpu/drm/amd/p

Re: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

@Feng, Kenneth please help me review this patch, this patch is reveiwed before. but this patch is missed from navi10 topic branch. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:31:47 PM To: amd-gfx@lis

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

1. the thermal temperature is asic related data, move the code logic to xxx_ppt.c. 2. replace data structure PP_TemperatureRange with smu_temperature_range. 3. change temperature uint from temp*1000 to temp (temperature uint). Signed-off-by: Kevin Wang Signed-off-by: Kenneth Feng Acked-by: Huang

[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

v2: change function name to smu_clk_dpm_is_enabled. add this helper function to check dpm clk feature is enabled. Change-Id: I7f9949033c318fec618a9701df4a082d54a626c8 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 69 --- .../gpu/drm/amd/powerplay/i

  1   2   >