Re: WARNING: locking bug in inet_autobind

2019-05-21 Thread Zhao, Yong
This commit was reverted later. I guess the revert was probably not picked up properly. Regards, Yong From: syzbot Sent: Tuesday, May 21, 2019 11:16 PM To: Zhao, Yong; airl...@linux.ie; Deucher, Alexander; amd-gfx@lists.freedesktop.org; a...@kernel.org; b...@vge

Re: WARNING: locking bug in inet_autobind

2019-05-21 Thread syzbot
syzbot has bisected this bug to: commit c0d9271ecbd891cdeb0fad1edcdd99ee717a655f Author: Yong Zhao Date: Fri Feb 1 23:36:21 2019 + drm/amdgpu: Delete user queue doorbell variables bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1433ece4a0 start commit: f49aa1de Mer

RE: [PATCH] drm/amd/powerplay: Fix code error for translating int type to bool type correctly

2019-05-21 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Chengming Gui Sent: 2019年5月21日 19:46 To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack Subject: [PATCH] drm/amd/powerplay: Fix code error for translating int type to bool type correctly [CAUTION: E

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

2019-05-21 Thread Kees Cook
On Tue, May 21, 2019 at 07:29:33PM +0100, Catalin Marinas wrote: > On Mon, May 20, 2019 at 04:53:07PM -0700, Evgenii Stepanov wrote: > > On Fri, May 17, 2019 at 7:49 AM Catalin Marinas > > wrote: > > > IMO (RFC for now), I see two ways forward: > > > [...] > > > 2. Similar shim to the above libc

Re: [PATCH 1/7] drm/amdkfd: Add gws number to kfd topology node properties

2019-05-21 Thread Kuehling, Felix
On 2019-05-15 4:37 p.m., Zeng, Oak wrote: > Add amdgpu_amdkfd interface to get num_gws and add num_gws > to /sys/class/kfd/kfd/topology/nodes/x/properties. Only report > num_gws if MEC FW support GWS barriers. Currently it is > determined by a environment variable which will be replaced It's not a

Re: [PATCH 4/7] drm/amdkfd: Add function to set queue gws

2019-05-21 Thread Kuehling, Felix
On 2019-05-15 4:37 p.m., Zeng, Oak wrote: > Add functions in process queue manager to > set/get queue gws. Also set process's number > of gws used. Currently only one queue in > process can use and use all gws. > > Change-Id: I03e480c8692db3eabfc3a188cce8904d5d962ab7 > Signed-off-by: Oak Zeng > -

Re: [PATCH 6/7] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-21 Thread Kuehling, Felix
On 2019-05-15 4:37 p.m., Zeng, Oak wrote: > [CAUTION: External Email] > > Add a new kfd ioctl to allocate queue GWS. Queue > GWS is released on queue destroy. > > Change-Id: I60153c26a577992ad873e4292e759e5c3d5bbd15 > Signed-off-by: Oak Zeng > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

Re: [PATCH 5/7] drm/amdgpu: Add function to add/remove gws to kfd process

2019-05-21 Thread Kuehling, Felix
On 2019-05-15 4:37 p.m., Zeng, Oak wrote: > GWS bo is shared between all kfd processes. Add function to add gws > to kfd process's bo list so gws can be evicted from and restored > for process. > > Change-Id: I75d74cfdadb7075ff8b2b68634e205deb73dc1ea > Signed-off-by: Oak Zeng > --- > drivers/gpu

Re: [PATCH 4/7] drm/amdkfd: Add function to set queue gws

2019-05-21 Thread Kuehling, Felix
On 2019-05-15 4:37 p.m., Zeng, Oak wrote: > Add functions in process queue manager to > set/get queue gws. Also set process's number > of gws used. Currently only one queue in > process can use and use all gws. > > Change-Id: I03e480c8692db3eabfc3a188cce8904d5d962ab7 > Signed-off-by: Oak Zeng > --

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

2019-05-21 Thread Jason Gunthorpe
On Fri, May 17, 2019 at 03:49:31PM +0100, Catalin Marinas wrote: > The tagged pointers (whether hwasan or MTE) should ideally be a > transparent feature for the application writer but I don't think we can > solve it entirely and make it seamless for the multitude of ioctls(). > I'd say you only op

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

2019-05-21 Thread Catalin Marinas
On Mon, May 20, 2019 at 04:53:07PM -0700, Evgenii Stepanov wrote: > On Fri, May 17, 2019 at 7:49 AM Catalin Marinas > wrote: > > IMO (RFC for now), I see two ways forward: > > > > 1. Make this a user space problem and do not allow tagged pointers into > >the syscall ABI. A libc wrapper would

Re: GPU passthrough support for Stoney [Radeon R2/R3/R4/R5 Graphics]?

2019-05-21 Thread Micah Morton
On Fri, May 17, 2019 at 9:59 AM Alex Deucher wrote: > > On Fri, May 17, 2019 at 11:36 AM Micah Morton wrote: > > > > On Thu, May 16, 2019 at 1:39 PM Alex Deucher wrote: > > > > > > On Thu, May 16, 2019 at 4:07 PM Micah Morton wrote: > > > > > > > > On Wed, May 15, 2019 at 7:19 PM Alex Deucher

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Gustavo A. R. Silva
On 5/21/19 3:59 AM, Christian König wrote: > BTW: Is there actually good documentation how to correctly do the variable > length array at end of structure thing in the kernel? > > I do know that I've seen a lot of different variants like array[] array[0] or > array[1] and I have also seen a

[PATCH] drm/amd/powerplay: Fix code error for translating int type to bool type correctly

2019-05-21 Thread Chengming Gui
Fix code error to support value < 0 or > 1. Signed-off-by: Chengming Gui --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index 3a47130..d5f0

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Christian König
Am 21.05.19 um 09:23 schrieb Daniel Vetter: On Tue, May 21, 2019 at 4:33 AM Alex Deucher wrote: On Mon, May 20, 2019 at 7:19 PM Pan, Xinhui wrote: Daniel, what you are talking about is totally wrong. 1) AFAIK, only one zero-size array can be in the end of a struct. 2) two struct_size will add

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Daniel Vetter
On Tue, May 21, 2019 at 4:33 AM Alex Deucher wrote: > > On Mon, May 20, 2019 at 7:19 PM Pan, Xinhui wrote: > > > > Daniel, what you are talking about is totally wrong. > > 1) AFAIK, only one zero-size array can be in the end of a struct. > > 2) two struct_size will add up struct itself twice. the