Re: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type V4

On Mon, Apr 29, 2019 at 11:16 PM Evan Quan wrote: > > Every ring type can have its own timeout setting. > > - V2: update lockup_timeout parameter format and cosmetic fixes > - V3: invalidate 0 and negative values > - V4: update lockup_timeout parameter format > > Change-Id: I992f224f36bb33acd56

RE: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type V3

Fixed in V4. Regards, Evan > -Original Message- > From: Alex Deucher > Sent: 2019年4月30日 9:34 > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Lou, Wentao ; > Daenzer, Michel ; Koenig, Christian > > Subject: Re: [PATCH] drm/amdgpu: enable separate timeout setting for > every

[PATCH] drm/amdgpu: enable separate timeout setting for every ring type V4

Every ring type can have its own timeout setting. - V2: update lockup_timeout parameter format and cosmetic fixes - V3: invalidate 0 and negative values - V4: update lockup_timeout parameter format Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e Signed-off-by: Evan Quan --- drivers/gpu/

RE: [PATCH] drm/amdgpu: Update latest xgmi topology info after each device is enumulated

Acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Liu, > Shaoyun > Sent: 2019年4月30日 3:20 > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Shaoyun > Subject: [PATCH] drm/amdgpu: Update latest xgmi topology info after each > device is enumulated > > [CAUTION: External E

Re: [PATCH] drm/amdgpu: remove ATPX_DGPU_REQ_POWER_FOR_DISPLAYS check when hotplug-in

On Mon, Apr 29, 2019 at 9:58 PM Aaron Liu wrote: > > In amdgpu_atif_handler, when hotplug event received, remove > ATPX_DGPU_REQ_POWER_FOR_DISPLAYS check. This bit's check will cause missing > system resume. > > Change-Id: Ic9a55fd44b721e59348a7768daeb41d414f21366 > Signed-off-by: Aaron Liu Revi

[PATCH] drm/amdgpu: remove ATPX_DGPU_REQ_POWER_FOR_DISPLAYS check when hotplug-in

In amdgpu_atif_handler, when hotplug event received, remove ATPX_DGPU_REQ_POWER_FOR_DISPLAYS check. This bit's check will cause missing system resume. Change-Id: Ic9a55fd44b721e59348a7768daeb41d414f21366 Signed-off-by: Aaron Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 3 +-- 1 file change

Re: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type V3

On Mon, Apr 29, 2019 at 9:29 PM Quan, Evan wrote: > > For old design, lockup_timeout affects non-compute IPs only(e.g. > amdgpu.lockup_timeout=1000). Compute jobs always use MAX_SCHEDULE_TIMEOUT. > For the new design, I would like it be backward compatible. With > [Non-Compute]:[Compute] format,

RE: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type V3

For old design, lockup_timeout affects non-compute IPs only(e.g. amdgpu.lockup_timeout=1000). Compute jobs always use MAX_SCHEDULE_TIMEOUT. For the new design, I would like it be backward compatible. With [Non-Compute]:[Compute] format, "amdgpu.lockup_timeout=1000" setting has the same effect as

Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path

I remember a past discussion to change the CSA allocation/mapping scheme to avoid this issue in the first place. Can adding the CSA to the VM be delayed a little to a point after the VM gets converted to a compute VM? Maybe the first command submission? Regards,   Felix On 2019-04-28 6:25 a.m

Re: [PATCH 00/27] KFD upstreaming

I'll drop patch 27 from this series until the potential OOM issues can be sorted out. The remaining patches are all KFD specific and shouldn't cause any trouble for graphics apps. If there are no other objections I'm planning to push patches 1-26 to amd-staging-drm-next tomorrow. Thanks,   Fe

Re: [PATCH 27/27] drm/amdgpu: Fix GTT size calculation

On 2019-04-29 8:34 a.m., Christian König wrote: > Am 28.04.19 um 09:44 schrieb Kuehling, Felix: >> From: Kent Russell >> >> GTT size is currently limited to the minimum of VRAM size or 3/4 of >> system memory. This severely limits the quanitity of system memory >> that can be used by ROCm applicat

Re: [PATCH v2 0/9] PCI: add help pci_dev_id

On Wed, Apr 24, 2019 at 09:10:21PM +0200, Heiner Kallweit wrote: > In several places in the kernel we find PCI_DEVID used like this: > PCI_DEVID(dev->bus->number, dev->devfn) Therefore create a helper > for it. > > v2: > - apply the change to all affected places in the kernel > > Heiner Kallweit

Re: [PATCH][next] drm/amd/display: fix incorrect null check on pointer

On Fri, Apr 26, 2019 at 5:48 PM Colin King wrote: > > From: Colin Ian King > > Currently an allocation is being made but the allocation failure > check is being performed on another pointer. Fix this by checking > the correct pointer. Also use the normal kernel idiom for null > pointer checks. >

[PATCH] drm/amdgpu: Update latest xgmi topology info after each device is enumulated

Adjust the sequence of set/get xgmi topology, so driver can have the latest XGMI topology info for future usage Change-Id: I627814f82459a6c9c3d72469f81309488b2a9133 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 32 1 file changed, 20 inse

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

I would clean them up further, but that's only moving code around so feel free to add my rb to those. Christian. Am 29.04.19 um 16:14 schrieb Grodzovsky, Andrey: Thanks David, with that only patches 5 and 6 are left for the series to be reviewed. Christian, any more comments on those patch

Re: [PATCH v13 16/20] IB/mlx4, arm64: untag user pointers in mlx4_get_umem_mr

On Wed, Mar 20, 2019 at 03:51:30PM +0100, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > mlx4_get_umem_mr() uses provided user poin

Re: [PATCH v13 10/20] kernel, arm64: untag user pointers in prctl_set_mm*

On Fri, Apr 26, 2019 at 4:50 PM Catalin Marinas wrote: > > On Mon, Apr 01, 2019 at 06:44:34PM +0200, Andrey Konovalov wrote: > > On Fri, Mar 22, 2019 at 4:41 PM Catalin Marinas > > wrote: > > > On Wed, Mar 20, 2019 at 03:51:24PM +0100, Andrey Konovalov wrote: > > > > @@ -2120,13 +2135,14 @@ stat

Re: [PATCH 3/3] drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)

On Mon, Apr 29, 2019 at 2:51 PM Kazlauskas, Nicholas wrote: > > On 4/26/19 5:40 PM, Mario Kleiner wrote: > > Pre-DCE12 needs special treatment for BTR / low framerate > > compensation for more stable behaviour: > > > > According to comments in the code and some testing on DCE-8 > > and DCE-11, DCE

Re: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type V3

On Mon, Apr 29, 2019 at 9:51 AM Evan Quan wrote: > > Every ring type can have its own timeout setting. > > - V2: update lockup_timeout parameter format and cosmetic fixes > - V3: invalidate 0 and negative values > > Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e > Signed-off-by: Evan Quan

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

Thanks David, with that only patches 5 and 6 are left for the series to be reviewed. Christian, any more comments on those patches ? Andrey On 4/27/19 10:56 PM, Zhou, David(ChunMing) wrote: Sorry, I only can put my Acked-by: Chunming Zhou on patch#3. I cannot full

Re: [PATCH] drm/amd/powerplay: enable ppfeaturemask module parameter support on Vega20

Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Monday, April 29, 2019 4:56 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan Subject: [PATCH] drm/amd/powerplay: enable ppfeaturemask module parameter support on Vega20

[PATCH] drm/amdgpu: enable separate timeout setting for every ring type V3

Every ring type can have its own timeout setting. - V2: update lockup_timeout parameter format and cosmetic fixes - V3: invalidate 0 and negative values Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- driver

Re: print firmware versions on amdgpu sysfs

Thank you Alex and Christian for the feedback. Ori will try to add ioctl into SMI CLI to retrieve firmware versions. Amber On 2019-04-29 8:22 a.m., Christian König wrote: We just need to keep in mind that sysfs has more restrictions than debugfs. E.g. one value per file, backward compatibility

Re: [PATCH 3/3] drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)

On 4/26/19 5:40 PM, Mario Kleiner wrote: > Pre-DCE12 needs special treatment for BTR / low framerate > compensation for more stable behaviour: > > According to comments in the code and some testing on DCE-8 > and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX > programming with a lag of one

Re: [PATCH 27/27] drm/amdgpu: Fix GTT size calculation

Am 28.04.19 um 09:44 schrieb Kuehling, Felix: From: Kent Russell GTT size is currently limited to the minimum of VRAM size or 3/4 of system memory. This severely limits the quanitity of system memory that can be used by ROCm application. Increase GTT size to the maximum of VRAM size or system

Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path

Am 28.04.19 um 12:25 schrieb Trigger Huang: In amdgpu open path, CSA will be mappened in VM, so when opening KFD, calling mdgpu_vm_make_compute will fail because it found this VM is not a clean VM with some mappings, as a result, it will lead to failed to create process VM object The fix is try

Re: print firmware versions on amdgpu sysfs

We just need to keep in mind that sysfs has more restrictions than debugfs. E.g. one value per file, backward compatibility etc... Apart from that I don't see any reason to not do it in sysfs. Christian. Am 26.04.19 um 20:35 schrieb Russell, Kent: The main reasoning and use case for sysfs woul

RE: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type

Thanks for reviewing. Will update them in V2. Regards, Evan > -Original Message- > From: Michel Dänzer > Sent: Monday, April 29, 2019 6:17 PM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Lou, Wentao ; > Koenig, Christian > Subject: Re: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type

On 2019-04-29 10:57 a.m., Evan Quan wrote: > Every ring type can have its own timeout setting. > > Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e > Signed-off-by: Evan Quan This is going in a good direction, but there are still some minor/cosmetic issues. > @@ -958,13 +960,16 @@ static v

Re: [PATCH] drm/amdgpu: enable separate timeout setting for every ring type

Am 29.04.19 um 10:57 schrieb Evan Quan: > Every ring type can have its own timeout setting. > > Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +++-- >

[PATCH] drm/amdgpu: enable separate timeout setting for every ring type

Every ring type can have its own timeout setting. Change-Id: I992f224f36bb33acd560162bffd2c3e987840a7e Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 82 +

[PATCH] drm/amd/powerplay: enable ppfeaturemask module parameter support on Vega20

Support DPM/DS/ULV related bitmasks of ppfeaturemask module parameter. Change-Id: I6b75becf8d39105189b30be41b58ec7d4425f356 Signed-off-by: Evan Quan --- .../drm/amd/powerplay/hwmgr/vega20_hwmgr.c| 21 +++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/amd/powe

[PATCH] drm/amd/powerplay: add helper function to get smu firmware & if version

add this helper function to get smc version. Change-Id: I6b06470cefd10fafcf06df8a5e8cb03bf79622c0 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 30 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/smu_v11_0.c

RE: [PATCH] drm/amd/powerplay: add helper function to get smu firmware & if version

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Wang, Kevin(Yang) > Sent: Monday, April 29, 2019 3:05 PM > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Ray ; Wang, Kevin(Yang) > > Subject: [PATCH] drm/amd/powerplay: add helper function t