[PATCH 3/3] drm/amdgpu: add more debug friendly prompts

2019-03-14 Thread Evan Quan
Large piece of codes share one error prompt. That is not friendly for debugging. Change-Id: I15f77210af6a409981fe44cf5dd3aa8ce48d948f Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 38 ++--- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git

[PATCH 2/3] drm/amdgpu: trivial typo fix

2019-03-14 Thread Evan Quan
"error" was not correctly spelled. Change-Id: Idc3acb6172469c1d63227cb5f0df75f912c10871 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/am

[PATCH 1/3] drm/amdgpu: error out on mode1 reset failure

2019-03-14 Thread Evan Quan
The error return value should be correctly reflected. Change-Id: I93bf6fa77193d4e3f102a4e223aa8cb18cb525cc Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/soc15.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/

Re: kernel errors with HMM enabled

2019-03-14 Thread Yang, Philip
Hi Tom, Yes, we are missing some HMM fixes/changes from 5.1, but the crash log seems not related to those fixes/changes in 5.1. I did see the similar crash log in __mmu_notifier_release path that should be fixed by the patch "use reference counting for HMM struct" as Alex mentioned. Since you

Re: kernel errors with HMM enabled

2019-03-14 Thread Michel Dänzer
On 2019-03-14 6:10 p.m., StDenis, Tom wrote: > On 2019-03-14 12:37 p.m., Alex Deucher wrote: >> Make sure you have this patch: >> https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=e811b0a799981eaa6fef1809278367471f14ba13 > > Hi Alex, > > The tip of our amd-staging-drm-next i

Re: kernel errors with HMM enabled

2019-03-14 Thread StDenis, Tom
On 2019-03-14 12:37 p.m., Alex Deucher wrote: > Make sure you have this patch: > https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=e811b0a799981eaa6fef1809278367471f14ba13 Hi Alex, The tip of our amd-staging-drm-next includes this patch (about 126 down from the tip). Tom _

[PATCH] drm/amd/display: Only put primary planes into the mode_info->planes list

2019-03-14 Thread Nicholas Kazlauskas
We want DRM planes to be initialized in the following order: - primary planes - overlay planes - cursor planes to support existing userspace expectations for plane z-ordering. This means that we also need to register CRTCs after all planes have been initialized since overlay planes can be placed

Re: Slow memory access when using OpenCL without X11

2019-03-14 Thread Lauri Ehrenpreis
Yes it affects this a bit but it doesn't get the speed up to "normal" level. I got best results with "profile_peak" - then the memcpy speed on CPU is 1/3 of what it is without opencl initialization: echo "profile_peak" > /sys/class/drm/card0/device/power_dpm_force_performance_level ./cl_slow_test

Re: kernel errors with HMM enabled

2019-03-14 Thread Alex Deucher
Make sure you have this patch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=e811b0a799981eaa6fef1809278367471f14ba13 Alex On Thu, Mar 14, 2019 at 12:36 PM StDenis, Tom wrote: > > Hi Philip, > > With your HMM patches enabled I'm seeing (attached) kernel errors while > r

kernel errors with HMM enabled

2019-03-14 Thread StDenis, Tom
Hi Philip, With your HMM patches enabled I'm seeing (attached) kernel errors while running piglit. Are these known? I see it all along amd-staging-drm-next until I roll back before your very first HMM patches. Tom log.gz Description: log.gz ___ am

Re: Slow memory access when using OpenCL without X11

2019-03-14 Thread Ernst Sjöstrand
Does echo high > /sys/class/drm/card0/device/power_dpm_force_performance_level or setting cpu scaling governor to performance affect it at all? Regards //Ernst Den tors 14 mars 2019 kl 14:31 skrev Lauri Ehrenpreis : > > I tried also with those 2 boards now: > https://www.asrock.com/MB/AMD/Fatal1t

Re: [PATCH xf86-video-ati] modesetting: add tile property support

2019-03-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, March 14, 2019 6:19 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] modesetting: add tile property support From: Dave Airlie This adds tiling support to th

Re: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update

2019-03-14 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, March 14, 2019 6:15 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update From: Michel Dänzer radeon_glamor_fini

[PATCH xf86-video-ati] modesetting: add tile property support

2019-03-14 Thread Michel Dänzer
From: Dave Airlie This adds tiling support to the driver, it retrieves the tile info from the kernel and translates it into the server format and exposes the property. (Ported from xserver commits 8fb8bbb3062f1a06621ab7030a9e89d5e8367b35 and 6abdb54a11dac4e8854ff94ecdcb90a14321ab31) (Ported fro

[PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update

2019-03-14 Thread Michel Dänzer
From: Michel Dänzer radeon_glamor_finish only works if we're using glamor, otherwise it'll crash. Fixes: ce7db51020d3 "Cancel pending scanout update in drmmode_crtc_scanout_update" Bug: https://bugs.debian.org/924540 Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 2 +- 1 file change