Re: [PATCH 07/18] drm/amd/display: Create overlay planes

2019-02-26 Thread Vishwakarma, Pratik
On 2/26/2019 4:16 AM, Bhawanpreet Lakha wrote: > From: Nicholas Kazlauskas > > [Why] > Raven has support for combining pipes for DRM_PLANE_TYPE_OVERLAY use > but no overlays are exposed to userspace. > > [How] > Expose overlay planes based on DC plane caps. > > If all the pipes are in use then th

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Alex Deucher
yes, go ahead. Alex On Tue, Feb 26, 2019 at 6:18 PM Zhao, Yong wrote: > > So can I submit it only with the ACKs? > > Yong > > On 2019-02-26 5:29 a.m., Christian König wrote: > > Am 26.02.19 um 00:03 schrieb Zhao, Yong: > >> This is recommended by HW designers. Previously when it was set to 1, >

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Zhao, Yong
So can I submit it only with the ACKs? Yong On 2019-02-26 5:29 a.m., Christian König wrote: > Am 26.02.19 um 00:03 schrieb Zhao, Yong: >> This is recommended by HW designers. Previously when it was set to 1, >> the PDE walk error in VM fault will be treated as >> PERMISSION_OR_INVALID_PAGE_FAULT

Re: [PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

2019-02-26 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v4.20.12, v4.19.25, v4.14.103, v4.9.160, v4.4.176, v3.18.136. v4.20.12: Build OK!

Re: The problem "ring gfx timeout" are experienced yet another AMD GPU Vega 8 user

2019-02-26 Thread Marek Olšák
Sadly, the logs don't contain any clue as to why it hangs. It would be helpful to check if the hang can be reproduced on Vega 56 or 64 as well. Marek On Tue, Feb 26, 2019 at 7:51 AM Mikhail Gavrilov < mikhail.v.gavri...@gmail.com> wrote: > On Tue, 26 Feb 2019 at 00:40, Marek Olšák wrote: > > >

Re: [PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-02-26 Thread Christian König
Am 26.02.19 um 19:10 schrieb Liu, Shaoyun: On 2019-02-26 2:55 a.m., Christian König wrote: Am 25.02.19 um 19:47 schrieb Liu, Shaoyun: On 2019-02-25 10:50 a.m., Christian König wrote: Am 22.02.19 um 22:28 schrieb Liu, Shaoyun: Adjust vram base offset for XGMI mapping when update the PT entry s

Re: [PATCH] drm/amdgpu: Eliminate the set_pde_pte function pointer in amdgpu_gmc_funcs

2019-02-26 Thread Zhao, Yong
Pushed. Thanks. Yong On 2019-02-26 1:53 p.m., Christian König wrote: > Am 26.02.19 um 18:43 schrieb Zhao, Yong: >> All the gmc_*_set_pde_pte functions are the same across different ASICs, >> so we can eliminate the set_pde_pte function pointer and instead use a >> generic function. >> >> Signed-o

Re: [PATCH] drm/amdgpu: Eliminate the set_pde_pte function pointer in amdgpu_gmc_funcs

2019-02-26 Thread Christian König
Am 26.02.19 um 18:43 schrieb Zhao, Yong: All the gmc_*_set_pde_pte functions are the same across different ASICs, so we can eliminate the set_pde_pte function pointer and instead use a generic function. Signed-off-by: Yong Zhao Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/

Re: [PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-02-26 Thread Liu, Shaoyun
On 2019-02-26 2:55 a.m., Christian König wrote: > Am 25.02.19 um 19:47 schrieb Liu, Shaoyun: >> On 2019-02-25 10:50 a.m., Christian König wrote: >>> Am 22.02.19 um 22:28 schrieb Liu, Shaoyun: Adjust vram base offset for XGMI mapping when update the PT entry so the address will fall into

[PATCH] drm/amdgpu: Eliminate the set_pde_pte function pointer in amdgpu_gmc_funcs

2019-02-26 Thread Zhao, Yong
All the gmc_*_set_pde_pte functions are the same across different ASICs, so we can eliminate the set_pde_pte function pointer and instead use a generic function. Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 27 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 10 +--

[PATCH 1/3] drm/amdgpu: remove non-sense NULL ptr check

2019-02-26 Thread Christian König
It's a bug having a dead pointer in the IDR, silently returning is the worst we can do. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH 2/3] drm/amdgpu: wait for VM to become idle during flush

2019-02-26 Thread Christian König
Make sure that not only the entities are flush, but that we also wait for the HW to finish all processing. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 ---

[PATCH 3/3] drm/amdgpu: stop evicting busy PDs/PTs

2019-02-26 Thread Christian König
Otherwise we won't be able to cleanly handle page faults. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index cd0ccfbbcb84..c

Re: [PATCH 0/5] Clean up TTM mmap offsets

2019-02-26 Thread Christian König
Am 07.02.19 um 10:45 schrieb Thomas Zimmermann: Am 07.02.19 um 10:36 schrieb Koenig, Christian: Am 07.02.19 um 09:59 schrieb Thomas Zimmermann: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET con

Re: The problem "ring gfx timeout" are experienced yet another AMD GPU Vega 8 user

2019-02-26 Thread Mikhail Gavrilov
On Tue, 26 Feb 2019 at 00:40, Marek Olšák wrote: > > Some shaders are stuck at "s_load_dwordx4 s[32:35], s[36:37], 0x0", but that > might mean all sorts of things. > > Do you also have the dmesg log? > > Marek All files together here: https://mega.nz/#F!c4RwAYDJ!0ds-bVIftIDV4KCQOaDIsw -- Best R

[PATCH 6/6] drm/amdgpu: allow huge invalid mappings on GMC8

2019-02-26 Thread Christian König
Only GMC9 supports true huge pages, but we can still free invalid mappings on GMC8. Signed-off-by: Christian König Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 4/6] drm/amdgpu: free PDs/PTs on demand

2019-02-26 Thread Christian König
When something is unmapped we now free the affected PDs/PTs again. Signed-off-by: Christian König Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 71 +++--- 1 file changed, 53 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/am

[PATCH 2/6] drm/amdgpu: let amdgpu_vm_clear_bo figure out ats status v2

2019-02-26 Thread Christian König
Instead of providing it from outside figure out the ats status in the function itself from the data structures. v2: simplify finding the right level Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 51 ++ 1 file changed, 28 insertions(+), 23 de

[PATCH 5/6] drm/amdgpu: drop the huge page flag

2019-02-26 Thread Christian König
Not needed any more since we now free PDs/PTs on demand. Signed-off-by: Christian König Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drive

[PATCH 1/6] drm/amdgpu: rework shadow handling during PD clear v2

2019-02-26 Thread Christian König
This way we only deal with the real BO in here. v2: use a do { ... } while loop instead Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 65 +++--- 1 file changed, 38 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm

[PATCH 3/6] drm/amdgpu: allocate VM PDs/PTs on demand

2019-02-26 Thread Christian König
Let's start to allocate VM PDs/PTs on demand instead of pre-allocating them during mapping. Signed-off-by: Christian König Reviewed-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 9 -- drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Christian König
Don't we want PDE faults to be treated the same way as page faults? Yeah, I think that this was actually the original intention. Problem is that this is actually the wrong approach for this. Or is the idea that we should never see a PDE fault unless something goes wrong Exactly, yes. What you

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Christian König
Am 26.02.19 um 00:03 schrieb Zhao, Yong: This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMISSION_OR_INVALID_PAGE_FAULT rather than usually expected OTHER_FAULT. As a result, the retry control in VM_CONTEXT*_CNTL will chang

Re: [PATCH] drm/amdgpu: Eliminate the set_pde_pte function pointer in amdgpu_gmc_funcs

2019-02-26 Thread Christian König
Am 25.02.19 um 23:47 schrieb Zhao, Yong: All the gmc_*_set_pde_pte functions are the same across different ASICs, so we can eliminate the set_pde_pte function pointer and instead use a generic function. Signed-off-by: Yong Zhao I think I prefer keeping the GMC specific description of the PTEs

RE: [PATCH v2] drm/amd/powerplay: add limit of pp_feature for smu (v2)

2019-02-26 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of likun Gao > Sent: Tuesday, February 26, 2019 4:15 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Gao, Likun > ; Huang, Ray > Subject: [PATCH v2] drm/amd/powerplay: add limi

[PATCH v2] drm/amd/powerplay: add limit of pp_feature for smu (v2)

2019-02-26 Thread likun Gao
From: Likun Gao Move pp_feature from the struct of amd_powerplay to amdgpu_device. Add pp_feature limit for overdrive interface. v2: put pp_feature into struct amdgpu_pm. Signed-off-by: Likun Gao Reviewed-by: Kevin Wang Suggested-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h