[PATCH] drm/amdgpu/virtual_dce: Need to pin the fb's bo

2018-12-20 Thread Emily Deng
When the bo is used to set mode, the bo need to be pinned. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 54 1 file changed, 41 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd

[PATCH v5 2/2] drm/sched: Rework HW fence processing.

2018-12-20 Thread Andrey Grodzovsky
Expedite job deletion from ring mirror list to the HW fence signal callback instead from finish_work, together with waiting for all such fences to signal in drm_sched_stop we garantee that already signaled job will not be processed twice. Remove the sched finish fence callback and just submit finis

[PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-20 Thread Andrey Grodzovsky
Decauple sched threads stop and start and ring mirror list handling from the policy of what to do about the guilty jobs. When stoppping the sched thread and detaching sched fences from non signaled HW fenes wait for all signaled HW fences to complete before rerunning the jobs. v2: Fix resubmission

Re: [PATCH] drm/amd/display/i2c_hw_engine_dce110: Remove duplicate header

2018-12-20 Thread Alex Deucher
On Thu, Dec 20, 2018 at 9:36 AM Brajeswar Ghosh wrote: > > Remove reg_helper.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Applied. thanks! Alex > --- > .../gpu/drm/amd/display/dc/i2caux/dce110/i2c_hw_engine_dce110.c | 1 - > 1 file changed, 1 deletion(-) > > diff --

Re: [PATCH] drm/amd/display/dcn10_hw_sequencer_debug: Remove duplicate header

2018-12-20 Thread Alex Deucher
On Thu, Dec 20, 2018 at 9:36 AM Brajeswar Ghosh wrote: > > Remove custom_float.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer_debug.c | 1 - > 1 file changed, 1 deletion(-) > > diff -

Re: [PATCH] drm/amd/display: Remove duplicate header

2018-12-20 Thread Alex Deucher
On Wed, Dec 19, 2018 at 3:41 AM Brajeswar Ghosh wrote: > > Remove custom_float.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a

Re: [PATCH 2/2] drm/amdgpu/nbio7.4: add hw bug workaround for vega20

2018-12-20 Thread Yang, Philip
This series are verified on 4 Vega20 by: Philip Yang On 2018-12-20 10:39 a.m., Kasiviswanathan, Harish wrote: > This patch set Reviewed-by: Harish Kasiviswanathan > > > On 2018-12-19 6:09 p.m., Alex Deucher wrote: >> Configure PCIE_CI_CNTL to work around a hw bug that affects >> some multi-GPU

Re: [PATCH][next] amdgpu/dc: remove various variables that are defined but never used

2018-12-20 Thread Alex Deucher
On Tue, Dec 18, 2018 at 8:06 AM Colin King wrote: > > From: Colin Ian King > > There are several variables that are defined and never used and hence can > be removed. Remove them. Cleans up clang -Wunused-const-variable warnings: > > warning: ‘dvi_hdmi_dongle_signature_str’ defined but not used >

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread StDenis, Tom
On 2018-12-20 11:07 a.m., Mikhail Gavrilov wrote: > On Thu, 20 Dec 2018 at 19:19, StDenis, Tom wrote: >> >> Ya I was right. With a plain build I can access the files just fine. >> >> >> >> I did manage to get into a weird shell where I couldn't cat >> amdgpu_gca_config from bash though after a re

Re: Trying to run AMD E9260 (Polaris 11) on NXP LS1012A-RDB

2018-12-20 Thread Bas Vermeulen
Hi Alex, I already have a similar patch in, that doesn't fix it just yet. I'll investigate some more. Bas Vermeulen On Thu, Dec 20, 2018 at 4:27 PM Alex Deucher wrote: > On Thu, Dec 20, 2018 at 9:06 AM Bas Vermeulen wrote: > > > > Hi all, > > > > I have connected an E9260 (Polaris 11 based) t

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread Mikhail Gavrilov
On Thu, 20 Dec 2018 at 19:19, StDenis, Tom wrote: > > Ya I was right. With a plain build I can access the files just fine. > > > > I did manage to get into a weird shell where I couldn't cat > amdgpu_gca_config from bash though after a reboot (had updates pending) > it works fine. > > If you can'

Re: [PATCH 2/2] drm/amdgpu/nbio7.4: add hw bug workaround for vega20

2018-12-20 Thread Kasiviswanathan, Harish
This patch set Reviewed-by: Harish Kasiviswanathan On 2018-12-19 6:09 p.m., Alex Deucher wrote: > Configure PCIE_CI_CNTL to work around a hw bug that affects > some multi-GPU compute workloads. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 7 +++ > 1 fi

Re: [PATCH] drm: return false in drm_arch_can_wc_memory() for ARM

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 09:56:57AM -0500, Alex Deucher wrote: > I'm not familiar enough with ARM to know if write combining > is actually an architectural limitation or if it's an issue > with the PCIe IPs used on various platforms, but so far > everyone that has tried to run radeon hardware on > A

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of S, Shirish Sent: Thursday, December 20, 2018 9:01:33 AM To: Li, Sun peng (Leo); Wentland, Harry; Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amdgpu

Re: [PATCH] drm/amd/display: fix compliler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of S, Shirish Sent: Thursday, December 20, 2018 9:01:04 AM To: Li, Sun peng (Leo); Wentland, Harry; Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amd/di

Re: Trying to run AMD E9260 (Polaris 11) on NXP LS1012A-RDB

2018-12-20 Thread Alex Deucher
On Thu, Dec 20, 2018 at 9:06 AM Bas Vermeulen wrote: > > Hi all, > > I have connected an E9260 (Polaris 11 based) to a mini-PCIe slot on my NXP > LS1012ARDB. > The GPU is seen, all the BARs are correctly assigned (but there's not enough > PCIe memory space for the big BARs). > > When I try to lo

[PATCH] drm/amdgpu: Add new VegaM pci id

2018-12-20 Thread Alex Deucher
Add a new pci id. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 9c77eaa45982..c806f984bcc5 100644 ---

Re: [PATCH] drm/amdgpu: add Vega20 PSP ASD firmware loading

2018-12-20 Thread Alex Deucher
Reviewed-by: Alex Deucher On Thu, Dec 20, 2018 at 9:50 AM Evan Quan wrote: > > Add PSP ASD firmware loading on Vega20. Not sure why > this was missing before. > > Change-Id: I047bee28323b5b3bf54b4eec6f7089406b2e07e1 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 40

[PATCH] drm: return false in drm_arch_can_wc_memory() for ARM

2018-12-20 Thread Alex Deucher
I'm not familiar enough with ARM to know if write combining is actually an architectural limitation or if it's an issue with the PCIe IPs used on various platforms, but so far everyone that has tried to run radeon hardware on ARM has had to disable it. So let's just make it official. Signed-off-b

[PATCH] drm/amdgpu: add Vega20 PSP ASD firmware loading

2018-12-20 Thread Evan Quan
Add PSP ASD firmware loading on Vega20. Not sure why this was missing before. Change-Id: I047bee28323b5b3bf54b4eec6f7089406b2e07e1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 40 -- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/d

[PATCH] drm/amd/display/dcn10_hw_sequencer_debug: Remove duplicate header

2018-12-20 Thread Brajeswar Ghosh
Remove custom_float.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer_debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer_debug.c b/drivers/gpu/drm/amd/disp

[PATCH] drm/amd/display/i2c_hw_engine_dce110: Remove duplicate header

2018-12-20 Thread Brajeswar Ghosh
Remove reg_helper.h which is included more than once Signed-off-by: Brajeswar Ghosh --- .../gpu/drm/amd/display/dc/i2caux/dce110/i2c_hw_engine_dce110.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/i2caux/dce110/i2c_hw_engine_dce110.c b/drivers/gpu/drm/amd/

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread StDenis, Tom
On 2018-12-20 9:08 a.m., Tom St Denis wrote: > On 2018-12-20 9:06 a.m., Tom St Denis wrote: >> On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: >>> On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: Well yup the kernel is not letting you open the files: As sudo/root you sho

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread StDenis, Tom
On 2018-12-20 9:06 a.m., Tom St Denis wrote: > On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: >> On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: >>> >>> Well yup the kernel is not letting you open the files: >>> >>> >>> As sudo/root you should be able to open these files with umr.  What >>> ha

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread StDenis, Tom
On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: > On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: >> >> Well yup the kernel is not letting you open the files: >> >> >> As sudo/root you should be able to open these files with umr. What >> happens if you just open a shell as root and run it? >>

Trying to run AMD E9260 (Polaris 11) on NXP LS1012A-RDB

2018-12-20 Thread Bas Vermeulen
Hi all, I have connected an E9260 (Polaris 11 based) to a mini-PCIe slot on my NXP LS1012ARDB. The GPU is seen, all the BARs are correctly assigned (but there's not enough PCIe memory space for the big BARs). When I try to load the amdgpu module, I can't get the driver to enable the acceleration

[PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread S, Shirish
Initializing structures with { } is known to be problematic since it doesn't necessararily initializes all bytes, in case of padding, causing random failures when structures are memcmp(). This patch fixes the structure initialisation compiler error by memsetting the entire structure elements inste

[PATCH] drm/amd/display: fix compliler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread S, Shirish
Initializing structures with { } is known to be problematic since it doesn't necessararily initializes all bytes, in case of padding, causing random failures when structures are memcmp(). This patch fixes the structure initialisation compiler error by memsetting the entire structure elements inste

Re: After Vega 56/64 GPU hang I unable reboot system

2018-12-20 Thread StDenis, Tom
On 2018-12-19 10:29 p.m., Mikhail Gavrilov wrote: > On Thu, 20 Dec 2018 at 03:41, StDenis, Tom wrote: > >> sudo strace umr -R gfx[.] 2>&1 | tee strace.log >> >> will capture everything. >> >> In the mean time I can fix at least the segfault. >> >> The issue is why can't it open "amdgpu_ring_gfx".

Re: [PATCH v4 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-20 Thread Koenig, Christian
Am 19.12.18 um 18:32 schrieb Grodzovsky, Andrey: > > On 12/19/2018 11:21 AM, Christian König wrote: >> Am 17.12.18 um 20:51 schrieb Andrey Grodzovsky: >>> Decauple sched threads stop and start and ring mirror >>> list handling from the policy of what to do about the >>> guilty jobs. >>> When stoppp

Re: [PATCH v2 06/16] drm/i915: Keep malloc references to MST ports

2018-12-20 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:19:50PM -0500, Lyude Paul wrote: > So that the ports stay around until we've destroyed the connectors, in > order to ensure that we don't pass an invalid pointer to any MST helpers > once we introduce the new MST VCPI helpers. > > Changes since v1: > * Move drm_dp_mst_ge

Re: [PATCH v2 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends

2018-12-20 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:19:45PM -0500, Lyude Paul wrote: > s/drm_dp_get_validated_port_ref/drm_dp_mst_topology_get_port_validated/ > s/drm_dp_put_port/drm_dp_mst_topology_put_port/ > s/drm_dp_get_validated_mstb_ref/drm_dp_mst_topology_get_mstb_validated/ > s/drm_dp_put_mst_branch_device/drm_dp_m