RE: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

Make igt for cross-driver, I think you should rename it first, not an intel specific. NO company wants their employee working on other company stuff. You can rename it to DGT(drm graphics test), and published following libdrm, or directly merge to libdrm, then everyone can use it and develop it

Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

On 10/26/2018 8:34 AM, Alex Deucher wrote: > On Thu, Oct 25, 2018 at 10:52 PM Agrawal, Akshu wrote: >> >> >> >> On 10/26/2018 8:09 AM, Alex Deucher wrote: >>> On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. Rea

Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

On Thu, Oct 25, 2018 at 10:52 PM Agrawal, Akshu wrote: > > > > On 10/26/2018 8:09 AM, Alex Deucher wrote: > > On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: > >> > >> This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. > >> > >> Reason for revert: > >> This patch sends msg PPSMC_MS

[pull] amdgpu drm-next-4.20

Hi Dave, Fixes for 4.20: - Powerplay updates for vega20 - Powerplay fixes - DC fix for CZ and ST - GPUVM fix - SR-IOV fix The following changes since commit f2bfc71aee75feff33ca659322b72ffeed5a243d: Merge tag 'drm-intel-next-fixes-2018-10-18' of git://anongit.freedesktop.org/drm/drm-intel int

Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

On 10/26/2018 8:09 AM, Alex Deucher wrote: > On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: >> >> This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. >> >> Reason for revert: >> This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) >> in wrong of sequence to SMU which is b

Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: > > This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. > > Reason for revert: > This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) > in wrong of sequence to SMU which is before PPSMC_MSG_UVDPowerON (0x0008). > This leads to

RE: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

Patch is Acked-by: Rex Zhu Regards Rex > -Original Message- > From: S, Shirish > Sent: Friday, October 26, 2018 12:28 AM > To: Zhu, Rex ; Agrawal, Akshu > ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PATCH] Revert "drm/amd/powerplay: Enable/Disable

RE: [PATCH] drm/amdgpu: fix reporting of failed msg sent to SMU

Patch is Reviewed-by: Rex Zhu Rex > -Original Message- > From: amd-gfx On Behalf Of S, > Shirish > Sent: Friday, October 26, 2018 6:37 AM > To: Deucher, Alexander ; Zhu, Rex > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PATCH] drm/amdgpu: fix reporting of failed msg sen

[PATCH] drm/amdgpu: fix reporting of failed msg sent to SMU

Currently send_msg_to_smc_async() only report which message failed, but the actual failing message is the previous one, which SMU is unable to service. This patch reads the contents of register where the SMU is stuck and report appropriately. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/pow

Re: [PATCH 1/8] dma-buf: remove shared fence staging in reservation object

Quoting Chris Wilson (2018-10-25 21:20:21) > Quoting Chris Wilson (2018-10-25 21:15:17) > > Quoting Christian König (2018-10-04 14:12:43) > > > No need for that any more. Just replace the list when there isn't enough > > > room any more for the additional fence. > > > > Just a heads up. After this

[PATCH] drm/amdgpu: Fix compute ring 1.0.0 failure after reset

Problem: After GPU reset on dGPUs with gfx8 compute ring 1.0.0 fails to pass the ring test. Ring registers inspection shows that it's active and no hang is observed (rptr == wptr) No significant diffs were observed between CP_HQD* registers for the ring in good and bad shape. Fix: No clear reason

Re: amdgpu: [powerplay] failed to send message 148 ret is 0

On Wed, 24 Oct 2018, Mikulas Patocka wrote: > Hi > > I have a Sapphire Pulse RX 570 ITX graphics card. > > On Linux, I get errors "amdgpu: [powerplay] failed to send message 148 ret > is 0" and the system is stuck for several seconds when they happen. The > card works, except for these error

Re: [PATCH 1/8] dma-buf: remove shared fence staging in reservation object

Quoting Chris Wilson (2018-10-25 21:15:17) > Quoting Christian König (2018-10-04 14:12:43) > > No need for that any more. Just replace the list when there isn't enough > > room any more for the additional fence. > > Just a heads up. After this series landed, we started hitting a > use-after-free w

Re: [PATCH 1/8] dma-buf: remove shared fence staging in reservation object

Quoting Christian König (2018-10-04 14:12:43) > No need for that any more. Just replace the list when there isn't enough > room any more for the additional fence. Just a heads up. After this series landed, we started hitting a use-after-free when iterating the shared list. <4> [109.613162] genera

Re: [PATCH] drm/amdgpu/amdkfd: clean up mmhub and gfxhub includes

On 2018-10-25 2:27 p.m., Alex Deucher wrote: > On Mon, Oct 22, 2018 at 6:25 PM Alex Deucher wrote: >> Use the appropriate mmhub and gfxhub headers rather than adding >> them to the gmc9 header. >> >> Signed-off-by: Alex Deucher > Ping? Reviewed-by: Felix Kuehling > > Alex > >> --- >> drivers

Re: [PATCH] drm/amd/display: set backlight level limit to 1

On 2018-10-25 2:58 a.m., Guttula, Suresh wrote: > This patch will work as workaround for silicon limitation > related to PWM dutycycle when the backlight level goes to 0. > > Actually PWM value is 16 bit value and valid range from 1-65535. > when ever user requested to set this PWM value to 0 whic

Re: [PATCH] drm/amdgpu/amdkfd: clean up mmhub and gfxhub includes

On Mon, Oct 22, 2018 at 6:25 PM Alex Deucher wrote: > > Use the appropriate mmhub and gfxhub headers rather than adding > them to the gmc9 header. > > Signed-off-by: Alex Deucher Ping? Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/gfxhub_

Re: [PATCH -next] drm/amd/powerplay: remove duplicated includes

On Sun, Oct 21, 2018 at 11:32 PM YueHaibing wrote: > > Remove some duplicated include. > > Signed-off-by: YueHaibing Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 - > drivers/gpu/drm/amd/powerplay/inc/smu7_common.h | 4 > drivers/gpu/

Re: [PATCH -next] drm/radeon/kms: remove set but not used variable 'pll'

On Sun, Oct 21, 2018 at 11:32 PM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/radeon/radeon_legacy_tv.c: In function > 'radeon_legacy_tv_init_restarts': > drivers/gpu/drm/radeon/radeon_legacy_tv.c:435:21: warning: > variable 'pll' set but not used [-Wu

Re: [PATCH v5 4/4] drm/amdgpu: Set FreeSync state using drm VRR properties

On 2018-10-12 12:44 p.m., Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The notify_freesync and set_freesync_property functions are dropped > from amdgpu_displa

Re: [PATCH v3] drm/amdgpu: Modify the argument of emit_ib interface

On Wed, Oct 24, 2018 at 10:58 AM Rex Zhu wrote: > > use the point of struct amdgpu_job as the function > argument instand of vmid, so the other members of > struct amdgpu_job can be visit in emit_ib function. > > v2: add a wrapper for getting the VMID > add the job before the ib on the paramet

Re: [PATCH] drm/amdgpu: Change AMDGPU_CSA_SIZE to 128K

On Wed, Oct 24, 2018 at 8:11 AM Rex Zhu wrote: > > In order to support new asics and MCBP feature > enablement on baremetal. > > Signed-off-by: Rex Zhu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_csa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v5 3/4] drm: Document variable refresh properties

On 2018-10-12 12:44 p.m., Nicholas Kazlauskas wrote: > These include the drm_connector 'vrr_capable' and the drm_crtc > 'vrr_enabled' properties. > > Signed-off-by: Nicholas Kazlauskas > --- > Documentation/gpu/drm-kms.rst | 7 +++ > drivers/gpu/drm/drm_connector.c | 22

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

On 2018-10-12 12:44 p.m., Nicholas Kazlauskas wrote: > This patch introduces the 'vrr_enabled' CRTC property to allow > dynamic control over variable refresh rate support for a CRTC. > > This property should be treated like a content hint to the driver - > if the hardware or driver is not capable

Re: [PATCH v5 1/4] drm: Add vrr_capable property to the drm connector

On 2018-10-12 12:44 p.m., Nicholas Kazlauskas wrote: > Modern display hardware is capable of supporting variable refresh rates. > This patch introduces the "vrr_capable" property on the connector to > allow userspace to query support for variable refresh rates. > > Atomic drivers should attach thi

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-12 4:31 a.m., Koenig, Christian wrote: > Am 12.10.2018 um 10:26 schrieb Michel Dänzer: >> On 2018-10-11 9:44 p.m., Harry Wentland wrote: >>> On 2018-10-03 04:25 AM, Mike Lothian wrote: I'm curious to know whether this will/could work over PRIME >>> I don't see why this shouldn't w

Re: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

Sean Paul writes: > On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: >> Hi all, >> >> This is just to collect feedback on this idea, and see whether the >> overall dri-devel community stands on all this. I think the past few >> cross-vendor uapi extensions all came with igts attach

[PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. Reason for revert: This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) in wrong of sequence to SMU which is before PPSMC_MSG_UVDPowerON (0x0008). This leads to SMU failing to service the request as it is dependent on UVD to b

Re: [PATCH] drm/amdgpu: fix VM leaf walking

On 2018-10-25 10:38 a.m., Christian König wrote: > Make sure we don't try to go down further after the leave walk already > ended. This fixes a crash with a new VM test. > > Signed-off-by: Christian König Reviewed-by: Felix Kuehling Regards,   Felix > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_v

RE: [PATCH] drm/amdgpu: fix VM leaf walking

How about add a return value for the function amdgpu_vm_pt_next? And change the code as: ret = amdgpu_vm_pt_next(adev, cursor); - while (amdgpu_vm_pt_descendant(adev, cursor)); + if (!ret) + while (amdgpu_vm_pt_descendant(adev, cursor)); Best Regards Rex From: amd-g

RE: [PATCH] drm/amdgpu: fix VM leaf walking

Patch is Tested-by: Rex Zhu rex@amd.com Regards Rex From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, October 25, 2018 11:08 PM To: Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM leaf walking Acked-by: Alex Deu

Re: [PATCH] drm/amdgpu: fix VM leaf walking

Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Thursday, October 25, 2018 10:38 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix VM leaf walking Make sure we don't try to go down further after the leave walk alread

[PATCH] drm/amdgpu: fix VM leaf walking

Make sure we don't try to go down further after the leave walk already ended. This fixes a crash with a new VM test. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_v

[PATCH 21/21] drm/amd/display: Add condition to sync eDP SW status and HW status

From: Lewis Huang [Why] Need to disable EDP backlight when enter S4 with EDP only and resume from S4 with secondary only. [How] Align the real hw and sw state via vBios scratch register in function enable_accelerated_mode when resume from S4. Signed-off-by: Lewis Huang Reviewed-by: Charlene Li

[PATCH 20/21] drm/amd/display: Remove the check to see if pp_display_cfg is changed

From: Fatemeh Darbehani [Why] When going to full-screen mode commit_planes_for_stream tries to decrease dcf_deep_sleep value, but safe_to_lower is false, so we don't send the new value to SMU but dc context gets updated. Later when dc_post_update_surfaces_to_stream tries to lower dcf_ds when safe

[PATCH 19/21] drm/amd/display: remove CRTC_3D_STRUCTURE_V_UPDATE_MODE bit programming.

From: Charlene Liu [Description] This is based on HW programming guide update. Signed-off-by: Charlene Liu Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 16/21] drm/amd/display: fix mirror rotation scaling math

From: Dmytro Laktyushkin Curretly dc will incorrectly calculate viewport when there is rotation or mirror being applied Signed-off-by: Dmytro Laktyushkin Reviewed-by: Su Chung Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 65 +-- 1 file changed,

[PATCH 18/21] drm/amd/display: Expose target backlight level

From: Anthony Koo [Why] DM may want to understand any backlight optimizations applied, so DM needs a way to query from the HW both the real current backlight, which may be value during transition. And also target backlight, which may be after some backlight optimizations applied. [How] Add inter

[PATCH 17/21] drm/amd/display: Guard against null stream_state in set_crc_source

From: Nicholas Kazlauskas [Why] The igt@kms_plane@pixel-format-pipe tests can create a sequence where stream_state is NULL during amdgpu_dm_crtc_set_crc_source which results in a null pointer dereference. [How] Guard against stream_state being NULL before accessing its fields. This doesn't fix

[PATCH 15/21] drm/amd/display: Retiring set_display_requirements in dm_pp_smu.h - part4

From: Fatemeh Darbehani [Why] In DCN we want direct DC to SMU calls, with minimal interference from pplib. The reason for each pp_smu interface mapping to 1 SMU message is so we can have the sequencing of different SMU message in DC and shared across different OS's. This will also simplify debugg

[PATCH 14/21] drm/amd/display: Remove program_csc_matrix

From: Krunoslav Kovac [Why] On DCN1/DCE, There are two functions programming OCSC: program_csc_matrix and program_output_csc. They do the same thing. [How] Consolidate to use only program_output_csc. Signed-off-by: Krunoslav Kovac Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/a

[PATCH 13/21] drm/amd/display: Fix some backlight variable styling

From: Anthony Koo variableNamingsLikeSo aren't to convention. use_this_instead. Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dm_services_types.h | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/dri

[PATCH 11/21] drm/amd/display: Remove some old TODO's

From: Eric Bernstein They are no longer relevant Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 12/21] drm/amd/display: Expand dc to use 16.16 bit backlight

From: Anthony Koo [Why] We want to increase precision for backlight setting. But DC interface takes 8 bit backlight level value only. [How] DMCU already takes 16 bit backlight level. Expand the DC interface to take 16.16 bit value. Max 32 bit backlight value (0x) will represent max backlight

[PATCH 10/21] drm/amd/display: Initial documentation for AMDgpu DC

From: Leo Li [Why] Documentation is helpful for the community to understand our code. This change does some high-level documentation of some DM interfaces with DRM, and the amdgpu base driver. [How] An entry for AMDgpu DC has been added to Documentation/gpu/drivers.rst TOC. amdgpu-dc.rst is crea

[PATCH 09/21] drm/amd/display: Fix potential nullptr error

From: Bhawanpreet Lakha [Why] Fix surface/plane potential nullptr [How] add null check Signed-off-by: Bhawanpreet Lakha Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/

[PATCH 08/21] drm/amd/display: 3.2.04

From: Steven Chiu Signed-off-by: Steven Chiu Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 4750a29..02db008 1

[PATCH 07/21] drm/amd/display: Fix up coverity issues

From: Aric Cyr [Why] Coverity found various high-impact issues that need resolving. [How] Fix some buffer overruns and uninitialized variables. Signed-off-by: Aric Cyr Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 +- drivers/g

[PATCH 06/21] drm/amd/display: remove interlace scaling adjustment

From: Dmytro Laktyushkin We do not need to adjust surface scaling when p2i is enabled and we do not support interlaced timing otherwise Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 9 - 1 file chang

[PATCH 05/21] drm/amd/display: Add missing pipes registers for VGA enable/disable

From: Nevenko Stupar Signed-off-by: Nevenko Stupar Reviewed-by: Aric Cyr Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h b/drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h i

[PATCH 02/21] drm/amd/display: 3.2.03

From: SivapiriyanKumarasamy Signed-off-by: SivapiriyanKumarasamy Reviewed-by: Tony Cheng Reviewed-by: Steven Chiu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/dr

[PATCH 03/21] drm/amd/display: Clip all remaining regamma points after first clipped point

From: SivapiriyanKumarasamy [Why] All values computed in the gamma curve after the first upperbound clipped point will need to be clipped anyways. We can avoid unnecessary computations and potential fixed point overflow by instead clipping these values to 1 automatically. [How] Track if upper-bo

[PATCH 04/21] drm/amd/display: fix dml max voltage state

From: Dmytro Laktyushkin Gabe's formula sometimes uses values from non-existent 'unsupported' state to do validation. This change adds this extra state so validation can work correctly. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/displa

[PATCH 01/21] drm/amd/display: Set gamma not working on MPO planes

From: Krunoslav Kovac [Why] Set gamma not working on certain planes in MPO configuration Root cause is that video format (YUV-420) isn't allowed for IGAM where gamma is applied. Fix is not easy though: 1. allowing will not work because IGAM is before ICSC so RGB gamma would be applied on YUV pixe

[PATCH 00/21] DC Patches Oct 25, 2018

From: Leo Li Summary of change: * Initial documentation of AMDgpu DM * Clean-up output CSC programming code * Some coverity fixes * Fix for possible null derefs in crc configuration and plane update paths Anthony Koo (3): drm/amd/display: Expand dc to use 16.16 bit backlight drm/amd/display:

Re: [PATCH] RFC: Make igts for cross-driver stuff mandatory?

On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: > Hi all, > > This is just to collect feedback on this idea, and see whether the > overall dri-devel community stands on all this. I think the past few > cross-vendor uapi extensions all came with igts attached, and > personally I thin

Re: [PATCH] RFC: Make igts for cross-driver stuff mandatory?

On Thu, Oct 25, 2018 at 11:58 AM Liviu Dudau wrote: > On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: > > Hi all, > > Hi, > > (Replying from my personal address as the work email seems to have let > this one go to /dev/null) > > > > > This is just to collect feedback on this idea, a

Re: [PATCH] RFC: Make igts for cross-driver stuff mandatory?

On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: > Hi all, Hi, (Replying from my personal address as the work email seems to have let this one go to /dev/null) > > This is just to collect feedback on this idea, and see whether the > overall dri-devel community stands on all this.

RE: [PATCH 4/4] drm/amdgpu: use GMC v9 KIQ workaround only for the GFXHUB

Add Wentao. Best wishes Emily Deng >-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Thursday, October 25, 2018 5:15 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH 4/4] drm/amdgpu: use GMC v9 KIQ workaround only for the >GFXHUB > >The MMHUB is not affected

RE: [PATCH 1/4] drm/amdgpu: remove nonsense in_interrupt() checks

Add Wentao. Best wishes Emily Deng >-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Thursday, October 25, 2018 5:15 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH 1/4] drm/amdgpu: remove nonsense in_interrupt() checks > >might_sleep() is supposed to raise

RE: [PATCH 3/4] drm/amdgpu: drop the busy wait for GMC v9 TLB invalidations

Add Wentao. Best wishes Emily Deng >-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Thursday, October 25, 2018 5:15 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH 3/4] drm/amdgpu: drop the busy wait for GMC v9 TLB >invalidations > >This code is not perfor

RE: [PATCH 2/4] drm/amdgpu: cleanup GMC v9 TLB invalidation

Add Wentao. Best wishes Emily Deng >-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Thursday, October 25, 2018 5:15 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH 2/4] drm/amdgpu: cleanup GMC v9 TLB invalidation > >Move the kiq handling into amdgpu_virt.c

[PATCH 3/4] drm/amdgpu: drop the busy wait for GMC v9 TLB invalidations

This code is not performance critical. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 7de

[PATCH 2/4] drm/amdgpu: cleanup GMC v9 TLB invalidation

Move the kiq handling into amdgpu_virt.c and drop the fallback. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 40 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 3 ++ drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 53 -

[PATCH 4/4] drm/amdgpu: use GMC v9 KIQ workaround only for the GFXHUB

The MMHUB is not affected by this. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index ff5e5f69b403..9ea73fb36572 10

[PATCH 1/4] drm/amdgpu: remove nonsense in_interrupt() checks

might_sleep() is supposed to raise if warning if called in interrupt or atomic context. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/

[PATCH 1/5] drm/amdgpu: fix amdgpu_vm_fini

We should not remove mappings in rbtree_postorder_for_each_entry_safe because that rebalances the tree. Signed-off-by: Christian König Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd