RE: [PATCH] drm/amdgpu/sriov: Set the default value about gds vmid0 size

2018-10-11 Thread Deng, Emily
>-Original Message- >From: Zhang, Jerry >Sent: Friday, October 12, 2018 1:18 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu/sriov: Set the default value about gds >vmid0 size > >On 10/12/2018 11:21 AM, Emily Deng wrote: >> For sriov, when first run wind

Re: [PATCH] drm/amdgpu/sriov: Set the default value about gds vmid0 size

2018-10-11 Thread Zhang, Jerry(Junwei)
On 10/12/2018 11:21 AM, Emily Deng wrote: For sriov, when first run windows guest, then run linux guest, the gds vmid0 size will be reset to 0 by windows guest. So if the value has been reset to 0, then set the value to the default value in linux guest. Signed-off-by: Emily Deng --- drivers/g

RE: [PATCH 1/2] drm/amdgpu: fix sdma doorbell comments typo

2018-10-11 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Frank.Min > Sent: Thursday, October 11, 2018 8:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Min, Frank > Subject: [PATCH 1/2] drm/amdgpu: fix sdma doorbell comments typo > > Change-Id: I0

RE: [PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov vf

2018-10-11 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Felix Kuehling > Sent: Friday, October 12, 2018 3:46 AM > To: Koenig, Christian ; Min, Frank > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdgpu: skip vm entries checking w

[PATCH] drm/amdgpu/sriov: Set the default value about gds vmid0 size

2018-10-11 Thread Emily Deng
For sriov, when first run windows guest, then run linux guest, the gds vmid0 size will be reset to 0 by windows guest. So if the value has been reset to 0, then set the value to the default value in linux guest. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 14 +++

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 04:56 PM, Kazlauskas, Nicholas wrote: > On 10/11/2018 04:39 PM, Harry Wentland wrote: >> On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: >>> Support for AMDGPU specific FreeSync properties and ioctls are dropped >>> from amdgpu_dm in favor of supporting drm variable refresh rate

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Kazlauskas, Nicholas
On 10/11/2018 04:39 PM, Harry Wentland wrote: On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The drm vrr_capable property is now attached to any

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The drm vrr_capable property is now attached to any DP/HDMI connector. > Its value is upda

Re: [PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov vf

2018-10-11 Thread Felix Kuehling
On 2018-10-11 08:32 AM, Christian König wrote: > Am 11.10.2018 um 14:09 schrieb Frank.Min: >> vm page table would be allocated while in amdgpu_vm_init >> by amdgpu_allocate_static_csa for sriov, so the checking >> here would be skipped. > > NAK, that checking is actually correct and points out that

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:25 AM, Mike Lothian wrote: > Hi > > I'm curious to know whether this will/could work over PRIME > I don't see why this shouldn't work over PRIME as long as the presenting GPU supports the new variable refresh rate API, but I know very little about prime, so maybe someone else

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:41 AM, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >> >> >> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>> On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: These patches are part of a proposed new interface for s

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 02:35 PM, Manasi Navare wrote: > On Wed, Oct 03, 2018 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >>> >>> >>> On 2018-10-01 03:15 AM, Daniel Vetter wrote: On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauska

[PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Nicholas Kazlauskas
Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The drm vrr_capable property is now attached to any DP/HDMI connector. Its value is updated accordingly to the connector's FreeSync capabiltiy. The fr

[PATCH v4 3/4] drm: Document variable refresh properties

2018-10-11 Thread Nicholas Kazlauskas
These include the drm_connector 'vrr_capable' and the drm_crtc 'vrr_enabled' properties. Signed-off-by: Nicholas Kazlauskas --- Documentation/gpu/drm-kms.rst | 7 +++ drivers/gpu/drm/drm_connector.c | 22 ++ 2 files changed, 29 insertions(+) diff --git a/Documentation

[PATCH v4 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-11 Thread Nicholas Kazlauskas
This patch introduces the 'vrr_enabled' CRTC property to allow dynamic control over variable refresh rate support for a CRTC. This property should be treated like a content hint to the driver - if the hardware or driver is not capable of driving variable refresh timings then this is not considered

[PATCH v4 1/4] drm: Add vrr_capable property to the drm connector

2018-10-11 Thread Nicholas Kazlauskas
Modern display hardware is capable of supporting variable refresh rates. This patch introduces the "vrr_capable" property on the connector to allow userspace to query support for variable refresh rates. Atomic drivers should attach this property to connectors that are capable of driving variable r

[PATCH v4 0/4] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Nicholas Kazlauskas
These patches are part of a proposed new interface for supporting variable refresh rate via DRM properties. === Changes from v3 === drm changes: * Docstring and formatting fixes amd/display changes: * Updated commit message and debug statements === Changes from v2 === The interface has chan

Re: [PATCH 00/18] VCN start/stop clean up

2018-10-11 Thread Alex Deucher
On Wed, Oct 10, 2018 at 3:27 PM James Zhu wrote: > > Clean up current VCN start/stop function, and update with latest > firmware/hardware implemention. > Series is: Acked-by: Alex Deucher > James Zhu (18): > drm/amdgpu/vcn:Add new register offset/mask for VCN > drm/amdgpu/vcn:Update latest

Re: [PATCH 18/18] drm/amdgpu/vcn:Update SPG mode UVD status clear

2018-10-11 Thread Leo Liu
Looks good to me. The whole series are: Acked-by: Leo Liu On 10/10/2018 02:42 PM, James Zhu wrote: Update Static Power Gate mode UVD status clear Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

Re: [PATCH 1/2] drm/amdgpu: fix sdma doorbell comments typo

2018-10-11 Thread Alex Deucher
On Thu, Oct 11, 2018 at 8:10 AM Frank.Min wrote: > > Change-Id: I0a3dff9f01a90717e0c32b7fa81a5e891bd1d52d > Signed-off-by: Frank.Min This patch is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov vf

2018-10-11 Thread Christian König
Am 11.10.2018 um 14:09 schrieb Frank.Min: vm page table would be allocated while in amdgpu_vm_init by amdgpu_allocate_static_csa for sriov, so the checking here would be skipped. NAK, that checking is actually correct and points out that this doesn't work correctly. Fix the function to be ab

[PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov vf

2018-10-11 Thread Frank . Min
vm page table would be allocated while in amdgpu_vm_init by amdgpu_allocate_static_csa for sriov, so the checking here would be skipped. Change-Id: Id30b86ad15ae509aeed9ed8ab60c259c88af3df5 Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 + 1 file changed, 5 inser

[PATCH 1/2] drm/amdgpu: fix sdma doorbell comments typo

2018-10-11 Thread Frank . Min
Change-Id: I0a3dff9f01a90717e0c32b7fa81a5e891bd1d52d Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index c21d9b9..6317f35 100644 --- a/

[PATCH 1/2] drm/amdgpu: fix sdma doorbell comments typo

2018-10-11 Thread Frank . Min
Change-Id: I0a3dff9f01a90717e0c32b7fa81a5e891bd1d52d Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index c21d9b9..6317f35 100644 --- a/