Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence

2018-08-15 Thread Christian König
Am 15.08.2018 um 20:49 schrieb Felix Kuehling: On 2018-08-15 02:27 PM, Christian König wrote: Am 15.08.2018 um 20:17 schrieb Felix Kuehling: On 2018-08-15 03:02 AM, Christian König wrote: Hi Felix, yeah, you pretty much nailed it. The problem is that the array itself is RCU protected. This m

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Zhu, Rex
> -Original Message- > From: Zhu, Rex > Sent: Thursday, August 16, 2018 1:41 PM > To: 'Alex Deucher' > Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org> > Subject: RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalidate tlb > > > > > -Original Mes

Re: [PATCH] drm/amd/display: Fix bug use wrong pp interface

2018-08-15 Thread Huang Rui
On Thu, Aug 16, 2018 at 03:54:19AM +, Deucher, Alexander wrote: > Acked-by: Alex Deucher > > > From: amd-gfx on behalf of Rex Zhu > > Sent: Wednesday, August 15, 2018 11:42:39 PM > To: amd-gfx@lists.freedesktop.org; Francis, David > Cc: Zhu, Rex > Subject:

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Zhu, Rex
> -Original Message- > From: Alex Deucher > Sent: Wednesday, August 15, 2018 10:14 PM > To: Zhu, Rex > Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalidate tlb > > On Wed, Aug 15, 2018 at

Re: [PATCH] drm/amdgpu: fix VM size reporting on Raven

2018-08-15 Thread Huang Rui
On Wed, Aug 15, 2018 at 02:05:54PM +0200, Christian König wrote: > Raven doesn't have an VCE block and so also no buggy VCE firmware. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

Re: [PATCH] drm/amd/display: Fix bug use wrong pp interface

2018-08-15 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, August 15, 2018 11:42:39 PM To: amd-gfx@lists.freedesktop.org; Francis, David Cc: Zhu, Rex Subject: [PATCH] drm/amd/display: Fix bug use wrong pp interface Used wrong pp interface, the

[PATCH] drm/amd/display: Fix bug use wrong pp interface

2018-08-15 Thread Rex Zhu
Used wrong pp interface, the original interface is exposed by dpm on SI and paritial CI. Pointed out by Francis David Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: fix VM size reporting on Raven

2018-08-15 Thread zhoucm1
On 2018年08月15日 20:05, Christian König wrote: Raven doesn't have an VCE block and so also no buggy VCE firmware. Signed-off-by: Christian König Acked-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

Re: [PATCH 2/2] drm/amdgpu: rework ctx entity creation

2018-08-15 Thread zhoucm1
On 2018年08月15日 18:59, Christian König wrote: Use a fixed number of entities for each hardware IP. The number of compute entities is reduced to four, SDMA keeps it two entities and all other engines just expose one entity. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 1/2] drm/amdgpu: cleanup HW_IP query

2018-08-15 Thread zhoucm1
On 2018年08月15日 18:59, Christian König wrote: Move the code into a separate function. Signed-off-by: Christian König Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 204 +--- 1 file changed, 110 insertions(+), 94 deletions(-) diff --

Re: [PATCH libdrm] amdgpu: fix off by one in handle_table_insert

2018-08-15 Thread Zhang, Jerry (Junwei)
On 08/15/2018 07:25 PM, Christian König wrote: Stupid me, max_key must always be larger than key. Signed-off-by: Christian König Good catch Reviewed-by: Junwei Zhang --- amdgpu/handle_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/handle_table.c b/amd

Re: [PATCH v3 0/5] drm/ttm,amdgpu: Introduce LRU bulk move functionality

2018-08-15 Thread Dieter Nützel
For the series Tested-by: Dieter Nützel on RX580, amd-staging-drm-next #5024f8dfe478 Dieter Am 13.08.2018 11:58, schrieb Huang Rui: The idea and proposal is originally from Christian, and I continue to work to deliver it. Background: amdgpu driver will move all PD/PT and PerVM BOs into idl

Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence

2018-08-15 Thread Felix Kuehling
On 2018-08-15 02:27 PM, Christian König wrote: > Am 15.08.2018 um 20:17 schrieb Felix Kuehling: >> On 2018-08-15 03:02 AM, Christian König wrote: >>> Hi Felix, >>> >>> yeah, you pretty much nailed it. >>> >>> The problem is that the array itself is RCU protected. This means that >>> you can only c

Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence

2018-08-15 Thread Christian König
Am 15.08.2018 um 20:17 schrieb Felix Kuehling: On 2018-08-15 03:02 AM, Christian König wrote: Hi Felix, yeah, you pretty much nailed it. The problem is that the array itself is RCU protected. This means that you can only copy the whole structure when you want to update it. The exception is re

Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence

2018-08-15 Thread Felix Kuehling
On 2018-08-15 03:02 AM, Christian König wrote: > Hi Felix, > > yeah, you pretty much nailed it. > > The problem is that the array itself is RCU protected. This means that > you can only copy the whole structure when you want to update it. > > The exception is reservation_object_add_shared() which o

Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence v2

2018-08-15 Thread Felix Kuehling
I applied your change to my local KFD staging branch and it through a presubmission build/test (sorry, only accessible from inside AMD): http://git.amd.com:8080/#/c/167906/ It passed, but checkpatch pointed out one issue: http://git.amd.com:8080/#/c/167906/1/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkf

allmodconfig/allyesconfig doesn't work with Kernel 4.18 - Was: Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled

2018-08-15 Thread Mauro Carvalho Chehab
Em Sat, 11 Aug 2018 17:54:12 +0200 Arnd Bergmann escreveu: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > > drivers/gpu/drm/amd/dis

Re: [PATCH] drm/amdgpu: fix VM size reporting on Raven

2018-08-15 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Wednesday, August 15, 2018 8:05:54 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix VM size reporting on Raven Raven doesn't have an VCE block and so also no buggy

Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Alex Deucher
On Wed, Aug 15, 2018 at 9:56 AM Zhu, Rex wrote: > > > > > -Original Message- > > From: amd-gfx On Behalf Of Emily > > Deng > > Sent: Wednesday, August 15, 2018 5:48 PM > > To: amd-gfx@lists.freedesktop.org > > Cc: Deng, Emily > > Subject: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime,

Re: [PATCH libdrm] amdgpu: fix off by one in handle_table_insert

2018-08-15 Thread Michel Dänzer
On 2018-08-15 01:25 PM, Christian König wrote: > Stupid me, max_key must always be larger than key. > > Signed-off-by: Christian König > --- > amdgpu/handle_table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/amdgpu/handle_table.c b/amdgpu/handle_table.c > index 15c

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Zhu, Rex
> -Original Message- > From: amd-gfx On Behalf Of Emily > Deng > Sent: Wednesday, August 15, 2018 5:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalidate tlb > > To avoid the tlb flush not inte

Re: [PATCH] drm/amdgpu: add status checking after fw is loaded

2018-08-15 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Huang Rui Sent: Wednesday, August 15, 2018 1:21:42 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: add status checking after fw is loaded The status field must be 0 after FW is

Re: Making a GDS Allocation for NGG

2018-08-15 Thread Jakub Okoński
Hey Jian-Rong, Will gfx9 get support from KMD and LLPC by the time gfx10 releases, or is it only going to be a gfx10-and-forward feature? If not, is there something missing in gfx9 hardware? Are you allowed to say? Thanks, Jakub On Wed, 15 Aug 2018 at 08:36 Jin, Jian-Rong wrote: > Hi Jakub。 >

Re: Making a GDS Allocation for NGG

2018-08-15 Thread Jin, Jian-Rong
GFX9 will not be supported. Thanks, Jian-Rong Jin 在 2018年8月15日,下午8:33,Jakub Okoński mailto:ja...@okonski.org>> 写道: Hey Jian-Rong, Will gfx9 get support from KMD and LLPC by the time gfx10 releases, or is it only going to be a gfx10-and-forward feature? If not, is there something missing in g

Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Christian König
Am 15.08.2018 um 14:54 schrieb Emily Deng: To avoid the tlb flush not interrupted by world switch, use kiq and one command to do tlb invalidate. v2: Add firmware version checking. v3: Refine the code, and move the firmware checking into gfx_v9_0_ring_emit_reg_write_reg_wait. v4: Change the nam

[PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Emily Deng
To avoid the tlb flush not interrupted by world switch, use kiq and one command to do tlb invalidate. v2: Add firmware version checking. v3: Refine the code, and move the firmware checking into gfx_v9_0_ring_emit_reg_write_reg_wait. v4: Change the name amdgpu_kiq_invalidate_tlb to amdgpu_kiq_reg

[PATCH 2/2] drm/amdgpu: For bare metal, use kiq to do invalidate tlb

2018-08-15 Thread Emily Deng
Remove the amdgpu_sriov_vf checking. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH] drm/amdgpu: fix VM size reporting on Raven

2018-08-15 Thread Christian König
Raven doesn't have an VCE block and so also no buggy VCE firmware. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c i

[PATCH libdrm] amdgpu: fix off by one in handle_table_insert

2018-08-15 Thread Christian König
Stupid me, max_key must always be larger than key. Signed-off-by: Christian König --- amdgpu/handle_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/handle_table.c b/amdgpu/handle_table.c index 15cd4763..4fdd29d3 100644 --- a/amdgpu/handle_table.c +++ b/amdgpu/h

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Deng, Emily
>-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Wednesday, August 15, 2018 7:14 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do >invalidate tlb > >Am 15.08.2018 um 13:08 schrieb Deng, E

Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Christian König
Am 15.08.2018 um 13:08 schrieb Deng, Emily: -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, August 15, 2018 6:50 PM To: Deng, Emily ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb A

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Deng, Emily
>-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Wednesday, August 15, 2018 6:50 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do >invalidate tlb > >Am 15.08.2018 um 11:48 schrieb Emily D

[PATCH 2/2] drm/amdgpu: rework ctx entity creation

2018-08-15 Thread Christian König
Use a fixed number of entities for each hardware IP. The number of compute entities is reduced to four, SDMA keeps it two entities and all other engines just expose one entity. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 291 dri

[PATCH 1/2] drm/amdgpu: cleanup HW_IP query

2018-08-15 Thread Christian König
Move the code into a separate function. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 204 +--- 1 file changed, 110 insertions(+), 94 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Christian König
Am 15.08.2018 um 11:48 schrieb Emily Deng: To avoid the tlb flush not interrupted by world switch, use kiq and one command to do tlb invalidate. v2: Add firmware version checking. v3: Refine the code, and move the firmware checking into gfx_v9_0_ring_emit_reg_write_reg_wait. SWDEV-161497 Sign

Re: [PATCH v2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Zhu, Rex
Remove the sriov check, The patch can work on both vega10 and Raven under bare metal with tip firmware. Best Regards Rex From: amd-gfx on behalf of Christian König Sent: Wednesday, August 15, 2018 3:07 PM To: Deng, Emily; amd-gfx@lists.freedesktop.org Sub

[PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Emily Deng
To avoid the tlb flush not interrupted by world switch, use kiq and one command to do tlb invalidate. v2: Add firmware version checking. v3: Refine the code, and move the firmware checking into gfx_v9_0_ring_emit_reg_write_reg_wait. SWDEV-161497 Signed-off-by: Emily Deng --- drivers/gpu/drm/a

[PATCH 2/2] drm/amdgpu: For bare metal, use kiq to do invalidate tlb

2018-08-15 Thread Emily Deng
Remove the amdgpu_sriov_vf checking. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/

RE: [PATCH] drm/amdgpu: MC_VM_FB_OFFSET is pf only register.

2018-08-15 Thread Deng, Emily
Sorry, sent the wrong patch, please ignore this email. >-Original Message- >From: Emily Deng >Sent: Wednesday, August 15, 2018 5:48 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deng, Emily >Subject: [PATCH] drm/amdgpu: MC_VM_FB_OFFSET is pf only register. > >Signed-off-by: Emily Deng >---

[PATCH] drm/amdgpu: MC_VM_FB_OFFSET is pf only register.

2018-08-15 Thread Emily Deng
Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index b60ed28..52b13e6 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +++

[PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Emily Deng
To avoid the tlb flush not interrupted by world switch, use kiq and one command to do tlb invalidate. v2: Add firmware version checking. v3: Refine the code, and move the firmware checking into gfx_v9_0_ring_emit_reg_write_reg_wait. SWDEV-161497 Signed-off-by: Emily Deng --- drivers/gpu/drm/a

RE: [PATCH v2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Deng, Emily
>-Original Message- >From: Koenig, Christian >Sent: Wednesday, August 15, 2018 3:08 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH v2] drm/amdgpu/sriov: For sriov runtime, use kiq to do >invalidate tlb > >> As need to let somebody to test all your bare metal test c

[PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence v2

2018-08-15 Thread Christian König
Fix quite a number of bugs here. Unfortunately only compile tested. v2: fix copy&paste error Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 103 ++- 1 file changed, 46 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

Re: [PATCH] drm/ttm: remove dead codes

2018-08-15 Thread Christian König
Am 15.08.2018 um 09:41 schrieb Huang Rui: These codes are not used. Signed-off-by: Huang Rui Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c| 5 + drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 8 +--- 2 files changed, 2 insertions(+), 11 deletions(-) di

[PATCH] drm/ttm: remove dead codes

2018-08-15 Thread Huang Rui
These codes are not used. Signed-off-by: Huang Rui --- drivers/gpu/drm/ttm/ttm_bo_util.c| 5 + drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 8 +--- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c

Re: [PATCH v2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

2018-08-15 Thread Christian König
As need to let somebody to test all your bare metal test cases, such as vega10, and other asics, as I don't have those environments, and only could test sriov. That is not much of a problem. We have plenty of people on the mailing list (including me) who can test this on both Vega10 and Raven.

Re: [PATCH] drm/amdgpu: fix amdgpu_amdkfd_remove_eviction_fence

2018-08-15 Thread Christian König
Hi Felix, yeah, you pretty much nailed it. The problem is that the array itself is RCU protected. This means that you can only copy the whole structure when you want to update it. The exception is reservation_object_add_shared() which only works because we replace an either signaled fence or