Re: [PATCH] drm/amdgpu: replace mutex with spin_lock (V2)

2018-06-21 Thread S, Shirish
On 6/22/2018 9:19 AM, S, Shirish wrote: On 6/22/2018 9:00 AM, Dave Airlie wrote: On 31 May 2018 at 20:02, Shirish S wrote: mutex's lead to sleeps which should be avoided in atomic context. Hence this patch replaces it with the spin_locks. Below is the stack trace: I'm not sure I really l

Re: [PATCH] drm/amdgpu: replace mutex with spin_lock (V2)

2018-06-21 Thread S, Shirish
On 6/22/2018 9:00 AM, Dave Airlie wrote: On 31 May 2018 at 20:02, Shirish S wrote: mutex's lead to sleeps which should be avoided in atomic context. Hence this patch replaces it with the spin_locks. Below is the stack trace: I'm not sure I really like this series of patches, going around re

Re: [PATCH] drm/amdgpu: replace mutex with spin_lock (V2)

2018-06-21 Thread Dave Airlie
On 31 May 2018 at 20:02, Shirish S wrote: > mutex's lead to sleeps which should be avoided in > atomic context. > Hence this patch replaces it with the spin_locks. > > Below is the stack trace: I'm not sure I really like this series of patches, going around replacing ATOMIC and mutex with spinloc

RE: [PATCH v2 1/2] drm/scheduler: Rename cleanup functions v2.

2018-06-21 Thread Zhou, David(ChunMing)
Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Andrey Grodzovsky Sent: Thursday, June 21, 2018 11:33 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: e...@anholt.net; Koenig, Christian ; Grodzo

Re: [PATCH] drm/amdgpu: band aid validating VM PTs

2018-06-21 Thread Zhang, Jerry (Junwei)
On 06/19/2018 08:57 PM, Christian König wrote: Always validating the VM PTs takes to much time. Only always validate the per VM BOs for now. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-21 Thread Lyude Paul
This fixes a regression I accidentally reduced that was picked up by kasan, where we were checking the CRTC atomic states after DRM's helpers had already freed them. Example: == BUG: KASAN: use-after-free in amdgpu_dm_atomic_commit_ta

[PATCH v2] drm/amd/display: Enable Stereo in Dal3

2018-06-21 Thread Harry Wentland
From: Alvin lee - program infoframe for Stereo - program stereo flip control registers properly v2: Add missing license headers Signed-off-by: Alvin lee Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/Makefile | 3 +- .../gpu/drm/amd/display/dc/cor

[pull] amdgpu, sched, ttm drm-next-4.19

2018-06-21 Thread Alex Deucher
Hi Dave, First feature request for 4.19. Highlights: - Add initial amdgpu documentation - Add initial GPU scheduler documention - GPU scheduler fixes for dying processes - Add support for the JPEG engine on VCN - Switch CI to use powerplay by default - EDC support for CZ - More powerplay cleanups

[PATCH 0/1] amdgpu, sched, ttm drm-next-4.19

2018-06-21 Thread Alex Deucher
Hi Dave, First feature request for 4.19. Highlights: - Add initial amdgpu documentation - Add initial GPU scheduler documention - GPU scheduler fixes for dying processes - Add support for the JPEG engine on VCN - Switch CI to use powerplay by default - EDC support for CZ - More powerplay cleanups

Re: [PATCH v2 1/2] drm/scheduler: Rename cleanup functions v2.

2018-06-21 Thread Christian König
Am 21.06.2018 um 17:33 schrieb Andrey Grodzovsky: Everything in the flush code path (i.e. waiting for SW queue to become empty) names with *_flush() and everything in the release code path names *_fini() This patch also effect the amdgpu and etnaviv drivers which use those functions. v2: Also a

[PATCH v2 2/2] drm/amdgpu: Rename entity cleanup finctions.

2018-06-21 Thread Andrey Grodzovsky
Everything in the flush code path (i.e. waiting for SW queue to become empty) names with *_flush() and everything in the release code path names *_fini() Signed-off-by: Andrey Grodzovsky Suggested-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu

[PATCH v2 1/2] drm/scheduler: Rename cleanup functions v2.

2018-06-21 Thread Andrey Grodzovsky
Everything in the flush code path (i.e. waiting for SW queue to become empty) names with *_flush() and everything in the release code path names *_fini() This patch also effect the amdgpu and etnaviv drivers which use those functions. v2: Also apply the change to vd3. Signed-off-by: Andrey Grodz

Re: [PATCH] drm/amdgpu: band aid validating VM PTs

2018-06-21 Thread Christian König
Am 21.06.2018 um 15:15 schrieb Huang Rui: On Wed, Jun 20, 2018 at 10:45:44PM +0800, Christian König wrote: Am 20.06.2018 um 13:25 schrieb Huang Rui: On Tue, Jun 19, 2018 at 02:57:00PM +0200, Christian König wrote: Always validating the VM PTs takes to much time. Only always validate the per VM

Re: [PATCH] drm/amdgpu: band aid validating VM PTs

2018-06-21 Thread Huang Rui
On Wed, Jun 20, 2018 at 10:45:44PM +0800, Christian König wrote: > Am 20.06.2018 um 13:25 schrieb Huang Rui: > > On Tue, Jun 19, 2018 at 02:57:00PM +0200, Christian König wrote: > >> Always validating the VM PTs takes to much time. Only always validate > >> the per VM BOs for now. > > Christian, yo

Re: [PATCH 2/5] dma-buf: remove kmap_atomic interface

2018-06-21 Thread Christian König
Am 21.06.2018 um 08:30 schrieb Daniel Vetter: On Thu, Jun 21, 2018 at 8:26 AM, Daniel Vetter wrote: On Wed, Jun 20, 2018 at 4:21 PM, Christian König wrote: Am 20.06.2018 um 16:04 schrieb Christian König: Am 20.06.2018 um 14:52 schrieb Daniel Vetter: On Wed, Jun 20, 2018 at 2:46 PM, Christia

Re: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs (v2)

2018-06-21 Thread Christian König
Am 20.06.2018 um 18:48 schrieb Tom St Denis: This adds what should be a stable interface to read GPU load from userspace. (v2): Fix comments and name of file per recommendations. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 47 ++