[PATCH] drm/amdgpu: fix the missed vcn fw version report

2018-05-22 Thread Huang Rui
It missed vcn.fw_version setting when init vcn microcode, and it will be used to report vcn ucode version via amdgpu_firmware_info sysfs interface. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH] drm/amdgpu: add checking for sos version

2018-05-22 Thread Zhang, Jerry (Junwei)
On 05/23/2018 01:45 PM, Huang Rui wrote: Signed-off-by: Huang Rui Acked-by: Alex Deucher Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1

[PATCH] drm/amdgpu: add checking for sos version

2018-05-22 Thread Huang Rui
Signed-off-by: Huang Rui Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c index 196e75d..efe5c1f 100644 -

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

2018-05-22 Thread Deng, Emily
Ping .. > -Original Message- > From: Emily Deng [mailto:emily.d...@amd.com] > Sent: Monday, May 21, 2018 4:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > To free the fence from the amdgpu_fence_slab, ne

drm/amdgpu: Use GTT for dumb buffer if sg display enabled (v2)

2018-05-22 Thread Deepak Sharma
When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram size <= 256M scan out will not be an issue. v2: Use amdgpu_display_supported_domains to get supported domain. Signed-off-by: Deepak Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 10

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Deepak Sharma
On 05/22/2018 05:12 AM, Christian König wrote: [SNIP] If the BO is moved from VRAM to VRAM (to make it linear) or from VRAM to GTT for scanout doesn't really matter. Not sure what you mean. Dumb BOs are only used for CPU access and scanout, and should be created accordingly. Well what I wan

Re: [PATCH] drm/amdgpu: consider user preference when pinning for SG display

2018-05-22 Thread Michel Dänzer
On 2018-05-18 09:12 PM, Alex Deucher wrote: > On Fri, May 18, 2018 at 4:21 AM, Michel Dänzer wrote: >> On 2018-05-17 06:55 PM, Alex Deucher wrote: >>> If the pin domain is set to GTT | VRAM, look at the preferred domains >>> for the bo and respect that if it's been set explicitly. >>> >>> Signed-o

Re: [PATCH 1/6] drm/amdgpu: rework VM state machine lock handling v2

2018-05-22 Thread Christian König
Patch 1: could you show the reserving VM? The idea is that only the moved state is accessed without the VM being reserved. Because of this we can remove the locks when we a) are sure that the BO isn't in the moved state and b) don't want to move it into the moved state. on 2nd thought, perh

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Christian König
[SNIP] If the BO is moved from VRAM to VRAM (to make it linear) or from VRAM to GTT for scanout doesn't really matter. Not sure what you mean. Dumb BOs are only used for CPU access and scanout, and should be created accordingly. Well what I wanted to say is that it isn't worse than before. On

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Michel Dänzer
On 2018-05-22 12:22 PM, Christian König wrote: > Am 22.05.2018 um 12:14 schrieb Michel Dänzer: >> On 2018-05-22 12:11 PM, Christian König wrote: >>> Am 22.05.2018 um 09:09 schrieb Michel Dänzer: On 2018-05-22 01:22 AM, Deepak Sharma wrote: > When vram size <= THRESHOLD(256M) lets use GTT f

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Christian König
Am 22.05.2018 um 12:14 schrieb Michel Dänzer: On 2018-05-22 12:11 PM, Christian König wrote: Am 22.05.2018 um 09:09 schrieb Michel Dänzer: On 2018-05-22 01:22 AM, Deepak Sharma wrote: When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram siz

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Michel Dänzer
On 2018-05-22 12:11 PM, Christian König wrote: > Am 22.05.2018 um 09:09 schrieb Michel Dänzer: >> On 2018-05-22 01:22 AM, Deepak Sharma wrote: >>> When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer >>> allocation. As SG will be enabled with vram size <= 256M >>> scan out will not be an

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Christian König
Am 22.05.2018 um 09:09 schrieb Michel Dänzer: On 2018-05-22 01:22 AM, Deepak Sharma wrote: When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram size <= 256M scan out will not be an issue. Signed-off-by: Deepak Sharma --- drivers/gpu/drm/a

Re: [PATCH] drm/amdgpu: consider user preference when pinning for SG display

2018-05-22 Thread Christian König
[SNIP] It's not that low resolution these days (normally the smallest native resolution of all connected displays, i.e. generally >= 1920x1080), i.e. on the order of ~10 MB of VRAM that can't be used for anything else. Hui, what? Isn't the fb freed after X takes over? Nope, that isn't possible

Re: [PATCH] drm/amdgpu: consider user preference when pinning for SG display

2018-05-22 Thread Michel Dänzer
On 2018-05-22 11:11 AM, Christian König wrote: > Am 22.05.2018 um 09:22 schrieb Michel Dänzer: >> On 2018-05-19 05:59 PM, Christian König wrote: >>> Am 18.05.2018 um 21:16 schrieb Alex Deucher: On Fri, May 18, 2018 at 2:22 PM, Samuel Li wrote: > On 2018-05-18 04:21 AM, Michel Dänzer wrote

Re: [PATCH] drm/amdgpu: consider user preference when pinning for SG display

2018-05-22 Thread Christian König
Am 22.05.2018 um 09:22 schrieb Michel Dänzer: On 2018-05-19 05:59 PM, Christian König wrote: Am 18.05.2018 um 21:16 schrieb Alex Deucher: On Fri, May 18, 2018 at 2:22 PM, Samuel Li wrote: On 2018-05-18 04:21 AM, Michel Dänzer wrote: On 2018-05-17 06:55 PM, Alex Deucher wrote: If the pin dom

Re: [PATCH] drm/amdgpu: consider user preference when pinning for SG display

2018-05-22 Thread Michel Dänzer
On 2018-05-19 05:59 PM, Christian König wrote: > Am 18.05.2018 um 21:16 schrieb Alex Deucher: >> On Fri, May 18, 2018 at 2:22 PM, Samuel Li wrote: >>> >>> On 2018-05-18 04:21 AM, Michel Dänzer wrote: On 2018-05-17 06:55 PM, Alex Deucher wrote: > If the pin domain is set to GTT | VRAM, loo

Re: [PATCH] drm/amdgpu/pp: remove duplicate assignment

2018-05-22 Thread Michel Dänzer
On 2018-05-21 05:17 PM, Alex Deucher wrote: > is_dpm_running callback was assigned to the same value > twice. Drop the duplicate. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Michel Dänzer
On 2018-05-22 01:22 AM, Deepak Sharma wrote: > When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer > allocation. As SG will be enabled with vram size <= 256M > scan out will not be an issue. > > Signed-off-by: Deepak Sharma > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +-- >