Re: [PATCH v2 xf86-video-amdgpu] Don't bail from drmmode_set_desired_modes immediately

2018-02-15 Thread Harry Wentland
On 2018-02-15 12:49 PM, Michel Dänzer wrote: > From: Michel Dänzer > > If we fail to find or set the mode for a CRTC, keep trying for the > remaining CRTCs, and only return FALSE if we failed for all CRTCs that > should be on. > > Signed-off-by: Michel Dänzer Thanks. This should help when band

[pull] amdgpu drm-next-4.16

2018-02-15 Thread Alex Deucher
Hi Dave, Just one fix for a hybrid laptop for 4.16. The following changes since commit 94fc27ac487a80daf42f97b1a0503d029f3c1325: Merge tag 'drm-intel-next-fixes-2018-02-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2018-02-08 08:21:37 +1000) are available in the git repo

Re: [PATCH v2 xf86-video-amdgpu] Don't bail from drmmode_set_desired_modes immediately

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 12:49 PM, Michel Dänzer wrote: > From: Michel Dänzer > > If we fail to find or set the mode for a CRTC, keep trying for the > remaining CRTCs, and only return FALSE if we failed for all CRTCs that > should be on. > > Signed-off-by: Michel Dänzer Reviewed-by: Alex Deucher

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 9:19 AM, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex internals by p

Re: [PATCH 1/2] drm/amdgpu: separate PASID mapping from VM flush

2018-02-15 Thread Christian König
Am 15.02.2018 um 20:16 schrieb Felix Kuehling: On 2018-02-15 09:24 AM, Christian König wrote: Stuffing the PASID mapping into the VM flush isn't flexible enough since the PASID mapping changes not as often as we need a VM flush. Signed-off-by: Christian König One comment inline. Other than th

Re: [PATCH 1/2] drm/amdgpu: separate PASID mapping from VM flush

2018-02-15 Thread Felix Kuehling
On 2018-02-15 09:24 AM, Christian König wrote: > Stuffing the PASID mapping into the VM flush isn't flexible enough since > the PASID mapping changes not as often as we need a VM flush. > > Signed-off-by: Christian König One comment inline. Other than that this is Reviewed-by: Felix Kuehling [sn

Re: [PATCH 2/2] drm/amdgpu: update the PASID mapping only on demand

2018-02-15 Thread Felix Kuehling
On 2018-02-15 09:24 AM, Christian König wrote: > Updating the PASID is rather heavyweight and shouldn't be done all the > time. > > Signed-off-by: Christian König Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 3 +

[PATCH v2 xf86-video-amdgpu] Don't bail from drmmode_set_desired_modes immediately

2018-02-15 Thread Michel Dänzer
From: Michel Dänzer If we fail to find or set the mode for a CRTC, keep trying for the remaining CRTCs, and only return FALSE if we failed for all CRTCs that should be on. Signed-off-by: Michel Dänzer --- v2: Print warning messages for trouble with a particular CRTC, and an error message only

[PATCH xf86-video-amdgpu] Don't bail from drmmode_set_desired_modes immediately

2018-02-15 Thread Michel Dänzer
From: Michel Dänzer If we fail to find or set the mode for a CRTC, keep trying for the remaining CRTCs, and only return FALSE if we failed for all CRTCs that should be on. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 31 +-- 1 file changed, 21 insertions

Re: [PATCH xf86-video-ati 2/2] Simplify depth 30 "kernel too old" error message

2018-02-15 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, February 15, 2018 11:50:24 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati 2/2] Simplify depth 30 "kernel too old" error message From: Michel Dä

[PATCH xf86-video-ati 2/2] Simplify depth 30 "kernel too old" error message

2018-02-15 Thread Michel Dänzer
From: Michel Dänzer We know it's depth 30, need to have xf86DrvMsg fill it in. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index b268f7ea7..85390e306 100644 --- a/src/radeon_kms.c ++

[PATCH xf86-video-ati 1/2] If glamor is too old for depth 30, fall back to EXA or ShadowFB

2018-02-15 Thread Michel Dänzer
From: Michel Dänzer Instead of not starting up at all. Corresponding to amdgpu commit 37c7260bdef3a53b0f0295a531f33938e9aad8cf. Signed-off-by: Michel Dänzer --- src/radeon_glamor.c | 8 src/radeon_kms.c| 9 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/

Re: [PATCH] drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm

2018-02-15 Thread Gustavo A. R. Silva
On 02/15/2018 06:32 AM, Christian König wrote: Am 15.02.2018 um 06:20 schrieb Gustavo A. R. Silva: Currently, if amdgpu_vm_bo_update() fails, the returned error is being ignored. Fix this by properly checking _r_ after calling amdgpu_vm_bo_update. Also, remove redundant code just before label

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-02-15 Thread Gustavo A. R. Silva
Hi Oded, On 02/15/2018 04:08 AM, Oded Gabbay wrote: Hi Gustavo, The patch is queued for the merge window of kernel 4.17 (opens in about 7 weeks from now). Awesome. Thanks for the info. -- Gustavo Oded On Wed, Feb 14, 2018 at 11:30 PM, Gustavo A. R. Silva wrote: Hi all, I was just wonde

[PATCH 2/2] drm/amdgpu: update the PASID mapping only on demand

2018-02-15 Thread Christian König
Updating the PASID is rather heavyweight and shouldn't be done all the time. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 37 + 3 file

[PATCH 1/2] drm/amdgpu: separate PASID mapping from VM flush

2018-02-15 Thread Christian König
Stuffing the PASID mapping into the VM flush isn't flexible enough since the PASID mapping changes not as often as we need a VM flush. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 - drivers/gpu/drm/amd/

[PATCH 3/3] drm/ttm: keep BOs reserved until end of eviction

2018-02-15 Thread Christian König
This avoids problems when BOs are evicted but directly moved back into the domain from other threads. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 37 + 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm

[PATCH 2/3] drm/ttm: handle already locked BOs during eviction and swapout.

2018-02-15 Thread Christian König
This solves the problem that when we swapout a BO from a domain we sometimes couldn't make room for it because holding the lock blocks all other BOs with this reservation object. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 33 - 1 file change

[PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-15 Thread Christian König
amdgpu needs to verify if userspace sends us valid addresses and the simplest way of doing this is to check if the buffer object is locked with the ticket of the current submission. Clean up the access to the ww_mutex internals by providing a function for this and extend the check to the thread ow

[PATCH] Revert "drm/radeon/pm: autoswitch power state when in balanced mode"

2018-02-15 Thread Alex Deucher
This reverts commit 1c331f75aa6ccbf64ebcc5a019183e617c9d818a. Breaks resume on some systems. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=100759 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/radeon_pm.c | 6 +- 1 file changed, 1 insertion(+), 5 delet

Re: [PATCH] drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm

2018-02-15 Thread Christian König
Am 15.02.2018 um 06:20 schrieb Gustavo A. R. Silva: Currently, if amdgpu_vm_bo_update() fails, the returned error is being ignored. Fix this by properly checking _r_ after calling amdgpu_vm_bo_update. Also, remove redundant code just before label _error_. Addresses-Coverity-ID: 1464280 ("Unused

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-02-15 Thread Oded Gabbay
Hi Gustavo, The patch is queued for the merge window of kernel 4.17 (opens in about 7 weeks from now). Oded On Wed, Feb 14, 2018 at 11:30 PM, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. > > Thanks > -- > Gustavo > > > On 01/19/2018 04:18 PM, Feli

[PATCH] drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm

2018-02-15 Thread Gustavo A. R. Silva
Currently, if amdgpu_vm_bo_update() fails, the returned error is being ignored. Fix this by properly checking _r_ after calling amdgpu_vm_bo_update. Also, remove redundant code just before label _error_. Addresses-Coverity-ID: 1464280 ("Unused value") Fixes: 0abc6878fc2d ("drm/amdgpu: update VM P