RE: [PATCH 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-15 Thread He, Roger
-Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, January 13, 2018 6:29 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; He, Roger ; Grodzovsky, Andrey Subject: [PATCH 2/2] drm/amdgpu: Use new TTM f

RE: [PATCH 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-15 Thread He, Roger
-Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, January 13, 2018 6:29 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; He, Roger ; Grodzovsky, Andrey Subject: [PATCH 1/2] drm/ttm: Allow page allo

[PATCH libdrm] drm: fix return value

2018-01-15 Thread Chunming Zhou
otherwise -ETIME is missed. Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 Signed-off-by: Chunming Zhou --- xf86drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86drm.c b/xf86drm.c index 8a327170..3881bd9f 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4241,7 +4241,7

Re: [PATCH 1/3] drm/amdgpu: remove agp_base

2018-01-15 Thread Samuel Li
The series Reviewed-by: Samuel Li Sam On 2018-01-15 06:51 AM, Christian König wrote: > No AGP support for in this driver. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgp

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-15 Thread Andrey Grodzovsky
Thanks Harry, P.S Just spotted following memory leak in DAL when loading/unloading Xorg - maybe something you also wanna take a look . unreferenced object 0x880059fc (size 24640):   comm "Xorg", pid 1395, jiffies 4295164722 (age 6699.912s)   hex dump (first 32 bytes):     01 00 00 00 0

Re: [PATCH] drm/amdgpu: only allow scatter/gather display with DC

2018-01-15 Thread Harry Wentland
On 2018-01-12 02:58 PM, Alex Deucher wrote: > Check if DC is enabled before allowing scanout buffers > to be pinned in system memory. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 - > 1 file changed, 4 insertion

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-15 Thread Harry Wentland
Hey Andrey, been sick for the last few days which is why I wasn't able to follow up on that other email thread. I'm still working from home today so won't be able to give this a spin. Leo, if you got a chance it'd be useful to see if we can repro it. If not I'll try it tomorrow. Harry On 2018

Re: Additional register waits in MM engines on Vega10

2018-01-15 Thread Leo Liu
On 01/15/2018 07:21 AM, Christian König wrote: Hi guys, The *_vm_flush functions on Vega10 insert an extra register wait before writing to the request register. That doesn't looks like it makes any sense to me and I think it is just a leftover from bringup. The sequences is based on inter

[git pull] amdkfd fixes for 4.16

2018-01-15 Thread Oded Gabbay
Hi Dave, a couple of minor fixes for 4.16: - fix NULL pointer dereference - fix compiler warning on large define values - remove unnecessary call to execute_queues_cpsch Thanks, Oded The following changes since commit 9be712ef4612268c28b9f1e2d850d3ceab06ef66: Merge tag 'drm/tegra/for-4.16-rc

Additional register waits in MM engines on Vega10

2018-01-15 Thread Christian König
Hi guys, The *_vm_flush functions on Vega10 insert an extra register wait before writing to the request register. That doesn't looks like it makes any sense to me and I think it is just a leftover from bringup. Now it's in the way of cleaning up the *_vm_flush functions into something common.

[PATCH 1/3] drm/amdgpu: remove extra wait in uvd_v7_0_ring_emit_vm_flush

2018-01-15 Thread Christian König
Most likely just a leftover from bringup. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c index 4c19c96a8e59

[PATCH 3/3] drm/amdgpu:remove extra wait from vcn_v1_0_dec|enc_ring_emit_vm_flush

2018-01-15 Thread Christian König
Most likely just a leftover from bringup. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 659a8f2d9bf

[PATCH 2/3] drm/amdgpu: remove extra wait from vce_v4_0_emit_vm_flush

2018-01-15 Thread Christian König
Most likely just a leftover from bringup. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c index 071fb17810d8..63115391

[PATCH 3/3] drm/amdgpu: move struct gart_funcs into amdgpu_gmc.h

2018-01-15 Thread Christian König
And rename it to struct gmc_funcs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 30 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 10 - drivers/gpu/drm/amd/amdgpu/amdgpu_gart

[PATCH 1/3] drm/amdgpu: remove agp_base

2018-01-15 Thread Christian König
No AGP support for in this driver. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index a40c821832c0..6462738021d5 100644 --- a/drivers/gpu/drm/am

[PATCH 2/3] drm/amdgpu: move struct amdgpu_mc into amdgpu_gmc.h

2018-01-15 Thread Christian König
And rename it to amdgpu_gmc as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 56 + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 16 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 16 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_d

Re: suspend/resume

2018-01-15 Thread Michel Dänzer
On 2018-01-14 05:59 PM, jean-pierre.eckm...@unige.ch wrote: > Bizarre. > > I followed your (Martin Babutzka)  ideas and loaded 4.15-rc7 > > and I am still getting the suspend/tresume issue with nvidia-384.111 The amd-gfx mailing list is about the open source drivers for AMD GPUs. For issues with