Re: [PATCH] drm/amdgpu: Correct the IB size of bo update mapping.

2017-12-27 Thread Chunming Zhou
Good catch, Reviewed-by: Chunming Zhou On 2017年12月28日 11:17, Emily Deng wrote: The amdgpu_vm_frag_ptes will call amdgpu_vm_update_ptes, and for buffer object that has shadow buffer, need twice commands. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 --

[PATCH] drm/amdgpu: Correct the IB size of bo update mapping.

2017-12-27 Thread Emily Deng
The amdgpu_vm_frag_ptes will call amdgpu_vm_update_ptes, and for buffer object that has shadow buffer, need twice commands. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-27 Thread He, Roger
Got it, thank you! -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, December 27, 2017 4:58 PM To: He, Roger ; Koenig, Christian ; Grodzovsky, Andrey Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system

Re: [PATCH 1/3] Skip xf86HandleColormaps() at color depth 30.

2017-12-27 Thread Mario Kleiner
On 12/27/2017 12:56 PM, Michel Dänzer wrote: On 2017-12-23 07:07 AM, Mario Kleiner wrote: The hardware gamma luts get bypassed at color depth 30 anyway, so skip their setup. Also skip drmmode_crtc_gamma_set() for a screen with depth 30. Signed-off-by: Mario Kleiner --- src/drmmode_display.c

Re: [PATCH 11/12] drm/amd/powerplay: drop unneeded newline

2017-12-27 Thread Julia Lawall
On Wed, 27 Dec 2017, Michel Dänzer wrote: > On 2017-12-27 03:51 PM, Julia Lawall wrote: > > PP_ASSERT_WITH_CODE prints a newline at the end of the message string, > > so the message string does not need to include a newline explicitly. > > Done using Coccinelle. > > > > Signed-off-by: Julia Lawa

Re: [PATCH xf86-video-ati 1/2] Move cursor related ScreenInit calls into AMDGPUCursorInit_KMS

2017-12-27 Thread Alex Deucher
On Wed, Dec 27, 2017 at 11:43 AM, Michel Dänzer wrote: > From: Michel Dänzer > > And bail if xf86_cursors_init fails. > > (Ported from amdgpu commit dfccaa7043ccb157a1f8be7313123792bb7e7001) > > Signed-off-by: Michel Dänzer Series is: Reviewed-by: Alex Deucher > --- > src/radeon_kms.c | 44 +

[PATCH xf86-video-ati 2/2] Keep track of how many SW cursors are visible on each screen

2017-12-27 Thread Michel Dänzer
From: Michel Dänzer And use this to determine when we cannot use page flipping for DRI clients. We previously did this based on whether the HW cursor cannot be used on at least one CRTC, which had at least two issues: * Even while the HW cursor cannot be used, no SW cursor may actually be visi

[PATCH xf86-video-ati 1/2] Move cursor related ScreenInit calls into AMDGPUCursorInit_KMS

2017-12-27 Thread Michel Dänzer
From: Michel Dänzer And bail if xf86_cursors_init fails. (Ported from amdgpu commit dfccaa7043ccb157a1f8be7313123792bb7e7001) Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/sr

Re: [PATCH 11/12] drm/amd/powerplay: drop unneeded newline

2017-12-27 Thread Michel Dänzer
On 2017-12-27 03:51 PM, Julia Lawall wrote: > PP_ASSERT_WITH_CODE prints a newline at the end of the message string, > so the message string does not need to include a newline explicitly. > Done using Coccinelle. > > Signed-off-by: Julia Lawall > > --- > > I couldn't figure out how to configure

Re: [PATCH] Only detect virtualization capabilities on Fiji and Tonga.

2017-12-27 Thread José Ramón Muñoz Pekkarinen
On Wednesday, 27 December 2017 09:45:57 EET Alex Deucher wrote: > On Tue, Dec 26, 2017 at 9:26 AM, José Pekkarinen wrote: > > Signed-off-by: José Pekkarinen > > NACK. This would break vega10 and this code path is only called on > vega10 asics. > > Alex True, this may not be harmful. T

[PATCH 11/12] drm/amd/powerplay: drop unneeded newline

2017-12-27 Thread Julia Lawall
PP_ASSERT_WITH_CODE prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall --- I couldn't figure out how to configure the kernel to get any of this code to compile. drivers/gpu/

Re: [PATCH] Look for bios sriov capabilities only if we are on Fiji or Tonga.

2017-12-27 Thread José Ramón Muñoz Pekkarinen
On Wednesday, 27 December 2017 09:49:40 EET Alex Deucher wrote: > On Mon, Dec 25, 2017 at 3:49 PM, José Pekkarinen wrote: > > Signed-off-by: José Pekkarinen > > NACK. This will break vega10. The virtualization table only exists > on sr-iov capable cards so the checks are safe on all asics. >

[PATCH 00/12] drop unneeded newline

2017-12-27 Thread Julia Lawall
Drop newline at the end of a message string when the printing function adds a newline. The complete semantic patch that detects this issue is as shown below (http://coccinelle.lip6.fr/). It works in two phases - the first phase counts how many uses of a function involve a newline and how many don

Re: [PATCH 3/3] Support exa screen color depth 30 on Linux 3.16 and later. (v2)

2017-12-27 Thread Michel Dänzer
On 2017-12-23 07:07 AM, Mario Kleiner wrote: > Linux 3.16's radeon-kms introduced 10 bpc fb support. > Currently, as of X-Server 1.19, this works with exa accel, > but not yet when using glamor acceleration. > > v2: Style fixes, check for glamor first, as suggested > by Michel. > > Signed-off

Re: [PATCH 2/3] exa: Accelerate ARGB2101010 pictures (v2)

2017-12-27 Thread Michel Dänzer
On 2017-12-23 07:07 AM, Mario Kleiner wrote: > From: Fredrik Höglund > > Tested by Mario on a Radeon HD 4000 series for the r600 > exa path, and on Radeon HD 5770 for the evergreen exa > path. > > Signed-off-by: Fredrik Höglund > Reviewed-and-Tested-by: Mario Kleiner > > v2: Add format handli

Re: [PATCH 1/3] Skip xf86HandleColormaps() at color depth 30.

2017-12-27 Thread Michel Dänzer
On 2017-12-23 07:07 AM, Mario Kleiner wrote: > The hardware gamma luts get bypassed at color > depth 30 anyway, so skip their setup. > > Also skip drmmode_crtc_gamma_set() for a screen > with depth 30. > > Signed-off-by: Mario Kleiner > --- > src/drmmode_display.c | 10 -- > 1 file chan

Re: [amd-staging-drm-next] regression - *ERROR* Don't have enable_spread_spectrum_on_ppll for v4

2017-12-27 Thread Michel Dänzer
On 2017-12-27 05:43 AM, Dieter Nützel wrote: > Hello AMD team, > > I got this since latest 'amd-staging-drm-next' git update > (#b956c586e58a) during boot with Polaris RX580 DC on: > > [    3.586342] [drm:dal_bios_parser_init_cmd_tbl [amdgpu]] *ERROR* Don't > have enable_spread_spectrum_on_ppll f

Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-27 Thread Michel Dänzer
On 2017-12-25 09:45 AM, He, Roger wrote: > > Could you tell me how to duplicate this issue? Maybe now I can look into it. It happened for me running piglit run -x glx-multithread-texture --process-isolation false gpu results/gpu. using the Mesa radeonsi driver on Tonga in a Ryzen 7 1700 (8 c