Hi Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.15-rc3 next-20171215]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
Hi Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.15-rc3 next-20171215]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
Hi Dave,
I forgot to include the DC fixes from Harry when I sent out
my fixes yesterday. This just adds them on top.
The following changes since commit 0507f438ea19d4280006467ba02956f6a693deca:
drm/amdgpu: fix MAP_QUEUES paramter (2017-12-12 15:40:11 -0500)
are available in the git repositor
add device to the name for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
drivers/gpu/drm/amd/amdgpu/cik.c | 2 +-
drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
drivers/gpu/drm/amd/
add device to the name for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 38 +
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 50 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 18
and move them to amdgpu_atombios.c for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 236 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 231 --
It's the only place it's used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 33 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 33 +-
3 files changed,
add device to the name for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dr
add device for consistency with other functions in this file.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +-
drivers/gpu/drm/amd/amdgpu/cik.c | 120 ++---
drivers/gpu/drm/
add device to the name for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c| 2 +-
drivers/gpu/drm/
It's the only place it's used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/driver
add device for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 10 +-
drivers/gp
It's the only place they are used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 95
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 99 +-
3 files changed, 97
for consistency with the other functions in that file.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
It's the only place they are used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 --
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 45 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 49 --
3 files changed, 47
Prefix the functions with device or device_ip for functions which
deal with ip blocks for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 176 +++--
1 file changed, 90 insertions(+), 86 deletions(-)
diff --git a/drivers/gpu/drm/a
add device for consistency with other functions in this file.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
drivers/gpu/drm/amd/amdgpu/cik.c | 2 +-
drivers/gpu/drm/amd/amdgpu/vi.c| 2 +-
amdgpu_device.c was getting pretty cluttered.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 16 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 792
drivers/gpu/drm/amd/amdgpu/amd
add device to the name for consistency.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 4 ++--
This file has gotten huge and has become a dumping ground for all
sorts of things. The function naming is also really inconsistent.
This patch set:
1. cleans up the function naming to make it consistent
2. moves all the debugfs stuff to it's own file
3. moves all the atom stuff to amdgpu_atombios.
From: amd-gfx on behalf of Andrey
Grodzovsky
Sent: Friday, December 15, 2017 2:09 PM
To: amd-gfx@lists.freedesktop.org
Cc: He, Roger; Daenzer, Michel; Koenig, Christian; Grodzovsky, Andrey
Subject: [PATCH] Revert "drm/amd/amdgpu: set gtt size according to system
This reverts commit ba851eed895c76be0eb4260bdbeb7e26f9ccfaa2.
With that change piglit max size tests (running with -t max.*size) are causing
OOM and hard hang on my CZ with 1GB RAM.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 +---
1 file changed, 5 inser
From: Colin Ian King
The null check on aconnector->base.edid_blob_ptr->data is redundant
since data is an array and can never be null. Remove it.
Detected by CoverityScan, CID#1460369 ("Array compared against 0")
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_
On 15 December 2017 at 18:27, Andrey Grodzovsky
wrote:
> fixes: 806d080360faecb4025d8e9c7490cb097c25 (amdgpu: Use new
> suite/test disabling functionality.)
> bug: https://bugs.freedesktop.org/show_bug.cgi?id=104280
Nit: remove the leading space.
>
> Signed-off-by: Andrey Grodzovsky
Am 15.12.2017 um 19:27 schrieb Andrey Grodzovsky:
fixes: 806d080360faecb4025d8e9c7490cb097c25 (amdgpu: Use new
suite/test disabling functionality.)
bug: https://bugs.freedesktop.org/show_bug.cgi?id=104280
Signed-off-by: Andrey Grodzovsky
Reviewed-by: Christian König
---
te
fixes: 806d080360faecb4025d8e9c7490cb097c25 (amdgpu: Use new suite/test
disabling functionality.)
bug: https://bugs.freedesktop.org/show_bug.cgi?id=104280
Signed-off-by: Andrey Grodzovsky
---
tests/amdgpu/vcn_tests.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/amdgpu
On 10 November 2017 at 04:30, Andrey Grodzovsky
wrote:
> Switch from disabling tests during run to using the new disable
> API.
>
> Signed-off-by: Andrey Grodzovsky
> ---
> tests/amdgpu/amdgpu_test.c| 14 ++--
> tests/amdgpu/amdgpu_test.h| 15
> tests/amdgpu/deadlock_tests.c
Am 15.12.2017 um 17:33 schrieb Samuel Li:
To improve cpu read performance. This is implemented for APUs currently.
v2: Adapt to change
https://lists.freedesktop.org/archives/amd-gfx/2017-October/015174.html
v3: Adapt to change "forward begin_cpu_access callback to drivers"
Change-Id: I7a583e23
To improve cpu read performance. This is implemented for APUs currently.
v2: Adapt to change
https://lists.freedesktop.org/archives/amd-gfx/2017-October/015174.html
v3: Adapt to change "forward begin_cpu_access callback to drivers"
Change-Id: I7a583e23a9ee706e0edd2a46f4e4186a609368e3
---
driver
From: Christian König
On CZ and newer APUs we can pin the fb into GART as well as VRAM.
v2: Don't enable gpu_vm_support for Raven yet since it leads to
a black screen. Need to debug this further before enabling.
Change-Id: Id0f8af3110e54a3aabf7a258871867bc121cc1a2
Signed-off-by: Christian K
From: Christian König
Allow drivers to implement their own begin_cpu_access callback.
Change-Id: I97709b42b9351a04ee7e01106107a87bc56ea258
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_prime.c | 13 +
include/drm/drm_drv.h | 2 ++
2 files changed, 15 insertions(+)
On 2017-12-15 05:53 AM, Colin King wrote:
> From: Colin Ian King
>
> The null check on aconnector->base.edid_blob_ptr->data is redundant
> since data is an array and can never be null. Remove it.
>
> Detected by CoverityScan, CID#1460369 ("Array compared against 0")
>
> Signed-off-by: Colin Ia
On 12/15/2017 01:05 PM, Christian König wrote:
I'm in favour of that. But I don't think what I proposed is a step
away from that direction. On the contrary. I've attached a POC patch
with the correctness checks stripped, not compile-tested. Much easier
to follow if you ask me, but if you fee
On 12/14/2017 03:52 AM, Christian König wrote:
Am 14.12.2017 um 08:19 schrieb Liu, Monk:
Problem with this is that amdgpu_check_soft_reset will not be
called, this function which prints which IP block was hung even when
later we opt not to recover.
I suggest instead to add a bool force_reset
Am 13.12.2017 um 20:01 schrieb Andrey Grodzovsky:
Add new parameter to control GPU recovery procedure.
Retire old way of disabling GPU recovery by setting lockup_timeout == 0 and
set default for lockup_timeout to 10s.
v2:
Add auto logic where reset is disabled for bare metal and enabled
for SR-I
Am 15.12.2017 um 11:53 schrieb Colin King:
From: Colin Ian King
The null check on aconnector->base.edid_blob_ptr->data is redundant
since data is an array and can never be null. Remove it.
Detected by CoverityScan, CID#1460369 ("Array compared against 0")
Signed-off-by: Colin Ian King
Ack
Am 15.12.2017 um 12:35 schrieb Thomas Hellstrom:
On 12/15/2017 10:53 AM, Christian König wrote:
Well this is more or less replicating what you are doing currently
but instead of spreading the checks and locking state all over the
code, both as local variables and parameters this is keeping it
On 12/15/2017 10:53 AM, Christian König wrote:
Well this is more or less replicating what you are doing currently
but instead of spreading the checks and locking state all over the
code, both as local variables and parameters this is keeping it in a
single place with correctness checks.
I d
Reviewed-and-Tested-by: Chunming Zhou
On 2017年12月15日 17:57, Christian König wrote:
Instead of falling back to 2 level and very limited address space use
2+1 PD support and 128TB + 512GB of virtual address space.
v2: cleanup defines, rebase on top of level enum
v3: fix inverted check in hardwa
Am 14.12.2017 um 16:25 schrieb Alex Deucher:
On Fri, Dec 8, 2017 at 3:10 PM, Alex Deucher wrote:
Same as previous asics. This was not yet set for gfx9.
Ping?
Acked-by: Christian König
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 17 -
driv
Am 15.12.2017 um 08:30 schrieb Chunming Zhou:
On 2017年12月15日 02:04, Alex Deucher wrote:
On Thu, Dec 14, 2017 at 7:03 AM, Christian König
wrote:
Instead of falling back to 2 level and very limited address space use
2+1 PD support and 128TB + 512GB of virtual address space.
v2: cleanup define
Instead of falling back to 2 level and very limited address space use
2+1 PD support and 128TB + 512GB of virtual address space.
v2: cleanup defines, rebase on top of level enum
v3: fix inverted check in hardware setup
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
Am 15.12.2017 um 10:38 schrieb Thomas Hellstrom:
On 12/15/2017 10:13 AM, Christian König wrote:
Hi Thomas,
actually I was very happy to get rid of that stuff.
Yes, wrappers that don't do anything don't make much sense, but this
is a different story.
I was not talking about the wrappers, bu
On 12/15/2017 10:13 AM, Christian König wrote:
Hi Thomas,
actually I was very happy to get rid of that stuff.
Yes, wrappers that don't do anything don't make much sense, but this is
a different story.
In the long run I indeed wanted to replace ctx->resv with the
ww_acquire_ctx to enable
user can change engine/mclk/soc/vcn clocks on Rv
v3: add smu version check
v2: fix no return statement
Change-Id: I4cba759701ab031085a687102de6566771f4494f
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 127 +
drivers/gpu/drm/amd/powerplay/hw
Change-Id: Ib89948c2a2ba8cede4a62875befde48c7bedba69
Reviewed-by: Alex Deucher
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
b/drivers/gpu/drm/amd/pow
Am 15.12.2017 um 08:32 schrieb Jim Qu:
Change-Id: I62720a2df92005c8838f2e6a505f7d4840903ebb
Signed-off-by: Jim Qu
Reviewed-by: Christian König for both.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd
Change-Id: I3d2a25cc9d483d2d529af0bcdb78dee891919d5e
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 10 +-
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 1 +
drivers/gpu/drm/amd/powerplay/hwmgr/pp_psm.c | 4 +++-
3 files changed, 5 insertions(+), 10 deleti
Am 15.12.2017 um 07:24 schrieb Thomas Hellstrom:
Hi.
On 12/14/2017 09:10 AM, Roger He wrote:
Change-Id: I0c6ece0decd18d30ccc94e5c7ca106d351941c62
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/
-Original Message-
From: Thomas Hellstrom [mailto:tho...@shipmail.org]
Sent: Friday, December 15, 2017 2:25 PM
To: He, Roger ; amd-gfx@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
Cc: Koenig, Christian
Subject: Re: [PATCH] drm/ttm: enable eviction for Per-VM-BO
Hi.
On 12/14/2
Hi Thomas,
actually I was very happy to get rid of that stuff.
In the long run I indeed wanted to replace ctx->resv with the
ww_acquire_ctx to enable eviction of even more things, but that is a
different story.
Recursive locking is usually something we should try to avoid.
Regards,
Christia
51 matches
Mail list logo
