Re: Operation context for TTM

2017-11-19 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel on RX580 amd-staging-drm-next 85d09ce5e5039644487e9508d6359f9f4cf64427 with glmark2, DiRT Rally and F1 2017 (radv) Dieter Am 17.11.2017 11:49, schrieb Christian König: Hi everyone, Michel already reviewed this back in April, but I didn't found time

Re: [PATCH 8/8] drm/amdgpu: use the new TTM bytes moved counter v2

2017-11-19 Thread Chunming Zhou
 Reviewed-by: Chunming Zhou for the series. btw: any new patch based on this for enabling eviction and swapout for per-vm-bo? Regards, David Zhou On 2017年11月17日 18:49, Christian König wrote: Instead of the global statistics use the per context bytes moved counter. v2: rebased Signed-off-b

Kernel crash/Null pointer dereference on vblank

2017-11-19 Thread Martin Babutzka
Dear AMD Developers, At first congratulations for the DC code submission to the 4.15 kernel. Unfortunately the major regression which I reported on 29.09., 06.10., 02.11. and 05.11. still exists. But this time I got additional debugging information maybe this helps to fix it. Summary: I am runnin

[PATCH 2/5] drm/amd/powerplay: Fix missing newlines at end of file

2017-11-19 Thread Ernst Sjöstrand
Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/include/kgd_pp_interface.h | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 5/5] drm/amd/powerplay: Followup fixes to mc_reg_address

2017-11-19 Thread Ernst Sjöstrand
This is a followup to: drm/amd/powerplay: Fix buffer overflows with mc_reg_address Rework *_set_mc_special_registers for the other architectures to use the same logic as the first patch. This allows the last entry of the array to be filled without an error message for example. This doesn't fix any

[PATCH 4/5] drm/amd/powerplay: Fix buffer overflows with mc_reg_address

2017-11-19 Thread Ernst Sjöstrand
Smatch warned about the following lines: ci_set_mc_special_registers() error: buffer overflow 'table->mc_reg_address' 16 <= 16 tonga_set_mc_special_registers() error: buffer overflow 'table->mc_reg_address' 16 <= 16 Change the logic to check before access instead of after incrementing. It's fine

[PATCH 1/5] drm/amd/powerplay: Minor fixes in processpptables.c

2017-11-19 Thread Ernst Sjöstrand
Reported by smatch: init_overdrive_limits() error: uninitialized symbol 'result'. get_clock_voltage_dependency_table() warn: inconsistent indenting Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 3/5] drm/amd/amdgpu: Fix missing null check in atombios_i2c.c

2017-11-19 Thread Ernst Sjöstrand
Reported by smatch: amdgpu_atombios_i2c_process_i2c_ch() error: we previously assumed 'buf' could be null Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atomb

Re: [PATCH 3/4] drm/amdkfd: Add CWSR support

2017-11-19 Thread Oded Gabbay
On Tue, Nov 14, 2017 at 11:41 PM, Felix Kuehling wrote: > This hardware feature allows the GPU to preempt shader execution in > the middle of a compute wave, save the state and restore it later > to resume execution. > > Memory for saving the state is allocated per queue in user mode and > the add

Re: [PATCH 2/4] drm/amdkfd: Add trap handler for CWSR

2017-11-19 Thread Oded Gabbay
On Tue, Nov 14, 2017 at 11:41 PM, Felix Kuehling wrote: > The trap handler is like an interrupt handler running on the GPU > compute unit. It is needed for supporting CWSR (compute wave > save/restore). > > This file defines an array with the pre-compiled GFXv8 shader ISA. > The assembly code is i

Re: [PATCH 1/4] drm/amdkfd: Cleanup qpd.pqm initialization

2017-11-19 Thread Oded Gabbay
On Tue, Nov 14, 2017 at 11:41 PM, Felix Kuehling wrote: > The PQM doesn't change after process creation. So initialize it in > kfd_create_process_device_data. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 + > drivers/gpu/drm/amd/amdkfd/kfd_

Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation

2017-11-19 Thread Oded Gabbay
On Thu, Nov 16, 2017 at 11:36 PM, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c > b/drivers/gpu/drm/amd/amdkfd/