RE: KFD event handling questions

2017-09-22 Thread Thangirala, Hari
Hi Felix, Event IDs reserved for debug events was an artifact of a debugger design. We changed our tools strategy so those limitations do not exist anymore. There's no need to reserve special event-IDs for debugger. 4096 is good enough and the new debug trap handler will use events from that po

Re: [PATCH 1/9] drm/ttm: remove unsued options from ttm_mem_global_alloc_page

2017-09-22 Thread Felix Kuehling
Nice patch series. I wasn't expecting that so quickly. Patches 4-7 change the ttm_page_alloc allocator, which isn't used by amdgpu (as far as I can tell). Did you test those changes with a different driver? I didn't review them in as much detail as the rest. Someone with a stake in them should pro

Re: [PATCH 9/9] drm/amdgpu: add VM support for huge pages

2017-09-22 Thread Felix Kuehling
On 2017-09-22 08:13 AM, Christian König wrote: > From: Christian König > > Convert GTT mappings into linear ones for huge page handling. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletion

[PATCH 1/2] drm/amdgpu: New header for fields needed to determine state of ECC.

2017-09-22 Thread David Panariti
Add header file with ECC field definitions (MASKs and SHIFTs). Change-Id: I6e420f11db8e701402088a5bc47f641d5ac41c47 Signed-off-by: David Panariti --- .../include/asic_reg/vega10/UMC/umc_6_0_sh_mask.h | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 drivers/gpu/

Report if ECC is enabled on Vega10.

2017-09-22 Thread David Panariti
VBIOS decides whether or not to enabled ECC. During init, we check and report the state. [PATCH 1/2] drm/amdgpu: New header for fields needed to determine [PATCH 2/2] drm/amdgpu: Add ability to determine and report if board ___ amd-gfx mailing list amd-

[PATCH 2/2] drm/amdgpu: Add ability to determine and report if board supports ECC.

2017-09-22 Thread David Panariti
Initialization code checks the ECC related registers, which are initialized by the VBIOS, to see if ECC is present and initialized and DRM_INFO()s the result. Change-Id: I8617269809cf3641c5151291ad5d964f55f7f835 Signed-off-by: David Panariti --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 207 ++

Re: [PATCH] drm/amdgpu: protect chash related code under macro

2017-09-22 Thread Kuehling, Felix
This should not be needed, because in Kconfig I made amdgpu depend on CONFIG_CHASH. Regards, Felix From: amd-gfx on behalf of S, Shirish Sent: Thursday, September 21, 2017 3:35:01 AM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: [PATC

[PATCH 7/9] drm/ttm: move more logic into ttm_page_pool_get_pages

2017-09-22 Thread Christian König
From: Christian König Make it easier to add huge page pool. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 98 +++- 1 file changed, 52 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm

[PATCH 8/9] drm/amdgpu: minor coding style fix

2017-09-22 Thread Christian König
From: Christian König Fix two minor 80 char issues. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 8fcc743

[PATCH 9/9] drm/amdgpu: add VM support for huge pages

2017-09-22 Thread Christian König
From: Christian König Convert GTT mappings into linear ones for huge page handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/

[PATCH 4/9] drm/ttm: allocate/free multiple pages in a single call

2017-09-22 Thread Christian König
From: Christian König Totally surprisingly this is more efficient than doing it page by page. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page

[PATCH 5/9] drm/ttm: DMA map/unmap compound pages as a whole

2017-09-22 Thread Christian König
From: Christian König Instead of mapping them bit by bit map/unmap the whole compound pages as in one call. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/d

[PATCH 6/9] drm/ttm: add transparent huge page support for cached allocations

2017-09-22 Thread Christian König
From: Christian König Try to allocate huge pages when it makes sense. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 49 ++-- 1 file changed, 41 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/driver

[PATCH 2/9] drm/ttm: add support for different pool sizes

2017-09-22 Thread Christian König
From: Christian König Correctly handle different page sizes in the memory accounting. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_memory.c | 10 +- drivers/gpu/drm/ttm/ttm_page_alloc.c | 5 +++-- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 7 --- include

[PATCH 1/9] drm/ttm: remove unsued options from ttm_mem_global_alloc_page

2017-09-22 Thread Christian König
From: Christian König Nobody is actually using that, remove it. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_memory.c | 6 ++ drivers/gpu/drm/ttm/ttm_page_alloc.c | 3 +-- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 3 +-- include/drm/ttm/ttm_memory.h |

[PATCH 3/9] drm/ttm: add transparent huge page support for DMA allocations v2

2017-09-22 Thread Christian König
From: Christian König Try to allocate huge pages when it makes sense. v2: fix comment and use ifdef Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 217 --- 1 file changed, 169 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/d

[PATCH 1/2] drm/amdgpu/sriov:now must reinit psp

2017-09-22 Thread Monk Liu
otherwise after VF FLR the KIQ cannot work Change-Id: Icb18e794b5e4dccfd70c811c138c7102df874203 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 2/2] drm/amdgpu/sriov:fix memory leak in psp_load_fw

2017-09-22 Thread Monk Liu
when doing gpu reset this routine shouldn't do anything resource allocating otherwise SRIOV gpu reset will cause memory leak Change-Id: I25da3a5b475196c75c7e639adc40751754625968 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 20 1 file changed, 12 inse

[PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast"

2017-09-22 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c b/

[PATCH] drm/amdgpu: protect chash related code under macro

2017-09-22 Thread S, Shirish
From: Shirish S The chash library is built only if CONFIG_CHASH is enabled, however there is code in amdgpu_ih.c which results in link error as it is not under appropriate macro. This patch brings chash related code in amdgpu_ih.c under CONFIG_CHASH. Signed-off-by: Shirish S --- drivers/gpu/

RE: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM

2017-09-22 Thread Liu, Monk
alright -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2017年9月22日 15:15 To: Liu, Monk ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM Hi Monk, I agree with Alex here. We shoul

Re: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM

2017-09-22 Thread Christian König
Hi Monk, I agree with Alex here. We should keep the SRIOV specialized handling to a minimum. Please add a code comment if you think somebody could accidentally change the code back. Regards, Christian. Am 22.09.2017 um 05:37 schrieb Liu, Monk: Alex Since CPU visible VRAM resource is very