On Fri, 2017-09-15 at 19:42 -0400, Felix Kuehling wrote:
> From: Yong Zhao
>
> The timeout in milliseconds should not be regarded as jiffies. This
> commit fixed that.
>
> Signed-off-by: Yong Zhao
> Signed-off-by: Felix Kuehling
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c |
When max_bytes is not 8 bytes aligned and bo size is larger than
max_bytes, the last 8 bytes in a ttm node may be left unchanged.
For example, on pre SDMA 4.0, max_bytes = 0x1f, and the bo size
is 0x20, the problem will happen. This commit fixed that.
Change-Id: I37c588a57cb63f1a8251fb5ead
We want to make DC less chatty but still allow bug reporters to
provide more detailed logs.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
Linux and Windows often desire different log levels.
Change-Id: Idd3c672e8b36f41de240e94d0c2d4b56ce60376e
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/amd/display/dc/basics/logger.c | 41 +++---
drivers/gpu/drm/
Log DC init but default log level to 0 (default for
amdgpu_dc_log) otherwise. Bug reporters can still make
DC more chatty by using the dc_log module param.
amdgpu.dc_log = 1
v2: Only provide runtime option, no compile time config
Change-Id: Icdfb849fa678225e2460519fbd8066540feb451a
Signed-off
We shouldn't be as chatty as we are, sitting in the kernel. This
patchset reduces the default log levels greatly but still allows
bug reporters and internal teams run with previous log levels, using
a dc_log module parameter.
Going forward we'll look into converting the existing logs into
DRM_DEBU
When uninitializing a kernel queue.
Signed-off-by: Yong Zhao
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c
b/drivers/gpu/drm/amd/amdkfd/kfd_kernel
From: Yong Zhao
Avoid intermediate negative numbers when doing calculations with a mix
of signed and unsigned variables where implicit conversions can lead
to unexpected results.
When kernel queue buffer wraps around to 0, we need to check that rptr
won't be overwritten by the new packet.
Signe
From: Yong Zhao
Several functions in DQM are shared between cpsch and nocpsch code.
Remove the misleading _nocpsch suffix from their names.
Signed-off-by: Yong Zhao
Signed-off-by: Felix Kuehling
---
.../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 24 +++---
1 file changed
Small self-contained KFD fixes that don't introduce any new functionality or
features. These may be suitable to include in drm-fixes for 4.14. Patch 11
may be controversial and I may just drop it if people think this is better
dealt with in udevd configuration files.
Andres Rodriguez (1):
drm/am
From: Yong Zhao
There are already CHIP_* definitions under amd_shared.h file on amdgpu
side, so KFD should reuse them rather than defining new ones.
Using enum for asic type requires default cases on switch statements
to prevent compiler warnings. BUG on unsupported ASICs. It should never
get th
From: Andres Rodriguez
Set the default permissions of /dev/kfd to be more than just root
accessible 600.
Signed-off-by: Andres Rodriguez
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/amd
From: Yong Zhao
The idea is to let kfd init and resume function share the same code path
as much as possible, rather than to have two copies of almost identical
code. That way improves the code readability and maintainability.
Signed-off-by: Yong Zhao
Signed-off-by: Felix Kuehling
---
drivers
From: Yong Zhao
The hard-coded values related to VMID were removed in KFD, as those
values can be calculated in the KFD initialization function.
Signed-off-by: Yong Zhao
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 9 ++---
drivers/gpu/drm/am
Adjust latencies and timeouts for dequeueing with HWS and consolidate
them in one place. Make them longer to allow long running waves to
complete without causing a timeout. The timeout is twice as long as the
latency plus some buffer to make sure we don't detect a timeout
prematurely.
Change timeo
To avoid spamming the log.
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_events.c | 5 -
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c
b/drivers/gpu/drm/amd/amdkfd/kfd_e
From: Yong Zhao
The timeout in milliseconds should not be regarded as jiffies. This
commit fixed that.
Signed-off-by: Yong Zhao
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 +---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
2
From: Yong Zhao
When we do suspend/resume through "sudo pm-suspend" while there is
HSA activity running, upon resume we will encounter HWS hanging, which
is caused by memory read/write failures. The root cause is that when
suspend, we neglected to unbind pasid from kfd device.
Another major chan
So it gets picked up properly by the kernel.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
index 6ec5c9f..77cab1f 100644
--- a/drivers/g
On Mon, 28 Aug 2017 21:53:10 -0400 Felix Kuehling
wrote:
> This adds a statically sized closed hash table implementation with
> low memory and CPU overhead. The API is inspired by kfifo.
>
> Storing, retrieving and deleting data does not involve any dynamic
> memory management, which makes it i
The structure returned from r600_audio_status() is only partially
initialized, and older gcc versions (4.3 and 4.4) warn about this:
drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status':
drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used
uninitialized in this functi
Fixes a hibernation regression on APUs.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=191571
Fixes: 274ad65c9d02bdc (drm/radeon: hard reset r600 and newer GPU when
hibernating.)
Signed-off-by: Alex Deucher
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_device.c | 2 +-
1 file c
On 2017-09-15 01:36 PM, Christian König wrote:
> Am 15.09.2017 um 19:33 schrieb Harry Wentland:
>> On 2017-09-15 01:26 PM, Christian König wrote:
>>> Am 15.09.2017 um 17:35 schrieb Felix Kuehling:
On 2017-09-15 11:28 AM, Christian König wrote:
> Am 15.09.2017 um 17:26 schrieb Deucher, Al
Am 15.09.2017 um 19:33 schrieb Harry Wentland:
On 2017-09-15 01:26 PM, Christian König wrote:
Am 15.09.2017 um 17:35 schrieb Felix Kuehling:
On 2017-09-15 11:28 AM, Christian König wrote:
Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
-Original Message-
From: Wentland, Harry
Sent:
On 2017-09-15 01:26 PM, Christian König wrote:
> Am 15.09.2017 um 17:35 schrieb Felix Kuehling:
>> On 2017-09-15 11:28 AM, Christian König wrote:
>>> Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
> -Original Message-
> From: Wentland, Harry
> Sent: Friday, September 15, 201
Am 15.09.2017 um 17:35 schrieb Felix Kuehling:
On 2017-09-15 11:28 AM, Christian König wrote:
Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
-Original Message-
From: Wentland, Harry
Sent: Friday, September 15, 2017 11:21 AM
To: Koenig, Christian; amd-gfx@lists.freedesktop.org
Cc: De
On 2017-09-15 11:27 AM, Deucher, Alexander wrote:
>> -Original Message-
>> From: Wentland, Harry
>> Sent: Friday, September 15, 2017 11:21 AM
>> To: Koenig, Christian; amd-gfx@lists.freedesktop.org
>> Cc: Deucher, Alexander; Grodzovsky, Andrey; Cheng, Tony
>> Subject: Re: [PATCH 3/3] drm/am
On 2017-09-15 11:28 AM, Christian König wrote:
> Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
>>> -Original Message-
>>> From: Wentland, Harry
>>> Sent: Friday, September 15, 2017 11:21 AM
>>> To: Koenig, Christian; amd-gfx@lists.freedesktop.org
>>> Cc: Deucher, Alexander; Grodzovsky,
On 2017-09-15 11:28 AM, Christian König wrote:
> Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
>>> -Original Message-
>>> From: Wentland, Harry
>>> Sent: Friday, September 15, 2017 11:21 AM
>>> To: Koenig, Christian; amd-gfx@lists.freedesktop.org
>>> Cc: Deucher, Alexander; Grodzovsk
Am 15.09.2017 um 17:26 schrieb Deucher, Alexander:
-Original Message-
From: Wentland, Harry
Sent: Friday, September 15, 2017 11:21 AM
To: Koenig, Christian; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Grodzovsky, Andrey; Cheng, Tony
Subject: Re: [PATCH 3/3] drm/amd/display: Redu
> -Original Message-
> From: Wentland, Harry
> Sent: Friday, September 15, 2017 11:21 AM
> To: Koenig, Christian; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Grodzovsky, Andrey; Cheng, Tony
> Subject: Re: [PATCH 3/3] drm/amd/display: Reduce DC chattiness
>
>
>
> On 2017-09-15
> -Original Message-
> From: Wentland, Harry
> Sent: Friday, September 15, 2017 11:21 AM
> To: Koenig, Christian; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Grodzovsky, Andrey; Cheng, Tony
> Subject: Re: [PATCH 3/3] drm/amd/display: Reduce DC chattiness
>
>
>
> On 2017-09-15
On 2017-09-15 11:08 AM, Christian König wrote:
> Am 15.09.2017 um 16:32 schrieb Harry Wentland:
>> Log DC init but default log level to 0 (default for
>> amdgpu_dc_log) otherwise. Bug reporters can still make
>> DC more chatty like so
>> amdgpu.dc_log = 1
>
> Which is exactly the reason why
Am 15.09.2017 um 16:32 schrieb Harry Wentland:
Log DC init but default log level to 0 (default for
amdgpu_dc_log) otherwise. Bug reporters can still make
DC more chatty like so
amdgpu.dc_log = 1
Which is exactly the reason why I think this patch is superfluous.
Either have a compile time
Am 14.09.2017 um 00:39 schrieb Samuel Li:
v2: drop hdp invalidate/flush.
Signed-off-by: Samuel Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 77 ++-
3 file
hi:
Do you have amdgpu hypervisor driver patches or compiled module available
to us?
We do the testing and we feed back the test results. We're very interested
in this.
When does it fit into the kernel?
maok...@126.com
From: Yu, Xiangliang
Date: 2017-09-15 10:15
To: maok...@126.c
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
Linux and Windows often desire different log levels.
Change-Id: Idd3c672e8b36f41de240e94d0c2d4b56ce60376e
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/amd/display/dc/basics/logger.c | 41 +++---
drivers/gpu/drm/
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Friday, September 15, 2017 8:00 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH] drm/amd/powerplay: Simplify smu7_voting_clients()
>
> Change-Id: I7853
Log DC init but default log level to 0 (default for
amdgpu_dc_log) otherwise. Bug reporters can still make
DC more chatty like so
amdgpu.dc_log = 1
Change-Id: Icdfb849fa678225e2460519fbd8066540feb451a
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/Kconfig| 10 +
We want to make DC less chatty but still allow bug reporters to
provide more detailed logs.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
We shouldn't be as chatty as we are, sitting in the kernel. This
patchset reduces the default log levels greatly but still allows
bug reporters and internal teams run with previous log levels. To
do that we use a module parameter and also make it a compile
time option.
One possibility would've bee
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Friday, September 15, 2017 8:19 AM
> To: Zhu, Rex; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: fix checkpatch.pl error to amdgpu_drv.c
>
> Am 15.0
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of ken.w...@amd.com
> Sent: Friday, September 15, 2017 3:58 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Ken
> Subject: [PATCH] drm/amdgpu: Add GPU reset functionality for Vega10
>
> From:
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Friday, September 15, 2017 2:29 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH] drm/amdgpu: add powerplay support for CI asics
>
> currently, for CI a
Am 15.09.2017 um 13:58 schrieb Rex Zhu:
fix checkpatch.pl error and warning:
1. ERROR: do not initialise globals to NULL
2. ERROR: do not initialise globals to 0
3. WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Change-Id: I7029087efcfa88c968be9d7ae42f2453bc4b1da0
Signed-off-by: Rex Zh
Change-Id: I78533929e1bbd60d5dca0edbfc62a402ca5c1bd1
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 59
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.h | 9 +---
2 files changed, 19 insertions(+), 49 deletions(-)
diff --git a/drivers/gpu/
fix checkpatch.pl error and warning:
1. ERROR: do not initialise globals to NULL
2. ERROR: do not initialise globals to 0
3. WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Change-Id: I7029087efcfa88c968be9d7ae42f2453bc4b1da0
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.
sure, thanks.
From: Christian König
Sent: Friday, September 15, 2017 4:13:45 PM
To: Wang, Ken; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Add GPU reset functionality for Vega10
Am 15.09.2017 um 09:57 schrieb ken.w...@amd.com:
> From: Ken Wang
Am 15.09.2017 um 09:57 schrieb ken.w...@amd.com:
From: Ken Wang
V2
Signed-off-by: Ken Wang
Acked-by: Christian König
I would give an rb, but I can't judge if the PSP stuff is actually
correct, maybe wait for Alex to have a look as well.
Regards,
Christian.
Change-Id: I6fd2c216a847473
From: Ken Wang
V2
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 21 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/a
From: ken.w...@amd.com
Sent: Friday, September 15, 2017 14:57
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Ken
Subject: [PATCH] drm/amdgpu: Add GPU reset functionality for Vega10
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444b
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
sorry about sending duplicated review, email server seems not working properly.
From: amd-gfx on behalf of
qingqing.w...@amd.com
Sent: Friday, September 15, 2017 3:05:56 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Ken
Subject: [PATCH] drm/amdgpu: Add GPU rese
Am 15.09.2017 um 08:57 schrieb ken.w...@amd.com:
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdg
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
From: Ken Wang
Signed-off-by: Ken Wang
Change-Id: I6fd2c216a84747313f18db25a444be5ed43b4f4b
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 10 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 3 +++
drivers/gpu/drm/amd/amdgpu/psp_v
59 matches
Mail list logo
