That's clever. I was scratching my head where the BOs were getting
validated, just by sharing the VM reservation object. Until I carefully
read your previous commit.
In general, I find the VM code extremely frustrating and confusing to
review. Too many lists of different things, and it's really ha
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Deucher, Alexander
> Sent: Friday, August 25, 2017 4:07 PM
> To: Kuehling, Felix; amd-gfx@lists.freedesktop.org
> Subject: RE: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
>
> > -Original
> -Original Message-
> From: Kuehling, Felix
> Sent: Friday, August 25, 2017 3:59 PM
> To: Deucher, Alexander; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
>
> On 2017-08-25 03:40 PM, Deucher, Alexander wrote:
> >> -Original Message-
> >
On 2017-08-25 03:40 PM, Deucher, Alexander wrote:
>> -Original Message-
>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
>> Of Felix Kuehling
>> Sent: Friday, August 25, 2017 3:34 PM
>> To: amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/amdgpu: Add sysfs
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Felix Kuehling
> Sent: Friday, August 25, 2017 3:34 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
>
> I think the power measurement is a b
On 25/08/17 03:33 PM, Felix Kuehling wrote:
I think the power measurement is a bit of a hack right now. It requires
pinging the SMU twice to start and stop the measurement, and waiting for
some time (but not too long) in between. I think if we want to expose
this via hwmon, we'll need to have som
I think the power measurement is a bit of a hack right now. It requires
pinging the SMU twice to start and stop the measurement, and waiting for
some time (but not too long) in between. I think if we want to expose
this via hwmon, we'll need to have some kind of timer that polls it in
regular inter
Am 25.08.2017 um 18:22 schrieb Marek Olšák:
On Fri, Aug 25, 2017 at 3:00 PM, Christian König
wrote:
Am 25.08.2017 um 12:32 schrieb zhoucm1:
On 2017年08月25日 17:38, Christian König wrote:
From: Christian König
Add the IOCTL interface so that applications can allocate per VM BOs.
Still WIP s
On Fri, Aug 25, 2017 at 3:13 PM, Christian König
wrote:
> Am 25.08.2017 um 16:41 schrieb Alex Deucher:
>>
>> On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell
>> wrote:
>>>
>>> sysfs is more stable, and doesn't require root to access
>>>
>>> Signed-off-by: Kent Russell
>>
>> Might as well move the v
Am 25.08.2017 um 16:41 schrieb Alex Deucher:
On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote:
sysfs is more stable, and doesn't require root to access
Signed-off-by: Kent Russell
Might as well move the vbios binary itself to sysfs as well. It
should be a stable interface :)
Yeah, but
On Fri, Aug 25, 2017 at 3:00 PM, Christian König
wrote:
> Am 25.08.2017 um 12:32 schrieb zhoucm1:
>>
>>
>>
>> On 2017年08月25日 17:38, Christian König wrote:
>>>
>>> From: Christian König
>>>
>>> Add the IOCTL interface so that applications can allocate per VM BOs.
>>>
>>> Still WIP since not all co
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Russell, Kent
> Sent: Friday, August 25, 2017 11:38 AM
> To: Alex Deucher
> Cc: amd-gfx list
> Subject: RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs
>
> Christian was saying that the V
That sounds good. There's already the sclk/mclk/pcieclk in the device sysfs
tree, it was just power that we had to obtain in the debugfs. Thanks, I'll work
on that now. And I'll add voltage because I am sure someone will ask for it
soon enough. hwmon makes perfect sense though, I'll add it in th
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Russell, Kent
> Sent: Friday, August 25, 2017 9:00 AM
> To: StDenis, Tom; Christian König; amd-gfx@lists.freedesktop.org
> Subject: RE: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
>
> There
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, August 25, 2017 8:56 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH umr 2/2] Add SI/CIK to read_vram.
>
> Tested with my Tahiti devic
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Friday, August 25, 2017 5:27 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH 2/4] drm/amd/powerplay: Remove obsolete code of
> reduced refresh rate feat
Christian was saying that the VBIOS binary should remain in debugfs (on the
other thread). I'll let you two discuss, since I have zero vested interest in
the location of the VBIOS binary :)
Kent
-Original Message-
From: Alex Deucher [mailto:alexdeuc...@gmail.com]
Sent: Friday, August
That's right, it'll be in there, or the sym-linked /sys/class/drm/card0/device
, depending on how you like to find the amdgpu device sysfs files.
Kent
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom
St Denis
Sent: Friday, August 25, 2017
On Fri, Aug 25, 2017 at 6:18 AM, Rex Zhu wrote:
> Change-Id: Ib2a3cd06c540a90eb33fc9e4ce0f3122c5f2c0d3
> Signed-off-by: Rex Zhu
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 66
> --
> 1 file changed, 66 deletions(-)
>
> diff --git
On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote:
> sysfs is more stable, and doesn't require root to access
>
> Signed-off-by: Kent Russell
Might as well move the vbios binary itself to sysfs as well. It
should be a stable interface :)
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_devic
On Fri, Aug 25, 2017 at 8:59 AM, Russell, Kent wrote:
> There is GPU Power usage reported through amdgpu_pm_info, which also has some
> other information as well. I'd like that in sysfs, but I am unsure if we are
> allowed to due to the other information reported there.
>
We can add a sysfs fi
Signed-off-by: Tom St Denis
---
src/app/print_config.c | 8 ++--
src/lib/discover.c | 23 +++
src/lib/scan_config.c | 9 +
src/umr.h | 1 +
4 files changed, 31 insertions(+), 10 deletions(-)
diff --git a/src/app/print_config.c b/src/app/print_
Acked-by: Tom St Denis
Seems to be the easiest way to find this is via
/sys/bus/pci/devices/${devname}/vbios_version
Tom
On 25/08/17 09:43 AM, Kent Russell wrote:
sysfs is more stable, and doesn't require root to access
Signed-off-by: Kent Russell
---
drivers/gpu/drm/amd/amdgpu/amdgpu_de
sysfs is more stable, and doesn't require root to access
Signed-off-by: Kent Russell
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 54 +-
1 file changed, 23 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/a
Right. And according to Christian, it doesn't fit the format anyways, so power
usage can stay. I'm working on the patch to move the vbios version to sysfs
from debugfs. Should be up shortly. Maybe I can just make a new sysfs file for
Average GPU usage by itself. Another task for another day. But
On 25/08/17 09:05 AM, Tom St Denis wrote:
On 25/08/17 08:59 AM, Russell, Kent wrote:
There is GPU Power usage reported through amdgpu_pm_info, which also
has some other information as well. I'd like that in sysfs, but I am
unsure if we are allowed to due to the other information reported there
On 25/08/17 09:05 AM, Tom St Denis wrote:
On 25/08/17 08:59 AM, Russell, Kent wrote:
There is GPU Power usage reported through amdgpu_pm_info, which also
has some other information as well. I'd like that in sysfs, but I am
unsure if we are allowed to due to the other information reported there
On 25/08/17 08:59 AM, Russell, Kent wrote:
There is GPU Power usage reported through amdgpu_pm_info, which also has some
other information as well. I'd like that in sysfs, but I am unsure if we are
allowed to due to the other information reported there.
I thought the sensors were added to th
Am 25.08.2017 um 12:32 schrieb zhoucm1:
On 2017年08月25日 17:38, Christian König wrote:
From: Christian König
Add the IOCTL interface so that applications can allocate per VM BOs.
Still WIP since not all corner cases are tested yet, but this reduces
average
CS overhead for 10K BOs from 21ms
There is GPU Power usage reported through amdgpu_pm_info, which also has some
other information as well. I'd like that in sysfs, but I am unsure if we are
allowed to due to the other information reported there.
Kent
-Original Message-
From: StDenis, Tom
Sent: Friday, August 25, 2017
On 25/08/17 08:56 AM, Christian König wrote:
Hi Kent,
agree on the VBIOS dump file, that clearly belongs to debugsf.
The power usage stuff I can't say much about cause I'm not deeply into
this, but keep in mind the restriction for sysfs:
1. It's a stable interface. So it must be very well des
Hi Kent,
agree on the VBIOS dump file, that clearly belongs to debugsf.
The power usage stuff I can't say much about cause I'm not deeply into
this, but keep in mind the restriction for sysfs:
1. It's a stable interface. So it must be very well designed.
2. Only one value per file. I think the
Tested with my Tahiti device.
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c
index f2c3a15c27fe..c254f5a2e406 100644
--- a/src/lib/read_vram.c
+++ b/src/lib/read_vram.c
@@ -815,6 +815,8 @@ int um
Since we add the IP name to the register names we
need to strip that off again.
Signed-off-by: Tom St Denis
---
src/lib/ring_decode.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c
index 9d6e366e4594..52855ab4fb62 100644
--- a/src/lib/ring_d
The decision to move the VBIOS version to sysfs has been decided. I didn't get
any confirmation regarding moving the GPU power usage, or the actual VBIOS
dump, as the dump seems to make more sense in debugfs. I'd like to move power
usage to sysfs as the SMI tool needs root privileges just to rea
Hi Kent,
Loosely following this thread. Was there a decision on whether to leave
this in debugfs or sysfs?
I'd like to throw the version string in umr's config output (umr -c) :-)
Cheers,
Tom
On 24/08/17 05:30 PM, Russell, Kent wrote:
The plan is for the vbios version to be available throug
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex
Zhu
Sent: Friday, August 25, 2017 18:18
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: delete pp dead code on
Change-Id: Ib2a3cd06c540a90eb33fc9e4ce0f3122c5f2c0d3
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 66 --
1 file changed, 66 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hw
On 2017年08月25日 17:38, Christian König wrote:
From: Christian König
Add the IOCTL interface so that applications can allocate per VM BOs.
Still WIP since not all corner cases are tested yet, but this reduces average
CS overhead for 10K BOs from 21ms down to 48us.
Wow, cheers, eventually you g
this feature was not supported on linux and obsolete.
Change-Id: I7434e9370e4a29489bff7feb1421e028710fbe14
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/include/pptable.h | 6 --
drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 18 --
drivers/gpu/drm/
Change-Id: I335123d3f77b11adc65b29463e12f825d19ca382
Signed-off-by: Roger He
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
b/drivers/gpu
Am 25.08.2017 um 11:45 schrieb Roger He:
Change-Id: I335123d3f77b11adc65b29463e12f825d19ca382
Signed-off-by: Roger He
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 2 +-
2 files changed, 2 insertions(+), 2 de
delete useless code.
Signed-off-by: Rex Zhu
Conflicts:
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
Change-Id: I403457762ee4cadb357f69ed0846adfa55a9dbea
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 111 +
1 file changed, 37 insertions(+), 74 deletions(
cherry-pick this change from windows.
Change-Id: If6eb8b096275e32a94e9ed1568fc1466b2417ecd
Signed-off-by: Rex Zhu
Conflicts:
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
---
.../gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 14
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.
Change-Id: I235d31017ebc2801e57a60e7e6293172dbf1c7d7
Signed-off-by: Rex Zhu
---
.../gpu/drm/amd/powerplay/hwmgr/processpptables.c | 62 +-
1 file changed, 50 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
b/drivers/gpu/drm/
From: Christian König
Add the IOCTL interface so that applications can allocate per VM BOs.
Still WIP since not all corner cases are tested yet, but this reduces average
CS overhead for 10K BOs from 21ms down to 48us.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
From: Christian König
Instead of using the vm_state use a separate flag to note
that the BO was moved.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++
2 files changed, 10 insertions(+), 6 deletions(-
From: Christian König
Per VM BOs are handled like VM PDs and PTs. They are always valid and don't
need to be specified in the BO lists.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 73 ---
From: Christian König
Keep track off relocated PDs/PTs instead of walking and checking all PDs.
v2: better root PD handling
Signed-off-by: Christian König
Reviewed-by: Alex Deucher (v1)
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 87 ++
drivers/gpu/drm/amd/am
From: Christian König
We changed this to use an extra list a while back, but for the next
series I need a separate flag again.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 37 ++
From: Christian König
Instead of validating all page tables when one was evicted,
track which one needs a validation.
v2: simplify amdgpu_vm_ready as well
Signed-off-by: Christian König
Reviewed-by: Alex Deucher (v1)
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 7 +-
drivers/gpu/drm/am
From: Christian König
That somehow got lost.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 7a0656c..c77689f 100644
--- a/driv
From: Christian König
Those are certainly not kernel allocations, instead set the NO_CPU_ACCESS flag.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu
From: Christian König
Stop checking the mapped BO itself, cause that one is
certainly not a page table.
Additional to that move the code into amdgpu_vm.c
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 33 ++---
drivers/gpu/drm/amd/amdg
Ok.
Thanks
Roger(Hongbo.He)
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: Friday, August 25, 2017 3:33 PM
To: He, Roger ; amd-gfx@lists.freedesktop.org
Cc: Koenig, Christian
Subject: Re: [PATCH] drm/amd/amdgpu: fix BANK_SELECT on Vega10
Hi Roger,
ther
Hi Roger,
there are a few warnings introduced by this commit:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c: In function
‘gfxhub_v1_0_init_cache_regs’:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c:127:16: warning: unused
variable ‘field’ [-Wunused-variable]
uint32_t tmp, field;
^
driv
56 matches
Mail list logo
