[PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations (v2)

May waste a bit of memory, but simplifies the interface significantly. v2: convert internal accounting to use 256bit slots Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 77 ++

Re: [PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

Alex Deucher wrote: On Fri, Jul 28, 2017 at 6:08 PM, Andy Furniss wrote: Alex Deucher wrote: May waste a bit of memory, but simplifies the interface significantly. Can't boot tonga with this (testing 4.14-wip) Should be fixed with this patch. Yes, OK with that, thanks.

Re: [PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

On Fri, Jul 28, 2017 at 6:08 PM, Andy Furniss wrote: > Alex Deucher wrote: >> >> May waste a bit of memory, but simplifies the interface >> significantly. > > > Can't boot tonga with this (testing 4.14-wip) Should be fixed with this patch. Alex > > Jul 28 23:00:29 ph4 kernel: [drm] amdgpu kerne

Re: [PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

Alex Deucher wrote: May waste a bit of memory, but simplifies the interface significantly. Can't boot tonga with this (testing 4.14-wip) Jul 28 23:00:29 ph4 kernel: [drm] amdgpu kernel modesetting enabled. Jul 28 23:00:29 ph4 kernel: [drm] initializing kernel modesetting (TONGA 0x1002:0x6939

[PATCH 1/1] drm/amdgpu: Fix KFD initialization for multi-GPU systems

kfd2kgd is device-specific, so it should not be a global variable. Merge amdgpu_amdkfd_load_interface and amdgpu_amdkfd_device_probe so that it's only needed as a local variable in one function. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 37 +++

[PATCH 2/4] drm/amdgpu/sdma4: drop hdp flush from wptr shadow update

The wb buffer is in system memory, not vram so the flush is useless. Cc: Frank Min Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/am

[PATCH 3/4] drm/amdgpu/sdma4: drop allocation of poll_mem_offs

We already allocate this as part of the ring structure, use that instead. Cc: Frank Min Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 45 +++--- 2 files changed, 9

[PATCH 4/4] drm/amdgpu/sdma4: move wptr polling setup

Move it up before ring enablement with all of the other engine setup and explicitly disable it for bare metal. Cc: Frank Min Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 24 +--- 1 file changed, 13 insertions(+), 11 d

[PATCH 1/4] drm/amdgpu/sdma4: set wptr shadow atomically (v2)

No functional change until wptr polling uses this location (future patch). v2: use WRITE_ONCE Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/

[PATCH 9/9 v2] ASoC: AMD: Add machine driver for cz rt5650

From: Akshu Agrawal The driver is used for AMD board using rt5650 codec. Signed-off-by: Akshu Agrawal Signed-off-by: Alex Deucher --- V2: Change ACPI ID to AMDI1002 sound/soc/amd/Kconfig | 7 ++ sound/soc/amd/Makefile | 2 + sound/soc/amd/acp-rt5645.c | 210 +

[PATCH 5/9 v2] ASoC: AMD: disabling memory gating in stoney platform

From: Vijendar Mukunda For Stoney platform, Memory gating is disabled.i.e SRAM Banks won't be turned off. By Default, SRAM Bank state set to ON. Added condition checks to skip SRAM Bank state set logic for Stoney platform. Signed-off-by: Vijendar Mukunda Signed-off-by: Alex Deucher --- v2: Ad

[PATCH 6/9 v2] ASoC: AMD: DMA driver changes for Stoney Platform

From: Vijendar Mukunda Added DMA driver changes for Stoney platform. Below are the key differences between Stoney and CZ In Stoney, Memory Gating is disabled.SRAM Banks won't be turned off.No Of SRAM Banks reduced to 6. DAGB Garlic Interface used and 16 bit resolution is supported. SRAM bank 1 &

[PATCH 1/9] ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver

From: Vijendar Mukunda Added quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to Designware driver. This quirk will set idx value to 1. By setting this quirk, it will override supported format as 16 bit resolution and bus width as 2 Bytes. Reviewed-by: Alex Deucher Signed-off-by: Vijendar Mukunda Signed

[PATCH 7/9 v2] ASoC: AMD: Audio buffer related changes for Stoney

From: Vijendar Mukunda Stoney uses 16kb SRAM memory for playback and 16Kb for capture.Modified Max buffer size to have the correct mapping between System Memory and SRAM. Added snd_pcm_hardware structures for playback and capture for Stoney. Signed-off-by: Vijendar Mukunda Signed-off-by: Alex

[PATCH 8/9 v2] drm/amd/amdgpu: Disabling Power Gating for Stoney platform

From: Vijendar Mukunda Power Gating is disabled in Stoney platform. Signed-off-by: Vijendar Mukunda Signed-off-by: Alex Deucher --- v2: added missing changes required for power gating and removed local variable. drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 51 ++-

[PATCH 2/9 v2] drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data

From: Vijendar Mukunda asic_type information is passed to ACP DMA Driver as platform data. Signed-off-by: Vijendar Mukunda Signed-off-by: Alex Deucher --- v2:Removed asic_type local variable and directly passing asic_type instance to ACP DMA driver as platform data. drivers/gpu/drm/amd/amdgp

[PATCH 3/9 v2] drm/amd/amdgpu: Added a quirk for Stoney platform

From: Vijendar Mukunda Added DW_I2S_QUIRK_16BIT_IDX_OVERRIDE quirk for Stoney. Supported format and bus width for I2S controller read from I2S Component Parameter registers. These are ready only registers. For Stoney, I2S Component Parameter registers are programmed to support 32 bit format and

[PATCH 4/9] drm/amdgpu Moving amdgpu asic types to a separate file

From: Akshu Agrawal Amdgpu asic types will be required for other drivers too. Hence, its better to keep it in a separate include file. Signed-off-by: Akshu Agrawal Signed-off-by: Alex Deucher --- New patch to share asic_type definitions between GPU and audio driver. drivers/gpu/drm/amd/inclu

[PATCH 0/9 v2] Add ASoC support for AMD Stoney APUs

This patch set updates the AMD GPU and Audio CoProcessor (ACP) audio drivers and the designware i2s driver for Stoney (ST). ST is an APU similar to Carrizo (CZ) which already has ACP audio support. The i2s controller and ACP audio DMA engine are part of the GPU and both need updating so I would li

Re: [PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

Am 28.07.2017 um 18:15 schrieb Alex Deucher: May waste a bit of memory, but simplifies the interface significantly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 65 -- drivers/gpu

[PATCH umr] Improve and fix VM decoding

We now filter the output nicely to not repeat PDE entries unncessarily. The VA mask was also fixed for AI platforms. Signed-off-by: Tom St Denis --- src/app/main.c | 6 +-- src/lib/read_vram.c | 128 +++- 2 files changed, 77 insertions(+),

Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

On Thu, Jul 27, 2017 at 6:43 PM, Alex Deucher wrote: > On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: >> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use >> designated initializers") mark other tableFunction entries with designated >> initializers. The randstruct plugin requi

Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

On Fri, Jul 28, 2017 at 2:13 AM, Christian König wrote: > Am 28.07.2017 um 03:43 schrieb Alex Deucher: >> >> On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: >>> >>> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use >>> designated initializers") mark other tableFunction entries

RE: [PATCH] drm/amd/powerplay: rv: Use designated initializers

> -Original Message- > From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of > Kees Cook > Sent: Friday, July 28, 2017 1:16 PM > To: Alex Deucher > Cc: LKML; David Airlie; amd-gfx list; Maling list - DRI developers; Deucher, > Alexander; Zhu, Rex; Koenig, Christian; Zhang, Haw

Re: [PATCH 3/3] drm/amd/powerplay: update didt configs

On Fri, Jul 28, 2017 at 5:59 AM, Huang Rui wrote: > On Fri, Jul 28, 2017 at 04:01:01PM +0800, Evan Quan wrote: >> Change-Id: I1506f4c6e9320a1e90a89be55368328cbaab7844 >> Signed-off-by: Evan Quan > > Reviewed-by: Huang Rui Reviewed-by: Alex Deucher > >> --- >> drivers/gpu/drm/amd/powerplay/hw

Re: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

On Fri, Jul 28, 2017 at 4:47 AM, Quan, Evan wrote: > Oops, the changes were made by a remote windows editor which added the > executable bit wrongly. > Thanks for the remind. Will pay attention to it. With the mode fixed, the patch is: Reviewed-by: Alex Deucher > > Regards, > Evan >>-Origi

Re: [PATCH 1/3] drm/amdgpu: update vega10 golden setting

On Fri, Jul 28, 2017 at 4:30 AM, Huang Rui wrote: > On Fri, Jul 28, 2017 at 04:00:28PM +0800, Evan Quan wrote: >> Change-Id: I44c22b126824ccb022bf5cefa1d73639ac1a53c7 >> Signed-off-by: Evan Quan > > Reviewed-by: Huang Rui Reviewed-by: Alex Deucher > >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v

Re: [PATCH] drm/amd/powerplay: add vclk/dclkSoftMin support for raven

On Fri, Jul 28, 2017 at 5:28 AM, Junwei Zhang wrote: > Signed-off-by: Junwei Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 9 + > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h | 2 ++ > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 2 ++ >

[PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

May waste a bit of memory, but simplifies the interface significantly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 65 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 65 -

Re: [PATCH 1/2] drm/amdgpu: Add a parameter to amdgpu_bo_create()

Got it. On 2017-07-28 05:01 AM, Christian König wrote: Am 27.07.2017 um 21:48 schrieb Yong Zhao: The parameter init_value contains the value to which we initialized VRAM bo when AMDGPU_GEM_CREATE_VRAM_CLEARED flag is set. Change-Id: I9ef3b9dd3ca9b98cc25dd2eaff68fbe1129c3e3c Signed-off-by: Yon

[PATCH libdrm 1/1] amdgpu: Add FX-9800P Bristol Ridge iGPU id

Signed-off-by: Jan Vesely --- data/amdgpu.ids | 1 + 1 file changed, 1 insertion(+) diff --git a/data/amdgpu.ids b/data/amdgpu.ids index 0b98c3c3..f6c65dd9 100644 --- a/data/amdgpu.ids +++ b/data/amdgpu.ids @@ -153,6 +153,7 @@ 9874, C5, AMD Radeon R6 Graphics 9874, C6, AMD Radeon R6

[PATCH umr] Support user named VM hubs

Signed-off-by: Tom St Denis --- src/app/main.c | 18 ++ src/lib/read_vram.c | 22 +- src/umr.h | 7 +-- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/src/app/main.c b/src/app/main.c index 0b46643400ba..006727ba7981 100644 -

Re: [PATCH 3/3] drm/amd/powerplay: update didt configs

On Fri, Jul 28, 2017 at 04:01:01PM +0800, Evan Quan wrote: > Change-Id: I1506f4c6e9320a1e90a89be55368328cbaab7844 > Signed-off-by: Evan Quan Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

[PATCH 3/3] drm/amd/powerplay: update didt configs

Change-Id: I1506f4c6e9320a1e90a89be55368328cbaab7844 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerpla

[PATCH] drm/amd/powerplay: add vclk/dclkSoftMin support for raven

Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 9 + drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h | 2 ++ drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 2 ++ drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 7 ++- 4 files changed, 19 insertions(+)

[PATCH 1/3] drm/amdgpu: add psp bootloader command list

Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 10 ++ drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h index 538f

[PATCH 3/3] drm/amdgpu: add psp ecc support for vega10

Disable ecc by default Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++ drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 60 + drivers/gpu/drm/amd/amdgpu/psp_v3_1.h | 2 ++ 3 files changed, 65 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: drop old ip definitions for gfxhub and mmhub

Am 28.07.2017 um 05:41 schrieb Alex Deucher: The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 2 --

Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

Am 28.07.2017 um 03:43 schrieb Alex Deucher: On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use designated initializers") mark other tableFunction entries with designated initializers. The randstruct plugin requires designated in

[PATCH 3/3] drm/amd/powerplay: update didt configs

Change-Id: I1506f4c6e9320a1e90a89be55368328cbaab7844 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerpla

[PATCH 0/3] *** Add PSP ECC support for Vega10 ***

Junwei Zhang (3): drm/amdgpu: add psp bootloader command list drm/amdgpu: add psp ecc support drm/amdgpu: add psp ecc support for vega10 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 20 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 32 + drivers/gpu/drm/amd/amdgpu/psp_v

[PATCH 2/3] drm/amdgpu: add psp ecc support

Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 17 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 22 ++ 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: make wb 256bit function names consistent

Am 27.07.2017 um 22:43 schrieb Alex Deucher: Use a lower case b to be consistent with the other wb functions. Signed-off-by: Alex Deucher I still suggest to get rid of all those variants and always allocate 256bits, but anyway the patch is Reviewed-by: Christian König . --- drivers/gpu

Re: [PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

Am 27.07.2017 um 21:48 schrieb Yong Zhao: We achieved that by setting S(SYSTEM) and P(PDE as PTE) bit to 1 for PDEs and setting S bit to 1 for PTEs when the corresponding addresses are not occupied by gpu driver allocated buffers. Change-Id: I52e41b6e93243dbbd08d97781da1c9a60ce1f9a4 Signed-off-b

Re: [PATCH 1/2] drm/amdgpu: Add a parameter to amdgpu_bo_create()

Am 27.07.2017 um 21:48 schrieb Yong Zhao: The parameter init_value contains the value to which we initialized VRAM bo when AMDGPU_GEM_CREATE_VRAM_CLEARED flag is set. Change-Id: I9ef3b9dd3ca9b98cc25dd2eaff68fbe1129c3e3c Signed-off-by: Yong Zhao I'm about to push a cleanup which removes a bunc

Re: [PATCH 1/5] drm/amdgpu/sdma4: drop unused register header

Am 27.07.2017 um 21:46 schrieb Alex Deucher: nbio registers are not used in this file. Cc: Frank Min Signed-off-by: Alex Deucher Patches #1 and #3-#5 are Reviewed-by: Christian König . I agree with Felix that #2 looks a bit ugly, but using writeq doesn't sounds like the correct answer ei

Re: [PATCH 2/5] drm/amdgpu/sdma4: set wptr shadow atomically

Am 27.07.2017 um 22:50 schrieb Alex Deucher: On Thu, Jul 27, 2017 at 4:39 PM, Felix Kuehling wrote: On 17-07-27 03:46 PM, Alex Deucher wrote: No functional change until wptr polling uses this location (future patch). Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu

RE: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

Oops, the changes were made by a remote windows editor which added the executable bit wrongly. Thanks for the remind. Will pay attention to it. Regards, Evan >-Original Message- >From: Michel Dänzer [mailto:mic...@daenzer.net] >Sent: Friday, July 28, 2017 4:38 PM >To: Quan, Evan >Cc: amd

Re: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

On Fri, Jul 28, 2017 at 04:00:45PM +0800, Evan Quan wrote: > Change-Id: Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193 > Signed-off-by: Evan Quan Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > mode

Re: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

On 28/07/17 05:00 PM, Evan Quan wrote: > Change-Id: Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > mode change 100644 => 100755 > drivers/gpu/drm/amd

Re: [PATCH 1/3] drm/amdgpu: update vega10 golden setting

On Fri, Jul 28, 2017 at 04:00:28PM +0800, Evan Quan wrote: > Change-Id: I44c22b126824ccb022bf5cefa1d73639ac1a53c7 > Signed-off-by: Evan Quan Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdg

Re: [PATCH] drm/amdgpu: drop old ip definitions for gfxhub and mmhub

On Thu, Jul 27, 2017 at 11:41:07PM -0400, Alex Deucher wrote: > The gfxhub and mmhub code are now helpers for gmc rather > than standalone IPs. When that changes these were left > over. Remove them. > > Signed-off-by: Alex Deucher Acked-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/gfxhu

[PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

Change-Id: Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c diff --git a/drive

[PATCH 1/3] drm/amdgpu: update vega10 golden setting

Change-Id: I44c22b126824ccb022bf5cefa1d73639ac1a53c7 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 49de169..85fead0 100644 --- a/drivers/