Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Gerd Hoffmann
Hi, > > That is done using the RADEON_TILING_SWAP_{16,32}BIT flag mentioned in > > another thread? > > Right. > > > > What about dumb bos? You've mentioned the swap flag isn't used for > > those. Which implies they are in little endian byte order (both gpu and > > cpu view). > > Right, AFA

Re: [PATCH 5/6] drm/amdgpu: implement grab reserved vmid V3

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/27/2017 01:00 PM, Chunming Zhou wrote: v2: move sync waiting only when flush needs v3: fix racy Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 72 -- 1 file changed, 68 inser

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v4

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/27/2017 01:00 PM, Chunming Zhou wrote: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub v4: fix racy condition Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 62

[PATCH 5/6] drm/amdgpu: implement grab reserved vmid V3

2017-04-26 Thread Chunming Zhou
v2: move sync waiting only when flush needs v3: fix racy Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 72 -- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH 6/6] drm/amdgpu: bump module verion for reserved vmid

2017-04-26 Thread Chunming Zhou
Change-Id: I1065e0430ed44f7ee6c29214b72e35a7343ea02b Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 55322b4..679

[PATCH 4/6] drm/amdgpu: add limitation for dedicated vm number v4

2017-04-26 Thread Chunming Zhou
v2: move #define to amdgpu_vm.h v3: move reserved vmid counter to id_manager, and increase counter before allocating vmid v4: rename to reserved_vmid_num Change-Id: Ie5958cf6dbdc1c8278e61d9158483472d6f5c6e3 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 + dr

[PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v4

2017-04-26 Thread Chunming Zhou
add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub v4: fix racy condition Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 62 +++--- 1 file changed, 49 insertions(+), 13

[PATCH 2/6] drm/amdgpu: add reserved vmid field in vm struct v2

2017-04-26 Thread Chunming Zhou
v2: rename dedicated_vmid to reserved_vmid Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 ++ 2 files changed, 18 insertions(+), 1 deletion(-) diff -

[PATCH 0/6 v4] *** Dedicated vmid per process v4 ***

2017-04-26 Thread Chunming Zhou
The current kernel implementation, which grabs the idle VMID from pool when emitting the job may: The back-to-back submission from one process could use different VMID. The submission to different queues from single process could use different VMID It works well in most case but cannot

[PATCH 1/6] drm/amdgpu: add vm ioctl

2017-04-26 Thread Chunming Zhou
It will be used for reserving vmid. Change-Id: Ib7169ea999690c8e82d0dcbccdd2d97760c0270a Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + include/uapi/

Re: [PATCH 5/6] drm/amdgpu: implement grab dedicated vmid V2

2017-04-26 Thread zhoucm1
On 2017年04月27日 10:52, Zhang, Jerry (Junwei) wrote: On 04/26/2017 07:10 PM, Chunming Zhou wrote: v2: move sync waiting only when flush needs Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 +++

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread zhoucm1
On 2017年04月27日 10:24, Zhang, Jerry (Junwei) wrote: On 04/27/2017 10:13 AM, zhoucm1 wrote: On 2017年04月26日 20:26, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b71

Re: [PATCH 5/6] drm/amdgpu: implement grab dedicated vmid V2

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/26/2017 07:10 PM, Chunming Zhou wrote: v2: move sync waiting only when flush needs Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 ++ 1 file changed, 61 insertions(+) dif

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/27/2017 10:13 AM, zhoucm1 wrote: On 2017年04月26日 20:26, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- dr

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/26/2017 08:26 PM, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread zhoucm1
On 2017年04月26日 20:26, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Michel Dänzer
On 26/04/17 09:11 PM, Gerd Hoffmann wrote: > Hi, > Just to reiterate, this won't work for the radeon driver, which programs the GPU to use (effectively, per the current definition that these are little endian GPU formats) DRM_FORMAT_XRGB with pre-R600 and DRM_FORMAT_BGRX8

Re: [PATCH 1/2] drm/radeon: Avoid overflows/divide-by-zero in latency_watermark calculations.

2017-04-26 Thread Alex Deucher
On Sun, Apr 23, 2017 at 7:33 PM, Mario Kleiner wrote: > At dot clocks > approx. 250 Mhz, some of these calcs will overflow and > cause miscalculation of latency watermarks, and for some overflows also > divide-by-zero driver crash. Make calcs more overflow resistant. > > This is a direct port of t

Re: [PATCH 1/2] drm/amdgpu: Add missing lb_vblank_lead_lines setup to DCE-6 path.

2017-04-26 Thread Alex Deucher
On Sun, Apr 23, 2017 at 7:02 PM, Mario Kleiner wrote: > This apparently got lost when implementing the new DCE-6 support > and would cause failures in pageflip scheduling and timestamping. > > Signed-off-by: Mario Kleiner > Cc: Alex Deucher > Cc: sta...@vger.kernel.org Applied. thanks! Alex

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-26 Thread Felix Kuehling
On 17-04-25 02:28 AM, Michel Dänzer wrote: > On 22/04/17 02:05 AM, Felix Kuehling wrote: >> __setup doesn't work in modules. > Right. We could build something like > drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to > handle this, but it's a bit ugly, which is one reason why I

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

2017-04-26 Thread Alex Xie
Hi, I knew this is part of ioctl. And I intended to fix this interruptible waiting in an ioctl. ioctl is one of driver interfaces, where interruptible waiting is good in some scenarios. For example, if ioctl performs IO operations in atomic way, we don't want ioctl to be interrupted by a sig

Re: [PATCH] Improve pipe split between amdgpu and amdkfd v4

2017-04-26 Thread Andres Rodriguez
Thanks for taking the time with the multiple iterations of the series! Regards, Andres On Wed, Apr 26, 2017 at 12:54 PM, Oded Gabbay wrote: > On Wed, Apr 26, 2017 at 6:50 PM, Andres Rodriguez wrote: >> Hey Oded, >> >> Let us know if you can reproduce the kfdtest results on your side. >> >> Rega

Re: [PATCH] Improve pipe split between amdgpu and amdkfd v4

2017-04-26 Thread Oded Gabbay
On Wed, Apr 26, 2017 at 6:50 PM, Andres Rodriguez wrote: > Hey Oded, > > Let us know if you can reproduce the kfdtest results on your side. > > Regards, > Andres > > Hi Andres, I run the kfdtest on your patch-set with KAVERI machine, and all the tests passed :) I've also gone over your code and i

RE: [PATCH] drm/amdgpu: remove unused and mostly unimplemented CGS functions

2017-04-26 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Wednesday, April 26, 2017 9:14 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: remove unused and mostly unimplemented > CGS functions > > From: C

RE: [PATCH] drm/amdgpu:fix get wrong gfx always on cu masks.

2017-04-26 Thread Deucher, Alexander
> -Original Message- > From: Deucher, Alexander > Sent: Wednesday, April 26, 2017 12:11 PM > To: Zhu, Rex; amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: RE: [PATCH] drm/amdgpu:fix get wrong gfx always on cu masks. > > > -Original Message- > > From: amd-gfx [mailto:amd-gfx

RE: [PATCH] drm/amdgpu:fix get wrong gfx always on cu masks.

2017-04-26 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, April 26, 2017 4:36 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amdgpu:fix get wrong gfx always on cu masks. > > Change-Id: I46d7f2

Re: [PATCH] Improve pipe split between amdgpu and amdkfd v4

2017-04-26 Thread Andres Rodriguez
Hey Oded, Let us know if you can reproduce the kfdtest results on your side. Regards, Andres On 2017-04-21 04:02 PM, Andres Rodriguez wrote: V4 updates: * Rebased onto latest 4.12-wip (ba16d6c), since I got test reports that the patch series failed to apply V3 updates: * Fixed kfd set re

Re: [rfc] drm sync objects (search for spock)

2017-04-26 Thread Christian König
Am 26.04.2017 um 11:57 schrieb Dave Airlie: On 26 April 2017 at 18:45, Christian König wrote: Am 26.04.2017 um 05:28 schrieb Dave Airlie: Okay I've gone around the sun with these a few times, and pretty much implemented what I said last week. This is pretty much a complete revamp. 1. sync ob

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Ville Syrjälä
On Wed, Apr 26, 2017 at 11:00:09AM +0900, Michel Dänzer wrote: > On 25/04/17 06:52 PM, Ville Syrjälä wrote: > > On Tue, Apr 25, 2017 at 12:18:52PM +0900, Michel Dänzer wrote: > >> On 24/04/17 03:25 PM, Gerd Hoffmann wrote: > >>> +#ifdef __BIG_ENDIAN > >>> + switch (bpp) { > >>> + case 8: > >>> +

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Gerd Hoffmann
> uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth) > { > uint32_t fmt; > #ifdef __BIG_ENDIAN > enum { LITTLE_ENDIAN = 0 }; > #else > enum { LITTLE_ENDIAN = 1 }; > #endif > /* ... */ > > (using an enum for

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Eric Engestrom
On Wednesday, 2017-04-26 07:53:10 +0200, Gerd Hoffmann wrote: > On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote: > > On 24/04/17 03:25 PM, Gerd Hoffmann wrote: > > > Return correct fourcc codes on bigendian. Drivers must be adapted to > > > this change. > > > > > > Signed-off-by: Gerd Hoffm

[PATCH] drm/amdgpu: remove unused and mostly unimplemented CGS functions

2017-04-26 Thread Christian König
From: Christian König Those functions are all unused and some not even implemented. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 233 drivers/gpu/drm/amd/include/cgs_common.h | 303 --- 2 files changed, 536 d

Re: [PATCH 5/6] drm/amdgpu: implement grab dedicated vmid V2

2017-04-26 Thread Christian König
Am 26.04.2017 um 13:10 schrieb Chunming Zhou: v2: move sync waiting only when flush needs Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 ++ 1 file changed, 61 insertions(+) di

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread Christian König
Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 70 +++--- 1 file ch

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Gerd Hoffmann
Hi, > >> Just to reiterate, this won't work for the radeon driver, which programs > >> the GPU to use (effectively, per the current definition that these are > >> little endian GPU formats) DRM_FORMAT_XRGB with pre-R600 and > >> DRM_FORMAT_BGRX with >= R600. > > > > Hmm, ok, how does bi

[PATCH 6/6] drm/amdgpu: bump module verion for reserved vmid

2017-04-26 Thread Chunming Zhou
Change-Id: I1065e0430ed44f7ee6c29214b72e35a7343ea02b Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 55322b4..679

[PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

2017-04-26 Thread Chunming Zhou
add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 70 +++--- 1 file changed, 57 insertions(+), 13 deletions(-) diff --g

[PATCH 4/6] drm/amdgpu: add limitation for dedicated vm number v3

2017-04-26 Thread Chunming Zhou
v2: move #define to amdgpu_vm.h v3: move reserved vmid counter to id_manager, and increase counter before allocating vmid Change-Id: Ie5958cf6dbdc1c8278e61d9158483472d6f5c6e3 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_v

[PATCH 5/6] drm/amdgpu: implement grab dedicated vmid V2

2017-04-26 Thread Chunming Zhou
v2: move sync waiting only when flush needs Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 1/6] drm/amdgpu: add vm ioctl

2017-04-26 Thread Chunming Zhou
It will be used for reserving vmid. Change-Id: Ib7169ea999690c8e82d0dcbccdd2d97760c0270a Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + include/uapi/

[PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread Chunming Zhou
Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 ++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.

[PATCH 0/6 v3] *** Dedicated vmid per process v3 ***

2017-04-26 Thread Chunming Zhou
*** BLURB HERE *** The current kernel implementation, which grabs the idle VMID from pool when emitting the job may: The back-to-back submission from one process could use different VMID. The submission to different queues from single process could use different VMID It works well in mo

Re: [rfc] drm sync objects (search for spock)

2017-04-26 Thread Dave Airlie
On 26 April 2017 at 18:45, Christian König wrote: > Am 26.04.2017 um 05:28 schrieb Dave Airlie: >> >> Okay I've gone around the sun with these a few times, and >> pretty much implemented what I said last week. >> >> This is pretty much a complete revamp. >> >> 1. sync objects are self contained dr

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread zhoucm1
On 2017年04月26日 17:45, Christian König wrote: Am 26.04.2017 um 11:14 schrieb zhoucm1: On 2017年04月26日 17:10, Christian König wrote: Am 26.04.2017 um 11:05 schrieb zhoucm1: On 2017年04月26日 16:49, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread Christian König
Am 26.04.2017 um 11:14 schrieb zhoucm1: On 2017年04月26日 17:10, Christian König wrote: Am 26.04.2017 um 11:05 schrieb zhoucm1: On 2017年04月26日 16:49, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Michel Dänzer
On 26/04/17 02:53 PM, Gerd Hoffmann wrote: > On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote: >> On 24/04/17 03:25 PM, Gerd Hoffmann wrote: >>> Return correct fourcc codes on bigendian. Drivers must be adapted to >>> this change. >>> >>> Signed-off-by: Gerd Hoffmann >> >> Just to reiterate,

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread zhoucm1
On 2017年04月26日 17:10, Christian König wrote: Am 26.04.2017 um 11:05 schrieb zhoucm1: On 2017年04月26日 16:49, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-26 Thread Michel Dänzer
On 26/04/17 03:06 AM, Nicolai Hähnle wrote: > On 25.04.2017 08:28, Michel Dänzer wrote: >> On 22/04/17 02:05 AM, Felix Kuehling wrote: >> >> So, I'm starting to think we need a shared module for this, which >> provides one or multiple module parameters to choose which driver to use >> for CIK/SI[0]

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread Christian König
Am 26.04.2017 um 11:05 schrieb zhoucm1: On 2017年04月26日 16:49, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

2017-04-26 Thread Christian König
Am 26.04.2017 um 11:04 schrieb Zhang, Jerry (Junwei): On 04/26/2017 04:51 PM, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- dri

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread zhoucm1
On 2017年04月26日 16:49, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/26/2017 04:51 PM, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 56 ++

Re: [PATCH 4/6] drm/amdgpu: add limitation for dedicated vm number v2

2017-04-26 Thread Christian König
Am 26.04.2017 um 09:10 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: v2: move #define to amdgpu_vm.h Change-Id: Ie5958cf6dbdc1c8278e61d9158483472d6f5c6e3 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdg

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

2017-04-26 Thread Christian König
Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 56 ++ 1 file changed, 56 inse

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread Christian König
Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2

[PATCH] drm/amdgpu:fix get wrong gfx always on cu masks.

2017-04-26 Thread Rex Zhu
Change-Id: I46d7f2531eaec8135ccaf64b5ce8abc433c54e1a Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 10 -- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 10 -- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 -- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- 4 f

Re: [PATCH 1/6] drm/amdgpu: add vm ioctl

2017-04-26 Thread Christian König
Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: It will be used for reserving vmid. Change-Id: Ib7169ea999690c8e82d0dcbccdd2d97760c0270a Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/am

Re: [rfc] drm sync objects (search for spock)

2017-04-26 Thread Christian König
Am 26.04.2017 um 05:28 schrieb Dave Airlie: Okay I've gone around the sun with these a few times, and pretty much implemented what I said last week. This is pretty much a complete revamp. 1. sync objects are self contained drm objects, they have a file reference so can be passed between process

Re: [PATCH 1/2] drm/amdgpu: Fix use of interruptible waiting

2017-04-26 Thread Christian König
Am 25.04.2017 um 23:25 schrieb Alex Xie: There is no good mechanism to handle the corresponding error. When signal interrupt happens, unpin is not called. As a result, inside AMDGPU, the statistic of pin size will be wrong. Change-Id: I4a06a227c2757c447cec0058ace4b028553658a2 Signed-off-by: Alex

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

2017-04-26 Thread Christian König
Am 26.04.2017 um 03:17 schrieb Michel Dänzer: On 26/04/17 06:25 AM, Alex Xie wrote: 1. The wait is short. There is not much benefit by interruptible waiting. 2. In this function and caller functions, the error handling for such interrupt is complicated and risky. Change-Id: I289674ecd3f5ef20c93

Re: [PATCH] drm/amdgpu: Fix use of interruptible waiting

2017-04-26 Thread Christian König
Am 25.04.2017 um 21:32 schrieb Alex Xie: Either in cgs functions or for callers of cgs functions: 1. The signal interrupt can affect the expected behaviour 2. There is no good mechanism to handle the corresponding error 3. There is no chance of deadlock in these single BO waiting 4. There is no c

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 ++ 2 files changed, 18 insertions(+), 1 deletion(-)

Re: [PATCH 4/6] drm/amdgpu: add limitation for dedicated vm number v2

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/24/2017 01:57 PM, Chunming Zhou wrote: v2: move #define to amdgpu_vm.h Change-Id: Ie5958cf6dbdc1c8278e61d9158483472d6f5c6e3 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH 1/6] drm/amdgpu: add vm ioctl

2017-04-26 Thread Zhang, Jerry (Junwei)
On 04/24/2017 01:57 PM, Chunming Zhou wrote: It will be used for reserving vmid. Change-Id: Ib7169ea999690c8e82d0dcbccdd2d97760c0270a Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 16 drivers/gpu/d