Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Flora Cui
On Wed, Sep 21, 2016 at 09:54:04AM +0800, zhoucm1 wrote: > > > On 2016年09月20日 19:40, Christian König wrote: > >Am 20.09.2016 um 13:16 schrieb Flora Cui: > >>Does this change make sense? > > > >Yes, exactly. Patch is Reviewed-by: Christian König > >. > Hi Flora, > Does this change work? > > if (&

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread zhoucm1
On 2016年09月20日 19:40, Christian König wrote: Am 20.09.2016 um 13:16 schrieb Flora Cui: Does this change make sense? Yes, exactly. Patch is Reviewed-by: Christian König . Hi Flora, Does this change work? if (&tbo->mem == mem) this checking seems always be false, right? Regards, David Zhou

RE: [PATCH xf86-video-ati] Only define transform_region function for XF86_CRTC_VERSION >= 4

2016-09-20 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Tuesday, September 20, 2016 5:03 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati] Only define transform_region function for > XF86_CRTC_VERSION >=

RE: [PATCH xf86-video-ati] Use local implementation of RegionDuplicate for older xserver

2016-09-20 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Tuesday, September 20, 2016 5:04 AM > To: amd-gfx@lists.freedesktop.org > Cc: Pali Rohár > Subject: [PATCH xf86-video-ati] Use local implementation of RegionDuplicate > f

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

2016-09-20 Thread Alex Deucher
On Tue, Sep 20, 2016 at 9:10 AM, Christian König wrote: > Am 20.09.2016 um 06:05 schrieb Deucher, Alexander: >>> >>> -Original Message- >>> From: Michel Dänzer [mailto:mic...@daenzer.net] >>> Sent: Monday, September 19, 2016 10:37 PM >>> To: Huang, Ray; Deucher, Alexander >>> Cc: amd-gfx@l

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

2016-09-20 Thread Christian König
Am 20.09.2016 um 06:05 schrieb Deucher, Alexander: -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Monday, September 19, 2016 10:37 PM To: Huang, Ray; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; Wang, Ken; Huan, Alvin Subject: Re: [PATCH 0/3] drm/amdgpu:

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Flora Cui
we need this fix for urgent promotion. so please please reply me asap. On Tue, Sep 20, 2016 at 01:02:20PM +0200, Christian König wrote: > Am 20.09.2016 um 12:41 schrieb Flora Cui: > >On Tue, Sep 20, 2016 at 06:19:33PM +0800, zhoucm1 wrote: > >> > >>On 2016年09月20日 17:09, Flora Cui wrote: > >>>Chang

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Christian König
Am 20.09.2016 um 13:16 schrieb Flora Cui: Does this change make sense? Yes, exactly. Patch is Reviewed-by: Christian König . But please be aware that there is at least one other bug I'm currently investigating. Regards, Christian. On Tue, Sep 20, 2016 at 01:02:20PM +0200, Christian Kön

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Flora Cui
Does this change make sense? On Tue, Sep 20, 2016 at 01:02:20PM +0200, Christian König wrote: > Am 20.09.2016 um 12:41 schrieb Flora Cui: > >On Tue, Sep 20, 2016 at 06:19:33PM +0800, zhoucm1 wrote: > >> > >>On 2016年09月20日 17:09, Flora Cui wrote: > >>>Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Christian König
Am 20.09.2016 um 12:41 schrieb Flora Cui: On Tue, Sep 20, 2016 at 06:19:33PM +0800, zhoucm1 wrote: On 2016年09月20日 17:09, Flora Cui wrote: Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- 1 file changed,

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Christian König
Am 20.09.2016 um 12:19 schrieb zhoucm1: On 2016年09月20日 17:09, Flora Cui wrote: Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Flora Cui
On Tue, Sep 20, 2016 at 06:19:33PM +0800, zhoucm1 wrote: > > > On 2016年09月20日 17:09, Flora Cui wrote: > >Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609 > >Signed-off-by: Flora Cui > >--- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread zhoucm1
On 2016年09月20日 17:09, Flora Cui wrote: Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers

[PATCH] drm/amdgpu: fix gtt_mgr bo's offset

2016-09-20 Thread Flora Cui
Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c index 26

[PATCH xf86-video-ati] Use local implementation of RegionDuplicate for older xserver

2016-09-20 Thread Michel Dänzer
From: Michel Dänzer It was only added in xserver 1.15. Fixes build against older xserver. Reported-by: Pali Rohár Signed-off-by: Michel Dänzer --- configure.ac | 6 ++ src/radeon.h | 19 +++ 2 files changed, 25 insertions(+) diff --git a/configure.ac b/configure.ac index

[PATCH xf86-video-ati] Only define transform_region function for XF86_CRTC_VERSION >= 4

2016-09-20 Thread Michel Dänzer
From: Michel Dänzer We're not using it with older xserver. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 4 1 file changed, 4 insertions(+) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index 9bcf657..0d61d49 100644 --- a/src/radeon_kms.c +++ b/src/radeon_kms.c @@ -402,6 +402,8