RE: [PATCH] drm/amdgpu:implement CONTEXT_CONTROL (v3)

2016-09-04 Thread Liu, Monk
Okay, just put it simple The approach my patch provided is absolutely correct, and I'm pretty sure of it, otherwise our close OGL UMD & windows d3d game already crashed for million times. First of all: Move CONTEXT_CONTROL into RB is a must and the correct thing, and this is not a questionable

RE: [PATCH] drm/amdgpu:implement CONTEXT_CONTROL (v3)

2016-09-04 Thread Liu, Monk
Ping again. If no one can give a proposal of a better solution, I'll use my way and push the patch. Repeat again: original design is incorrect (DE preamble part is not covered by Preamble_flag at all), besides it doesn't support virtualization. If anybody reject patches, please give a proposal

Re: [PATCH] amd/powerplay: use kmemdup instead of kmalloc + memcpy

2016-09-04 Thread Christian König
Am 04.09.2016 um 04:36 schrieb Edward O'Callaghan: Save a few clocks by replacing calls to kmalloc followed by memcpy with a single call to kmemdup. Signed-off-by: Edward O'Callaghan Reviewed-by: Christian König . --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 9 +++-- 1 file ch