[PATCH] drm/amd/amdgpu: S4 issue for amdgpu

2016-08-31 Thread jimqu
reset the asic if adapter is not powerdown when doing freeze() thaw() and restore(), in order to get a valid state of adapter. Change-Id: Id2e4587c06b556eb651ab9277ffc903f780dea56 Signed-off-by: JimQu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 +-- drivers/gpu/drm/am

Re: AMD and free and open source software

2016-08-31 Thread Michel Dänzer
On 01/09/16 11:25 AM, Bridgman, John wrote: > One suggestion that was made recently was for AMD to supply packages > containing only HW microcode images for AMD GPUs... The microcode images for AMD GPUs have already been split out into a separate firmware-amd-graphics package in Debian sid (and pr

RE: AMD and free and open source software

2016-08-31 Thread Bridgman, John
Right... the microcode is part of the HW design; some vendors build the microcode images into the chip, while others have the BIOS or driver load them at start-up. The industry is generally moving to driver-loaded microcode, but I don't believe any vendor is planning to start opening up their

RE: AMD and free and open source software

2016-08-31 Thread Bridgman, John
One suggestion that was made recently was for AMD to supply packages containing only HW microcode images for AMD GPUs... you would still be using a non-free package but you would not have to enable the entire non-free Debian package that contains both real "firmware" and HW microcode for a numbe

Re: AMD and free and open source software

2016-08-31 Thread Huang Rui
We don't have the plan to open up firmware source. Thanks, Rui On Thu, Sep 01, 2016 at 04:16:59AM +0800, Frederique wrote: > Dear Huang Rui, > > I recently swapped my NVIDIA Geforce 980 Ti for an AMD R9 Fury because > of the devoted efforts that are being made towards a free and open > source

Re: [PATCH 04/10] drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF

2016-08-31 Thread Michel Dänzer
On 01/09/16 07:08 AM, Alex Deucher wrote: > Missed this case previously. No need to do anything if the > device is already off. runtime pm will handle it. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletion

Re: [PATCH 02/10] drm/amdgpu: handle runtime pm correctly in amdgpu_driver_open_kms

2016-08-31 Thread Michel Dänzer
On 01/09/16 07:08 AM, Alex Deucher wrote: > Need to fix the error pathes. Typo? "pathes" > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_k

Re: [PATCH 03/10] drm/amdgpu: handle runtime pm in fbcon

2016-08-31 Thread Michel Dänzer
On 01/09/16 07:08 AM, Alex Deucher wrote: > Ported from nouveau. > > Signed-off-by: Alex Deucher [...] > +static int > +amdgpufb_open(struct fb_info *info, int user) > +{ > + struct amdgpu_fbdev *rfbdev = info->par; > + struct amdgpu_device *adev = rfbdev->adev; > + int ret = pm_run

Re: [PATCH 01/10] drm/amdgpu: handle runtime pm in drm pre/post close

2016-08-31 Thread Michel Dänzer
On 01/09/16 07:08 AM, Alex Deucher wrote: > Close was not handled correctly. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > b/drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 07/10] drm/radeon: handle runtime pm correctly in amdgpu_driver_open_kms

2016-08-31 Thread Alex Deucher
Need to fix the error paths. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_kms.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c index 0252527..4388dde 100644 --- a/driver

[PATCH 01/10] drm/amdgpu: handle runtime pm in drm pre/post close

2016-08-31 Thread Alex Deucher
Close was not handled correctly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index f1b9e0f..45f98b4 100644 --- a/drivers/gpu/drm/

[PATCH 03/10] drm/amdgpu: handle runtime pm in fbcon

2016-08-31 Thread Alex Deucher
Ported from nouveau. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c index 9191467..eaa5dcc 100644 --- a/drivers/

[PATCH 05/10] drm/amdgpu: set runtime pm state to active on resume

2016-08-31 Thread Alex Deucher
The sbios always powers up the dGPU on resume. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 716adb5..3426ae2 100644 ---

[PATCH 04/10] drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF

2016-08-31 Thread Alex Deucher
Missed this case previously. No need to do anything if the device is already off. runtime pm will handle it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev

[PATCH 08/10] drm/radeon: handle runtime pm in fbcon

2016-08-31 Thread Alex Deucher
Ported from nouveau. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_fb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index 0e3143a..1ae32c9 100644 --- a/drivers/gpu/drm/rade

[PATCH 10/10] drm/radeon: set runtime pm state to active on resume

2016-08-31 Thread Alex Deucher
The sbios always powers up the dGPU on resume. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 081e95e..5fdd48c 100644 --- a/drivers/gp

[PATCH 06/10] drm/radeon: handle runtime pm in drm pre/post close

2016-08-31 Thread Alex Deucher
Close was not handled correctly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_kms.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c index 835563c..0252527 100644 --- a/drivers/gpu/drm/radeon/radeo

[PATCH 09/10] drm/radeon: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF

2016-08-31 Thread Alex Deucher
Missed this case previously. No need to do anything if the device is already off. runtime pm will handle it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b

[PATCH 02/10] drm/amdgpu: handle runtime pm correctly in amdgpu_driver_open_kms

2016-08-31 Thread Alex Deucher
Need to fix the error pathes. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 45f98b4..c2c7fb1 10

RE: GPU lockup with amdgpu driver

2016-08-31 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Luya Tshimbalanga > Sent: Wednesday, August 31, 2016 5:46 PM > To: amd-gfx@lists.freedesktop.org > Subject: Re: GPU lockup with amdgpu driver > > -BEGIN PGP SIGNED MESSAGE- > Hash: SH

Re: GPU lockup with amdgpu driver

2016-08-31 Thread Luya Tshimbalanga
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 To reproduce the bug, grab the latest snapshot of linux-firmware 20160816 (git7c3dfc0b). Install latest kernel 4.8.0+ and also staging kernels. GPU lockup happens on boot on both amdgpu and radeon drivers. - -- Luya Tshimbalanga Graphic & Web Desig

RE: [PATCH 4/4] drm/amd/powerplay: read power state table from vbios and can't be changed. so allocate memory for request ps and current ps.

2016-08-31 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, August 31, 2016 5:06 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 4/4] drm/amd/powerplay: read power state table from > vbios and can't be

[PATCH 3/4] drm/amd/powerplay: refine struct name for coding style reason.

2016-08-31 Thread Rex Zhu
delete useless member. Change-Id: I03585fc3476f2954735f487c17dffa668287ad45 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/inc/power_state.h | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/inc/power_state.h b/driv

[PATCH 4/4] drm/amd/powerplay: read power state table from vbios and can't be changed. so allocate memory for request ps and current ps.

2016-08-31 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +- drivers/gpu/drm/amd/powerplay/eventmgr/psm.c | 5 +++-- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 15 +-- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/power

[PATCH 1/4] drm/amd/powerplay: refine struct name for code style reason.

2016-08-31 Thread Rex Zhu
Change-Id: I491a1de273f350a14576c45b2ec986365797dcc0 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 4 ++-- drivers/gpu/drm/amd/powerplay/inc/power_state.h | 2 +- 3 files changed, 4 insertions

[PATCH 2/4] drm/amd/powerplay: add vce state tables initialize for ppt v1.

2016-08-31 Thread Rex Zhu
Change-Id: Ib44bf1c7c1cb71ce619cc4589608e4c049f9db7e Signed-off-by: Rex Zhu --- .../amd/powerplay/hwmgr/tonga_processpptables.c| 58 ++ drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 22 ++-- 2 files changed, 75 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH v2 00/15] drm/amdgpu/si: Make SI DPM workable

2016-08-31 Thread Alex Deucher
On Wed, Aug 31, 2016 at 1:23 AM, Huang Rui wrote: > Hi all, > > These patchest resolve the DPM issues of SI. > SI DPM doesn't work since it implemented, the following patches fix > several issues to make SI DPM workable now. > > Patch 1: Update SI firmware path to share it with radeon > > Patch 2

[pull] amdgpu drm-fixes-4.8

2016-08-31 Thread Alex Deucher
Hi Dave, Fixes for 4.8: - 2 CI S4 fixes - error handling fix I have additional features for 4.9, but I'll be out of the office next week, so I probably won't get to send them out until the following week. The following changes since commit 279cf3f23870f7eb8ca071115e06d3d5ca0a2b9e: drm/nouveau

GPU lockup with amdgpu driver

2016-08-31 Thread Luya Tshimbalanga
Upon recommendation from Phoronix comment, here is the bug report.[1] Updating linux-firmware snapshot from 20160609 (gita4bbc811) to 20160816 (git7c3dfc0b) caused a GPU lockup on enabled amdgpu driver for CIK (Sea Island) card affecting kernel 4.8+ and the staging kernel branches. An example be

RE: [PATCH xf86-video-ati 2/2] Add support for ScreenPtr::SyncSharedPixmap

2016-08-31 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Wednesday, August 31, 2016 4:56 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati 2/2] Add support for > ScreenPtr::SyncSharedPixmap > > From: Mich

Re: [PATCH] drm/amdgpu:implement CONTEXT_CONTROL (v3)

2016-08-31 Thread Christian König
Looks good to me in general, a few nit picks and sugegstions below. Am 31.08.2016 um 05:49 schrieb Monk Liu: v1: for gfx8, use CONTEXT_CONTROL package to dynamically skip preamble CEIB and other load_xxx command in sequence. v2: support GFX7 as well, and bump up version. remove cntxcntl in comp

RE: [PATCH] drm/amdgpu:implement CONTEXT_CONTROL (v3)

2016-08-31 Thread Liu, Monk
If no one object, I'll push the patch tomorrow. Tested with FIJI and BONAIRE locally. BR Monk -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Wednesday, August 31, 2016 11:49 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk

[PATCH xf86-video-ati 2/2] Add support for ScreenPtr::SyncSharedPixmap

2016-08-31 Thread Michel Dänzer
From: Michel Dänzer This allows deferring shared pixmap updates between different drivers. Signed-off-by: Michel Dänzer --- This change requires a corresponding xserver change adding the SyncSharedPixmap field. I'll only push it once the xserver change has landed. src/radeon_kms.c | 43 +

[PATCH xf86-video-ati 1/2] Only copy from screen pixmap to shared pixmap on demand for slave scanout

2016-08-31 Thread Michel Dänzer
From: Michel Dänzer Only copy once for each time we update the corresponding scanout pixmap. This can significantly reduce the bandwidth usage when there are frequent updates to the screen pixmap. This initial implementation only works when both the master and slave screens use this driver. Sig

RE: [PATCH] drm/amd/powerplay: fix issue vce dpm can't be enabled on tonga.

2016-08-31 Thread Zhu, Rex
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, August 30, 2016 5:51 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: fix issue vce dpm can't be enabled on tonga. Am 30.08.20