Re: [PATCH 2/4] amdgpu: add export/import semaphore apis

2016-08-21 Thread zhoucm1
On 2016年08月21日 14:23, Edward O'Callaghan wrote: On 08/18/2016 05:55 PM, Chunming Zhou wrote: They are used for sharing semaphore across process. Change-Id: I262adf10913d365bb93368b492e69140af522c64 Signed-off-by: Chunming Zhou --- amdgpu/amdgpu.h | 40

[PATCH v3 xserver 3/4] modesetting: move common page flip handle to pageflip.c

2016-08-21 Thread Qiang Yu
The common page flip handle framework can be shared with DRI2 page flip. Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/driver.h | 28 hw/xfree86/drivers/modesetting/pageflip.c | 102 -- hw/xfree86/drivers/modesetting/present.c | 63 +++--

[PATCH v3 xserver 2/4] modesetting: move ms_do_pageflip to pageflip.c

2016-08-21 Thread Qiang Yu
Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/Makefile.am | 1 + hw/xfree86/drivers/modesetting/driver.h| 48 ++ hw/xfree86/drivers/modesetting/pageflip.c | 251 hw/xfree86/drivers/modesetting/present.c | 252

[PATCH v3 xserver 1/4] modesetting: make ms_do_pageflip generic for share with DRI2

2016-08-21 Thread Qiang Yu
Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/present.c | 38 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c index 0093fb

[PATCH v3 xserver 4/4] modesetting: add DRI2 page flip support

2016-08-21 Thread Qiang Yu
Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c| 237 ++- hw/xfree86/drivers/modesetting/driver.h | 5 +- hw/xfree86/drivers/modesetting/drmmode_display.h | 3 + hw/xfree86/drivers/modesetting/pageflip.c| 7 +- hw/xfree86/dr

Re: [PATCH 5/6] drm/amdgpu: use fence-array for ctx release

2016-08-21 Thread zhoucm1
On 2016年08月21日 14:42, Edward O'Callaghan wrote: On 08/18/2016 05:50 PM, Chunming Zhou wrote: benifits: 1. don't block userspace release at all. 2. make sure userspace can look up dependency if fence isn't signaled. If they cannot find ctx, that means the dependecy is signaled. Change-Id: I91

[PATCH v3 xserver 0/4] modesetting: add DRI2 page flip support

2016-08-21 Thread Qiang Yu
Hi guys, This patch set is for adding DRI2 page flip support to modesetting driver. I mainly take reference of amdgpu DDX and reuse present page flip code in the modesetting driver. V2: 1. fix DRI2 page flip success handler event memory leak 2. adjust patch sequence to make DRI2 use the common

Re: [PATCH xf86-video-amdgpu] Fix cursor size for SI

2016-08-21 Thread Michel Dänzer
On 19/08/16 07:43 PM, Marek Olšák wrote: > From: Marek Olšák > > This doesn't fix the missing cursor, which seems to be a kernel issue, > because it's missing with modesetting as well. With this sentence removed from the commit log, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer

Re: [PATCH v2 xserver 0/5] modesetting: add DRI2 page flip support

2016-08-21 Thread Michel Dänzer
On 19/08/16 09:50 PM, Qiang Yu wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > V2: > 1. fix DRI2 page flip success handler event memory leak >

Re: [PATCH 0/1] AMDGPU SI support almost fixed

2016-08-21 Thread Dave Airlie
On 19 August 2016 at 19:01, Marek Olšák wrote: > Hi, > > This amdgpu patch fixes DCE support. Now only the cursor is broken: > > [ 37.936022] [drm:dce_v6_0_crtc_cursor_set2 [amdgpu]] *ERROR* bad cursor > width or height 128 x 128 > > Everything else seems to work. I've not tested UVD and VCE. >

Re: [PATCH drm/amdgpu] Use correct mask in dce_v8_0_afmt_setmode() and fix comment typos.

2016-08-21 Thread Edward O'Callaghan
On 08/22/2016 10:38 AM, Alexandre Demers wrote: > We were using the same mask twice. Looking at radeon, it seems > we should be using HDMI_AVI_INFO_CONT instead as the second mask. > > Being there, fix typos in comments and improved readability. > > I haven't looked at other DCEs, the mask may

Re: [PATCH drm/amdgpu] Fix indentation in dce_v8_0_audio_write_sad_regs()

2016-08-21 Thread Edward O'Callaghan
On 08/22/2016 10:38 AM, Alexandre Demers wrote: > Fixed indentation for readability. > > Signed-off-by: Alexandre Demers Reviewed-by: Edward O'Callaghan > --- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drive

[PATCH drm/amdgpu] Use correct mask in dce_v8_0_afmt_setmode() and fix comment typos.

2016-08-21 Thread Alexandre Demers
We were using the same mask twice. Looking at radeon, it seems we should be using HDMI_AVI_INFO_CONT instead as the second mask. Being there, fix typos in comments and improved readability. I haven't looked at other DCEs, the mask may also be wrong for them. Signed-off-by: Alexandre Demers ---

[PATCH drm/amdgpu] Fix indentation in dce_v8_0_audio_write_sad_regs()

2016-08-21 Thread Alexandre Demers
Fixed indentation for readability. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index 3ff1258..c7e5d5f 10

rx480 error messages with 4.8rc2

2016-08-21 Thread Jarkko Korpi
I quess these are rather harmless. [1.533109] amdgpu :01:00.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0x 1.532641] CRAT table not found 1.534583] Can't find requested voltage id in vdd_dep_on_sclk table! But even they all would be harmless I think it's worth t