Re: TODO in our sources - please clean them up

On Mon, Sep 24, 2012 at 2:43 PM, Myriam Schweingruber wrote: > And while you are at it: please also remove uncommented code if you > find some, git can restore any of that if necessary since all is in > the history. s/uncommented/commented out -- Mark Kretschmann Amarok Develope

Review Request: Refactoring of Collection config UI code

ith config. Thanks, Mark Kretschmann ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Refactoring of Collection config UI code

ity of the UI, tested connections with config. Thanks, Mark Kretschmann ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Refactoring of Collection config UI code

ity of the UI, tested connections with config. Thanks, Mark Kretschmann ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Refactoring of Collection config UI code

Oops, I didn't mean to post it three times. The ReviewBoard UI fooled me. -- Mark Kretschmann Amarok Developer, Senior Software Engineer at Nokia Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org - http://noki

Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

already running instance. This is how the "%U" works. Exception: If you run Amarok with the -m or --multipleinstances flag, it will happily start another instance. - Mark Kretschmann On March 5, 2013, 5:02 p.m., Harikrishnan S. wrote: > > ---

Re: Review Request 109295: Improved formatting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109295/#review28650 --- Ship it! Ship It! - Mark Kretschmann On March 5, 2013, 7

Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

> On March 6, 2013, 7:36 a.m., Mark Kretschmann wrote: > > Please don't apply this patch. Here's why: > > > > Amarok is really not supposed to be running more than one instance at the > > same time (it's a "KUniqueApplication"). If you try t

[amarok] src/context/engines/wikipedia: Fix crashes on track change (both with Phonon-GStreamer and Phonon-VLC).

Git commit d13bd61842627ffb2382b5d59a020ea7a5124ca5 by Mark Kretschmann. Committed on 08/05/2013 at 12:29. Pushed by markey into branch 'master'. Fix crashes on track change (both with Phonon-GStreamer and Phonon-VLC). What happened: The Wikipedia applet uses QtWebKit for HTML ren

C++11

specially of popular features like Lambda Functions, which have been implemented for a good while in all common compilers. With GCC and Clang this wouldn't be a problem. I'm not so sure about the Microsoft compiler (Patrick do you know?). -- Mark Kretschmann Amarok Developer Fellow o

Re: [amarok] src/context/engines/wikipedia: Fix crashes on track change (both with Phonon-GStreamer and Phonon-VLC).

and cherry-pick a couple of important bugfixes, then tag as 2.7.1. We only need to release this for Linux (does not affect Windows, AFAICS). -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org _

Re: C++11

On Wed, May 8, 2013 at 3:51 PM, Edward Toroshchin wrote: > On Wed, May 08, 2013 at 02:50:26PM +0200, Mark Kretschmann wrote: >> I'd really like to start using some C++11 features in Amarok. It has been >> argued that only few compilers support all of C++11's features at t

Re: Review Request 110362: BR 317385 - Command line options like --queue and --append do not work

doesn't fix the bug at all. The command line argument issues are just a symptom of the underlying bug, see my comments in the report. I'm debugging this currently. - Mark Kretschmann On May 9, 2013, 5:51 p.m., Anmol A

Re: C++11

;> With some Lambda usage, it becomes a good deal more readable and >> pleasant to work with, and less error prone. This is how it could look >> instead: >> >> From 7cca04eb25169e5befb3e5d6a1290795c3e651b8 Mon Sep 17 00:00:00 2001 >> From: Mark Kretschmann >>

Re: C++11

arlier. > And as it would only be amarok for the beginning that would require c++11 > there would be no harm done to the guis providing Kontact, Calligra etc. Using this nice C++11 compiler support comparison [1], I tried to determine which compiler versions could suffice as a baseline for us, su

Re: Amarok 2.7.1 release considerations

commits cannot add/change i18n strings. It's a micro patch, so why not. Looks completely safe. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: C++11

On Sun, May 12, 2013 at 11:26 AM, Matěj Laitl wrote: > On 10. 5. 2013 Mark Kretschmann wrote: >> Using this nice C++11 compiler support comparison [1], I tried to >> determine which compiler versions could suffice as a baseline for us, >> supporting most of C++11's co

Re: Review Request 110362: BR 317385 - Command line options like --queue and --append do not work

was a misunderstanding, as we know by now. - Mark Kretschmann On May 12, 2013, 1:24 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110101: fixes Bug 242256 - JJ: Make Magnatue service use KWallet for password storage

ore or less a copy of the last.fm Wallet Code. So maybe >>> the GpodderService could also be a Candidate for using this >>> KWalletHelper class ;) >>> >>> Greetings, >>> Stefan >>> -BEGIN PGP SIGNATURE- >>> Version: GnuPG v1.4.12 (

Testing needed for Amarok 2.7.1

-2.7.1.tar.bz2 Nota bene: Amarok 2.7.1 will not compile with the Clang compiler. This is a known issue. Thanks in advance! -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org

Re: Review Request 110498: Add refresh button to FileBrowser

filesystems that support directory watching. - Mark Kretschmann On May 18, 2013, 11:25 a.m., Abhinandan Ramaprasath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110498: Add refresh button to FileBrowser

s bug report: https://bugs.kde.org/show_bug.cgi?id=213666 The arguments are valid. Directory watching does not work with some filesystems like NFS and CIFS. So I agree that this patch is useful. - Mark Kretschmann On May 18, 2013, 11:25 a.m., Abhinandan Ramaprasath

Re: Review Request 108717: nepomuk: implement custom QueryMaker

evel/src/amarok/src/App.cpp:206 #18 0x0040f948 in main (argc=4, argv=0x7fffbaed34b8) at /home/mark/Devel/src/amarok/src/main.cpp:330 - Mark Kretschmann On May 18, 2013, 8:06 p.m., Edward Hades Toroshchin wrote: > > --- &g

Re: Review Request 110520: create new collections without restart

collections immediately when the plugin is being disabled? - Mark Kretschmann On May 19, 2013, 8:43 a.m., Edward Hades Toroshchin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

[amarok] /: Add an audio analyzer visualization applet.

Git commit 0009faab5a60f89c3db59aafb6c000d3642be14f by Mark Kretschmann. Committed on 14/05/2013 at 11:26. Pushed by markey into branch 'master'. Add an audio analyzer visualization applet. The analyzer code itself is lifted from Amarok 1.x and then adapted for our needs. The architect

Re: Review Request 110498: Add refresh button to FileBrowser

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110498/ --- (Updated May 24, 2013, 9:49 a.m.) Status -- This change has been mark

[amarok] src/context: Add analyzer applet to the user's existing config.

Git commit 7f7de7db91c6d544785f89613843dbc361195c76 by Mark Kretschmann. Committed on 24/05/2013 at 19:56. Pushed by markey into branch 'master'. Add analyzer applet to the user's existing config. This trickery is needed to give the new analyzer applet some visibility when upgr

Re: Amarok 3 architecture brainstorm (was: GSoC considerations)

opinion on that matter. > Guys? > > I'd like to start hacking on this at Akademy, are you attending? (not much > sooner because there are more important things on my TODO list for 2.8) I'm interested, but like Matej I first want to finish my TODO for 2.8. I think we sho

[amarok] /: Add OpenGL analyzers, and make analyzers configurable (right-click).

Git commit 7c139193a4fcb74a0a3cfdddbe85a3c1168f0de0 by Mark Kretschmann. Committed on 26/05/2013 at 10:49. Pushed by markey into branch 'master'. Add OpenGL analyzers, and make analyzers configurable (right-click). I've ported two OpenGL analyzers from Amarok 1.x. One of them

Re: Please subscribe to http://fisheye.amarok.kde.org/

de review tool that we can evaluate. Both are from Atlassian, makers of web-based development tools that are often considered the best in their class. Myriam took the effort to get a free license from Atlassian for us, last night. Don't be so uptight, Matej :p -- Mark Kretschmann Amarok Devel

Help needed with ContextView

the applet is on the viewport or not. So the analyzer is painted above the other applet. How can I determine if a context applet is currently on the viewport? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.o

Re: Help needed with ContextView

On Sun, Jun 2, 2013 at 9:19 PM, Mark Kretschmann wrote: > How can I determine if a context applet is currently on the viewport? Ok, it's fixed. Turns out it was super simple. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.or

Splash Screen

time has become so fast (except for Gimp or OpenOffice maybe) that they no longer make sense. Thoughts? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing

[amarok] src: Remove options for features that are no longer implemented.

Git commit 81e5809f62aaf0a145a407df2eed62502577012d by Mark Kretschmann. Committed on 17/06/2013 at 19:01. Pushed by markey into branch 'master'. Remove options for features that are no longer implemented. * Crossfading (code had no effect at all, and there was no GUI option) * Track

[amarok] src: Remove "Configure Amarok" item from the systray menu.

Git commit 8490f7c2b470834e19a1a7f7bad7113c1e7dd5ef by Mark Kretschmann. Committed on 17/06/2013 at 20:16. Pushed by markey into branch 'master'. Remove "Configure Amarok" item from the systray menu. In a recent discussion on IRC, we agreed that having the configure item i

Re: Resume from pause is broken

On Mon, Jun 17, 2013 at 9:33 PM, Mathias Panzenböck wrote: > Is it a know bug that today's git version cannot resume from pause anymore > or should I write a bugreport? How do you mean resume from pause? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation

Re: Resume from pause is broken

On Mon, Jun 17, 2013 at 10:51 PM, Mathias Panzenböck wrote: > When I pause, "unpausing" does not work. I have to close amarok and start it > again in order to get it > playing again. Works just fine here. Are you sure that nothing else in your system changed? -- Mark

Re: Resume from pause is broken

nd likely. On the other hand, there was only one small change to EngineController yesterday, which couldn't really influence pausing/unpausing. To make sure, try this: git reset --hard 38cc39940d473d9c2d7666f5aebe4226c48c6c23 -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foun

[amarok] /: Volume fadeout is now also available for pause.

Git commit 6d2addeba3847d773f80531e6b8048e2a774ee49 by Mark Kretschmann. Committed on 18/06/2013 at 12:08. Pushed by markey into branch 'master'. Volume fadeout is now also available for pause. We had fadeout on stop before, but as Amarok uses pause instead of stop in its default con

Re: Review Request 111212: Kill long running scripts

? - Mark Kretschmann On June 24, 2013, 10:40 a.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111212: Kill long running scripts

hink anyone could tell what impact this has. - Mark Kretschmann On June 24, 2013, 10:40 a.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request 111212: Kill long running scripts

g/r/111212/#comment25679> Please do actually remove the options, including the GUI for them too. - Mark Kretschmann On June 25, 2013, 1:49 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply

Static code analysis available

scans for open source projects. To get access, create an account on the following site, and then simply click "Add Project", and then "Amarok": http://scan.coverity.com/ -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.o

Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

an earlier Amarok version, but it got lost at some point :) Do you have push rights for kde git, or should we push it for you? - Mark Kretschmann On June 27, 2013, 7:48 p.m., fleissig fleissig wrote: > > --- > This is an auto

Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

> On June 28, 2013, 4:59 p.m., Mark Kretschmann wrote: > > Nice patch! I recall we used to have this feature in an earlier Amarok > > version, but it got lost at some point :) > > > > Do you have push rights for kde git, or should we push it for you? > > fleis

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

llectionScript.cpp <http://git.reviewboard.kde.org/r/111343/#comment25957> Use the KDE_DEPRECATED macro src/scriptengine/ScriptingDefines.h <http://git.reviewboard.kde.org/r/111343/#comment25960> Better variable name please - Mark Kretschmann On July 1,

Re: Review Request 110934: Adds a Offline Mode to Amarok i.e. fixes Bug 229111

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110934/ --- (Updated July 2, 2013, 10:29 a.m.) Status -- This change has been dis

Re: Review Request 110036: WIP - Simple equalizer scripting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/#review35437 --- test, ignore - Mark Kretschmann On April 18, 2013, 8:03 a.m

[amarok] src/scriptengine: Add another missing include.

Git commit 19f67b09ff29b6339e02f2646b4ab14378159231 by Mark Kretschmann. Committed on 06/07/2013 at 20:29. Pushed by markey into branch 'master'. Add another missing include. How can this code compile in some situations, and in others it doesn't? CCMAIL: amarok-devel@kde.org M

Unifying singleton accessors

equires extra boilerplate code. Can we get rid of "The::myObject()" and standardize on "instance()"? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Am

Missing QStringList includes

file. And so on. What witchery is this? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/a

[amarok] /: Make OpenGL (and thus the analyzer applet) an optional dependency.

Git commit 3c4a6f324aef29c08bc1d5222f5dd2adc1dd4f8d by Mark Kretschmann. Committed on 09/07/2013 at 13:53. Pushed by markey into branch 'master'. Make OpenGL (and thus the analyzer applet) an optional dependency. Kubuntu packagers have informed me that OpenGL support is not yet readily

[amarok] /: Bump Qt dependency to version 4.8.3.

Git commit fa427c64a042b47135f7ecf0010be4f477f0e12c by Mark Kretschmann. Committed on 11/07/2013 at 09:00. Pushed by markey into branch 'master'. Bump Qt dependency to version 4.8.3. The rationale is that Qt 4.8.3 fixed the crash bug in QtScript that made Amarok almost impossible to us

Re: Review Request 111512: MPRIS2: avoid updating Metadata when between tracks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111512/#review35986 --- Ship it! Looking good, please push to master. - Mark

Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs

gh if FindFFMpeg.cmake is also included in KDE 4.8, which we still support. - Mark Kretschmann On July 15, 2013, 1:18 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111510/#review36018 --- Ship it! Ship It! - Mark Kretschmann On July 15, 2013, 1

Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add

/playlist/PlaylistController.cpp:231: error: use of undeclared identifier 'StartPlay' - Mark Kretschmann On July 21, 2013, 9:16 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add

ttp://git.reviewboard.kde.org/r/111635/#comment26908> The tooltip is too long, I think. In Amarok it is shown as one extremely long line. As QToolTip supports Rich Text, it might be better to break it up into paragraphs. - Mark Kretschmann On July 24, 2013, 2:41 p.m., Matěj Laitl

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36526 --- Ship it! Ship It! - Mark Kretschmann On July 24, 2013, 2

Re: Need a mentor for an SoK idea

ve mentors for SoK and > about how many SoK projects will be hosted by Amarok. I can mentor you. Would you like that? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amar

Re: SoK idea

us mailing list of course), and the developers that are online at a given time usually help out the others. So it's not that much of a problem I would think. If you are generally ok with that, we could go ahead with your proposal. -- Mark Kretschmann Amarok Developer Fellow of the Free Softwa

Re: SoK idea

lection framework. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Triggering Copy to Collection from within a Service

same feature for the Download function as well, but of course I'd rather do it without duplicating the code. Can I trigger Copy to Collection from within the service in a clean way? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http

Re: Review Request 111991: Better handling of non-writeable UMS collections

<http://git.reviewboard.kde.org/r/111991/#comment27707> As per KDE HIG, please don't use contractions in user visible strings. src/core-impl/collections/umscollection/UmsCollectionLocation.cpp <http://git.reviewboard.kde.org/r/111991/#comment27708> Make this const,

Re: Review Request 111991: Better handling of non-writeable UMS collections

n the actual writing failed? - Mark Kretschmann On Aug. 10, 2013, 4:44 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 111991: Better handling of non-writeable UMS collections

> On Aug. 10, 2013, 7:26 p.m., Mark Kretschmann wrote: > > I'm not so sure about the warning that is shown when an unwritable UMS > > collection is loaded. First of all it seems to me this would belong on a > > higher level, as other collections could be read-only as

Re: Review Request 111991: Better handling of non-writeable UMS collections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/#review37511 --- Ship it! Ship It! - Mark Kretschmann On Aug. 11, 2013, 11

Re: Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/album hasn't changed

. - Mark Kretschmann On Aug. 13, 2013, 6:41 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37921 --- What's up with this one, is it already shipped? -

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review37922 --- What's the status of this patch? - Mark Kretschmann On

ToolTips and Automatic Formatting

d use). What do you think is the best way to go forward? -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mai

Re: ToolTips and Automatic Formatting

like this: find . -type f -print0 | xargs -0 sed -i 's/subdomainA.example.com/subdomainB.example.com/g' -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-

Re: Introduction: Season of KDE 2013

), and usually whoever is around at a given time helps out the others if they have any questions. So I don't think that it's a huge issue, as you would still be able to get the advice and guidance you need. If you are ok with this, we could continue discussing the details of your pr

Re: git HEAD compile error

, the applet isn't loading anymore, so there's clearly something wrong. Will try to figure it out tomorrow, thanks for reporting. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org _

Re: git HEAD compile error

On Fri, Aug 16, 2013 at 9:03 PM, Mark Kretschmann wrote: > On Fri, Aug 16, 2013 at 6:19 PM, Mathias Panzenböck > wrote: >> Current HEAD (141c1191f8849cfa91e8684edd11ab5b726ef101) gives me this >> compile error: >> >> Linking CXX shared module ../../../../li

Re: ToolTips and Automatic Formatting

On Sun, Aug 18, 2013 at 10:36 AM, vedant agarwala wrote: > > > > On Sun, Aug 18, 2013 at 11:38 AM, Yuri Chornoivan wrote: >> >> п'ятниця, 16-сер-2013 10:44:45 Mark Kretschmann написано: >> > Heya, >> > >> > as we noticed recently

BACKPORT keyword

Heya, I just had a smart idea, which happens rarely enough: If we make commits where we already know that they should be backported later, put the keyword BACKPORT in the commit log. Later when we assemble the stable branch we can then simply grep over the whole log. -- Mark Kretschmann Amarok

Re: ToolTips and Automatic Formatting

On Fri, Aug 16, 2013 at 10:44 AM, Mark Kretschmann wrote: > Heya, > > as we noticed recently, many of Amarok's ToolTips look very ugly and > have readability issues because they are not formatted. Therefore a > longer ToolTip is being rendered as one giant long line. The Qt AP

Re: Review Request 112248: 313504: prefer QLatin1String

deteriorates code readability for very little performance gain. Frank, most of the checks on EBN are for micro-optimizations. They are low hanging fruit, and as such they generally make sense to follow, but there are corner cases like this one where the cost outweighs the benefits. - Mark

Re: Review Request 112169: Stop after current track to tray menu

ome. I am wondering though why the keyboard shortcut doesn't suffice. - Mark Kretschmann On Aug. 20, 2013, 2:50 a.m., Shitikanth Kashyap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112221/ --- (Updated Aug. 25, 2013, 8:45 a.m.) Status -- This change has been mar

Re: Review Request 110426: KWalletHelper class for services using the KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review38518 --- Any news for this patch? - Mark Kretschmann On May 20, 2013

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

? - Mark Kretschmann On July 31, 2013, 6:22 p.m., Vedant Agarwala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109369/#review38520 --- What's the current status of this patch? - Mark Kretsc

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

Matěj Laitl wrote: > I don't think that TagLib itself is origin of the string, I think it just > reads the identifier that is in the actual tag (which can vary file by file). > Or perhaps you can prove me wrong by pointing out relevant part of TagLib > source code? > >

Re: Need a mentor for an SoK idea

name). > Also, now that I had a look at my propoasl from the SoK site, I see that all > the formatting, HTML links and even whitespaces other than space, have been > removed. Now it just looks like a ugly long paragraph :( That's terrible indeed. Could you edit the text and format it bet

Re: Amarok Scripting API

On Wed, Aug 28, 2013 at 3:48 PM, Anmol Ahuja wrote: > Here's the current state of the Amarok Scripting API. : Thanks Anmol. Now please also explain what the different colors mean. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/m

Re: Amarok Scripting API

On Wed, Aug 28, 2013 at 7:05 PM, Anmol Ahuja wrote: >> I think he means that the grey ones existed from before and the black ones >> were added by him. > Yep, that's it. > I'm sorry, I should've clarified. Right, but I see three different colors. Grey, a very

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38939 --- Ship it! Ship It! - Mark Kretschmann On Aug. 30, 2013, 1

Re: SoK - Implementing cue sheet and embedded cue sheet support in Amarok

___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org __

Re: Review Request 112417: FIX: 283022 - Performance with large feed (6000 items) very poor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112417/#review39570 --- Ship it! Looks good to me. - Mark Kretschmann On Aug. 31

Re: Amarok Scripting API

t; QString description > bool isNull > QString customValue > QString url > public slots: > bool save(); > void initFromString( const QString & urlString ); > bool run(); > void removeFromDb(); > QStrin

Re: Added support for Visualizations using VSXu

re out what's wrong yet (could be an issue with my Intel driver, or something else). If any of you folks want to try it too, that would be great, so we can see if the problem is reproducible elsewhere. If you have any build issues we can help. -- Mark Kretschmann Amarok Developer Fel

Re: Added support for Visualizations using VSXu

On Tue, Sep 10, 2013 at 7:50 PM, Konrad Zemek wrote: > On 10.09.2013 13:22, Mark Kretschmann wrote: >> >> On Sun, Sep 8, 2013 at 9:04 PM, Dinesh wrote: >>> >>> Hi Folks, >>> >>> Finally done adding support for Visualizations using VSXu.(!!!) >

Changes in GMock

nce the packaging to some degree if we can find a better solution. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail

Re: Changes in GMock

s nightmare). Try to erase the thought of writing this from your memory. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org ht

[amarok] /: Rewrite Block Analyzer to use pure OpenGL instead of QGLPaintEngine2.

Git commit f4a3f4fcf59cc0c592bd6d703542cb162a19721c by Mark Kretschmann. Committed on 19/07/2013 at 08:37. Pushed by markey into branch 'master'. Rewrite Block Analyzer to use pure OpenGL instead of QGLPaintEngine2. This rewrite should fix a number of issues that users had, especially

[amarok] /: Enable C++11 features, as discussed with other core devs.

Git commit 271ebaed8bd29a7ca78707fa6a696418c7c008b3 by Mark Kretschmann. Committed on 20/10/2013 at 16:09. Pushed by markey into branch 'master'. Enable C++11 features, as discussed with other core devs. Let the fun begin :) CCMAIL: amarok-devel@kde.org M +2-0CMakeLists

Re: Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

ttp://git.reviewboard.kde.org/r/113384/#comment31447> I think it is confusing to abuse the "slots" keyword like this. Is there an alternative? Or at least a comment should be added. - Mark Kretschmann On Oct. 22, 2013, 4:07 p.m., A

  1   2   3   4   >