malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.
REVISION SUMMARY
This patch removes some redundant functionality from ContextView and makes
the QML parts instead rely on KF5::Kirigam
Thank you for taking case of the release!
Stefano
On Wed, Mar 7, 2018 at 8:49 PM, Heiko Becker wrote:
> Hello everybody,
>
> as it may be customary for the upcoming season the Amarok team did some
> spring cleaning and is proud to announce the immediate release of Amarok
> 2.9.0. While we reali
markey accepted this revision.
markey added a comment.
This revision is now accepted and ready to land.
Kirigami2 seems really nifty. Nice choice.
REPOSITORY
R181 Amarok
BRANCH
kf5
REVISION DETAIL
https://phabricator.kde.org/D11150
To: malteveerman, #amarok, markey
Cc: markey, #amarok
markey closed this revision.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D11150
To: malteveerman, #amarok, markey
Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise,
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
/root/amarok/amarok-2.9.0/src/playlist/proxymodels/SortAlgorithms.cpp: In
member function ‘bool Playlist::multilevelLessThan::operator()(const
QAbstractItemModel*, int, int) const’:
/root/amarok/amarok-2.9.0/src/playlist/proxymodels/SortAlgorithms.cpp:98:21:
error: expected primary-expression befor
Hello Michał,
On 03/08/18 12:57, Michał Zając wrote:
> /root/amarok/amarok-2.9.0/src/playlist/proxymodels/SortAlgorithms.cpp:
> In member function ‘bool Playlist::multilevelLessThan::operator()(const
> QAbstractItemModel*, int, int) const’:
> /root/amarok/amarok-2.9.0/src/playlist/proxymodels/Sort