Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-10-21 Thread Alex Merry
> On Sept. 20, 2013, 11:33 a.m., Matěj Laitl wrote: > > src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml, lines 21-23 > > > > > > Hmm, I must say I don't like having a rating property for a "player" > >

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

2013-10-21 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113272/ --- (Updated Oct. 21, 2013, 4:34 p.m.) Review request for Amarok. Repository

Re: Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers

2013-10-21 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113275/ --- (Updated Oct. 21, 2013, 4:35 p.m.) Review request for Amarok. Repository

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

2013-10-21 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113277/ --- (Updated Oct. 21, 2013, 4:37 p.m.) Review request for Amarok. Repository

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

2013-10-21 Thread Konrad Zemek
> On Oct. 18, 2013, 10 a.m., Matěj Laitl wrote: > > src/statsyncing/Config.h, line 39 > > > > > > I guess the ability have an extra comma is a g++ extension to C++, > > right? Only thing I like about it is clearer

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

2013-10-21 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113278/ --- (Updated Oct. 21, 2013, 4:39 p.m.) Review request for Amarok. Repository

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

2013-10-21 Thread Konrad Zemek
> On Oct. 17, 2013, 2:27 p.m., Edward Hades Toroshchin wrote: > > Music, lines 11-12 > > > > > > Probably you should remove private data, like directory path and > > library ID. I don't really care about the data