Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112040/ --- (Updated Aug. 16, 2013, 7:16 a.m.) Status -- This change has been mar

Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112040/#review37920 --- This review has been submitted with commit 9d12f655f1ac1f518aa

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-16 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37921 --- What's up with this one, is it already shipped? - Mark Kretsch

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-08-16 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review37922 --- What's the status of this patch? - Mark Kretschmann On July

ToolTips and Automatic Formatting

2013-08-16 Thread Mark Kretschmann
Heya, as we noticed recently, many of Amarok's ToolTips look very ugly and have readability issues because they are not formatted. Therefore a longer ToolTip is being rendered as one giant long line. The Qt API offers automatic formatting with line-breaks for ToolTips, but there is an ugly API qui

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-08-16 Thread Matěj Laitl
> On Aug. 16, 2013, 9:19 a.m., Mark Kretschmann wrote: > > What's the status of this patch? Please merge, after testing this locally and resolving the two very minor issues that I and Kondard have found. - Matěj --- This is an automati

Re: ToolTips and Automatic Formatting

2013-08-16 Thread Matěj Laitl
On 16. 8. 2013 Mark Kretschmann wrote: > Heya, > > as we noticed recently, many of Amarok's ToolTips look very ugly and > have readability issues because they are not formatted. Therefore a > longer ToolTip is being rendered as one giant long line. The Qt API > offers automatic formatting with li

Re: ToolTips and Automatic Formatting

2013-08-16 Thread vedant agarwala
Hello. I think the best way to go forward is, as you have said, changing all the ToolTip strings, since we have nothing better. Doing it manually would be very boring but I think it wouldn't take more than a few hours. We would just have to find setToolTip (and similar functions) and change them. I

Re: ToolTips and Automatic Formatting

2013-08-16 Thread Mark Kretschmann
On Fri, Aug 16, 2013 at 11:07 AM, vedant agarwala wrote: > Hello. > I think the best way to go forward is, as you have said, changing all the > ToolTip strings, since we have nothing better. Doing it manually would be > very boring but I think it wouldn't take more than a few hours. We would > jus

Re: Introduction: Season of KDE 2013

2013-08-16 Thread Mark Kretschmann
On Sun, Aug 11, 2013 at 5:46 AM, Avik Pal wrote: > Hi, > I am Avik Pal, undergraduate student of computer science at the Bengal > Engineering & Science University, Shibpur. I was going through the season of > KDE website and the > Amarok project drew my attention especially the project Improvi

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37949 --- This review has been submitted with commit 31fdb4ab1b72fa39290

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/ --- (Updated Aug. 16, 2013, 12:34 p.m.) Status -- This change has been ma

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-16 Thread Christoph Feck
> On Aug. 12, 2013, 4:48 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Can you please "forward" this patch to Dolphin's fork of the KPlacesView? > > I'm sure they need this patch as well. > > > > Thanks ! You are right, the code is identical there. https://git.reviewboard.kde.org/r/

git HEAD compile error

2013-08-16 Thread Mathias Panzenböck
Current HEAD (141c1191f8849cfa91e8684edd11ab5b726ef101) gives me this compile error: Linking CXX shared module ../../../../lib/amarok_data_engine_labels.so CMakeFiles/amarok_context_applet_analyzer.dir/BlockAnalyzer.o: In function `BlockAnalyzer::resizeEvent(QResizeEvent*)': /home/panzi/softwar

Re: git HEAD compile error

2013-08-16 Thread Mark Kretschmann
On Fri, Aug 16, 2013 at 6:19 PM, Mathias Panzenböck wrote: > Current HEAD (141c1191f8849cfa91e8684edd11ab5b726ef101) gives me this > compile error: > > Linking CXX shared module ../../../../lib/amarok_data_engine_labels.so > CMakeFiles/amarok_context_applet_analyzer.dir/BlockAnalyzer.o: In functio

[KDE Bugtracking System] REMINDER: current Amarok regressions

2013-08-16 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 231187: https://bugs.kde.org/show_bug.cgi?id=231187 Priority: NOR Severity: normal Platform: unspecified Assignee: amarok-bugs