Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-14 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/#review17355 --- The resolver failed to download for me. Got an QNetworkReply::

Re: [amarok/v2.6.0] src: Bump plugin version for the 2.6 release to 69

2012-08-14 Thread Bart Cerneels
On Mon, Aug 13, 2012 at 1:14 PM, Matěj Laitl wrote: > Git commit 7350833639f56105c333d59eed1b821b3dfd06fb by Matěj Laitl. > Committed on 11/08/2012 at 11:07. > Pushed by laitl into tag 'v2.6.0'. > > Bump plugin version for the 2.6 release to 69 > > ...or, is it really needed to sing this song when

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-14 Thread Bart Cerneels
> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 57 > > > > > > I'd rather you checked here, if m_controller is 0. Yup, can be

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-14 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/#review17359 --- src/core-impl/collections/spotifycollection/SpotifySettings.cp

[amarok] /: Merge branch 'liblastfm1'

2012-08-14 Thread Matěj Laitl
Git commit 24b3feaf279199100f1a0a41e40e22a5408d7411 by Matěj Laitl. Committed on 14/08/2012 at 16:22. Pushed by laitl into branch 'master'. Merge branch 'liblastfm1' Amarok developers, users building git: you'll need to upgrade your liblastfm to >= 1.0.0 for Last.fm support to be included. * lib

Re: Review Request: liblastfm1 port

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105276/#review17393 --- This review has been submitted with commit 24b3feaf279199100f1

Jenkins build is still unstable: amarok_master #224

2012-08-14 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Heya, Edward Hades wrote: Git commit 84c05d37ac5be1c836948ca5e41a0f824969544e by Edward Hades. Committed on 14/08/2012 at 21:49. Pushed by hades into branch 'master'. Detect Amazon country automatically. This uses KDE locale settings and avoids "choose your country" popup at first startup. BU

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Edward Hades
On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote: > I'm very opposed to that solution, as now the plugin sends queries > to the service even without having an explicit users consent. Sending > data to a web service without the user knowing about it is a bad thing. First, the commit in

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote: I'm very opposed to that solution, as now the plugin sends queries to the service even without having an explicit users consent. Sending data to a web service without the user knowing about it is a bad thing.