GSoC update: Integrate Spotify into Amarok

2012-07-22 Thread Ryan Feng
Hi, Now the Spotify collection feature works well in "Unmerged view" of collection browser[1], but it's still not stable under "Merged view". What I've done this week: - Added TrackProxy class to retrieve track information in the playlist when loading Amarok - Added SpotifyConfigWidget c

Re: GSoC update: Integrate Spotify into Amarok

2012-07-22 Thread Teo Mrnjavac
On Sun, Jul 22, 2012 at 2:45 PM, Ryan Feng wrote: > Hi, > > Now the Spotify collection feature works well in "Unmerged view" of > collection browser[1], but it's still not stable under "Merged view". > What I've done this week: > > Added TrackProxy class to retrieve track information in the playli

Re: Review Request: SoK - Unit Test : core/meta/support/PrivateMetaRegistry

2012-07-22 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105525/#review16229 --- Ship it! Looks good, but there seems to be logic error, see be

Re: Review Request: SqlScanResultProcessor: fix data-loss bug; squashed commits, recent on top

2012-07-22 Thread Matěj Laitl
> On July 11, 2012, 9:20 a.m., Ralf Engels wrote: > > Looks good for now. > > What I would really like is some more test cases to check for the current > > problems. > > > > Also I am working on a solution for the database schema as you can see from > > the database table .svg file in the docs

Re: Review Request: Multiple EngineController and related fixes, incl. fix for release_blocker bug 299890 (squashed commits, recent on top)

2012-07-22 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105610/#review16232 --- Hmm, I think I've found a solution for trackFinishedPlaying(),