Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

2012-06-11 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14597 --- I'm assuming this is mostly code copied and edited (but not com

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

2012-06-11 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- One minor comment: Please don't remove copyright headers when

Review Request: StatSyncing GSoC week 3 (squashed commits, recent on top)

2012-06-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105219/ --- Review request for Amarok, Bart Cerneels and Myriam Schweingruber. Descrip

Re: Review Request: StatSyncing GSoC week 1 (squashed commits, recent on top)

2012-06-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105055/ --- (Updated June 11, 2012, 10:46 a.m.) Review request for Amarok, Bart Cernee

Re: Review Request: StatSyncing GSoC week 2 (squashed commits, recent on top)

2012-06-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105100/ --- (Updated June 11, 2012, 10:47 a.m.) Review request for Amarok, Bart Cernee

Build failed in Jenkins: amarok_master #140

2012-06-11 Thread Jenkins CI Daemon
See Changes: [sam] Fix inconsistent scrobbling with GStreamer backend [matej] Trivial change in proxy collection EditCapability -- Started by an SCM change [EnvInject] - Loading node environment variabl

Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/ --- Review request for Amarok. Description --- MediaDeviceCache: remove p

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14622 --- Ship it! Testing done: mounted an external HDD via Plasma's De

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14624 --- >From the code: 297 if ((*it)->mountType() == "nfs"

Build failed in Jenkins: amarok_master #141

2012-06-11 Thread Jenkins CI Daemon
See Changes: [vonreth] added missing translations and updated some [kde] Fix insert options in AddTrack in the MPRIS1 interface -- Started by an SCM change [EnvInject] - Loading node environment variabl

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

2012-06-11 Thread Zhengliang Feng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok. Descriptio

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

2012-06-11 Thread Zhengliang Feng
> On June 11, 2012, 8:52 a.m., Leo Franchi wrote: > > One minor comment: > > > > Please don't remove copyright headers when copying files from another > > project--this is important for both legal and authorship (e.g. "who do I > > ask when this code doesn't work") reasons. The ScriptResolver

Build failed in Jenkins: amarok_master #143

2012-06-11 Thread Jenkins CI Daemon
See Changes: [kde] Update the changelog -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace Checkout:amarok_ma

Build failed in Jenkins: amarok_master #142

2012-06-11 Thread Jenkins CI Daemon
See Changes: [kde] Make the playlist code a little clearer [kde] Play the correct track when inserting tracks into a sorted playlist -- Started by an SCM change [EnvInject] - Loading node environment va

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

2012-06-11 Thread Zhengliang Feng
> On June 11, 2012, 8:41 a.m., Bart Cerneels wrote: > > I'm assuming this is mostly code copied and edited (but not completely) > > from the playdar work done by Andy for GSoC 2010. > > As far as I understand it the protocol used by the Tomahawk resolver is > > still the same (playdar API), so

Build failed in Jenkins: amarok_master #145

2012-06-11 Thread Jenkins CI Daemon
See Changes: [kde] Add more debugging info for mpris:artUrl in the MPRIS2 interface -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: amarok_master #144

2012-06-11 Thread Jenkins CI Daemon
See Changes: [kde] Construct the MPRIS1 arturl the same way as the MPRIS2 mpris:artUrl -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: amarok_master #146

2012-06-11 Thread Jenkins CI Daemon
See Changes: [kde] MPRIS: Actually use the cached we created -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Jenkins build is still unstable: amarok_master #147

2012-06-11 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

[KDE Bugtracking System] REMINDER: current Amarok regressions

2012-06-11 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 230991: https://bugs.kde.org/show_bug.cgi?id=230991 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-b

[KDE Bugtracking System] Release blockers

2012-06-11 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 279966: https://bugs.kde.org/show_bug.cgi?id=279966 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary: