Re: Amarok 2.5.0 has a bad memory leak

2012-05-23 Thread Bart Cerneels
Hey Gerald. Thanks for the data you gathered. It certainly proves we have a memleak problem. As you point out it's probably related to the playlist, but that is not directly a give and likely is not the only memleak there is. I'll have a go finding it before the next release anyway. I'm sharing th

Re: Amarok 2.5.0 has a bad memory leak

2012-05-23 Thread Erik Hovland
Does the attached patch help at all? E On Wed, May 23, 2012 at 3:17 AM, Bart Cerneels wrote: > Hey Gerald. > Thanks for the data you gathered. It certainly proves we have a > memleak problem. As you point out it's probably related to the > playlist, but that is not directly a give and likely is

Re: Amarok 2.5.0 has a bad memory leak

2012-05-23 Thread Mathias Panzenböck
Out of curiosity: Why use a QShardPointer and not directly allocate the object on the stack? Would do the same. On 05/23/2012 08:33 PM, Erik Hovland wrote: Does the attached patch help at all? E On Wed, May 23, 2012 at 3:17 AM, Bart Cerneels wrote: Hey Gerald. Thanks for the data you gather

Re: Amarok 2.5.0 has a bad memory leak

2012-05-23 Thread Erik Hovland
> Out of curiosity: > Why use a QShardPointer and not directly allocate the object on the stack? > Would do the same. You're probably right. I was staring at the code too long to recognize such simplicity. Reworked patch attached. E -- Erik Hovland e...@hovland.org http://hovland.org/ 0001-Fi

[Tomahawk Integration] Fourth week of GSoC

2012-05-23 Thread Lucas Lira Gomes
Hi everyone, last week domme and lfranchi discovered what was crashing libtomahawk when it was syncing playlists/stations between peers. During these two weeks I've been trying to make libtomahawk aware of the tracks amarok has added or deleted from its database. This database synchronisation is n

GSoC Update - Semantic Collection for Amarok

2012-05-23 Thread Phalgun Guduthur
Hello Its been a while since my last update. Been held up by my university exams. These are the updates since my last mail. - No Tracker backend for Amarok, after vHanda's suggestion. Its yet to reach full maturity (and reception). Will be concentrating on a Nepomuk backend only from now