Re: Review Request: Revert broken workaround previously not working solid fstab monitoring

2012-05-14 Thread Stefan Brüns
> On May 7, 2012, 4:20 p.m., Bart Cerneels wrote: > > Why not use ifdef's to conditionally compile in the workaround? Because the workaround is broken? Specifically, although it works, it polls *every second* for a list of all mountpoints (parsing mtab and fstab) and all Solid storage devices,

Re: Review Request: Improve automatic scrolling of text in Lyrics applet

2012-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104935/#review13795 --- This review has been submitted with commit c4386adf8963c65e5be

Re: Review Request: Improve automatic scrolling of text in Lyrics applet

2012-05-14 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104935/#review13805 --- Ship it! I wanted to do exactly the same for ages, thanks for

Re: Review Request: Improve automatic scrolling of text in Lyrics applet

2012-05-14 Thread Alexander Potashev
> On May 14, 2012, 10:10 a.m., Matěj Laitl wrote: > > I wanted to do exactly the same for ages, thanks for the patch! Only one > > small point - using floating point arithmetics is slightly slower, but in > > infrequent cases like this the slowdown is absolutelny below measurable > > margin -

[KDE Bugtracking System] Release blockers

2012-05-14 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 242350: https://bugs.kde.org/show_bug.cgi?id=242350 Priority: NOR Severity: major Platform: Archlinux Packages Assignee: amarok-bugs-d...@kde.org Status: NEW Summary: M

GSoC report #3

2012-05-14 Thread Riccardo Iaconelli
Hi, already time for GSoC report #3. This week: * I held two meetings in which I discussed, and possibly finalized, the decision about how to handle data (C++ models vs. Plasma dataengines) * I've started to play with QML directly and began working directly on the code, having a better idea of w