Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/ --- (Updated Sept. 26, 2015, 12:16 p.m.) Status -- This change has been

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
> On Sept. 26, 2015, 11:48 a.m., Stefan Derkits wrote: > > Ship It! I don't have a KDE dev account. Could you do it ? Thanks :) - Aditya --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/1

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/#review85961 --- Ship it! Ship It! - Stefan Derkits On Sept. 26, 2015, 11:4

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/ --- (Updated Sept. 26, 2015, 11:41 a.m.) Review request for Amarok, Stefan De

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/#review85960 --- cmake/modules/FindLibLastFm.cmake (line 19)

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Myriam Schweingruber
> On Sept. 25, 2015, 9:46 p.m., Myriam Schweingruber wrote: > > erm, /usr/local/include? are you sure? That folder is normally empty, I > > guess you meant /usr/include/liblastfm5, no? > > Aditya Dev Sharma wrote: > I'm quite sure about it. /usr/local/include was empty initially. But > ins

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Olivier Churlaud
> On sep. 25, 2015, 9:46 après-midi, Myriam Schweingruber wrote: > > erm, /usr/local/include? are you sure? That folder is normally empty, I > > guess you meant /usr/include/liblastfm5, no? > > Aditya Dev Sharma wrote: > I'm quite sure about it. /usr/local/include was empty initially. But

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/ --- (Updated Sept. 25, 2015, 8:42 p.m.) Status -- This change has been d

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
> On Sept. 25, 2015, 7:46 p.m., Myriam Schweingruber wrote: > > erm, /usr/local/include? are you sure? That folder is normally empty, I > > guess you meant /usr/include/liblastfm5, no? I'm quite sure about it. /usr/local/include was empty initially. But installing LastFm (the Qt5 version) inst

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/#review85938 --- erm, /usr/local/include? are you sure? That folder is normally

Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125394/ --- Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam Sc