Re: [PATCH] drm/i915/bios: Define eDP pipe joiner feature for VBT

2025-01-08 Thread Vodapalli, Ravi Kumar
On 1/8/2025 8:06 PM, Dnyaneshwar Bhadane wrote: There is new field "edp pipe joiner feature" size of 2 bytes in the eDP VBT block. Each bit represent panel number to be enable/disable for this feature. Default value: For ARL platform, 0x to keep the feature disabled by default. Xe3lpd on

Re: [PATCH 1/4] drm/i915: Drop 64bpp YUV formats from ICL+ SDR planes

2024-12-31 Thread Vodapalli, Ravi Kumar
On 12/18/2024 11:06 PM, Ville Syrjala wrote: From: Ville Syrjälä I'm seeing underruns with these 64bpp YUV formats on TGL. The weird details: - only happens on pipe B/C/D SDR planes, pipe A SDR planes seem fine, as do all HDR planes - somehow CDCLK related, higher CDCLK allows for bigger

Re: [PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2024-12-31 Thread Vodapalli, Ravi Kumar
On 12/13/2024 11:33 AM, Suraj Kandpal wrote: Usually retimers take around 30 to 40ms to exit all devices from sleep state. Extended wake timeout request helps to give additional time by reading the DPCD register through which sink requests the minimal amount of time required to wake the sink

Re: [CI v3 2/6] drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()

2024-12-30 Thread Vodapalli, Ravi Kumar
On 12/30/2024 7:44 PM, Jani Nikula wrote: Propagate errors from intel_hdmi_init_connector() to be able to handle them at callers. This is similar to intel_dp_init_connector(). Cc: Sergey Senozhatsky Cc: Ville Syrjala Reported-and-tested-by: Sergey Senozhatsky Closes: https://lore.kernel.

Re: [PATCH] drm/i915: Remove deadcode

2024-12-30 Thread Vodapalli, Ravi Kumar
On 12/27/2024 5:10 PM, Tvrtko Ursulin wrote: Hi, On 22/12/2024 17:47, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" i915_active_acquire_for_context() was added in 2020 by commit 5d9341370f57 ("drm/i915: Export a preallocate variant of i915_active_acquire()") but has never been

Re: [PATCH] drm/i915/display: Don't program DBUF_CTL tracker state service

2024-12-20 Thread Vodapalli, Ravi Kumar
On 12/20/2024 2:49 AM, Cavitt, Jonathan wrote: -Original Message- From: Roper, Matthew D Sent: Thursday, December 19, 2024 12:50 PM To: Cavitt, Jonathan Cc: Vodapalli, Ravi Kumar;intel-gfx@lists.freedesktop.org; Vivekanandan, Balasubramani; De Marchi, Lucas; Sousa, Gustavo; Taylor

RE: [PATCH] drm/i915/display: Don't program DBUF_CTL tracker state service

2024-12-19 Thread Vodapalli, Ravi Kumar
-Original Message- From: Bhadane, Dnyaneshwar Sent: Thursday, December 19, 2024 12:55 PM To: Vodapalli, Ravi Kumar ; intel-gfx@lists.freedesktop.org Cc: Vivekanandan, Balasubramani ; Roper, Matthew D ; De Marchi, Lucas ; Sousa, Gustavo ; Taylor, Clinton A ; Atwood, Matthew S

Re: [PATCH] drm/i915/display: Don't program DBUF_CTL tracker state service

2024-12-18 Thread Vodapalli, Ravi Kumar
Hi, My inline comments On 12/18/2024 2:07 AM, Bhadane, Dnyaneshwar wrote: -Original Message- From: Vodapalli, Ravi Kumar Sent: Tuesday, December 17, 2024 11:00 PM To:intel-gfx@lists.freedesktop.org Cc: Vivekanandan, Balasubramani ; Roper, Matthew D ; De Marchi, Lucas ; Sousa

Re: [Intel-gfx] [PATCH v2 12/27] FIXME: drm/i915/xe2lpd: Add display power well

2023-09-07 Thread Vodapalli, Ravi Kumar
Looks Good. Reviewed-by: Ravi Kumar Vodapalli Thanks, Ravi Kumar V On 9/7/2023 9:07 PM, Lucas De Marchi wrote: From: Ravi Kumar Vodapalli Add Display Power Well for LNL platform, mostly it is same as MTL platf

Re: [Intel-gfx] [PATCH v2 25/27] drm/i915/lnl: Add support for CDCLK initialization sequence

2023-09-07 Thread Vodapalli, Ravi Kumar
Looks Good. Reviewed-by: Ravi Kumar Vodapalli Thanks, Ravi Kumar V -Original Message- From: De Marchi, Lucas Sent: Thursday, September 7, 2023 9:08 PM To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org Cc: Vodapalli, Ravi Kumar ; De Marchi, Lucas Subject: [PATCH v2

Re: [Intel-gfx] [PATCH v2 12/27] FIXME: drm/i915/xe2lpd: Add display power well

2023-09-07 Thread Vodapalli, Ravi Kumar
Looks Good. Reviewed-by: Ravi Kumar Vodapalli Thanks, Ravi Kumar V On 9/7/2023 9:07 PM, Lucas De Marchi wrote: From: Ravi Kumar Vodapalli Add Display Power Well for LNL platform, mostly it is same as MTL platfor

Re: [Intel-gfx] [PATCH v2 12/27] FIXME: drm/i915/xe2lpd: Add display power well

2023-09-07 Thread Vodapalli, Ravi Kumar
Looks Good. Reviewed-by: Ravi Kumar Vodapalli Thanks, Ravi Kumar V On 9/7/2023 9:07 PM, Lucas De Marchi wrote: From: Ravi Kumar Vodapalli Add Display Power Well for LNL platform, mostly it is same as MTL platform so reused the code Changes are: 1. AUX_CH_CTL and AUX_CH_DATA1 are different

Re: [Intel-gfx] [PATCH] drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence()

2023-06-21 Thread Vodapalli, Ravi Kumar
Hi Gustavo, Looks good, On 6/14/2023 3:16 AM, Gustavo Sousa wrote: That function is not defined anywhere. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_cx0_phy.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.h b/driv