[clang] [clang-tools-extra] [flang] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

@@ -58,7 +58,7 @@ CHECK-CNT3-NOT: {{^}}this is duplicate CHECK-CNT4-COUNT-5: this is duplicate CHECK-CNT4-EMPTY: -Many-label: +Many-LABEL: RoboTux wrote: IMO this makes it harder to spot that this is *not* a FileCheck directive. I think we should drop al

[clang-tools-extra] [clang] [llvm] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: Thanks for fixing the unused variable @DamonFool , I was about to revert and push a new patch. https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[llvm] [clang-tools-extra] [clang] Add out-of-line-atomics support to GlobalISel (PR #74588)

https://github.com/RoboTux closed https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: My apologies @arsenm, I had missed your review comments. All fixed now. https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: > > // At -O0, fast-regalloc cannot cope with the live vregs necessary to > > This sounds extremely unsound Just to clarify, is the expectation for me to solve this in this patch or can this be done in a separate patch? Note that this is existing code exercised when compiling a

[clang] [clang-tools-extra] [llvm] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: > > > Not an expert on atomics, but why would we have a libcall for -O0 but not > > > for O1 in the tests? > > > > > > I looked at it for the u?(min|max) and it seemed to boil down to the atomic > > expand pass being run at -O1 and above. > > No sorry, it's not that it's only

[clang] [llvm] [clang-tools-extra] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: > > Not an expert on atomics, but why would we have a libcall for -O0 but not > > for O1 in the tests? > > I looked at it for the u?(min|max) and it seemed to boil down to the atomic > expand pass being run at -O1 and above. No sorry, it's not that it's only run at O1 and above

[clang-tools-extra] [llvm] [clang] Add out-of-line-atomics support to GlobalISel (PR #74588)

RoboTux wrote: > Not an expert on atomics, but why would we have a libcall for -O0 but not for > O1 in the tests? I looked at it for the u?(min|max) and it seemed to boil down to the atomic expand pass being run at -O1 and above. https://github.com/llvm/llvm-project/pull/74588 ___

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

Bug#1037878: ultracopier: diff for NMU version 2.2.6.0-1.1

Thanks, much appreciated. Feel free to upload it right away. Best regards, Thomas On 10 September 2023 09:12:35 WEST, Marcos Talau wrote: >Control: tags 1037878 + patch >Control: tags 1037878 + pending > > >Dear maintainer, > >I've prepared an NMU for ultracopier (versioned as 2.2.6.0-1.1) and >

Bug#1037878: ultracopier: diff for NMU version 2.2.6.0-1.1

Thanks, much appreciated. Feel free to upload it right away. Best regards, Thomas On 10 September 2023 09:12:35 WEST, Marcos Talau wrote: >Control: tags 1037878 + patch >Control: tags 1037878 + pending > > >Dear maintainer, > >I've prepared an NMU for ultracopier (versioned as 2.2.6.0-1.1) and >

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

Bug#1043140: Patches work for me

FYI when rebuilding weston-12 with the patches listed in https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1257/commits weston stop crashing. Best regards, Thomas

Bug#1043140: Patches work for me

FYI when rebuilding weston-12 with the patches listed in https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1257/commits weston stop crashing. Best regards, Thomas

Bug#1043140: libweston-12-0: Weston fails to start with "Assertion `csi->width == width' failed"

Package: libweston-12-0 Version: 12.0.1-1 Severity: important Tags: upstream After upgrading my system sddm fails to start a wayland session with the following error in .local/share/sddm/wayland-session.log: weston: ../libweston/output-capture.c:398 weston_output_pull_capture_task: Assertion `cs

Bug#1043140: libweston-12-0: Weston fails to start with "Assertion `csi->width == width' failed"

Package: libweston-12-0 Version: 12.0.1-1 Severity: important Tags: upstream After upgrading my system sddm fails to start a wayland session with the following error in .local/share/sddm/wayland-session.log: weston: ../libweston/output-capture.c:398 weston_output_pull_capture_task: Assertion `cs

Bug#1037878: Processed: tagging 1037878

Unfortunately I won't be able to do it until August but anyone feel free to do an NMU. My apologies. Best regards, Thomas On 21 July 2023 07:04:57 GMT+08:00, alpha_one_x86 wrote: >Fixed into the last version, please update to Ultracopier 2.2.6.7

Bug#1037878: Processed: tagging 1037878

Unfortunately I won't be able to do it until August but anyone feel free to do an NMU. My apologies. Best regards, Thomas On 21 July 2023 07:04:57 GMT+08:00, alpha_one_x86 wrote: >Fixed into the last version, please update to Ultracopier 2.2.6.7

[PATCH] D138274: Add version to all LLVM cmake package

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa2d3d9943: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] ecfa2d3 - Add version to all LLVM cmake package

Author: Thomas Preud'homme Date: 2022-11-25T21:57:58Z New Revision: ecfa2d3d9943a48411d04a4b3103c42b4653d9af URL: https://github.com/llvm/llvm-project/commit/ecfa2d3d9943a48411d04a4b3103c42b4653d9af DIFF: https://github.com/llvm/llvm-project/commit/ecfa2d3d9943a48411d04a4b3103c42b4653d9af

[PATCH] D138274: Add version to all LLVM cmake package

thopre updated this revision to Diff 477916. thopre added a comment. Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138274 Files: clang

[PATCH] D138274: Add version to all LLVM cmake package

thopre reopened this revision. thopre added inline comments. This revision is now accepted and ready to land. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM @LLVM_VERS

[clang] b62c8d3 - Revert: Add version to all LLVM cmake package

Author: Thomas Preud'homme Date: 2022-11-25T10:54:58Z New Revision: b62c8d396f7dbef61122e169ef143276e74eff05 URL: https://github.com/llvm/llvm-project/commit/b62c8d396f7dbef61122e169ef143276e74eff05 DIFF: https://github.com/llvm/llvm-project/commit/b62c8d396f7dbef61122e169ef143276e74eff05

[clang] ad485b7 - Add version to all LLVM cmake package

Author: Thomas Preud'homme Date: 2022-11-20T21:09:50Z New Revision: ad485b71b51168ce13282ae159bd8feff48baf84 URL: https://github.com/llvm/llvm-project/commit/ad485b71b51168ce13282ae159bd8feff48baf84 DIFF: https://github.com/llvm/llvm-project/commit/ad485b71b51168ce13282ae159bd8feff48baf84

[PATCH] D138274: Add version to all LLVM cmake package

This revision was automatically updated to reflect the committed changes. Closed by commit rGad485b71b511: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org

[PATCH] D138274: Add version to all LLVM cmake package

thopre added a comment. In D138274#3938218 , @arsenm wrote: > I thought we had this already. The amount of boiler plate required repeated > in each component is depressing, but I wouldn't be surprised if it's really > needed I could configure the LLVMV

[PATCH] D138274: Add version to all LLVM cmake package

thopre created this revision. thopre added reviewers: smeenai, arsenm, stella.stamenova, stellaraccident, Ericson2314, pmccormick, beanz. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a86a23c10d: [Test] Fix driverkit-path.c with lib64 dir (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llv

[clang] f3a86a2 - [Test] Fix driverkit-path.c with lib64 dir

Author: Thomas Preud'homme Date: 2022-11-08T09:54:47Z New Revision: f3a86a23c10db44cbcb432d56201475721c64bdc URL: https://github.com/llvm/llvm-project/commit/f3a86a23c10db44cbcb432d56201475721c64bdc DIFF: https://github.com/llvm/llvm-project/commit/f3a86a23c10db44cbcb432d56201475721c64bdc

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

thopre created this revision. thopre added reviewers: yln, rsmith. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137484 Files: clang/t

[Lldb-commits] [lldb] 8e757c6 - Fix conversion error to Expected

Author: Thomas Preud'homme Date: 2022-05-25T20:51:14+01:00 New Revision: 8e757c6b500dc18f0cc5a7c027682ac2aacf8eb0 URL: https://github.com/llvm/llvm-project/commit/8e757c6b500dc18f0cc5a7c027682ac2aacf8eb0 DIFF: https://github.com/llvm/llvm-project/commit/8e757c6b500dc18f0cc5a7c027682ac2aac

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e757c6b500d: Fix conversion error to Expected (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126402/new/ https://reviews.llvm.org/D126

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre added a comment. In D126402#3538078 , @wallace wrote: > thank you! > > I'm surprised the compiler didn't do this automatically As mentioned, this is GCC 7.5. It might be different with a newer version. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre created this revision. thopre added reviewers: wallace, jj10306. Herald added a project: All. thopre requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Ubuntu 18.04 with GCC 7.5 Intel trace code fails to build due to failure to conve

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c failure (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https:/

[clang] 7e65ffa - [test, x86] Fix spurious x86-target-features.c failure

Author: Thomas Preud'homme Date: 2022-05-18T09:27:32+01:00 New Revision: 7e65ffaa8bb65adc0324ccbea1fef56cab6eafe1 URL: https://github.com/llvm/llvm-project/commit/7e65ffaa8bb65adc0324ccbea1fef56cab6eafe1 DIFF: https://github.com/llvm/llvm-project/commit/7e65ffaa8bb65adc0324ccbea1fef56cab6

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre updated this revision to Diff 430029. thopre marked an inline comment as done. thopre added a comment. Be more conservative in what we reject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 Files:

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre created this revision. thopre added reviewers: sconstab, craig.topper, andrew.w.kaylor, zbrid, chandlerc. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a7a28075b7f: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 8a7a280 - Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

Author: Thomas Preud'homme Date: 2021-09-17T15:21:22+01:00 New Revision: 8a7a28075b7fa70d56b131c10a4d1add777d5830 URL: https://github.com/llvm/llvm-project/commit/8a7a28075b7fa70d56b131c10a4d1add777d5830 DIFF: https://github.com/llvm/llvm-project/commit/8a7a28075b7fa70d56b131c10a4d1add777

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre updated this revision to Diff 373214. thopre added a comment. Remove old PM tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109956/new/ https://reviews.llvm.org/D109956 Files: clang/test/CodeGen/pgo-sample-thinlto-summary.c Index: c

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added a comment. In D109234#3004253 , @gregmiller wrote: > Hello, > We are maintaining a downstream version of the monorepo based on the LLVM > main branch. We have not transitioned to the new PM yet. In a recent attempt > to merge the latest u

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre created this revision. thopre added reviewers: gregmiller, tejohnson, davide, danielcdh. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Re-add -fexperimental-new-pass-manager to Clang::CodeG

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG005fc11ebdd6: [PGO] Change ThinLTO test for targets with loop unrolling disabled (authored by Sherwin da Cruz <59867245+sherwin...@users.noreply.github.com>, committed by thopre). Repository: rG LLVM G

[clang] 005fc11 - [PGO] Change ThinLTO test for targets with loop unrolling disabled

Author: Sherwin da Cruz Date: 2021-09-16T11:13:16+01:00 New Revision: 005fc11ebdd6e1af29efee3d7c5da86f56138414 URL: https://github.com/llvm/llvm-project/commit/005fc11ebdd6e1af29efee3d7c5da86f56138414 DIFF: https://github.com/llvm/llvm-project/commit/005fc11ebdd6e1af29efee3d7c5da86f56138414.dif

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when l

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when l

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Ah fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. In D104854#2957735 , @kpn wrote: > In D104854#2957490 , @lebedev.ri > wrote: > >> In D104854#2957471 , @sepavloff >> wrote: >> >>> In D104854#295

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e11ccad837c: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86 (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES

[clang] 1e11cca - [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

Author: Thomas Preud'homme Date: 2021-08-12T21:38:35+01:00 New Revision: 1e11ccad837c2d0d848349e7bc8f5800e5d365fc URL: https://github.com/llvm/llvm-project/commit/1e11ccad837c2d0d848349e7bc8f5800e5d365fc DIFF: https://github.com/llvm/llvm-project/c

[clang] 1397e19 - Set supported target for asan-use-callbacks test

Author: Thomas Preud'homme Date: 2021-08-10T15:01:44+01:00 New Revision: 1397e19129ef7aa6c2ba6f6018ff172a5022a1eb URL: https://github.com/llvm/llvm-project/commit/1397e19129ef7aa6c2ba6f6018ff172a5022a1eb DIFF: https://github.com/llvm/llvm-project/c

[PATCH] D107633: Set supported target for asan-use-callbacks test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1397e19129ef: Set supported target for asan-use-callbacks test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre updated this revision to Diff 365465. thopre added a comment. Remove REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 Files: clang/test/CodeGen/asan-use-callbacks.cpp Index: clang/test/

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre updated this revision to Diff 365425. thopre added a comment. Use x86_64-linux-gnu as triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/ https://reviews.llvm.org/D107667 Files: clang/test/CodeGen/thinlto-clang-diagnostic-ha

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre created this revision. thopre added reviewers: xur, tejohnson, lebedev.ri. Herald added subscribers: ormris, pengfei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test CodeGen/thinlto-

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre created this revision. thopre added reviewers: kstoimenov, vitalybuka. Herald added subscribers: pengfei, krytarowski. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicitely set x86_64-linux-gnu as a target for asan-use-c

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. LGTM (besides comment fix) but I'm not too familiar with the vector side of things Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6967 + // NaN has all exp bits set and a non zero significand. Therefore: + // isnan(V) == ((exp mask - (ab

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it tak

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

thopre added a comment. +1 for this change but being a downstream target only I prefer to let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 __

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

thopre added a comment. In D102630#2764705 , @dblaikie wrote: > @thopre - as an aside: It'd be helpful if you could include some text in the > text box when marking something "approved" through phabricator. There's a > bug/limitation that approvals with

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } jdoerfert wrote: > thopre wrote

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } I'm getting #0 for both functio

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 8cee150 - [C++, test] Fix typo in NSS* vars

Author: Thomas Preud'homme Date: 2021-04-20T12:07:41+01:00 New Revision: 8cee150e9ac467dd93199722b8bd8af3024df697 URL: https://github.com/llvm/llvm-project/commit/8cee150e9ac467dd93199722b8bd8af3024df697 DIFF: https://github.com/llvm/llvm-project/commit/8cee150e9ac467dd93199722b8bd8af3024

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre updated this revision to Diff 338811. thopre marked an inline comment as done. thopre added a comment. Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ ht

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGSTK-N

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGSTK-N

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.ll

[clang] e018698 - [clang, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-07T09:43:58+01:00 New Revision: e018698bec363637f0da25b68da9ba8c3192d1cb URL: https://github.com/llvm/llvm-project/commit/e018698bec363637f0da25b68da9ba8c3192d1cb DIFF: https://github.com/llvm/llvm-project/c

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335640. thopre added a comment. Rename NUW_RN for CHECK-YES to NUW Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index: clang/

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335618. thopre added a comment. Change attribute check to a positive match Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ddunbar, MaskRay, rjmccall, spatel, arsenm, hfinkel, void, mcrosier. thopre requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Clang test CodeGen/libcalls.c contains CHECK-NOT directives using a

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG828ec9e9e5da: [OpenCL, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99857/new/ https://reviews.l

[clang] 828ec9e - [OpenCL, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-05T21:11:39+01:00 New Revision: 828ec9e9e5da8a2e7d1bfa523b9a712658ee6ffc URL: https://github.com/llvm/llvm-project/commit/828ec9e9e5da8a2e7d1bfa523b9a712658ee6ffc DIFF: https://github.com/llvm/llvm-project/c

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3e0feca92: [DebugInfo, CallSites, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99830/new/ htt

[clang] 4dd3e0f - [DebugInfo, CallSites, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-05T11:39:24+01:00 New Revision: 4dd3e0feca9295c615f06f9f96f1e7ccdd63bb3d URL: https://github.com/llvm/llvm-project/commit/4dd3e0feca9295c615f06f9f96f1e7ccdd63bb3d DIFF: https://github.com/llvm/llvm-project/c

[clang] 292726b - [HIP, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-04T19:30:49+01:00 New Revision: 292726b6443c7d7be4bb03af40cd3f60188b2ff7 URL: https://github.com/llvm/llvm-project/commit/292726b6443c7d7be4bb03af40cd3f60188b2ff7 DIFF: https://github.com/llvm/llvm-project/commit/292726b6443c7d7be4bb03af40cd3f60188

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG292726b6443c: [HIP, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99832/new/ https://reviews.llvm

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41b5100e438: [HIP-Clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99831/new/ https://review

[clang] a41b510 - [HIP-Clang, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-04T19:30:27+01:00 New Revision: a41b5100e43810694c09469bc725f560e7ef239f URL: https://github.com/llvm/llvm-project/commit/a41b5100e43810694c09469bc725f560e7ef239f DIFF: https://github.com/llvm/llvm-project/c

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: hliao, craig.topper, neil.hickey, yaxunl, baldrick. Herald added subscribers: ldrumm, Anastasia. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenOpenCL/fpmath.cl uses a variable defined in an earlier C

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99838/new/ https://revie

[clang] 1cc9d94 - [C++20, test] Fix use of undef FileCheck variable

Author: Thomas Preud'homme Date: 2021-04-04T00:05:48+01:00 New Revision: 1cc9d949a1233e8b17b3b345ccb67ca7296c1a6c URL: https://github.com/llvm/llvm-project/commit/1cc9d949a1233e8b17b3b345ccb67ca7296c1a6c DIFF: https://github.com/llvm/llvm-project/c

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre created this revision. thopre added reviewers: respindola, pcc, EricWF. thopre requested review of this revision. Herald added a project: clang. The NSS FileCheck variables at the end of the CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in the use of an undefined variab

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

thopre created this revision. thopre added reviewers: rsmith, EricWF, akhuang. thopre requested review of this revision. Herald added a project: clang. Commit f495de43bd5da50286da6020e508d106cfc60f57 forgot two lines when remo

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: yaxunl, ashi1, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenCUDA/kernel-stub-name.cu uses never defined DKERN variable in a CHECK-NOT directive. This commit replace the variable

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ashi1, yaxunl, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Commit 8129521318accc44c2a009647572f6ebd3fc56dd changed a line defining PREFIX in clang test CodeGenCUDA/device-stub.cu into a CHECK-NO

  1   2   3   4   5   6   7   8   9   10   >