Re: [go-nuts] mac/windows tcp read-after-deadline expired bug

2024-11-18 Thread Steven Hartland
I believe the problem you have is that your readFull can return a partial read if an error occurs e.g. timeout so when that happens you lose data by overwriting the partial result with the next read. If you apply something like the following, which returns the bytes read and continues the read fro

Re: [go-nuts] Congrats to the Go team

2024-04-27 Thread Steven Hartland
0 ± 0%~ (p=1.000 n=6) ¹ >>> 1.000 ± 0%~ (p=1.000 n=6) ¹ >>> MulFixed-8 0.000 ± 0% 0.000 ± 0%~ (p=1.000 n=6) ¹ >>> 0.000 ± 0%~ (p=1.000 n=6) ¹ >>> MulDecimal-82.000 ± 0% 2.000 ± 0%~ (p=1.000 n=

Re: [go-nuts] Congrats to the Go team

2024-04-25 Thread Steven Hartland
ecimal-8 4.000 ± ∞ ¹ 4.000 ± ∞ ¹ ~ > (p=1.000 n=1) ² > StringBigInt-8 1.000 ± ∞ ¹ 1.000 ± ∞ ¹ ~ > (p=1.000 n=1) ² > StringBigFloat-87.000 ± ∞ ¹ 7.000 ± ∞ ¹ ~ > (p=1.000 n=1)

Re: [go-nuts] Congrats to the Go team

2024-04-24 Thread Steven Hartland
What’s it look like when your run it through https://pkg.go.dev/golang.org/x/perf/cmd/benchstat which will provide a nice side by side comparison? On Wed, 24 Apr 2024 at 19:26, 'Robert Engels' via golang-nuts < golang-nuts@googlegroups.com> wrote: > I have a fairly stable project github.com/robah

Re: [go-nuts] Re: <-ctx.Done() panic - link injecting bot?

2024-03-30 Thread Steven Hartland
gt; abuse "Spam". Whether anyone reads these is doubtful though. > > The first spam was on 3 Jan 2024 and I reported it straight away; it > hasn't stopped the new ones coming through. > > On Saturday 30 March 2024 at 10:21:18 UTC Steven Hartland wrote: > >

Re: [go-nuts] Re: <-ctx.Done() panic - link injecting bot?

2024-03-30 Thread Steven Hartland
Johans account looks like a bot designed to inject links, possibly malicious, is there an admin who can investigate and take the appropriate action? On Fri, 29 Mar 2024 at 12:11, Johan Liebert wrote: -- You received this message because you are subscribed to the Google Groups "golang-nuts" gr

Re: [go-nuts] Data structure code review

2024-03-03 Thread Steven Hartland
Some feedback: Instead of errors.New(emptyDataStructureMessage("stack")) use an emptyDataError type, where it implements the error interface by adding an Error() string method, for example: type emptyDataError string func (e emptyDataError) Error() string { return fmt.Sprintf("not empty %s ex

Re: [go-nuts] help

2024-02-18 Thread Steven Hartland
What’s your DATABASE_URL? If your on Windows make sure you use localhost not 127.0.0.1 as they aren’t necessarily the same thing On Sun, 18 Feb 2024 at 04:54, Sunday Ajayi wrote: > Hi guys, > Please I am having a little issue with my go project using docker. > > I set up my Postgres db in docker

Re: [go-nuts] Re: help with thread limit

2024-02-01 Thread Steven Hartland
Ignore that as it just triggers a panic if the limit is exceeded, however based on that I'm guessing it's not going to be possible. On Thu, 1 Feb 2024 at 19:01, Steven Hartland wrote: > Sounds sensible to me. > > I haven't read the entire thread, pun intended ;-), s

Re: [go-nuts] Re: help with thread limit

2024-02-01 Thread Steven Hartland
up. > > Thanks, > Steve > > On Thu, Feb 1, 2024 at 8:34 AM Steven Hartland > wrote: > >> To be honest I would question if its a usable solution if they are >> limiting that low on threads, so is the fix to switch or have the provider >> increase the limit to a

Re: [go-nuts] Re: help with thread limit

2024-02-01 Thread Steven Hartland
To be honest I would question if its a usable solution if they are limiting that low on threads, so is the fix to switch or have the provider increase the limit to a sensible number? On Thu, 1 Feb 2024 at 16:08, Steve Roth wrote: > Thanks to the people who suggested how to limit the number of ap

Re: [go-nuts] Disable false positive go vet check in tests per line?

2024-01-28 Thread Steven Hartland
Thanks Kurtis, that's a good workaround :) On Sun, 28 Jan 2024 at 21:24, Kurtis Rader wrote: > What happens if you just alias the var? > > argsCopy := args > fmt.Printf("%v\n", argsCopy) > > > On Sun, Jan 28, 2024 at 12:13 PM Steven Hartland < > s

[go-nuts] Disable false positive go vet check in tests per line?

2024-01-28 Thread Steven Hartland
When running a test I'm getting: missing ... in args forwarded to print-like function Usually this would be helpful as the pass in variadic should generally be expanded with ... but in this case I specifically want the result of args passed as a slice. Is there a way to disable go vet checks for

Re: [go-nuts] Re: Good examples of Go back ends?

2024-01-23 Thread Steven Hartland
It's high level, but there's some good stuff mentioned in https://github.com/avelino/awesome-go On Mon, 22 Jan 2024 at 15:23, george looshch wrote: > hi Jason, > > thanks a million for pointing out the vagueness of my question! English > isn’t my mother tongue so now i see where you’re coming fr

Re: [go-nuts] unix.Select with fd gotten from named pipe on macos behaves differently compared to linux

2023-12-21 Thread Steven Hartland
poll and select for this behavior was broken in FreeBSD up until 195423 was committed as detailed by this bug report . Given the MacOS and FreeBSD have related history I wouldn't be surprised if

Re: [go-nuts] CPU usage increasing day by day because of Cron

2023-07-06 Thread Steven Hartland
Your use of sync.WaitGroup looks strange. Typically you would expect to call wg.Add(1) before a goroutine is started, wg.Done() before it returns and wg.Wait() to ensure all goroutines have completed. This doesn't seem to be what you're doing. Consider restructuring to make best use of the gorouti

Re: [go-nuts] slog - potentially broken test

2023-07-03 Thread Steven Hartland
Looks like a bug, I suspect because you have a space in the path the path was quoted breaking the regexp as it's not expecting the final quote. Try editing the regexp to: ^time=\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}(Z|[+-]\d{2}:\d{2}) level=INFO source=.*logger_test.go:\d{3}"? msg=msg2$ On Mon

[go-nuts] pkg.go.dev down?

2023-03-08 Thread Steven Hartland
Is there an issue with pkg.go.dev atm as packages are failing to load after a long time with a 500 error for example time -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving

Re: [go-nuts] Best way to mark unused parameters/error values reported by linter

2023-03-06 Thread Steven Hartland
I would use the following if I truly wanted to ignore an error, but I would question if ignoring the error from os.Open was ever a good idea. If you want to handle a file not found error then do so, don't just ignore the error. file, _ := os.Open(name) //nolint: errcheck On Mon, 6 Mar 2023 at 20:1

Re: [go-nuts] go install of forked repo

2022-12-03 Thread Steven Hartland
Check out go work I achieve it’s exactly what you are looking for, allowing for projects to use temporary local versions of packages On Sat, 3 Dec 2022 at 11:55, Duncan Harris wrote: > This seems a noddy question but can't easily find an answer with Google > apparently. I may have lost the plot

Re: [go-nuts] imported and not used "errors"

2022-09-27 Thread Steven Hartland
Something is already running on localhost port 8080. use a different port. On Tue, 27 Sept 2022 at 16:15, Conor O'Neill wrote: > I am following a tutorial to great an API in Go with a framework called > Gin. > > I have imported errors and created a function like so; > > func createBook(c *gin.Co

Re: [go-nuts] How to check Cmd.ProcessState without triggering the race checker?

2022-07-25 Thread Steven Hartland
Looks like session already has what you need as you can check if session.Exited has been closed something like: select { case <- session.Exited: // Handle session has ended default: // Handle session hasn't ended } On Sat, 23 Jul 2022 at 21:39, TheDiveO wrote: > In my open source fi

Re: [go-nuts] Data race in sql package

2022-07-21 Thread Steven Hartland
I'm guessing that Michal is flagging is there no way to write safe code if your using stmt.QueryContext(ctx) and rows.Scan into a sql.RawBytes as QueryContext kicks off a go routine that monitors the ctx, closing rows if cancelled and that ctx can be cancelled at any time. The only thing that spri

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-14 Thread Steven Hartland
Any thoughts on my previous reply? On Mon, 4 Jul 2022 at 23:33, Steven Hartland wrote: > I'm not sure we're on the same page, so let me try and clarify. > > The files have multiple tracks, the standard audio and video and 3 > metadata tracks. I'm using the c

Re: [go-nuts] how to minimize the size of struct?

2022-07-14 Thread Steven Hartland
https://pkg.go.dev/reflect#Type.Size or https://pkg.go.dev/unsafe#Sizeof On Wed, 13 Jul 2022 at 08:00, xie cui wrote: > > https://github.com/orijtech/structslop/blob/13637e228c1a50d8444da1b71a83aff3b6536851/structslop.go#L246-L267 > why sort by can minimize the sizeof > struct? > is there some

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-04 Thread Steven Hartland
I'm not sure we're on the same page, so let me try and clarify. The files have multiple tracks, the standard audio and video and 3 metadata tracks. I'm using the command line option -map 0:m:handler_name:"" to identify the tracks to copy. Given a single file this works as expected, but as soon as

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I should mention that this one of a few fixes needed to enable successful copying of GoPro metadata when using concat to join files, but wanted to start with from its size was the simplest one :) On Sat, 2 Jul 2022 at 11:44, Steven Hartland wrote: > I'm using concat to join multiple fi

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
8x ... I believe the reason for the failure is that this early return prevents the metadata from being preserved. On Sun, 19 Jun 2022 at 21:18, Marton Balint wrote: > > > On Sun, 12 Jun 2022, Steven Hartland wrote: > > > Remove return after copying extradata as this prevents

[FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-12 Thread Steven Hartland
Remove return after copying extradata as this prevents metadata being duplicated correctly. Signed-off-by: Steven Hartland --- libavformat/concatdec.c | 1 - tests/ref/fate/concat-demuxer-simple2-lavf-ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [go-nuts] Re: No downloadable go1.18.1 version for darwin

2022-04-14 Thread Steven Hartland
Looks like this is fixed now. On Wed, 13 Apr 2022 at 15:48, Brian Candler wrote: > It's mentioned in the original announcement > : > > "macOS binary artifacts for Go 1.18.1 are not available at this time due > to an issue

Re: [go-nuts] encoding/json mistakenly transfer int64 format to string

2022-04-12 Thread Steven Hartland
First off, the package you're using for redis isn't maintained; you should switch to github.com/gomodule/redigo/redis instead, which will allow you to remove the c == nil check as that doesn't happen. In your example you're ignoring error from json.Marshal which could be hiding a problem, so I wou

Re: [go-nuts] GO routine never exits based on stop condition - unable to find the reason

2022-03-28 Thread Steven Hartland
ver saw this pattern before. Thanks for > your help !! > If you have any reference material for further reading for patterns like > this can you please share them. > > Regards, > Gowtham > > On Mon, 28 Mar 2022 at 12:21, Steven Hartland > wrote: > >> There is no guar

Re: [go-nuts] GO routine never exits based on stop condition - unable to find the reason

2022-03-28 Thread Steven Hartland
There is no guarantee that the select chooses the done case, so you need to check in work case as well e.g. https://go.dev/play/p/zAj_qfO4uMA On Mon, 28 Mar 2022 at 16:54, Gowtham Raj wrote: > In this example, we have a *worker*. The idea here is simulate clean > shutdown of all go routines base

Re: zfs mirrored pool dead after a disk death and reset

2022-02-25 Thread Steven Hartland
Have you tried removing the dead disk physically. I've seen in the past a bad disk sending causing bad data to be sent to the controller causing knock on issues. Also the output doesn't show multiple devices, only nvd0. I'm hoping you didn't use nv raid to create the mirror, as that means there's

Re: [go-nuts] Re: Advise about using go mod retract to fix pre go mod v2.0.0 tag

2022-01-04 Thread Steven Hartland
no "/v2" suffix, for compatibility with old code). > > Therefore, the Go toolchain will go look at whatever is latest for " > github.com/gomodule/redigo", then use the retractions there. It won't > look for "github.com/gomodule/redigo/v2". > On F

Re: [go-nuts] Re: Advise about using go mod retract to fix pre go mod v2.0.0 tag

2021-12-31 Thread Steven Hartland
r retractions, and > that would be in the v1 series (no v# in the URL, so must be v0 or v1). > > On Friday, December 3, 2021 at 6:53:04 AM UTC-8 Steven Hartland wrote: > >> One of the golang packages I maintain redigo had a v2.0.0 tag created >> before the introduction of

[go-nuts] Advise about using go mod retract to fix pre go mod v2.0.0 tag

2021-12-03 Thread Steven Hartland
One of the golang packages I maintain redigo had a v2.0.0 tag created before the introduction of go mod and this still causes challenges today. A kind soul pointed out go mod retract the other day in the h

Re: [go-nuts] Re: pkg.go.dev jump to broken?

2021-11-17 Thread Steven Hartland
Didn't touch anything on my side and it's working again today, error has gone from the console as well, so can only assume someone fixed something. Thanks for feedback Brian :) Regards Steve On Tue, 16 Nov 2021 at 20:44, Brian Candler wrote: > Works for me: Chrome 96.0.4664.45, macOS 10.

[go-nuts] pkg.go.dev jump to broken?

2021-11-16 Thread Steven Hartland
Clicking the jump to or pressing F on pkg.go.dev seems to be broken here. In Chrome console I'm seeing security warning about eval, which could be the cause: Content Security Policy of your site blocks the use of 'eval' in JavaScript` The Content Security Policy (CSP) prevents the evaluation of ar

[go-nuts] Re: Help getting database/sql pooling merged

2021-10-29 Thread Steven Hartland
Just a quick bump to see if we can get this over the line in time for the 1.18 release freeze in just a couple of days time? On Sat, 23 Oct 2021 at 00:29, Steven Hartland wrote: > There's been a long standing bug > <https://github.com/golang/go/issues/39471> in database/

[go-nuts] Help getting database/sql pooling merged

2021-10-22 Thread Steven Hartland
There's been a long standing bug in database/sql pooling which means SetConnMaxIdleTime doesn't work. I found and fixed the bug back in June of 2020, but have so far been unable to get this relatively si

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-18 Thread Steven Hartland
ls > downloading any of its dependencies recursively and doing the same thing... > I'm sure you can see how this can take some time -- especially for large > projects. > > Anyway, it sounds to me like what you're asking to do requires the use of > the type-checker

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-17 Thread Steven Hartland
> wrote: > I am not sure what "import external packages" means. > > Apart dot imports (which I have never seen used for real) why would you > need to load the imported packages? > > On Saturday, 16 October 2021 at 20:34:17 UTC+1 Steven Hartland wrote: > >&

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-16 Thread Steven Hartland
objKind = ast.Typ > case *types.Builtin: > objKind = ast.Fun > default: > return nil, fmt.Errorf("unexpected builtin %s of type %T", o.Name(), o) > } > obj := ast.NewObj(objKind, name) > if u.Insert(obj) != nil { > return nil, fmt.Errorf("types internal error: double

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-16 Thread Steven Hartland
t 2:13 PM Steven Hartland > wrote: > >> I converted my code to x/tools/go/packages >> <https://pkg.go.dev/golang.org/x/tools@v0.1.7/go/packages> and while it >> did solve the problem it's VERY slow in comparison. >> >> I have a set of 21 tests ope

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-15 Thread Steven Hartland
: directory /tmp/tests76985775 outside available modules I fixed it by calling ioutil.TempDir with "." but that's not ideal. Thoughts? On Tue, 12 Oct 2021 at 13:42, Steven Hartland wrote: > Thanks David, much appreciated, I will have a look at both. > > When migrating from g

Re: [go-nuts] ast.NewPackage errors for built in types

2021-10-12 Thread Steven Hartland
Thanks David, much appreciated, I will have a look at both. When migrating from go/ast to go/types did you hit anything of note I should look out for? On Mon, 11 Oct 2021 at 17:06, David Finkel wrote: > > > On Mon, Oct 11, 2021 at 5:48 AM Steven Hartland > wrote: > >> If

[go-nuts] ast.NewPackage errors for built in types

2021-10-11 Thread Steven Hartland
If the ast.Files passed to ast.NewPackage includes built in types such as int it returns an error e.g. file1.go:5:6: undeclared name: int Is there a way to prevent that? Playground example: https://play.golang.org/p/Yg30TTzoLHP My goal is to take multiple files, resolve inter file dependencies e

Re: [go-nuts] What is the point of gzip Reader.Close?

2021-06-21 Thread Steven Hartland
Internally close calls z.decompressor.Close() where decompressor is typically obtained via flat.NewReader(r) which states NewReader returns a new ReadCloser that can be used to read the uncompressed version of r. If r does not also implement io.ByteReader, the decompressor may read more data than

Re: [go-nuts] no generic ?

2021-02-22 Thread Steven Hartland
The proposal to add generics to go has been accepted and it is due to be added in v1.18 On Sun, 21 Feb 2021 at 21:02, alex-coder wrote: > Hi all ! > I'm just a beginner in Golang and I see a discussion in regards to > introduce generics into Go. > But is it possible to provide an example where i

Re: [go-nuts] When set time.Location, will be detected Data Race

2020-07-24 Thread Steven Hartland
Always serialise t.UTC()? On 24/07/2020 04:26, Mike Cohen wrote: To be clear, the time.MarshalJSON() function produces valid RFC 3339 timestamps which allow arbitrary timezones. This means that local time offset is used in the string representation. Although all representations are technically

Re: [go-nuts] Re: Variadic Arguments and Interfaces

2020-05-17 Thread Steven Hartland
Did you use the correct calling convension e.g. db.Query(query, cond...) The ... makes the slice variadic, passing echData.Active, exchData.Role instead of just a interface slice On 17/05/2020 23:27, Saied Seghatoleslami wrote: I hate to dig up something from 2012, but I have come across a sim

Re: [go-nuts] Too many open files / broken pipe issue.

2020-05-08 Thread Steven Hartland
Few things which may help: 1. Use pprof to look at goroutines, see if you have a leak there. 2. What does linux utility lsof say? Don't forget that each network connection uses a "file" so it may not be a real file hand instead a network socket, which given your screen shot could be due to netw

Re: vfs.zfs.min_auto_ashift and OpenZFS

2020-05-01 Thread Steven Hartland
Looks like it should still be there if your using the in tree ZFS: https://svnweb.freebsd.org/base/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c?revision=358333&view=markup#l144 On 01/05/2020 19:03, Graham Perrin wrote: In my sysctl.conf: vfs.zfs.min_auto_ashift=12 – if I recall c

Re: make kernel ignore broken SATA disk

2020-04-12 Thread Steven Hartland
On 12/04/2020 18:08, Stefan Bethke wrote: Am 12.04.2020 um 19:03 schrieb Slawa Olhovchenkov : Now I can't boot into single user mode anymore, ZFS just waits forever, and the kernel is printing an endless chain of SATA error messages. I really need a way to remove the broken disk before ZFS tri

Re: [go-nuts] go commands hang indefinitely

2020-04-09 Thread Steven Hartland
What happens if you kill -ABRT the process? On Fri, 10 Apr 2020 at 01:16, Juan Monroy-Nieto wrote: > Hello everyone, I am compelled to stop just lurking. > > Go Version 1.14.1 on MacOS Mohave. > > Similarly to a recent post >

Re: SFP+ on PRO/10GbE

2020-03-25 Thread Steven Hartland
een rebooted > since going to 10G. > > Is that what you meant? > > On Tue, Mar 24, 2020, at 6:48 PM, Steven Hartland wrote: > > Watch out for the fact some nics don't fully initialise until they are > > given an IP. > > > > On 24/03/2020 21:45, Dan Langill

Re: SFP+ on PRO/10GbE

2020-03-24 Thread Steven Hartland
Watch out for the fact some nics don't fully initialise until they are given an IP. On 24/03/2020 21:45, Dan Langille wrote: On Tue, Mar 24, 2020, at 4:58 PM, Sergey Akhmatov wrote: On 2020-03-24 11:22 PM, Dan Langille wrote: media: Ethernet autoselect (1000baseSX ) status: ac

[go-nuts] godoc.org - Internal server error

2020-01-19 Thread Steven Hartland
Looks like somethings wrong with godoc.org atm, not sure who maintains this as every page just errors for me ATM, hence reaching out here in the hope someone who does reads this list. An example is accessing: https://godoc.org/github.com/spf13/pflag Internal server error. -- You received this

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Steven Hartland
Aren’t the current and suggested the same there or do I need more coffee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we fr

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Steven Hartland
Aren’t the current and suggested the same there or do I need more coffee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we fr

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-18 Thread Steven Hartland
Thanks for all the feedback Warner, some more comments in line below, would be interested in your thoughts. On 17/12/2019 02:53, Warner Losh wrote: On Mon, Dec 16, 2019, 5:28 PM Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Be aware that ZFS already does

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-18 Thread Steven Hartland
Thanks for all the feedback Warner, some more comments in line below, would be interested in your thoughts. On 17/12/2019 02:53, Warner Losh wrote: On Mon, Dec 16, 2019, 5:28 PM Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Be aware that ZFS already does

Re: svn commit: r355837 - head/sys/cam

2019-12-16 Thread Steven Hartland
Sticky keyboard there Warner? On a more serious note the fact that the controllers lie about the underlying location of data, the impact of skipping the TRIM requests can have a much more serious impact than one might think depending on the drive, so this type of optimisation can significantly

Re: svn commit: r355837 - head/sys/cam

2019-12-16 Thread Steven Hartland
Sticky keyboard there Warner? On a more serious note the fact that the controllers lie about the underlying location of data, the impact of skipping the TRIM requests can have a much more serious impact than one might think depending on the drive, so this type of optimisation can significantly

Re: svn commit: r355832 - head/sys/cam

2019-12-16 Thread Steven Hartland
What if any is the impact on request ordering with this new delayed TRIM? On 17/12/2019 00:13, Warner Losh wrote: Author: imp Date: Tue Dec 17 00:13:21 2019 New Revision: 355832 URL: https://svnweb.freebsd.org/changeset/base/355832 Log: Add rate limiters to TRIM. Add rate limiters to

Re: svn commit: r355832 - head/sys/cam

2019-12-16 Thread Steven Hartland
What if any is the impact on request ordering with this new delayed TRIM? On 17/12/2019 00:13, Warner Losh wrote: Author: imp Date: Tue Dec 17 00:13:21 2019 New Revision: 355832 URL: https://svnweb.freebsd.org/changeset/base/355832 Log: Add rate limiters to TRIM. Add rate limiters to

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-16 Thread Steven Hartland
Be aware that ZFS already does a pretty decent job of this already, so the statement about upper layers isn't true for all. It even has different priorities for different request types so I'm a little concerned that doing it at both layers could cause issues. In addition to this if its anythin

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-16 Thread Steven Hartland
Be aware that ZFS already does a pretty decent job of this already, so the statement about upper layers isn't true for all. It even has different priorities for different request types so I'm a little concerned that doing it at both layers could cause issues. In addition to this if its anythin

Re: svn commit: r355430 - head/sys/cam/scsi

2019-12-06 Thread Steven Hartland
If the illegal chars where removed or replaced would the result be useful, if so might that be a better approach? On Fri, 6 Dec 2019 at 00:06, Alan Somers wrote: > Author: asomers > Date: Fri Dec 6 00:06:05 2019 > New Revision: 355430 > URL: https://svnweb.freebsd.org/changeset/base/355430 > >

Re: svn commit: r355430 - head/sys/cam/scsi

2019-12-06 Thread Steven Hartland
If the illegal chars where removed or replaced would the result be useful, if so might that be a better approach? On Fri, 6 Dec 2019 at 00:06, Alan Somers wrote: > Author: asomers > Date: Fri Dec 6 00:06:05 2019 > New Revision: 355430 > URL: https://svnweb.freebsd.org/changeset/base/355430 > >

Re: Slow zfs destroy

2019-11-28 Thread Steven Hartland
It may well depend on the extent of the deletes occurring. Have you tried disabling TRIM to see if it eliminates the delay?     Regards     Steve On 28/11/2019 09:59, Eugene Grosbein wrote: 28.11.2019 14:26, Steven Hartland wrote: As you mentioned it’s on SSD you could be suffering from

Re: Slow zfs destroy

2019-11-27 Thread Steven Hartland
As you mentioned it’s on SSD you could be suffering from poor TRIM performance from your devices if you run gstat -pd you’ll be able to get an indication if this is the case. On Thu, 28 Nov 2019 at 06:50, Eugene Grosbein wrote: > Hi! > > Is it normal that "zfs destroy" for one ZVOL with attribut

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Steven Hartland
Pretty sure we had at least two systems using root with log just fine, so would be interested to know why this isn’t supported anymore? On Sun, 3 Nov 2019 at 13:26, Toomas Soome wrote: > Author: tsoome > Date: Sun Nov 3 13:25:47 2019 > New Revision: 354283 > URL: https://svnweb.freebsd.org/chan

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Steven Hartland
Pretty sure we had at least two systems using root with log just fine, so would be interested to know why this isn’t supported anymore? On Sun, 3 Nov 2019 at 13:26, Toomas Soome wrote: > Author: tsoome > Date: Sun Nov 3 13:25:47 2019 > New Revision: 354283 > URL: https://svnweb.freebsd.org/chan

Re: [go-nuts] go 1.13.1 (linux x64): time.After not working as expected

2019-10-14 Thread Steven Hartland
Your not checking done in your for loop. On 14/10/2019 13:39, Jeff Kayser wrote: I'm working through the most excellent book "Concurrency in Go", doing the example on page 162-166.  My code is here: https://play.golang.org/p/7kokkAIdhov The program is not triggering the timeout section of the

Re: [go-nuts] Is there a preferred REDIS driver or go psckage?

2019-09-09 Thread Steven Hartland
https://github.com/gomodule/redigo/ written by Gary Burd is still maintained. We actively use it in production heavily. On Mon, 9 Sep 2019 at 19:19, joe mcguckin wrote: > > > Thanks, > > Joe > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group.

Re: [go-nuts] Re: Option to disable version validation in 1.13?

2019-09-04 Thread Steven Hartland
n > 42439a7714cc' >> go.mod >echo 'replace github.com/golangci/lint-1 > v0.0.0-20180610141402-ee948d087217 => github.com/golangci/lint-1 > ee948d087217' >> go.mod >echo 'replace mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34 => &

[go-nuts] Option to disable version validation in 1.13?

2019-09-03 Thread Steven Hartland
Trying to update to 1.13 but the new version validation breaks golangci-lint installs with: invalid pseudo-version: does not match version-control timestamp https://golang.org/doc/go1.13#version-validation lists a number of options if you're maintaining a module but nothing seems relevant for

svn commit: r346594 - head/sbin/camcontrol

2019-09-03 Thread Steven Hartland
Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it usin

svn commit: r346594 - head/sbin/camcontrol

2019-09-03 Thread Steven Hartland
Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it usin

Re: [go-nuts] By passing go type check when performing bitwise operator

2019-09-01 Thread Steven Hartland
This has been changed in the upcoming 1.13 release, so you might want to try the latest release candidate. On 01/09/2019 19:03, Albert Tedja wrote:  I am trying to perform some bitwise operators, but Go is not letting me because the mask is an uint and the values are int. Setting the mask to i

Re: [go-nuts] Goroutine scheduled 10 seconds too late

2019-08-24 Thread Steven Hartland
Out of interest what OS? Is the machine virtualised? You might want to try doing an OS syscall trace to see if it’s stuck in an OS call for some reason. Regards Steve On Sat, 24 Aug 2019 at 03:37, Michael Andersen wrote: > This is built with go 1.12.5, incidentally, but I have seen this on

Re: [go-nuts] Re: Tips for reproducing flaky Go tests

2019-08-17 Thread Steven Hartland
We’ve found stress invaluable in helping to reproduce flaky tests https://godoc.org/golang.org/x/tools/cmd/stress On Sat, 17 Aug 2019 at 01:50, Maxim Fateev wrote: > I wish Go had a deterministic execution mode with predefined randomization > seed. The to reproduce such test you would only need

Re: [go-nuts] Re: Build issues on FreeBSD ZoF "unexpected stale targets"

2019-07-20 Thread Steven Hartland
You might want to see if dtrace can shed some light on this? On Sat, 20 Jul 2019 at 01:25, wrote: > > > On Friday, July 19, 2019 at 2:24:30 PM UTC-7, Steven Hartland wrote: >> >> Mat is actually running a non-standard kernel, with the ZFS filesystem >> from the

Re: [go-nuts] Re: Build issues on FreeBSD ZoF "unexpected stale targets"

2019-07-19 Thread Steven Hartland
Mat is actually running a non-standard kernel, with the ZFS filesystem from the core OS replaced with a ZFS version derived from Linux ZFS port. I've not looked at the details of the port, but one suggestion would be do you see the same behaviour if you build on UFS volume while still running

Re: [go-nuts] ioutil.ReadDir error

2019-07-19 Thread Steven Hartland
If you want this behavior you'll need to use the lower level methods in the os package .     Regards     Steve On 19/07/2019 11:54, rob wrote: I have this in my code   files, err := ioutil.ReadDir(CleanDirName)   if err != nil {     log.Println(

Re: [go-nuts] Does this code safe?

2019-07-05 Thread Steven Hartland
Use the same method for both Load and Set, also your example will never complete as your for loops will run forever. On 05/07/2019 15:53, Cholerae Hu wrote: | package main import ( "sync/atomic" "sync" ) func main() { var n int32 var m sync.Mutex var wg sync.WaitGroup wg.Add(2) go func() { fo

Re: [go-nuts] Re: Go will shine on huge web projects, but how about simple ones?

2019-06-08 Thread Steven Hartland
Couple of things that you might want to investigate: 1. Is SetReadDeadline the same as SO_RCVTIMEO (vm vs socket)? 2. Is c.Close()  the same as shutdown (flushes vs doesn't)? 3. Is print is the same as fmt.Fprintf / c.Write (buffered vs unbuffered)? With the go I'd be tempted to put everything fr

Re: [go-nuts] Creating HTTP API with extra '/' (without quotes) at the end of the route, takes only 'GET' request.

2019-06-07 Thread Steven Hartland
I believe this is documented here: https://golang.org/pkg/net/http/#ServeMux On 07/06/2019 07:46, Mayank Gupta wrote: Hi All, I wanted to make sure before filing an issue on Github. Here's the code using net/http package to create a restful web API. If I hit any route using Postman app, no matte

Re: ZFS...

2019-06-07 Thread Steven Hartland
Great to hear you got your data back even after all the terrible luck you suffered! Regards Steve On Fri, 7 Jun 2019 at 00:49, Michelle Sullivan wrote: > Michelle Sullivan wrote: > >> On 02 May 2019, at 03:39, Steven Hartland > wrote: > >> > >> > &g

Re: [go-nuts] Re: Go 1.8 port to FreeBSD/PowerPC64

2019-06-04 Thread Steven Hartland
Newer versions of go require an older version of go (1.4) to bootstrap, that may be related to your issue? On 04/06/2019 04:21, Curtis Hamilton wrote: Currently. the FreeBSD port only supports "i386 amd64 armv6 armv7" and does not support powerpc64 (ppc64). I'm starting with an older version

Re: svn commit: r348255 - head/sys/kern

2019-05-24 Thread Steven Hartland
Just wanted to say I really appreciate the details in this commit message. Its often the case the message get overlooked when it comes to the time needed to write a truly useful message to others and this a great example of the quality we should all try to follow. Regards Steve On Fri, 24 Ma

Re: svn commit: r348255 - head/sys/kern

2019-05-24 Thread Steven Hartland
Just wanted to say I really appreciate the details in this commit message. Its often the case the message get overlooked when it comes to the time needed to write a truly useful message to others and this a great example of the quality we should all try to follow. Regards Steve On Fri, 24 Ma

Re: replacement for lang/phantomjs [deprecated]

2019-05-22 Thread Steven Hartland
Pretty sure chrome has a headless mode now, perhaps you could use that. On 22/05/2019 12:39, dangerwillrobinsondan...@gmail.com wrote: On May 22, 2019, at 19:33, Kurt Jaeger wrote: Hi! The port lang/phantomjs is marked as deprecated / expired 2019-05-15. Is there any alternative in the p

Re: FreeBSD flood of 8 breakage announcements in 3 mins.

2019-05-15 Thread Steven Hartland
Is disagree, having them hatched causes us less work not more, as others have said one update not many, which result in one outage of systems that need patching not many. Regards Steve On Wed, 15 May 2019 at 16:48, Julian H. Stacey wrote: > Hi, Reference: > > From: Alan Somers >

svn commit: r347384 - stable/12/sbin/camcontrol

2019-05-09 Thread Steven Hartland
Author: smh Date: Thu May 9 08:35:50 2019 New Revision: 347384 URL: https://svnweb.freebsd.org/changeset/base/347384 Log: MFC r346594: Add ATA power mode support to camcontrol Sponsored by: Multiplay Modified: stable/12/sbin/camcontrol/camcontrol.8 stable/12/sbin/camcontrol/camcontrol

Re: [go-nuts] Re: using channels to gather bundles from inputs for batch processing

2019-05-02 Thread Steven Hartland
You can see it doesn't wait by adding a counter as seen here: https://play.golang.org/p/-eqKggUEjhQ On 02/05/2019 21:09, Louki Sumirniy wrote: I have been spending my time today getting my knowledge of this subject adequate enough to use channels for a UDP transport with FEC creating sharded pi

Re: [go-nuts] Re: using channels to gather bundles from inputs for batch processing

2019-05-02 Thread Steven Hartland
Without the wait group it doesn't wait, so you're not guaranteed for all / any of the goroutines to complete. On 02/05/2019 21:09, Louki Sumirniy wrote: I have been spending my time today getting my knowledge of this subject adequate enough to use channels for a UDP transport with FEC creating

Re: ZFS...

2019-05-01 Thread Steven Hartland
On 01/05/2019 15:53, Michelle Sullivan wrote: Paul Mather wrote: On Apr 30, 2019, at 11:17 PM, Michelle Sullivan wrote: Been there done that though with ext2 rather than UFS..  still got all my data back... even though it was a nightmare.. Is that an implication that had all your data b

  1   2   3   4   5   6   7   8   9   10   >