Re: [tin-bugs] Tin incorrectly parses comment blocks in CFWS blocks (per RFC5322 3.2.2)

2024-11-11 Thread Stephen Hurd
Sorry about the formatting, I'm between mail clients right now, and using Thunderbird. On 2024-11-11 18:39, Nicholas Boel wrote: Either way, I've included Stephen, one of the developers of the server software I'm using. As we were in a lengthy conversation last night about this and I'm not muc

svn commit: r348999 - in head: bin/stty share/man/man4 sys/dev/uart sys/dev/usb/serial sys/kern sys/sys

2019-06-12 Thread Stephen Hurd
Author: shurd Date: Wed Jun 12 18:07:04 2019 New Revision: 348999 URL: https://svnweb.freebsd.org/changeset/base/348999 Log: Some devices take undesired actions when RTS and DTR are asserted. Some development boards for example will reset on DTR, and some radio interfaces will transmit on RT

svn commit: r348999 - in head: bin/stty share/man/man4 sys/dev/uart sys/dev/usb/serial sys/kern sys/sys

2019-06-12 Thread Stephen Hurd
Author: shurd Date: Wed Jun 12 18:07:04 2019 New Revision: 348999 URL: https://svnweb.freebsd.org/changeset/base/348999 Log: Some devices take undesired actions when RTS and DTR are asserted. Some development boards for example will reset on DTR, and some radio interfaces will transmit on RT

svn commit: r347542 - in stable/12: share/man/man4 sys/net

2019-05-13 Thread Stephen Hurd
Author: shurd Date: Mon May 13 18:48:08 2019 New Revision: 347542 URL: https://svnweb.freebsd.org/changeset/base/347542 Log: MFC r346708: iflib: Better control over queue core assignment By default, cores are now assigned to queues in a sequential manner rather than all NICs starting

svn commit: r346708 - in head: share/man/man4 sys/net

2019-04-25 Thread Stephen Hurd
Author: shurd Date: Thu Apr 25 21:24:56 2019 New Revision: 346708 URL: https://svnweb.freebsd.org/changeset/base/346708 Log: iflib: Better control over queue core assignment By default, cores are now assigned to queues in a sequential manner rather than all NICs starting at the first core

svn commit: r346708 - in head: share/man/man4 sys/net

2019-04-25 Thread Stephen Hurd
Author: shurd Date: Thu Apr 25 21:24:56 2019 New Revision: 346708 URL: https://svnweb.freebsd.org/changeset/base/346708 Log: iflib: Better control over queue core assignment By default, cores are now assigned to queues in a sequential manner rather than all NICs starting at the first core

svn commit: r344472 - stable/11/sys/net

2019-02-22 Thread Stephen Hurd
Author: shurd Date: Fri Feb 22 18:24:57 2019 New Revision: 344472 URL: https://svnweb.freebsd.org/changeset/base/344472 Log: MFC r333131: Fix iflib_encap() EFBIG handling bugs 1) Don't give up if m_collapse() fails. Rather than giving up, try m_defrag() immediately. 2) Fix a le

svn commit: r344471 - stable/12/sys/net

2019-02-22 Thread Stephen Hurd
Author: shurd Date: Fri Feb 22 18:02:46 2019 New Revision: 344471 URL: https://svnweb.freebsd.org/changeset/base/344471 Log: MFC r344162: iflib: Improve return values of interrupt handlers. iflib was returning FILTER_HANDLED, in cases where FILTER_STRAY was more correct. This potenti

svn commit: r344162 - head/sys/net

2019-02-15 Thread Stephen Hurd
Author: shurd Date: Fri Feb 15 18:51:43 2019 New Revision: 344162 URL: https://svnweb.freebsd.org/changeset/base/344162 Log: iflib: Improve return values of interrupt handlers. iflib was returning FILTER_HANDLED, in cases where FILTER_STRAY was more correct. This potentially caused issues

svn commit: r344162 - head/sys/net

2019-02-15 Thread Stephen Hurd
Author: shurd Date: Fri Feb 15 18:51:43 2019 New Revision: 344162 URL: https://svnweb.freebsd.org/changeset/base/344162 Log: iflib: Improve return values of interrupt handlers. iflib was returning FILTER_HANDLED, in cases where FILTER_STRAY was more correct. This potentially caused issues

svn commit: r343441 - stable/12/sys/netinet

2019-01-25 Thread Stephen Hurd
Author: shurd Date: Fri Jan 25 18:30:12 2019 New Revision: 343441 URL: https://svnweb.freebsd.org/changeset/base/343441 Log: MFC r343047: Fix window update issue when scaling disabled When the TCP window scale option is not used, and the window opens up enough in one soreceive, a win

svn commit: r343099 - stable/11/sys/net

2019-01-16 Thread Stephen Hurd
Author: shurd Date: Wed Jan 16 19:20:14 2019 New Revision: 343099 URL: https://svnweb.freebsd.org/changeset/base/343099 Log: MFC r342855: Use iflib_if_init_locked() during resume instead of iflib_init_locked(). iflib_init_locked() assumes that iflib_stop() has been called, however, i

svn commit: r343047 - head/sys/netinet

2019-01-15 Thread Stephen Hurd
Author: shurd Date: Tue Jan 15 17:40:19 2019 New Revision: 343047 URL: https://svnweb.freebsd.org/changeset/base/343047 Log: Fix window update issue when scaling disabled When the TCP window scale option is not used, and the window opens up enough in one soreceive, a window update will no

svn commit: r343047 - head/sys/netinet

2019-01-15 Thread Stephen Hurd
Author: shurd Date: Tue Jan 15 17:40:19 2019 New Revision: 343047 URL: https://svnweb.freebsd.org/changeset/base/343047 Log: Fix window update issue when scaling disabled When the TCP window scale option is not used, and the window opens up enough in one soreceive, a window update will no

svn commit: r343024 - stable/12/sys/net

2019-01-14 Thread Stephen Hurd
Author: shurd Date: Mon Jan 14 18:40:37 2019 New Revision: 343024 URL: https://svnweb.freebsd.org/changeset/base/343024 Log: MFC r342855: Use iflib_if_init_locked() during resume instead of iflib_init_locked(). iflib_init_locked() assumes that iflib_stop() has been called, however, i

svn commit: r342855 - head/sys/net

2019-01-07 Thread Stephen Hurd
Author: shurd Date: Mon Jan 7 23:46:54 2019 New Revision: 342855 URL: https://svnweb.freebsd.org/changeset/base/342855 Log: Use iflib_if_init_locked() during resume instead of iflib_init_locked(). iflib_init_locked() assumes that iflib_stop() has been called, however, it is not called fo

svn commit: r342855 - head/sys/net

2019-01-07 Thread Stephen Hurd
Author: shurd Date: Mon Jan 7 23:46:54 2019 New Revision: 342855 URL: https://svnweb.freebsd.org/changeset/base/342855 Log: Use iflib_if_init_locked() during resume instead of iflib_init_locked(). iflib_init_locked() assumes that iflib_stop() has been called, however, it is not called fo

svn commit: r342194 - stable/12/sys/net

2018-12-18 Thread Stephen Hurd
Author: shurd Date: Tue Dec 18 17:31:31 2018 New Revision: 342194 URL: https://svnweb.freebsd.org/changeset/base/342194 Log: MFC r341824: Fix !tx_abdicate error from r336560 r336560 was supposed to restore pre-r323954 behaviour when tx_abdicate is not set (the default case). However,

svn commit: r341824 - head/sys/net

2018-12-11 Thread Stephen Hurd
Author: shurd Date: Tue Dec 11 17:46:01 2018 New Revision: 341824 URL: https://svnweb.freebsd.org/changeset/base/341824 Log: Fix !tx_abdicate error from r336560 r336560 was supposed to restore pre-r323954 behaviour when tx_abdicate is not set (the default case). However, it appears that r

svn commit: r341824 - head/sys/net

2018-12-11 Thread Stephen Hurd
Author: shurd Date: Tue Dec 11 17:46:01 2018 New Revision: 341824 URL: https://svnweb.freebsd.org/changeset/base/341824 Log: Fix !tx_abdicate error from r336560 r336560 was supposed to restore pre-r323954 behaviour when tx_abdicate is not set (the default case). However, it appears that r

svn commit: r341427 - in stable/12/sys/dev: ixgbe ixl

2018-12-03 Thread Stephen Hurd
Author: shurd Date: Mon Dec 3 15:18:35 2018 New Revision: 341427 URL: https://svnweb.freebsd.org/changeset/base/341427 Log: MFC r341156: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in

svn commit: r341156 - in head/sys/dev: ixgbe ixl

2018-11-28 Thread Stephen Hurd
Author: shurd Date: Wed Nov 28 17:37:17 2018 New Revision: 341156 URL: https://svnweb.freebsd.org/changeset/base/341156 Log: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in the count of co

svn commit: r341156 - in head/sys/dev: ixgbe ixl

2018-11-28 Thread Stephen Hurd
Author: shurd Date: Wed Nov 28 17:37:17 2018 New Revision: 341156 URL: https://svnweb.freebsd.org/changeset/base/341156 Log: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in the count of co

svn commit: r340735 - releng/12.0/sys/net

2018-11-21 Thread Stephen Hurd
Author: shurd Date: Wed Nov 21 17:33:19 2018 New Revision: 340735 URL: https://svnweb.freebsd.org/changeset/base/340735 Log: MFS r340729: Prevent POLA violation with TSO/CSUM offload Ensure that any time CSUM_IP_TSO or CSUM_IP6_TSO is set that the corresponding CSUM_IP6?_TCP / CSUM_I

svn commit: r340729 - stable/12/sys/net

2018-11-21 Thread Stephen Hurd
Author: shurd Date: Wed Nov 21 17:14:57 2018 New Revision: 340729 URL: https://svnweb.freebsd.org/changeset/base/340729 Log: MFC r340435: Prevent POLA violation with TSO/CSUM offload Ensure that any time CSUM_IP_TSO or CSUM_IP6_TSO is set that the corresponding CSUM_IP6?_TCP / CSUM_I

svn commit: r340634 - releng/12.0/sys/net

2018-11-19 Thread Stephen Hurd
Author: shurd Date: Mon Nov 19 16:40:19 2018 New Revision: 340634 URL: https://svnweb.freebsd.org/changeset/base/340634 Log: MFS r340629 r340434: Fix leaks caused by ifc_nhwtxqs never being initialized (broken by r333502) and clear the last ring in the case where isc_nfl != isc_nrxqs

svn commit: r340629 - stable/12/sys/net

2018-11-19 Thread Stephen Hurd
Author: shurd Date: Mon Nov 19 15:18:30 2018 New Revision: 340629 URL: https://svnweb.freebsd.org/changeset/base/340629 Log: MFC r340434, r340445 r340434: Fix leaks caused by ifc_nhwtxqs never being initialized r333502 removed initialization of ifc_nhwtxqs, and it's not clear there

svn commit: r340445 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 20:36:18 2018 New Revision: 340445 URL: https://svnweb.freebsd.org/changeset/base/340445 Log: Clear RX completion queue state veriables in iflib_stop() iflib_stop() was not resetting the rxq completion queue state variables. This meant that for any driver th

svn commit: r340445 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 20:36:18 2018 New Revision: 340445 URL: https://svnweb.freebsd.org/changeset/base/340445 Log: Clear RX completion queue state veriables in iflib_stop() iflib_stop() was not resetting the rxq completion queue state variables. This meant that for any driver th

svn commit: r340435 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 15:23:39 2018 New Revision: 340435 URL: https://svnweb.freebsd.org/changeset/base/340435 Log: Prevent POLA violation with TSO/CSUM offload Ensure that any time CSUM_IP_TSO or CSUM_IP6_TSO is set that the corresponding CSUM_IP6?_TCP / CSUM_IP flags are also s

svn commit: r340435 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 15:23:39 2018 New Revision: 340435 URL: https://svnweb.freebsd.org/changeset/base/340435 Log: Prevent POLA violation with TSO/CSUM offload Ensure that any time CSUM_IP_TSO or CSUM_IP6_TSO is set that the corresponding CSUM_IP6?_TCP / CSUM_IP flags are also s

svn commit: r340434 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 15:16:45 2018 New Revision: 340434 URL: https://svnweb.freebsd.org/changeset/base/340434 Log: Fix leaks caused by ifc_nhwtxqs never being initialized r333502 removed initialization of ifc_nhwtxqs, and it's not clear there's a need to copy it into the struct

svn commit: r340434 - head/sys/net

2018-11-14 Thread Stephen Hurd
Author: shurd Date: Wed Nov 14 15:16:45 2018 New Revision: 340434 URL: https://svnweb.freebsd.org/changeset/base/340434 Log: Fix leaks caused by ifc_nhwtxqs never being initialized r333502 removed initialization of ifc_nhwtxqs, and it's not clear there's a need to copy it into the struct

svn commit: r340366 - stable/12/sys/dev/e1000

2018-11-12 Thread Stephen Hurd
Author: shurd Date: Mon Nov 12 16:28:07 2018 New Revision: 340366 URL: https://svnweb.freebsd.org/changeset/base/340366 Log: MFC r340310: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in

svn commit: r340365 - stable/12/sys/net

2018-11-12 Thread Stephen Hurd
Author: shurd Date: Mon Nov 12 16:08:14 2018 New Revision: 340365 URL: https://svnweb.freebsd.org/changeset/base/340365 Log: MFC r340236: Fix rxcsum issue introduced in r338838 r338838 attempted to fix issues with rxcsum and rxcsum6. However, the rxcsum bits were set as though if_set

svn commit: r340310 - head/sys/dev/e1000

2018-11-09 Thread Stephen Hurd
Author: shurd Date: Fri Nov 9 22:18:43 2018 New Revision: 340310 URL: https://svnweb.freebsd.org/changeset/base/340310 Log: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in the count of co

svn commit: r340310 - head/sys/dev/e1000

2018-11-09 Thread Stephen Hurd
Author: shurd Date: Fri Nov 9 22:18:43 2018 New Revision: 340310 URL: https://svnweb.freebsd.org/changeset/base/340310 Log: Fix first-packet completion The first packet after the ring is initialized was never completed as isc_txd_credits_update() would not include it in the count of co

svn commit: r340236 - head/sys/net

2018-11-07 Thread Stephen Hurd
Author: shurd Date: Wed Nov 7 19:31:48 2018 New Revision: 340236 URL: https://svnweb.freebsd.org/changeset/base/340236 Log: Fix rxcsum issue introduced in r338838 r338838 attempted to fix issues with rxcsum and rxcsum6. However, the rxcsum bits were set as though if_setcapenablebit() was

svn commit: r340236 - head/sys/net

2018-11-07 Thread Stephen Hurd
Author: shurd Date: Wed Nov 7 19:31:48 2018 New Revision: 340236 URL: https://svnweb.freebsd.org/changeset/base/340236 Log: Fix rxcsum issue introduced in r338838 r338838 attempted to fix issues with rxcsum and rxcsum6. However, the rxcsum bits were set as though if_setcapenablebit() was

svn commit: r340202 - in stable/12/sys: kern sys

2018-11-06 Thread Stephen Hurd
Author: shurd Date: Tue Nov 6 20:46:00 2018 New Revision: 340202 URL: https://svnweb.freebsd.org/changeset/base/340202 Log: MFC r339861: Drain grouptaskqueue of the gtask before detaching it. taskqgroup_detach() would remove the task even if it was running or enqueued, which could l

svn commit: r339861 - in head/sys: kern sys

2018-10-29 Thread Stephen Hurd
Author: shurd Date: Mon Oct 29 14:36:03 2018 New Revision: 339861 URL: https://svnweb.freebsd.org/changeset/base/339861 Log: Drain grouptaskqueue of the gtask before detaching it. taskqgroup_detach() would remove the task even if it was running or enqueued, which could lead to panics (see

svn commit: r339861 - in head/sys: kern sys

2018-10-29 Thread Stephen Hurd
Author: shurd Date: Mon Oct 29 14:36:03 2018 New Revision: 339861 URL: https://svnweb.freebsd.org/changeset/base/339861 Log: Drain grouptaskqueue of the gtask before detaching it. taskqgroup_detach() would remove the task even if it was running or enqueued, which could lead to panics (see

svn commit: r339267 - head/sys/dev/e1000

2018-10-09 Thread Stephen Hurd
Author: shurd Date: Tue Oct 9 20:16:19 2018 New Revision: 339267 URL: https://svnweb.freebsd.org/changeset/base/339267 Log: Use mbuf defines to construct csum offload masks rather than literals Reviewed by: erj Approved by: re (rgrimes) Sponsored by: Limelight Networks Differential

svn commit: r339267 - head/sys/dev/e1000

2018-10-09 Thread Stephen Hurd
Author: shurd Date: Tue Oct 9 20:16:19 2018 New Revision: 339267 URL: https://svnweb.freebsd.org/changeset/base/339267 Log: Use mbuf defines to construct csum offload masks rather than literals Reviewed by: erj Approved by: re (rgrimes) Sponsored by: Limelight Networks Differential

svn commit: r339207 - head/sys/dev/e1000

2018-10-05 Thread Stephen Hurd
Author: shurd Date: Fri Oct 5 20:16:20 2018 New Revision: 339207 URL: https://svnweb.freebsd.org/changeset/base/339207 Log: Fix igb corrupting checksums with BPF and VLAN When using a vlan with igb and the vlanhwcsum option, any mbufs which already had the TCP, UDP, or SCTP checksum calc

svn commit: r339207 - head/sys/dev/e1000

2018-10-05 Thread Stephen Hurd
Author: shurd Date: Fri Oct 5 20:16:20 2018 New Revision: 339207 URL: https://svnweb.freebsd.org/changeset/base/339207 Log: Fix igb corrupting checksums with BPF and VLAN When using a vlan with igb and the vlanhwcsum option, any mbufs which already had the TCP, UDP, or SCTP checksum calc

svn commit: r338840 - head/sys/dev/e1000

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 20:06:44 2018 New Revision: 338840 URL: https://svnweb.freebsd.org/changeset/base/338840 Log: Add IFCAP_TSO6 for igb It seems igb supports TSO6, but the capability got lost in the iflib update. Restore this capability. PR: 231476 Reported by

svn commit: r338840 - head/sys/dev/e1000

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 20:06:44 2018 New Revision: 338840 URL: https://svnweb.freebsd.org/changeset/base/338840 Log: Add IFCAP_TSO6 for igb It seems igb supports TSO6, but the capability got lost in the iflib update. Restore this capability. PR: 231476 Reported by

svn commit: r338838 - head/sys/net

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 19:35:35 2018 New Revision: 338838 URL: https://svnweb.freebsd.org/changeset/base/338838 Log: Fix capabilities handling for iflib drivers Various capabilities were not being handled correctly in the SIOCSIFCAP handler. Specifically: IFCAP_RXCSUM and IFC

svn commit: r338838 - head/sys/net

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 19:35:35 2018 New Revision: 338838 URL: https://svnweb.freebsd.org/changeset/base/338838 Log: Fix capabilities handling for iflib drivers Various capabilities were not being handled correctly in the SIOCSIFCAP handler. Specifically: IFCAP_RXCSUM and IFC

svn commit: r338834 - in head/share/man: man4 man9

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 18:24:32 2018 New Revision: 338834 URL: https://svnweb.freebsd.org/changeset/base/338834 Log: Add iflib.4 manpage The new manpage documents the tunables and statistic sysctls exposed by iflib. Reviewed by: bcr Approved by: re (gjb) Sponsored by: L

svn commit: r338834 - in head/share/man: man4 man9

2018-09-20 Thread Stephen Hurd
Author: shurd Date: Thu Sep 20 18:24:32 2018 New Revision: 338834 URL: https://svnweb.freebsd.org/changeset/base/338834 Log: Add iflib.4 manpage The new manpage documents the tunables and statistic sysctls exposed by iflib. Reviewed by: bcr Approved by: re (gjb) Sponsored by: L

svn commit: r338505 - head/sys/net

2018-09-06 Thread Stephen Hurd
Author: shurd Date: Thu Sep 6 18:51:52 2018 New Revision: 338505 URL: https://svnweb.freebsd.org/changeset/base/338505 Log: Clean up iflib sysctls Remove sysctls: txq_drain_encapfail - now a duplicate of encap_txd_encap_fail intr_link - was never incremented intr_msix - was never inc

svn commit: r338505 - head/sys/net

2018-09-06 Thread Stephen Hurd
Author: shurd Date: Thu Sep 6 18:51:52 2018 New Revision: 338505 URL: https://svnweb.freebsd.org/changeset/base/338505 Log: Clean up iflib sysctls Remove sysctls: txq_drain_encapfail - now a duplicate of encap_txd_encap_fail intr_link - was never incremented intr_msix - was never inc

svn commit: r338373 - head/sys/net

2018-08-29 Thread Stephen Hurd
Author: shurd Date: Wed Aug 29 16:21:34 2018 New Revision: 338373 URL: https://svnweb.freebsd.org/changeset/base/338373 Log: Fix compile error due to missing parenthesis in r338372 Approved by: re (gjb) Modified: head/sys/net/iflib.c Modified: head/sys/net/iflib.c =

svn commit: r338373 - head/sys/net

2018-08-29 Thread Stephen Hurd
Author: shurd Date: Wed Aug 29 16:21:34 2018 New Revision: 338373 URL: https://svnweb.freebsd.org/changeset/base/338373 Log: Fix compile error due to missing parenthesis in r338372 Approved by: re (gjb) Modified: head/sys/net/iflib.c Modified: head/sys/net/iflib.c =

svn commit: r338372 - head/sys/net

2018-08-29 Thread Stephen Hurd
Author: shurd Date: Wed Aug 29 15:55:25 2018 New Revision: 338372 URL: https://svnweb.freebsd.org/changeset/base/338372 Log: Fix potential data corruption in iflib The MP ring may have txq pointers enqueued. Previously, these were passed to m_free() when IFC_QFLUSH was set. This patch c

svn commit: r338372 - head/sys/net

2018-08-29 Thread Stephen Hurd
Author: shurd Date: Wed Aug 29 15:55:25 2018 New Revision: 338372 URL: https://svnweb.freebsd.org/changeset/base/338372 Log: Fix potential data corruption in iflib The MP ring may have txq pointers enqueued. Previously, these were passed to m_free() when IFC_QFLUSH was set. This patch c

svn commit: r336560 - head/sys/net

2018-07-20 Thread Stephen Hurd
Author: shurd Date: Fri Jul 20 17:45:26 2018 New Revision: 336560 URL: https://svnweb.freebsd.org/changeset/base/336560 Log: Add knob to control tx ring abdication. r323954 changed the mp ring behaviour when 64-bit atomics were available to abdicate the TX ring rather than having one beco

svn commit: r336560 - head/sys/net

2018-07-20 Thread Stephen Hurd
Author: shurd Date: Fri Jul 20 17:45:26 2018 New Revision: 336560 URL: https://svnweb.freebsd.org/changeset/base/336560 Log: Add knob to control tx ring abdication. r323954 changed the mp ring behaviour when 64-bit atomics were available to abdicate the TX ring rather than having one beco

svn commit: r336559 - head/sys/net

2018-07-20 Thread Stephen Hurd
Author: shurd Date: Fri Jul 20 17:24:45 2018 New Revision: 336559 URL: https://svnweb.freebsd.org/changeset/base/336559 Log: Improve netmap TX handling when TX IRQs are not used/supported Use the timer to poll for TX completions when there are outstanding TX slots. Track when the last dri

svn commit: r336559 - head/sys/net

2018-07-20 Thread Stephen Hurd
Author: shurd Date: Fri Jul 20 17:24:45 2018 New Revision: 336559 URL: https://svnweb.freebsd.org/changeset/base/336559 Log: Improve netmap TX handling when TX IRQs are not used/supported Use the timer to poll for TX completions when there are outstanding TX slots. Track when the last dri

svn commit: r334862 - head/sys/net

2018-06-08 Thread Stephen Hurd
Author: shurd Date: Fri Jun 8 21:49:19 2018 New Revision: 334862 URL: https://svnweb.freebsd.org/changeset/base/334862 Log: Remove tx task spinning added in r333686 This caused issues with PASTE. Just remove the reschedule since the DELAY() should be enough for use cases such as pkt-gen

svn commit: r334862 - head/sys/net

2018-06-08 Thread Stephen Hurd
Author: shurd Date: Fri Jun 8 21:49:19 2018 New Revision: 334862 URL: https://svnweb.freebsd.org/changeset/base/334862 Log: Remove tx task spinning added in r333686 This caused issues with PASTE. Just remove the reschedule since the DELAY() should be enough for use cases such as pkt-gen

svn commit: r334358 - in head/sys: kern net sys

2018-05-29 Thread Stephen Hurd
Author: shurd Date: Tue May 29 21:56:39 2018 New Revision: 334358 URL: https://svnweb.freebsd.org/changeset/base/334358 Log: iflib: mark irq allocation name parameter as constant The *name parameter passed to iflib_irq_alloc_generic and iflib_softirq_alloc_generic is never modified. Many

svn commit: r334358 - in head/sys: kern net sys

2018-05-29 Thread Stephen Hurd
Author: shurd Date: Tue May 29 21:56:39 2018 New Revision: 334358 URL: https://svnweb.freebsd.org/changeset/base/334358 Log: iflib: mark irq allocation name parameter as constant The *name parameter passed to iflib_irq_alloc_generic and iflib_softirq_alloc_generic is never modified. Many

svn commit: r334178 - stable/11/sys/dev/bnxt

2018-05-24 Thread Stephen Hurd
Author: shurd Date: Thu May 24 18:53:29 2018 New Revision: 334178 URL: https://svnweb.freebsd.org/changeset/base/334178 Log: MFC: r333792 Avoid spurious warnings when hardware LRO is enabled by not attempting to configure invalid VNICs. Approved by: re (gjb) Submitted by: bharga

svn commit: r333686 - head/sys/net

2018-05-16 Thread Stephen Hurd
Author: shurd Date: Wed May 16 21:03:22 2018 New Revision: 333686 URL: https://svnweb.freebsd.org/changeset/base/333686 Log: Work around lack of TX IRQs in iflib for netmap When poll() is called via netmap, txsync is initially called, and if there are no available buffers to reclaim, it w

svn commit: r333686 - head/sys/net

2018-05-16 Thread Stephen Hurd
Author: shurd Date: Wed May 16 21:03:22 2018 New Revision: 333686 URL: https://svnweb.freebsd.org/changeset/base/333686 Log: Work around lack of TX IRQs in iflib for netmap When poll() is called via netmap, txsync is initially called, and if there are no available buffers to reclaim, it w

svn commit: r333637 - head/sys/netinet

2018-05-15 Thread Stephen Hurd
Author: shurd Date: Tue May 15 16:54:41 2018 New Revision: 333637 URL: https://svnweb.freebsd.org/changeset/base/333637 Log: Check that ifma_protospec != NULL in inm_lookup If ifma_protospec is NULL when inm_lookup() is called, there is a dereference in a NULL struct pointer. This ensures

svn commit: r333637 - head/sys/netinet

2018-05-15 Thread Stephen Hurd
Author: shurd Date: Tue May 15 16:54:41 2018 New Revision: 333637 URL: https://svnweb.freebsd.org/changeset/base/333637 Log: Check that ifma_protospec != NULL in inm_lookup If ifma_protospec is NULL when inm_lookup() is called, there is a dereference in a NULL struct pointer. This ensures

svn commit: r333612 - head/sys/net

2018-05-14 Thread Stephen Hurd
Author: shurd Date: Mon May 14 20:06:49 2018 New Revision: 333612 URL: https://svnweb.freebsd.org/changeset/base/333612 Log: Replace rmlock with epoch in lagg Use the new epoch based reclamation API. Now the hot paths will not block at all, and the sx lock is used for the softc data. Thi

svn commit: r333612 - head/sys/net

2018-05-14 Thread Stephen Hurd
Author: shurd Date: Mon May 14 20:06:49 2018 New Revision: 333612 URL: https://svnweb.freebsd.org/changeset/base/333612 Log: Replace rmlock with epoch in lagg Use the new epoch based reclamation API. Now the hot paths will not block at all, and the sx lock is used for the softc data. Thi

svn commit: r333505 - in head/sys: netinet netinet6

2018-05-11 Thread Stephen Hurd
Author: shurd Date: Fri May 11 21:42:27 2018 New Revision: 333505 URL: https://svnweb.freebsd.org/changeset/base/333505 Log: Fix LORs in in6?_leave_group() r333175 updated the join_group functions, but not the leave_group ones. Reviewed by: sbruno Sponsored by: Limelight Networks

svn commit: r333505 - in head/sys: netinet netinet6

2018-05-11 Thread Stephen Hurd
Author: shurd Date: Fri May 11 21:42:27 2018 New Revision: 333505 URL: https://svnweb.freebsd.org/changeset/base/333505 Log: Fix LORs in in6?_leave_group() r333175 updated the join_group functions, but not the leave_group ones. Reviewed by: sbruno Sponsored by: Limelight Networks

svn commit: r333503 - stable/11/sys/net

2018-05-11 Thread Stephen Hurd
Author: shurd Date: Fri May 11 20:40:26 2018 New Revision: 333503 URL: https://svnweb.freebsd.org/changeset/base/333503 Log: MFC r29, r66, r73 r29: Fix off-by-one error requesting tx interrupt r66: Cleanup queues when iflib_device_register fails r73: Log iflib_tx

svn commit: r333501 - head/usr.sbin/mld6query

2018-05-11 Thread Stephen Hurd
Author: shurd Date: Fri May 11 19:37:18 2018 New Revision: 333501 URL: https://svnweb.freebsd.org/changeset/base/333501 Log: Fix mld6query(8) and add a new -g option The mld6query command relies on KAME behaviour which allows the ipv6mr_multiaddr member of the request object in a IPV6_JOI

svn commit: r333501 - head/usr.sbin/mld6query

2018-05-11 Thread Stephen Hurd
Author: shurd Date: Fri May 11 19:37:18 2018 New Revision: 333501 URL: https://svnweb.freebsd.org/changeset/base/333501 Log: Fix mld6query(8) and add a new -g option The mld6query command relies on KAME behaviour which allows the ipv6mr_multiaddr member of the request object in a IPV6_JOI

Re: iflib-if_em tests with HEAD and lagg panic [Was: Re: svn commit: r333338 - in stable/11/sys: dev/bnxt kern net sys]

2018-05-10 Thread Stephen Hurd
cksum failed" and > "[drm2:pid:hangcheck_hung]...GPU hung" issues to track/report, but since > finding Xorg's secret about "MatchIsKeyboard" took me too much time, > this is postponed. > > -harry > -- [image: Limelight Networks] <http://www.

Re: iflib-if_em tests with HEAD and lagg panic [Was: Re: svn commit: r333338 - in stable/11/sys: dev/bnxt kern net sys]

2018-05-10 Thread Stephen Hurd
PM, but 21:49... > So I think it's most likely any UTC+>2 time, so the revision I tested > was probably Diff 42294 <https://reviews.freebsd.org/B16487>. > > Just tell me if it was useful for you to test the latest revision again. > > -harry > --

Re: iflib-if_em tests with HEAD and lagg panic [Was: Re: svn commit: r333338 - in stable/11/sys: dev/bnxt kern net sys]

2018-05-08 Thread Stephen Hurd
0xfe008fe183f0 > ether_output_frame() at ether_output_frame+0xaa/frame 0xfe008fe18420 > ether_output() at ether_output+0x68b/frame 0xfe008fe184c0 > arprequest() at arprequest+0x474/frame 0xfe008fe185c0 > arp_ifinit() at arp_ifinit+0x58/frame 0xfe008fe18600 >

svn commit: r333373 - head/sys/net

2018-05-08 Thread Stephen Hurd
Author: shurd Date: Tue May 8 17:15:10 2018 New Revision: 73 URL: https://svnweb.freebsd.org/changeset/base/73 Log: iflib: print message when iflib_tx_structures_setup fails Print a message when iflib_tx_structures_setup fails, like we do for iflib_rx_structures_setup. Now t

svn commit: r333373 - head/sys/net

2018-05-08 Thread Stephen Hurd
Author: shurd Date: Tue May 8 17:15:10 2018 New Revision: 73 URL: https://svnweb.freebsd.org/changeset/base/73 Log: iflib: print message when iflib_tx_structures_setup fails Print a message when iflib_tx_structures_setup fails, like we do for iflib_rx_structures_setup. Now t

svn commit: r333366 - head/sys/net

2018-05-08 Thread Stephen Hurd
Author: shurd Date: Tue May 8 16:56:02 2018 New Revision: 66 URL: https://svnweb.freebsd.org/changeset/base/66 Log: iflib: cleanup queues when iflib_device_register fail Submitted by: Jacob Keller Reviewed by: gallatin MFC after:3 days Sponsored by: Intel Corporation

svn commit: r333366 - head/sys/net

2018-05-08 Thread Stephen Hurd
Author: shurd Date: Tue May 8 16:56:02 2018 New Revision: 66 URL: https://svnweb.freebsd.org/changeset/base/66 Log: iflib: cleanup queues when iflib_device_register fail Submitted by: Jacob Keller Reviewed by: gallatin MFC after:3 days Sponsored by: Intel Corporation

svn commit: r333364 - in stable/11: share/man/man4 sys/dev/bnxt

2018-05-08 Thread Stephen Hurd
Vogel Aq Mt jfvo...@gmail.com +and +.An Stephen Hurd Aq Mt sh...@freebsd.org , and is currently maintained by -.An Stephen Hurd Aq Mt stephen.h...@broadcom.com . +.An Broadcom Limited Aq Mt freebsd@broad

svn commit: r333341 - stable/11/sys/net

2018-05-07 Thread Stephen Hurd
Author: shurd Date: Mon May 7 23:10:02 2018 New Revision: 41 URL: https://svnweb.freebsd.org/changeset/base/41 Log: MFC r333253-r333254 Fixes invalid free()s when iflib_queues_alloc() fails, and remove unused brscp variable. Approved by: re (gjb@) Modified: stable/11/sys

svn commit: r333340 - stable/11/sys/net

2018-05-07 Thread Stephen Hurd
Author: shurd Date: Mon May 7 22:33:40 2018 New Revision: 40 URL: https://svnweb.freebsd.org/changeset/base/40 Log: Direct commit to stable/11 to fix botched r38 netmap nm_intr is not part of stable/11 Approved by: re (marius@) Sponsored by: Limelight Networks Modified

svn commit: r333338 - in stable/11/sys: dev/bnxt kern net sys

2018-05-07 Thread Stephen Hurd
Author: shurd Date: Mon May 7 21:42:22 2018 New Revision: 38 URL: https://svnweb.freebsd.org/changeset/base/38 Log: Merge iflib changes to 11-STABLE MFC r300147, r300153, r300154, r300215, r301563, r301567, r302372, r307560, r307562, r307563, r307568, r308792, r311039, r311837,

svn commit: r333254 - head/sys/net

2018-05-04 Thread Stephen Hurd
Author: shurd Date: Fri May 4 15:20:34 2018 New Revision: 333254 URL: https://svnweb.freebsd.org/changeset/base/333254 Log: iflib: fix invalid free during queue allocation failure In r301567, code was added to cleanup to prevent memory leaks for the Tx and Rx ring structs. This code care

svn commit: r333254 - head/sys/net

2018-05-04 Thread Stephen Hurd
Author: shurd Date: Fri May 4 15:20:34 2018 New Revision: 333254 URL: https://svnweb.freebsd.org/changeset/base/333254 Log: iflib: fix invalid free during queue allocation failure In r301567, code was added to cleanup to prevent memory leaks for the Tx and Rx ring structs. This code care

svn commit: r333253 - head/sys/net

2018-05-04 Thread Stephen Hurd
Author: shurd Date: Fri May 4 15:11:16 2018 New Revision: 333253 URL: https://svnweb.freebsd.org/changeset/base/333253 Log: iflib: remove unused brscp pointer from iflib_queues_alloc This pointer was no longer written to as of r315217. Since nothing writes to the variable, remove it.

svn commit: r333253 - head/sys/net

2018-05-04 Thread Stephen Hurd
Author: shurd Date: Fri May 4 15:11:16 2018 New Revision: 333253 URL: https://svnweb.freebsd.org/changeset/base/333253 Log: iflib: remove unused brscp pointer from iflib_queues_alloc This pointer was no longer written to as of r315217. Since nothing writes to the variable, remove it.

svn commit: r333218 - head/sys/net

2018-05-03 Thread Stephen Hurd
Author: shurd Date: Thu May 3 17:02:31 2018 New Revision: 333218 URL: https://svnweb.freebsd.org/changeset/base/333218 Log: Allow iflib NIC drivers to sleep rather than busy wait Since the move to SMP NIC driver locking has had to go through serious contortions using mtx around long runn

svn commit: r333218 - head/sys/net

2018-05-03 Thread Stephen Hurd
Author: shurd Date: Thu May 3 17:02:31 2018 New Revision: 333218 URL: https://svnweb.freebsd.org/changeset/base/333218 Log: Allow iflib NIC drivers to sleep rather than busy wait Since the move to SMP NIC driver locking has had to go through serious contortions using mtx around long runn

svn commit: r333175 - in head/sys: kern net netinet netinet6 sys

2018-05-02 Thread Stephen Hurd
Author: shurd Date: Wed May 2 19:36:29 2018 New Revision: 333175 URL: https://svnweb.freebsd.org/changeset/base/333175 Log: Separate list manipulation locking from state change in multicast Multicast incorrectly calls in to drivers with a mutex held causing drivers to have to go through

svn commit: r333175 - in head/sys: kern net netinet netinet6 sys

2018-05-02 Thread Stephen Hurd
Author: shurd Date: Wed May 2 19:36:29 2018 New Revision: 333175 URL: https://svnweb.freebsd.org/changeset/base/333175 Log: Separate list manipulation locking from state change in multicast Multicast incorrectly calls in to drivers with a mutex held causing drivers to have to go through

svn commit: r332734 - in stable/11/sys: kern net

2018-04-18 Thread Stephen Hurd
Author: shurd Date: Wed Apr 18 18:45:04 2018 New Revision: 332734 URL: https://svnweb.freebsd.org/changeset/base/332734 Log: MFC r332388: Make BPF global lock an SX This allows NIC drivers to sleep on polling config operations. PR: 323477 Submitted by: Matthew Macy

svn commit: r332729 - head/sys/net

2018-04-18 Thread Stephen Hurd
Author: shurd Date: Wed Apr 18 15:34:18 2018 New Revision: 332729 URL: https://svnweb.freebsd.org/changeset/base/332729 Log: iflib: Fix queue distribution when there are no threads Previously, if there are no threads, all queues which targeted cores that share an L2 cache were bound to a

svn commit: r332729 - head/sys/net

2018-04-18 Thread Stephen Hurd
Author: shurd Date: Wed Apr 18 15:34:18 2018 New Revision: 332729 URL: https://svnweb.freebsd.org/changeset/base/332729 Log: iflib: Fix queue distribution when there are no threads Previously, if there are no threads, all queues which targeted cores that share an L2 cache were bound to a

  1   2   3   4   5   6   7   >