> I think it would be preferable if mxm_setup() was passed the pci
> device for uniformity, and have mxm_setup() call romfile_xxx() itself.
Do you mean, run mxm30_setup unconditionally?
And it checks if the file exists:
else if (mxm30_setup(pci))
/* nothing left to do here */
> Ah, I missed that vgahook_setup() checks for NULL. Out of curiosity,
> is it possible to limit this support to a particular hardware vendor
> instead of by existence of file?
ATI, AMD, and Nvidia based MXM cards exist. I don't know of a way to
probe it to find out if it's an MXM format card. And
/codeberg.org/Riku_V/mxmdump/
Signed-off-by: Riku Viitanen riku.viita...@protonmail.com
---
src/vgahooks.c | 79 ++
1 file changed, 79 insertions(+)
diff --git a/src/vgahooks.c b/src/vgahooks.c
index 1f149532..6adf5b9b 100644
--- a/src/vgahooks.c
> I'd suggest to add a romfile_loadfile_low()
I can definitely do that.
> or add a 'struct zone_s'
> parameter instead of passing in a function pointer.
Sounds sensible. I see there's a malloc that takes zone as argument.
> Also: What the trailing bytes are used for?
Only for re-implementing t
te a tool to do it on Linux: https://codeberg.org/Riku_V/mxmdump/
Signed-off-by: Riku Viitanen
---
src/optionroms.c | 9 +++
src/vgahooks.c | 69
src/vgahooks.h | 9 +++
3 files changed, 87 insertions(+)
create mode 100644 src/v
-by: Riku Viitanen
---
src/romfile.c | 25 -
src/romfile.h | 2 ++
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/src/romfile.c b/src/romfile.c
index b598274e..8bf95713 100644
--- a/src/romfile.c
+++ b/src/romfile.c
@@ -47,10 +47,12 @@ romfile_find(const
I accidentally replied to Daniel Kiper only.
--- Forwarded Message ---
From: Riku Viitanen
Date: On Sunday, April 30th, 2023 at 15.26
Subject: Re: [PATCH] at_keyboard.c: add timeout to fix hang on hp elitebooks
To: Daniel Kiper
> On Friday, April 28th, 2023 at 16.38, Daniel Kiper
This fixes GRUB on Coreboot on HP EliteBooks by implementing
a 200ms timeout. GRUB used to hang. See: https://ticket.coreboot.org/issues/141
---
grub-core/term/at_keyboard.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/grub-core/term/at_keyboard.c b/grub-core/ter
ooting
Severity: Major
Priority: 5 - Normal
Item Group: Hardware-specific
Status: None
Privacy: Public
Assigned to: None
Originator Name: Riku Viitanen
Originator Email: riku.viita...@protonma
