Re: [lldb-dev] Some API test failures are really opaque/could be improved

2021-11-04 Thread Raphael Isemann via lldb-dev
Is someone currently working on fixing this? FWIW, I think David's change seems to go in the right direction (when I originally looked at this I also ended up on the wrong rpath but I thought it was some other code that set the wrong value. Didn't realize we have two places where this happens). I t

[lldb-dev] The two PDB plugins in LLDB

2021-11-02 Thread Raphael Isemann via lldb-dev
Hi all, I'm currently working on a patch that requires updating to all our debug information parsers and I noticed that we have two PDB plugins. One seems to be 'native' and uses a LLVM-internal parser while the non-native reuses parts of Microsoft DIA SDK from what I can see. IIUC the native plu

Re: [lldb-dev] [llvm-dev] Upstream an LLDB language plugin for D and support of custom expressions

2021-11-02 Thread Raphael Isemann via lldb-dev
I think having more language plugins in LLDB is in general a good thing. Given the past experience with other plugins (that have been since removed) there are probably a few things that should be clarified before we merge new plugins: 1. Who is going to maintain it? In the past we had to remove t

Re: [lldb-dev] Some API test failures are really opaque/could be improved

2021-10-19 Thread Raphael Isemann via lldb-dev
Actually the RPATH theory is wrong, but the LLVM_ENABLE_PROJECT workaround *should* still work. Am Di., 19. Okt. 2021 um 18:02 Uhr schrieb Raphael Isemann : > > I just saw in your review comment that this is using > LLVM_ENABLE_RUNTIMES and not LLVM_ENABLE_PROJECTS for libcxx, so the > failure jus

Re: [lldb-dev] Some API test failures are really opaque/could be improved

2021-10-19 Thread Raphael Isemann via lldb-dev
I just saw in your review comment that this is using LLVM_ENABLE_RUNTIMES and not LLVM_ENABLE_PROJECTS for libcxx, so the failure just comes from us setting the wrong RPATH due to the different runtimes library directory (at least from what I can see). Would it be possible to put libcxx in LLVM_ENA

Re: [lldb-dev] Some API test failures are really opaque/could be improved

2021-10-18 Thread Raphael Isemann via lldb-dev
I think https://reviews.llvm.org/D111978 , https://reviews.llvm.org/D111981 and the other patches Pavel & me put up today should improve this situation IIUC. - Raphael Am Mo., 18. Okt. 2021 um 05:54 Uhr schrieb David Blaikie via lldb-dev : > > Wondering if anyone else has encountered/dealt with d

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Raphael Isemann via lldb-dev
Just two comments on the process here: 1. I don't think we can really make a 'wrong' decision regarding what code review platform we use. While Github's review interface has its own problems, it's not so bad that it would actually prevent people from reviewing code. Having said that, the only way

Re: [lldb-dev] SB API questions

2021-05-29 Thread Raphael Isemann via lldb-dev
I think patches are always welcome and I don't see any problems with the proposed new API (haven't really checked though if they are all unavailable* through the SB API). The only downside to extending the SB API is that we have to maintain it forever. So if we add an API then it should be abstract

Re: [lldb-dev] Help fixing deadlock in DWARF symbol preloading

2021-02-04 Thread Raphael Isemann via lldb-dev
We could also just give the Module a std::string with the description and update it in the few places where we actually update it. The m_arch already has a setter in place that just needs to be used in a few more places, so the infrastructure is kind of already there (at least for m_arch). The desc

Re: [lldb-dev] Evaluating the same expression at the same breakpoint gets slower after a certain number of steps

2019-08-22 Thread Raphael Isemann via lldb-dev
The test lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/main.cpp is testing this feature, so you should get a 10 (instead of a correct 12345) when you break in main.cpp:31 in this test and eval "expr a" while you have this feature disabled. At least for me that's

Re: [lldb-dev] lldb-mi has been moved to its own GitHub repository

2019-08-13 Thread Raphael Isemann via lldb-dev
Agreed, I made a PR (which is work in progress): https://github.com/lldb-tools/lldb-mi/pull/5 (I didn't try compiling against a compiled LLDB, so that is subject to change). Am Di., 13. Aug. 2019 um 19:29 Uhr schrieb Ted Woodward : > > The build instructions in README.md are a tad sparse: > > Buil

Re: [lldb-dev] Bugzilla default-assignee vs default-cc

2019-04-12 Thread Raphael Isemann via lldb-dev
Yeah, the latter sounds more like what I had in mind. And thanks for doing this by the way! - Raphael Am Fr., 12. Apr. 2019 um 11:12 Uhr schrieb Jonas Devlieghere : > > On Fri, Apr 12, 2019 at 10:56 AM Raphael Isemann wrote: >> >> Can't we just have a list like lldb-bugs (similar to llvm-bugs)

Re: [lldb-dev] Bugzilla default-assignee vs default-cc

2019-04-12 Thread Raphael Isemann via lldb-dev
Can't we just have a list like lldb-bugs (similar to llvm-bugs) as the default-cc? This way I would have all the bugzilla talk also available in my mail, which means I can use my mail client to read comments and search them. And people that don't care about every bug update just don't subscribe to

Re: [lldb-dev] Test suite failures on Fedora Linux?

2019-03-27 Thread Raphael Isemann via lldb-dev
Sorry, was traveling and the internet wasn't good enough for git. Thanks for pushing a fix Pavel! - Raphael Am Mi., 27. März 2019 um 16:37 Uhr schrieb Pavel Labath via lldb-dev : > > On 26/03/2019 14:48, David Zarzycki via lldb-dev wrote: > > > >> On Mar 26, 2019, at 3:07 AM, Jan Kratochvil > >>

Re: [lldb-dev] Test suite failures on Fedora Linux?

2019-03-25 Thread Raphael Isemann via lldb-dev
The import-std-module patches are probably just llvm.org/pr35043, so I'll rename the variables there and that should fix it. Not sure about the others. - Raphael Am Mo., 25. März 2019 um 12:06 Uhr schrieb David Zarzycki via lldb-dev : > > Hello, > > I’m trying to build/test/run the latest lldb on

Re: [lldb-dev] Stackoverflow crash when evaluating an invalid expression

2019-03-07 Thread Raphael Isemann via lldb-dev
You can also dump() the AST to a file on disk if that is easier to capture than stderr. See the overload of `dump()` that takes a stream: https://clang.llvm.org/doxygen/ASTDumper_8cpp_source.html#l00225 - Raphael Am Do., 7. März 2019 um 19:20 Uhr schrieb Ben Ruthig : > > Hey Raphael, > > Yes, you

Re: [lldb-dev] Stackoverflow crash when evaluating an invalid expression

2019-03-07 Thread Raphael Isemann via lldb-dev
Hi Ben, I think I already answered this last week: http://lists.llvm.org/pipermail/lldb-dev/2019-February/014789.html I don't think you'll get an answer here without posting the problematic source or giving any more information as I described in my mail. Cheers, - Raphael Am Do., 7. März 2019 u

Re: [lldb-dev] Stackoverflow crash when evaluating an invalid expression

2019-02-28 Thread Raphael Isemann via lldb-dev
The most likely explanation is that we somehow build a Clang AST where a class has it's itself as a base class or as a field type. Not sure how that happened, but I assume something like CRTP could maybe trigger such a bug. Please break in `getASTRecordLayout` and run `D->dumpColor()` in two diffe

Re: [lldb-dev] [8.0.0 Release] Please write release notes

2019-02-21 Thread Raphael Isemann via lldb-dev
I'm not sure what to do with potential LLDB release notes. Should I just add a LLDB section to the LLVM release notes or do we actually have a separate file for LLDB like clang/libcxx/lld do? - Raphael Am Di., 19. Feb. 2019 um 16:26 Uhr schrieb Hans Wennborg via lldb-dev : > > Hello everyone, > >

Re: [lldb-dev] [RFC] Using Sphinx to generate documentation

2018-12-07 Thread Raphael Isemann via lldb-dev
I think if we want to actually lower the entry barrier for contributing/fixing things on the website, then the server should do this. From what I know the other LLVM projects also generate the HTML on the server (at least I've never seen anyone commit generated HTML files), so this hopefully should

Re: [lldb-dev] The lit test driver gets killed because of SIGHUP

2018-12-05 Thread Raphael Isemann via lldb-dev
@Jonas: Did you confirm it is SIGHUP? I remember that we were not sure whether the signal kind was SIGHUP or SIGINT. - Raphael Am Mi., 5. Dez. 2018 um 10:25 Uhr schrieb Pavel Labath via lldb-dev : > > On 05/12/2018 03:49, Jonas Devlieghere via lldb-dev wrote: > > Hi everyone, > > > > Since we swit

Re: [lldb-dev] [cfe-dev] ASTImporter patches and improvements, please help

2018-12-01 Thread Raphael Isemann via lldb-dev
Hi Gábor, I replied inline. Am Sa., 1. Dez. 2018 um 17:00 Uhr schrieb Gábor Márton via cfe-dev : > > Dear LLDB Developers, > > There is an ongoing activity to improve ASTImporter in Clang to make it > support > C++ (and C) completely and correctly. Our team works on cross translation > unit >

Re: [lldb-dev] TestExprCompletion failing

2018-09-06 Thread Raphael Isemann via lldb-dev
As is tradition, some "NFC" commit broke broke that :). Reverted it in r341532. Thanks for the hint! - Raphael Am Do., 6. Sep. 2018 um 02:35 Uhr schrieb Davide Italiano : > > Raphael, this test has been failing for a while. > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/9755/console

[lldb-dev] LLDB Phabricator project and review group

2018-08-28 Thread Raphael Isemann via lldb-dev
Hi all, we now have a LLDB project on Phabricator[1][2]. You can tag your patches now as belonging to the LLDB project. This will automatically add the respective commit mailing list (thanks Ben!), so the number of steps for creating a LLDB review stay the same. It will also automatically put you

Re: [lldb-dev] LLDB nightly benchmarks and flamegraphs

2018-08-03 Thread Raphael Isemann via lldb-dev
lot. That probably also will feature a nicer web interface. >> >> On Fri, Aug 3, 2018 at 3:37 PM Raphael Isemann via lldb-dev >> wrote: >>> >>> Hi everyone, >>> >>> I wanted to share a (hopefully useful) service for LLDB that I added >>

[lldb-dev] LLDB nightly benchmarks and flamegraphs

2018-08-03 Thread Raphael Isemann via lldb-dev
Hi everyone, I wanted to share a (hopefully useful) service for LLDB that I added recently: If you go to https://teemperor.de/lldb-bench/ you'll now see graphs that show the instruction count and memory usage of the last LLDB nightlies (one per day). If you click on a graph you'll see a flame gra

Re: [lldb-dev] Phabricator repository

2018-08-02 Thread Raphael Isemann via lldb-dev
On Behalf Of >> > > Pavel >> > > > > Labath via lldb-dev >> > > > > Sent: Wednesday, August 01, 2018 3:52 AM >> > > > > To: Raphael Isemann; Eric Liu >> > > > > Cc: LLDB >> > > > > Subject: Re: [lldb-d

Re: [lldb-dev] Phabricator repository

2018-08-01 Thread Raphael Isemann via lldb-dev
; > Labath via lldb-dev > > > > Sent: Wednesday, August 01, 2018 3:52 AM > > > > To: Raphael Isemann; Eric Liu > > > > Cc: LLDB > > > > Subject: Re: [lldb-dev] Phabricator repository > > > > > > > > Sounds like a good idea, t

Re: [lldb-dev] Phabricator repository

2018-08-01 Thread Raphael Isemann via lldb-dev
t sure what specifically needs > > to be done to make that happen. Eric might know more... > > On Wed, 1 Aug 2018 at 03:17, Raphael Isemann via lldb-dev > > wrote: > > > > > > Could we get LLDB into this repository list here? > > > https://reviews.llvm

[lldb-dev] Phabricator repository

2018-07-31 Thread Raphael Isemann via lldb-dev
Could we get LLDB into this repository list here? https://reviews.llvm.org/diffusion/ Beside that it's a bit confusing to the user that lldb is the only missing project there, it also breaks phabricator/arcanist which seems to list LLDB commits as LLVM-repo commits (at least my commits get automat

Re: [lldb-dev] Moderator needed for lldb-commits

2018-07-09 Thread Raphael Isemann via lldb-dev
Hi Tanya, I'm also in! - Raphael Am Mo., 9. Juli 2018 um 13:50 Uhr schrieb Jonas Devlieghere via lldb-dev : > > Hi Tanya, > > I'd be happy to take care of this! > > Cheers, > Jonas > > > On Jul 6, 2018, at 6:01 PM, Tanya Lattner via lldb-dev > > wrote: > > > > LLDB Developers, > > > > Moderator