pranavk wrote:
I fixed this in #125787
https://github.com/llvm/llvm-project/pull/120670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pranavk closed
https://github.com/llvm/llvm-project/pull/125787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pranavk created
https://github.com/llvm/llvm-project/pull/125787
Fixes e8a486ea97895a18e1bba75431d37d9758886084
>From eaa2581b6b81aa616296f09b859024b3d22fe3c8 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Tue, 4 Feb 2025 23:35:44 +
Subject: [PATCH] Fix broken clang co
pranavk wrote:
Checking ...
https://github.com/llvm/llvm-project/pull/120670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pranavk wrote:
Thank you
https://github.com/llvm/llvm-project/pull/120670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1334,6 +1334,16 @@ class X86_64ABIInfo : public ABIInfo {
return T.isOSLinux() || T.isOSNetBSD();
}
+ bool returnCXXRecordGreaterThan128InMem() const {
+// Clang <= 20.0 did not do this.
+if (getContext().getLangOpts().getClangABICompat() <=
+LangOpt
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 2c049c1a377e0b9142d4dcb8682ea27837750810 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/2] [clang] Return larger CXX records in memory
We incorrectly re
pranavk wrote:
We don't need this urgently. I am fine just keeping it like this.
https://github.com/llvm/llvm-project/pull/120670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pranavk wrote:
Oops. Too bad. I didn't realize we branched off release/20.x
Anyhow, I made necessary tweaks to now make it a LLVM 21 feature.
> There is a X86 Support section
It feels more appropriate to put this in "ABI changes section" than "X86
support" since it's not a "support". But I a
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 2c049c1a377e0b9142d4dcb8682ea27837750810 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH] [clang] Return larger CXX records in memory
We incorrectly return
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 2fc0a12eaef09e26143a78c2071009394e5a4f3b Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/2] [clang] Return larger CXX records in memory
We incorrectly re
pranavk wrote:
> Shouldn't this have some sort of Release not maybe under the X86 section?
there's no x86 section in the release notes. So I added it in ABI section.
https://github.com/llvm/llvm-project/pull/120670
___
cfe-commits mailing list
cfe-co
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 3f7f567dde22f7501822b83c33eeff8dd596 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/2] [clang] Return larger CXX records in memory
We incorrectly re
@@ -2949,6 +2950,13 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
+ bool IsX8664Target =
+ S.Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86_64;
+ bool IsX
pranavk wrote:
> Shouldn't this have some sort of Release not maybe under the X86 section?
you mean mention this in release section? I plan to add a note in
clang/docs/ReleaseNotes.rst. Next week.
https://github.com/llvm/llvm-project/pull/120670
___
pranavk wrote:
Took a look at failing tests -- they need to be modified to conform to the new
ABI. Should be easy to do.
https://github.com/llvm/llvm-project/pull/121944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/121944
>From 2347ae937659988e54bc6b9f47b6edb0fdaa8c13 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Tue, 7 Jan 2025 14:48:00 +
Subject: [PATCH] [X86] Return illegal vectors in memory
When vector size doesn't fi
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 852907ee0d0806f2c48c07a7c0d5746ad0a48367 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH] [clang] Return larger CXX records in memory
We incorrectly return
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 4b6839317bcd2a014011cb91b5a3e58d4a47b0b1 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/5] [clang] Return larger CXX records in memory
We incorrectly re
@@ -2067,6 +2081,10 @@ void X86_64ABIInfo::classify(QualType Ty, uint64_t
OffsetBase, Class &Lo,
classify(I.getType(), Offset, FieldLo, FieldHi, isNamedArg);
Lo = merge(Lo, FieldLo);
Hi = merge(Hi, FieldHi);
+if (returnCXXRecordGreaterThan128InM
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 4b6839317bcd2a014011cb91b5a3e58d4a47b0b1 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/4] [clang] Return larger CXX records in memory
We incorrectly re
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 4b6839317bcd2a014011cb91b5a3e58d4a47b0b1 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/3] [clang] Return larger CXX records in memory
We incorrectly re
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/120670
>From 4b6839317bcd2a014011cb91b5a3e58d4a47b0b1 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 20 Dec 2024 02:17:23 +
Subject: [PATCH 1/2] [clang] Return larger CXX records in memory
We incorrectly re
https://github.com/pranavk created
https://github.com/llvm/llvm-project/pull/120670
We incorrectly return CXX records in AVX registers when they should be returned
in memory. This is violation of x86-64 psABI.
Detailed discussion is here:
https://groups.google.com/g/x86-64-abi/c/BjOOyihHuqg/m
https://github.com/pranavk approved this pull request.
https://github.com/llvm/llvm-project/pull/115570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pranavk wrote:
This is causing similar errors for us as well.
https://github.com/llvm/llvm-project/pull/114070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -924,17 +924,20 @@
ItaniumCXXABI::EmitMemberPointerConversion(CodeGenFunction &CGF,
if (isa(src))
return EmitMemberPointerConversion(E, cast(src));
+ QualType DstType = E->getType(), SrcType = E->getSubExpr()->getType();
pranavk wrote:
`SrcType` is
https://github.com/pranavk closed
https://github.com/llvm/llvm-project/pull/108311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pranavk wrote:
Breaks multiple of our internal workloads and chromium open-source project
(https://issues.chromium.org/issues/366045258)
https://github.com/llvm/llvm-project/pull/108311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/pranavk created
https://github.com/llvm/llvm-project/pull/108311
…de loaded from different modules (#104512)"
This reverts commit d778689fdc812033e7142ed87e4ee13c4997b3f9.
>From 2bce8ffa0ede2e21c590768f0b533c7e793b Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Thu, 1
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
pranavk wrote:
I am seeing internal crashes due to this as well. I am reverting this as it's
causing issues in chromium open-source project as well as @aeubanks mentioned
a
pranavk wrote:
This doesn't seem to handle all the cases? See
https://github.com/abseil/abseil-cpp/pull/1711 for absl build failures that are
not silenced by using this option.
https://github.com/llvm/llvm-project/pull/98613
___
cfe-commits mailing l
pranavk wrote:
Could we perhaps put this behind a flag to help with the transition?
Some cases can already be silenced with -Wno-missing-dependent-template-keyword
but cases like above in absl are hard errors and there are no workarounds.
https://github.com/llvm/llvm-project/pull/98547
__
pranavk wrote:
Sorry, I just pushed the reverts. I reverted the commits for now. Feel free to
re-land with fixes.
https://github.com/llvm/llvm-project/pull/84050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
Author: Pranav Kant
Date: 2024-04-26T00:18:08Z
New Revision: 0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7
URL:
https://github.com/llvm/llvm-project/commit/0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7
DIFF:
https://github.com/llvm/llvm-project/commit/0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7.diff
LOG: R
Author: Pranav Kant
Date: 2024-04-26T00:17:28Z
New Revision: 45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58
URL:
https://github.com/llvm/llvm-project/commit/45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58
DIFF:
https://github.com/llvm/llvm-project/commit/45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58.diff
LOG: R
pranavk wrote:
Yes, I also think that this should be reverted. This commit seems to
erroneously fail on cases like this:
https://github.com/tink-crypto/tink-cc/blob/4501627fe9ee312ad5d413600f050827b5f725ed/tink/util/secret_proto.h#L62
Note that ParseFromArray is being on an instance of T. So c
pranavk wrote:
This makes clang crash in some cases. Here's a sample:
https://godbolt.org/z/4sbvna4WY
https://github.com/llvm/llvm-project/pull/84050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Pranav Kant
Date: 2024-04-23T22:08:50Z
New Revision: e1321fafbc024007023ce5d9b88d987a920c3bca
URL:
https://github.com/llvm/llvm-project/commit/e1321fafbc024007023ce5d9b88d987a920c3bca
DIFF:
https://github.com/llvm/llvm-project/commit/e1321fafbc024007023ce5d9b88d987a920c3bca.diff
LOG: R
pranavk wrote:
@mahtohappy can we please revert this in the meantime while you look for a fix
here. Feel free to land it again with the fix.
https://github.com/llvm/llvm-project/pull/89036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
pranavk wrote:
```
In file included from /usr/local/foo/home/prka/wip/unique/test.cpp:1:
In file included from
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/memory:78:
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:1085:14:
error: no matching convers
pranavk wrote:
This commit is still problematic. Minimal reproducer
(https://godbolt.org/z/hE7M8EfT1).
We should get this reverted again.
https://github.com/llvm/llvm-project/pull/83124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
pranavk wrote:
I have same opinion as @lntue and Nick.
https://github.com/llvm/llvm-project/pull/85070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/83918
>From c28121199d5e16efb908a3058a52c6b5b2016848 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Mon, 4 Mar 2024 22:19:04 +
Subject: [PATCH 1/3] [clang][CUDA] Disable float128 diagnostics for device
compilati
https://github.com/pranavk edited
https://github.com/llvm/llvm-project/pull/83918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4877,7 +4877,9 @@ void Sema::AddModeAttr(Decl *D, const AttributeCommonInfo
&CI,
NewElemTy = Context.getRealTypeForBitwidth(DestWidth, ExplicitType);
if (NewElemTy.isNull()) {
-Diag(AttrLoc, diag::err_machine_mode) << 1 /*Unsupported*/ << Name;
+// Only emit
@@ -4877,7 +4877,9 @@ void Sema::AddModeAttr(Decl *D, const AttributeCommonInfo
&CI,
NewElemTy = Context.getRealTypeForBitwidth(DestWidth, ExplicitType);
if (NewElemTy.isNull()) {
-Diag(AttrLoc, diag::err_machine_mode) << 1 /*Unsupported*/ << Name;
+// Only emit
@@ -4877,7 +4877,9 @@ void Sema::AddModeAttr(Decl *D, const AttributeCommonInfo
&CI,
NewElemTy = Context.getRealTypeForBitwidth(DestWidth, ExplicitType);
if (NewElemTy.isNull()) {
-Diag(AttrLoc, diag::err_machine_mode) << 1 /*Unsupported*/ << Name;
+// Only emit
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/83918
>From c28121199d5e16efb908a3058a52c6b5b2016848 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Mon, 4 Mar 2024 22:19:04 +
Subject: [PATCH 1/2] [clang][CUDA] Disable float128 diagnostics for device
compilati
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/83918
>From c28121199d5e16efb908a3058a52c6b5b2016848 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Mon, 4 Mar 2024 22:19:04 +
Subject: [PATCH] [clang][CUDA] Disable float128 diagnostics for device
compilation
https://github.com/pranavk created
https://github.com/llvm/llvm-project/pull/83918
None
>From 39fa380fc3df9775e59b1957dca4a7f927702360 Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Mon, 4 Mar 2024 22:19:04 +
Subject: [PATCH] [clang][CUDA] Disable float128 diagnostics for device
compila
Author: Pranav Kant
Date: 2023-10-04T18:19:24Z
New Revision: 7d21086d0ca4a680e96e0f4cd3e2597ebe027a48
URL:
https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597ebe027a48
DIFF:
https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597ebe027a48.diff
LOG: R
https://github.com/pranavk closed
https://github.com/llvm/llvm-project/pull/67196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/67196
>From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 22 Sep 2023 20:50:32 +
Subject: [PATCH 1/3] [clang] Predefined macros for float128 support
---
clang/lib/
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/67196
>From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 22 Sep 2023 20:50:32 +
Subject: [PATCH 1/3] [clang] Predefined macros for float128 support
---
clang/lib/
@@ -1076,6 +1076,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineFloatMacros(Builder, "FLT", &TI.getFloatFormat(), "F");
DefineFloatMacros(Builder, "DBL", &TI.getDoubleFormat(), "");
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L
https://github.com/pranavk updated
https://github.com/llvm/llvm-project/pull/67196
>From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 22 Sep 2023 20:50:32 +
Subject: [PATCH 1/2] [clang] Predefined macros for float128 support
---
clang/lib/
https://github.com/pranavk edited
https://github.com/llvm/llvm-project/pull/67196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pranavk created
https://github.com/llvm/llvm-project/pull/67196
None
>From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001
From: Pranav Kant
Date: Fri, 22 Sep 2023 20:50:32 +
Subject: [PATCH] [clang] Predefined macros for float128 support
---
clang/li
59 matches
Mail list logo
